Re: [Qemu-block] [Qemu-devel] [PATCH v12 22/36] qapi: Don't let implicit enum MAX member collide

2015-11-18 Thread Markus Armbruster
Eric Blake writes: > On 11/18/2015 06:12 AM, Markus Armbruster wrote: >> Eric Blake writes: >> >>> Now that we guarantee the user doesn't have any enum values >>> beginning with a single underscore, we can use that for our >>> own purposes. Renaming ENUM_MAX to ENUM__MAX makes it obvious >>> t

Re: [Qemu-block] [Qemu-devel] [PATCH v12 22/36] qapi: Don't let implicit enum MAX member collide

2015-11-18 Thread Eric Blake
On 11/18/2015 06:12 AM, Markus Armbruster wrote: > Eric Blake writes: > >> Now that we guarantee the user doesn't have any enum values >> beginning with a single underscore, we can use that for our >> own purposes. Renaming ENUM_MAX to ENUM__MAX makes it obvious >> that the sentinel is generated

Re: [Qemu-block] [Qemu-devel] [PATCH v12 22/36] qapi: Don't let implicit enum MAX member collide

2015-11-18 Thread Markus Armbruster
Eric Blake writes: > Now that we guarantee the user doesn't have any enum values > beginning with a single underscore, we can use that for our > own purposes. Renaming ENUM_MAX to ENUM__MAX makes it obvious > that the sentinel is generated. The ENUM__MAX are mildly ugly. If we cared, we could