Re: [Qemu-block] [Qemu-devel] [PATCH v14 00/19] QAPI/QOM work for non-scalar object properties

2016-10-21 Thread Daniel P. Berrange
On Fri, Oct 21, 2016 at 11:35:10AM +0200, Markus Armbruster wrote: > Uh, replied to the wrong v14... The one I reviewed is actually v15, > Message-Id: <1475246744-29302-1-git-send-email-berra...@redhat.com> > http://lists.gnu.org/archive/html/qemu-devel/2016-09/msg08238.html Sorry, my bad for

Re: [Qemu-block] [Qemu-devel] [PATCH v14 00/19] QAPI/QOM work for non-scalar object properties

2016-10-21 Thread Markus Armbruster
Uh, replied to the wrong v14... The one I reviewed is actually v15, Message-Id: <1475246744-29302-1-git-send-email-berra...@redhat.com> http://lists.gnu.org/archive/html/qemu-devel/2016-09/msg08238.html Markus Armbruster writes: > I've warmed quite a bit to this series while

Re: [Qemu-block] [Qemu-devel] [PATCH v14 00/19] QAPI/QOM work for non-scalar object properties

2016-10-20 Thread Markus Armbruster
I've warmed quite a bit to this series while reviewing it. In particular, I've come around to like structuring the command line -> QAPI pipeline exactly like the JSON -> QAPI pipeline, namely 1. parse into QObject, 2. convert to QAPI with the QObject input visitor. QObject serves as abstract

Re: [Qemu-block] [Qemu-devel] [PATCH v14 00/19] QAPI/QOM work for non-scalar object properties

2016-10-20 Thread Daniel P. Berrange
On Thu, Oct 20, 2016 at 05:06:33PM +0200, Markus Armbruster wrote: > I've warmed quite a bit to this series while reviewing it. In > particular, I've come around to like structuring the command line -> > QAPI pipeline exactly like the JSON -> QAPI pipeline, namely 1. parse > into QObject, 2.