Re: [Qemu-block] [Qemu-devel] [PATCH v2 1/3] block: Extrace bdrv_parse_detect_zeroes_flags

2015-06-10 Thread Fam Zheng
On Wed, 06/10 17:11, Fam Zheng wrote: > On Mon, 06/08 16:53, Paolo Bonzini wrote: > > > > > > On 08/06/2015 16:17, Eric Blake wrote: > > >> > + > > >> > +if (detect_zeroes == BLOCKDEV_DETECT_ZEROES_OPTIONS_UNMAP && > > >> > +!(bdrv_flags & BDRV_O_UNMAP)) { > > >> > +error_setg

Re: [Qemu-block] [Qemu-devel] [PATCH v2 1/3] block: Extrace bdrv_parse_detect_zeroes_flags

2015-06-10 Thread Fam Zheng
On Mon, 06/08 16:53, Paolo Bonzini wrote: > > > On 08/06/2015 16:17, Eric Blake wrote: > >> > + > >> > +if (detect_zeroes == BLOCKDEV_DETECT_ZEROES_OPTIONS_UNMAP && > >> > +!(bdrv_flags & BDRV_O_UNMAP)) { > >> > +error_setg(errp, "setting detect-zeroes to unmap is not allowed

Re: [Qemu-block] [Qemu-devel] [PATCH v2 1/3] block: Extrace bdrv_parse_detect_zeroes_flags

2015-06-08 Thread Paolo Bonzini
On 08/06/2015 16:17, Eric Blake wrote: >> > + >> > +if (detect_zeroes == BLOCKDEV_DETECT_ZEROES_OPTIONS_UNMAP && >> > +!(bdrv_flags & BDRV_O_UNMAP)) { >> > +error_setg(errp, "setting detect-zeroes to unmap is not allowed " >> > + "without setting discar

Re: [Qemu-block] [Qemu-devel] [PATCH v2 1/3] block: Extrace bdrv_parse_detect_zeroes_flags

2015-06-08 Thread Eric Blake
On 06/08/2015 04:34 AM, Fam Zheng wrote: > The logic will be shared with qmp_drive_mirror. s/Extrace/Extract/ in the subject > > Signed-off-by: Fam Zheng > --- > block.c | 26 ++ > blockdev.c| 14 ++ > include/block/block.h | 3 +++