Re: [Qemu-block] [Qemu-devel] [PATCH v2 2/6] block: Fix dirty bitmap in bdrv_co_discard

2015-05-11 Thread Fam Zheng
On Mon, 05/11 15:22, John Snow wrote: > > > On 05/06/2015 12:52 AM, Fam Zheng wrote: > > Unsetting dirty globally with discard is not very correct. The discard may > > zero > > out sectors (depending on can_write_zeroes_with_unmap), we should replicate > > this change to destinition side to make

Re: [Qemu-block] [Qemu-devel] [PATCH v2 2/6] block: Fix dirty bitmap in bdrv_co_discard

2015-05-11 Thread John Snow
On 05/06/2015 12:52 AM, Fam Zheng wrote: > Unsetting dirty globally with discard is not very correct. The discard may > zero > out sectors (depending on can_write_zeroes_with_unmap), we should replicate > this change to destinition side to make sure that the guest sees the same > data. > > Cal