Re: [Qemu-block] [Qemu-devel] [PATCH v2 3/6] qapi: add block-dirty-bitmap-enable/disable

2018-02-05 Thread Vladimir Sementsov-Ogievskiy
03.02.2018 19:09, Markus Armbruster wrote: Vladimir Sementsov-Ogievskiy writes: Signed-off-by: Vladimir Sementsov-Ogievskiy --- qapi/block-core.json | 42 ++ blockdev.c | 42

Re: [Qemu-block] [Qemu-devel] [PATCH v2 3/6] qapi: add block-dirty-bitmap-enable/disable

2018-02-03 Thread Markus Armbruster
Vladimir Sementsov-Ogievskiy writes: > Signed-off-by: Vladimir Sementsov-Ogievskiy > --- > qapi/block-core.json | 42 ++ > blockdev.c | 42 ++ > 2 files

Re: [Qemu-block] [Qemu-devel] [PATCH v2 3/6] qapi: add block-dirty-bitmap-enable/disable

2018-02-02 Thread Vladimir Sementsov-Ogievskiy
22.01.2018 22:56, John Snow wrote: On 01/22/2018 02:51 PM, Eric Blake wrote: On 01/22/2018 03:09 AM, Vladimir Sementsov-Ogievskiy wrote: I have to admit exposing this interface still makes me nervous, but :) Mechanically correct, and with suggesting phrasing changes: Reviewed-by: John Snow

Re: [Qemu-block] [Qemu-devel] [PATCH v2 3/6] qapi: add block-dirty-bitmap-enable/disable

2018-01-22 Thread John Snow
On 01/22/2018 02:51 PM, Eric Blake wrote: > On 01/22/2018 03:09 AM, Vladimir Sementsov-Ogievskiy wrote: > >>> I have to admit exposing this interface still makes me nervous, but :) >>> >>> Mechanically correct, and with suggesting phrasing changes: >>> >>> Reviewed-by: John Snow

Re: [Qemu-block] [Qemu-devel] [PATCH v2 3/6] qapi: add block-dirty-bitmap-enable/disable

2018-01-22 Thread Eric Blake
On 01/22/2018 03:09 AM, Vladimir Sementsov-Ogievskiy wrote: >>> >> I have to admit exposing this interface still makes me nervous, but :) >> >> Mechanically correct, and with suggesting phrasing changes: >> >> Reviewed-by: John Snow Should we go with an x- prefix for now, and

Re: [Qemu-block] [Qemu-devel] [PATCH v2 3/6] qapi: add block-dirty-bitmap-enable/disable

2018-01-22 Thread Vladimir Sementsov-Ogievskiy
20.01.2018 02:50, John Snow wrote: On 01/16/2018 07:54 AM, Vladimir Sementsov-Ogievskiy wrote: Signed-off-by: Vladimir Sementsov-Ogievskiy --- qapi/block-core.json | 42 ++ blockdev.c | 42

Re: [Qemu-block] [Qemu-devel] [PATCH v2 3/6] qapi: add block-dirty-bitmap-enable/disable

2018-01-19 Thread John Snow
On 01/16/2018 07:54 AM, Vladimir Sementsov-Ogievskiy wrote: > Signed-off-by: Vladimir Sementsov-Ogievskiy > --- > qapi/block-core.json | 42 ++ > blockdev.c | 42 ++ > 2 files