Re: [Qemu-block] [Qemu-devel] [PATCH v3] opts: produce valid command line in qemu_opts_print

2015-08-28 Thread Markus Armbruster
Kővágó Zoltán dirty.ice...@gmail.com writes:

 2015-08-26 15:15 keltezéssel, Markus Armbruster írta:
 Stefan Hajnoczi stefa...@gmail.com writes:

 On Tue, Jul 7, 2015 at 3:42 PM, Kővágó, Zoltán
 dirty.ice...@gmail.com wrote:
 This will let us print options in a format that the user would actually
 write it on the command line (foo=bar,baz=asd,etc=def), without
 prepending a spurious comma at the beginning of the list, or quoting
 values unnecessarily.  This patch provides the following changes:
 * write and id=, if the option has an id
 * do not print separator before the first element
 * do not quote string arguments
 * properly escape commas (,) for QEMU

 Signed-off-by: Kővágó, Zoltán dirty.ice...@gmail.com
 Reviewed-by: Markus Armbruster arm...@redhat.com

 Feel free to send a Ping email reply if your patches haven't been
 reviewed after about 1 week.

 Reviewed-by: Stefan Hajnoczi stefa...@redhat.com

 Route via qemu-trivial or qemu-block?


 Hmm, I originally intended qemu-trivial, qemu-block was added via
 scripts/get_maintainer.pl.

If I remember correctly, the initial patch didn't include the iotests
updates.  The current one does.

Let's give the block maintainers a few days to take this patch.  If none
of them bites, it's -trivial.



Re: [Qemu-block] [Qemu-devel] [PATCH v3] opts: produce valid command line in qemu_opts_print

2015-08-26 Thread Kővágó Zoltán

2015-08-26 15:15 keltezéssel, Markus Armbruster írta:

Stefan Hajnoczi stefa...@gmail.com writes:


On Tue, Jul 7, 2015 at 3:42 PM, Kővágó, Zoltán dirty.ice...@gmail.com wrote:

This will let us print options in a format that the user would actually
write it on the command line (foo=bar,baz=asd,etc=def), without
prepending a spurious comma at the beginning of the list, or quoting
values unnecessarily.  This patch provides the following changes:
* write and id=, if the option has an id
* do not print separator before the first element
* do not quote string arguments
* properly escape commas (,) for QEMU

Signed-off-by: Kővágó, Zoltán dirty.ice...@gmail.com
Reviewed-by: Markus Armbruster arm...@redhat.com


Feel free to send a Ping email reply if your patches haven't been
reviewed after about 1 week.

Reviewed-by: Stefan Hajnoczi stefa...@redhat.com


Route via qemu-trivial or qemu-block?



Hmm, I originally intended qemu-trivial, qemu-block was added via 
scripts/get_maintainer.pl.


Zoltan