Re: [Qemu-block] [Qemu-devel] [PATCH v3 02/11] fdc: refactor pick_geometry

On 12/17/2015 02:53 AM, Markus Armbruster wrote: > John Snow writes: > >> Modify this function to operate directly on FDrive objects instead of >> unpacking and passing all of those parameters manually. >> >> Helps reduce complexity in each caller, and reduces the number of

Re: [Qemu-block] [Qemu-devel] [PATCH v3 02/11] fdc: refactor pick_geometry

John Snow writes: > On 12/17/2015 02:53 AM, Markus Armbruster wrote: >> John Snow writes: >> >>> Modify this function to operate directly on FDrive objects instead of >>> unpacking and passing all of those parameters manually. >>> >>> Helps reduce complexity

Re: [Qemu-block] [Qemu-devel] [PATCH v3 02/11] fdc: refactor pick_geometry

John Snow writes: > Modify this function to operate directly on FDrive objects instead of > unpacking and passing all of those parameters manually. > > Helps reduce complexity in each caller, and reduces the number of args. For now, there's just one. Diffstat suggests it's an