Re: [Qemu-block] [Qemu-devel] [PATCH v3 2/2] virtio-blk: Use blk_drain() to drain IO requests

2015-07-02 Thread Stefan Hajnoczi
On Wed, Jul 1, 2015 at 4:52 PM, Markus Armbruster wrote: > Stefan Hajnoczi writes: > >> On Mon, Jun 29, 2015 at 08:10:20AM +0200, Markus Armbruster wrote: >>> Alexander Yarygin writes: >>> > Markus Armbruster writes: >>> > * Ignorant answer: I was told that the bdrv_drain_all()'s comment is >>>

Re: [Qemu-block] [Qemu-devel] [PATCH v3 2/2] virtio-blk: Use blk_drain() to drain IO requests

2015-07-01 Thread Markus Armbruster
Stefan Hajnoczi writes: > On Mon, Jun 29, 2015 at 08:10:20AM +0200, Markus Armbruster wrote: >> Alexander Yarygin writes: >> > Markus Armbruster writes: >> > * Ignorant answer: I was told that the bdrv_drain_all()'s comment is >> > obsolete and we can use bdrv_drain(). Here is a link to the o

Re: [Qemu-block] [Qemu-devel] [PATCH v3 2/2] virtio-blk: Use blk_drain() to drain IO requests

2015-06-30 Thread Stefan Hajnoczi
On Mon, Jun 29, 2015 at 08:10:20AM +0200, Markus Armbruster wrote: > Alexander Yarygin writes: > > Markus Armbruster writes: > > * Ignorant answer: I was told that the bdrv_drain_all()'s comment is > > obsolete and we can use bdrv_drain(). Here is a link to the old > > thread: http://marc.inf

Re: [Qemu-block] [Qemu-devel] [PATCH v3 2/2] virtio-blk: Use blk_drain() to drain IO requests

2015-06-28 Thread Markus Armbruster
Alexander Yarygin writes: > Markus Armbruster writes: > >> Just spotted this in my git-pull... >> >> Alexander Yarygin writes: >> >>> Each call of the virtio_blk_reset() function calls blk_drain_all(), >>> which works for all existing BlockDriverStates, while draining only >>> one is needed. >>

Re: [Qemu-block] [Qemu-devel] [PATCH v3 2/2] virtio-blk: Use blk_drain() to drain IO requests

2015-06-26 Thread Alexander Yarygin
Markus Armbruster writes: > Just spotted this in my git-pull... > > Alexander Yarygin writes: > >> Each call of the virtio_blk_reset() function calls blk_drain_all(), >> which works for all existing BlockDriverStates, while draining only >> one is needed. >> >> This patch replaces blk_drain_all(

Re: [Qemu-block] [Qemu-devel] [PATCH v3 2/2] virtio-blk: Use blk_drain() to drain IO requests

2015-06-26 Thread Markus Armbruster
Just spotted this in my git-pull... Alexander Yarygin writes: > Each call of the virtio_blk_reset() function calls blk_drain_all(), > which works for all existing BlockDriverStates, while draining only > one is needed. > > This patch replaces blk_drain_all() by blk_drain() in > virtio_blk_reset(