Re: [Qemu-block] [Qemu-devel] [PATCH v5 3/4] qmp: add monitor command to add/remove a child

2015-10-12 Thread Kevin Wolf
Am 09.10.2015 um 20:24 hat Max Reitz geschrieben: > On 09.10.2015 18:42, Dr. David Alan Gilbert wrote: > > * Max Reitz (mre...@redhat.com) wrote: > >> On 08.10.2015 08:15, Markus Armbruster wrote: > >>> Max Reitz writes: > >>> > On 22.09.2015 09:44, Wen Congyang wrote: > > The new QMP com

Re: [Qemu-block] [Qemu-devel] [PATCH v5 3/4] qmp: add monitor command to add/remove a child

2015-10-12 Thread Dr. David Alan Gilbert
* Max Reitz (mre...@redhat.com) wrote: > On 09.10.2015 18:42, Dr. David Alan Gilbert wrote: > > * Max Reitz (mre...@redhat.com) wrote: > >> On 08.10.2015 08:15, Markus Armbruster wrote: > >>> Max Reitz writes: > >>> > On 22.09.2015 09:44, Wen Congyang wrote: > > The new QMP command name i

Re: [Qemu-block] [Qemu-devel] [PATCH v5 3/4] qmp: add monitor command to add/remove a child

2015-10-12 Thread Markus Armbruster
"Dr. David Alan Gilbert" writes: > * Max Reitz (mre...@redhat.com) wrote: >> On 08.10.2015 08:15, Markus Armbruster wrote: >> > Max Reitz writes: >> > >> >> On 22.09.2015 09:44, Wen Congyang wrote: >> >>> The new QMP command name is x-blockdev-child-add, and >> >>> x-blockdev-child-del. >> >>>

Re: [Qemu-block] [Qemu-devel] [PATCH v5 3/4] qmp: add monitor command to add/remove a child

2015-10-12 Thread Markus Armbruster
Max Reitz writes: > On 08.10.2015 08:15, Markus Armbruster wrote: >> Max Reitz writes: >> >>> On 22.09.2015 09:44, Wen Congyang wrote: The new QMP command name is x-blockdev-child-add, and x-blockdev-child-del. It justs for adding/removing quorum's child now, and don't support all >>>

Re: [Qemu-block] [Qemu-devel] [PATCH v5 3/4] qmp: add monitor command to add/remove a child

2015-10-09 Thread Dr. David Alan Gilbert
* Max Reitz (mre...@redhat.com) wrote: > On 08.10.2015 08:15, Markus Armbruster wrote: > > Max Reitz writes: > > > >> On 22.09.2015 09:44, Wen Congyang wrote: > >>> The new QMP command name is x-blockdev-child-add, and > >>> x-blockdev-child-del. > >>> It justs for adding/removing quorum's child

Re: [Qemu-block] [Qemu-devel] [PATCH v5 3/4] qmp: add monitor command to add/remove a child

2015-10-09 Thread Max Reitz
On 08.10.2015 10:29, Alberto Garcia wrote: > On Thu 08 Oct 2015 08:15:25 AM CEST, Markus Armbruster wrote: >>> For the second point, you should also consider how useful this >>> feature is to management tools. Just being able to remove and attach >>> children from a quorum node seems very useful on

Re: [Qemu-block] [Qemu-devel] [PATCH v5 3/4] qmp: add monitor command to add/remove a child

2015-10-09 Thread Max Reitz
On 08.10.2015 08:15, Markus Armbruster wrote: > Max Reitz writes: > >> On 22.09.2015 09:44, Wen Congyang wrote: >>> The new QMP command name is x-blockdev-child-add, and x-blockdev-child-del. >>> It justs for adding/removing quorum's child now, and don't support all >>> kinds of children, >> >> I

Re: [Qemu-block] [Qemu-devel] [PATCH v5 3/4] qmp: add monitor command to add/remove a child

2015-10-09 Thread Max Reitz
On 09.10.2015 18:42, Dr. David Alan Gilbert wrote: > * Max Reitz (mre...@redhat.com) wrote: >> On 08.10.2015 08:15, Markus Armbruster wrote: >>> Max Reitz writes: >>> On 22.09.2015 09:44, Wen Congyang wrote: > The new QMP command name is x-blockdev-child-add, and > x-blockdev-child-d

Re: [Qemu-block] [Qemu-devel] [PATCH v5 3/4] qmp: add monitor command to add/remove a child

2015-10-08 Thread Alberto Garcia
On Thu 08 Oct 2015 12:03:45 PM CEST, Kevin Wolf wrote: >> Note that if we want to make this interface stable there's one use >> case missing: there's currently no way to change the vote threshold. >> > The right way to change the voting threshold is bdrv_reopen(). Adding > support to quorum for ch

Re: [Qemu-block] [Qemu-devel] [PATCH v5 3/4] qmp: add monitor command to add/remove a child

2015-10-08 Thread Kevin Wolf
Am 08.10.2015 um 10:29 hat Alberto Garcia geschrieben: > On Thu 08 Oct 2015 08:15:25 AM CEST, Markus Armbruster wrote: > >> For the second point, you should also consider how useful this > >> feature is to management tools. Just being able to remove and attach > >> children from a quorum node seems

Re: [Qemu-block] [Qemu-devel] [PATCH v5 3/4] qmp: add monitor command to add/remove a child

2015-10-08 Thread Alberto Garcia
On Thu 08 Oct 2015 08:15:25 AM CEST, Markus Armbruster wrote: >> For the second point, you should also consider how useful this >> feature is to management tools. Just being able to remove and attach >> children from a quorum node seems very useful on its own. I don't see >> why we should wait for

Re: [Qemu-block] [Qemu-devel] [PATCH v5 3/4] qmp: add monitor command to add/remove a child

2015-10-07 Thread Markus Armbruster
Max Reitz writes: > On 22.09.2015 09:44, Wen Congyang wrote: >> The new QMP command name is x-blockdev-child-add, and x-blockdev-child-del. >> It justs for adding/removing quorum's child now, and don't support all >> kinds of children, > > It does support all kinds of children for quorum, doesn't