Re: [Qemu-block] Is the use of bdrv_getlength() in qcow.c kosher?

On 08/04/2017 10:32 AM, Eric Blake wrote: > On 08/04/2017 07:45 AM, Markus Armbruster wrote: >> Markus Armbruster writes: >> >>> bdrv_getlength() can fail. The uses in qcow.c don't check. Is that >>> safe? >> >> There's another one in qcow2_co_pwritev_compressed(). >> >> Yet

Re: [Qemu-block] Is the use of bdrv_getlength() in qcow.c kosher?

On 08/04/2017 07:45 AM, Markus Armbruster wrote: > Markus Armbruster writes: > >> bdrv_getlength() can fail. The uses in qcow.c don't check. Is that >> safe? > > There's another one in qcow2_co_pwritev_compressed(). > > Yet another one in dump_refcounts(). > > While we're

[Qemu-block] Is the use of bdrv_getlength() in qcow.c kosher?

bdrv_getlength() can fail. The uses in qcow.c don't check. Is that safe?

Re: [Qemu-block] Is the use of bdrv_getlength() in qcow.c kosher?

Markus Armbruster writes: > bdrv_getlength() can fail. The uses in qcow.c don't check. Is that > safe? There's another one in qcow2_co_pwritev_compressed(). Yet another one in dump_refcounts(). While we're talking: the one in qcow2_measure() assigns to a variable of type

Re: [Qemu-block] Is the use of bdrv_getlength() in qcow.c kosher?

Markus Armbruster writes: > bdrv_getlength() can fail. The uses in qcow.c don't check. Is that > safe? There's another one in vpc_open().