Re: [RFC PATCH 0/2] Allow changing bs->file on reopen

2021-02-05 Thread Kevin Wolf
Am 05.02.2021 um 13:47 hat Alberto Garcia geschrieben: > On Thu 21 Jan 2021 11:52:17 AM CET, Kevin Wolf wrote: > >> Hmm, still, removing a filter which want to unshare WRITE even when > >> doesn't have any parents will be a problem anyway, so we'll need a > >> new command to drop filter with a

Re: [RFC PATCH 0/2] Allow changing bs->file on reopen

2021-02-05 Thread Alberto Garcia
On Thu 21 Jan 2021 11:52:17 AM CET, Kevin Wolf wrote: >> Hmm, still, removing a filter which want to unshare WRITE even when >> doesn't have any parents will be a problem anyway, so we'll need a >> new command to drop filter with a logic like in bdrv_drop_filter in >> my series. >> >> Or, we can

Re: [RFC PATCH 0/2] Allow changing bs->file on reopen

2021-01-21 Thread Kevin Wolf
Am 18.01.2021 um 11:22 hat Vladimir Sementsov-Ogievskiy geschrieben: > 15.01.2021 16:02, Alberto Garcia wrote: > > Hi, > > > > during the past months we talked about making x-blockdev-reopen stable > > API, and one of the missing things was having support for changing > > bs->file. See here for

Re: [RFC PATCH 0/2] Allow changing bs->file on reopen

2021-01-20 Thread Vladimir Sementsov-Ogievskiy
20.01.2021 16:51, Alberto Garcia wrote: On Mon 18 Jan 2021 11:22:49 AM CET, Vladimir Sementsov-Ogievskiy wrote: This is still an RFC but you can see the idea. Good idea and I glad to see that my patches help:) Hmm, still, removing a filter which want to unshare WRITE even when doesn't have

Re: [RFC PATCH 0/2] Allow changing bs->file on reopen

2021-01-20 Thread Alberto Garcia
On Mon 18 Jan 2021 11:22:49 AM CET, Vladimir Sementsov-Ogievskiy wrote: >> This is still an RFC but you can see the idea. > > Good idea and I glad to see that my patches help:) > > Hmm, still, removing a filter which want to unshare WRITE even when > doesn't have any parents will be a problem

Re: [RFC PATCH 0/2] Allow changing bs->file on reopen

2021-01-18 Thread Vladimir Sementsov-Ogievskiy
15.01.2021 16:02, Alberto Garcia wrote: Hi, during the past months we talked about making x-blockdev-reopen stable API, and one of the missing things was having support for changing bs->file. See here for the discusssion (I can't find the message from Kashyap that started the thread in the web

Re: [RFC PATCH 0/2] Allow changing bs->file on reopen

2021-01-15 Thread Kashyap Chamarthy
On Fri, Jan 15, 2021 at 02:02:36PM +0100, Alberto Garcia wrote: > Hi, Hi, > during the past months we talked about making x-blockdev-reopen stable > API, and one of the missing things was having support for changing > bs->file. See here for the discusssion (I can't find the message from >

[RFC PATCH 0/2] Allow changing bs->file on reopen

2021-01-15 Thread Alberto Garcia
Hi, during the past months we talked about making x-blockdev-reopen stable API, and one of the missing things was having support for changing bs->file. See here for the discusssion (I can't find the message from Kashyap that started the thread in the web archives):