Re: [RFC v3 2/5] qemu-io: add zoned block device operations.

2022-06-28 Thread Sam Li
Damien Le Moal 于2022年6月28日周二 17:11写道: > > On 6/28/22 16:56, Stefan Hajnoczi wrote: > > On Mon, Jun 27, 2022 at 08:19:14AM +0800, Sam Li wrote: > >> diff --git a/qemu-io-cmds.c b/qemu-io-cmds.c > >> index 2f0d8ac25a..3f2592b9f5 100644 > >> --- a/qemu-io-cmds.c > >> +++ b/qemu-io-cmds.c > >> @@

Re: [RFC v3 2/5] qemu-io: add zoned block device operations.

2022-06-28 Thread Damien Le Moal
On 6/28/22 16:56, Stefan Hajnoczi wrote: > On Mon, Jun 27, 2022 at 08:19:14AM +0800, Sam Li wrote: >> diff --git a/qemu-io-cmds.c b/qemu-io-cmds.c >> index 2f0d8ac25a..3f2592b9f5 100644 >> --- a/qemu-io-cmds.c >> +++ b/qemu-io-cmds.c >> @@ -1706,6 +1706,122 @@ static const cmdinfo_t flush_cmd = {

Re: [RFC v3 2/5] qemu-io: add zoned block device operations.

2022-06-28 Thread Sam Li
Stefan Hajnoczi 于2022年6月28日周二 16:20写道: > > On Mon, Jun 27, 2022 at 08:19:14AM +0800, Sam Li wrote: > > diff --git a/qemu-io-cmds.c b/qemu-io-cmds.c > > index 2f0d8ac25a..3f2592b9f5 100644 > > --- a/qemu-io-cmds.c > > +++ b/qemu-io-cmds.c > > @@ -1706,6 +1706,122 @@ static const cmdinfo_t

Re: [RFC v3 2/5] qemu-io: add zoned block device operations.

2022-06-28 Thread Stefan Hajnoczi
On Mon, Jun 27, 2022 at 08:19:14AM +0800, Sam Li wrote: > diff --git a/qemu-io-cmds.c b/qemu-io-cmds.c > index 2f0d8ac25a..3f2592b9f5 100644 > --- a/qemu-io-cmds.c > +++ b/qemu-io-cmds.c > @@ -1706,6 +1706,122 @@ static const cmdinfo_t flush_cmd = { > .oneline= "flush all in-core file

Re: [RFC v3 2/5] qemu-io: add zoned block device operations.

2022-06-27 Thread Sam Li
Hannes Reinecke 于2022年6月27日周一 15:30写道: > > On 6/27/22 02:19, Sam Li wrote: > > --- > > Good coding style would advise to add some text here what the patch does. > > > block/io.c | 21 +++ > > include/block/block-io.h | 13 + > > qemu-io-cmds.c | 121

Re: [RFC v3 2/5] qemu-io: add zoned block device operations.

2022-06-27 Thread Hannes Reinecke
On 6/27/22 02:19, Sam Li wrote: --- Good coding style would advise to add some text here what the patch does. block/io.c | 21 +++ include/block/block-io.h | 13 + qemu-io-cmds.c | 121 +++ 3 files changed, 155

[RFC v3 2/5] qemu-io: add zoned block device operations.

2022-06-26 Thread Sam Li
--- block/io.c | 21 +++ include/block/block-io.h | 13 + qemu-io-cmds.c | 121 +++ 3 files changed, 155 insertions(+) diff --git a/block/io.c b/block/io.c index 789e6373d5..656a1b7271 100644 --- a/block/io.c +++ b/block/io.c