Re: [Qemu-block] [Qemu-devel] [PATCH v4 22/23] block: Relax bdrv_aligned_preadv() assertion

2017-10-02 Thread John Snow
On 09/13/2017 12:03 PM, Eric Blake wrote: > Now that bdrv_is_allocated accepts non-aligned inputs, we can > remove the TODO added in commit d6a644bb. > > Signed-off-by: Eric Blake Reviewed-by: John Snow

Re: [Qemu-block] qemu-img: Check failed: No space left on device

2017-10-02 Thread Stefan Hajnoczi
On Tue, Sep 26, 2017 at 04:31:22PM +0200, Nicolas Ecarnot wrote: > Le 21/09/2017 à 16:31, Stefan Hajnoczi a écrit : > > On Tue, Sep 19, 2017 at 12:09:06PM +0200, Nicolas Ecarnot wrote: > > > Hello, > > > > > > First post here, so maybe I should introduce myself : > > > - I'm a sysadmin for

Re: [Qemu-block] [Qemu-devel] [PATCH v4 23/23] qemu-io: Relax 'alloc' now that block-status doesn't assert

2017-10-02 Thread John Snow
On 09/13/2017 12:03 PM, Eric Blake wrote: > Previously, the alloc command required that input parameters be > sector-aligned and clamped to 32 bits, because the underlying > bdrv_is_allocated used a 32-bit parameter and asserted aligned > inputs. But now that we have fixed block status to

Re: [Qemu-block] [Qemu-devel] [PATCH v5 2/6] qapi/qlist: Add qlist_append_null() macro

2017-10-02 Thread Markus Armbruster
Max Reitz writes: > Signed-off-by: Max Reitz Reviewed-by: Markus Armbruster

Re: [Qemu-block] [Qemu-devel] [PATCH 12/18] block/dirty-bitmap: Add bdrv_dirty_iter_next_area

2017-10-02 Thread Vladimir Sementsov-Ogievskiy
25.09.2017 18:49, Vladimir Sementsov-Ogievskiy wrote: I have a patch on list, which adds hbitmap_next_zero function, it may help https://lists.nongnu.org/archive/html/qemu-devel/2017-02/msg00809.html there is a mistake in this hbitmap_next_zero, I'll send today corrected version as part of

Re: [Qemu-block] [Qemu-devel] [PATCH v5 3/6] qapi: Add qobject_is_equal()

2017-10-02 Thread Markus Armbruster
Max Reitz writes: > This generic function (along with its implementations for different > types) determines whether two QObjects are equal. > > Signed-off-by: Max Reitz Reviewed-by: Markus Armbruster

Re: [Qemu-block] [PATCH 4/4] iotests: Add test 197 for covering copy-on-read

2017-10-02 Thread Eric Blake
On 09/30/2017 10:03 PM, Jeff Cody wrote: > On Sat, Sep 30, 2017 at 03:11:21PM -0500, Eric Blake wrote: >> Add a test for qcow2 copy-on-read behavior, including exposure >> for the just-fixed bugs. >> >> The copy-on-read behavior is always to a qcow2 image, but the >> test is careful to allow

[Qemu-block] [PATCH 5/8] qemu-options: Add missing -iscsi Texinfo documentation

2017-10-02 Thread Markus Armbruster
Cc: Ronnie Sahlberg Cc: Kevin Wolf Cc: Max Reitz Cc: qemu-bl...@nongnu.org Signed-off-by: Markus Armbruster --- qemu-options.hx | 6 ++ 1 file changed, 6 insertions(+) diff --git a/qemu-options.hx

[Qemu-block] [PATCH 3/8] qemu-options qemu-doc: Move "Device URL Syntax" to qemu-doc

2017-10-02 Thread Markus Armbruster
Commit 0f5314a (v1.0) added section "Device URL Syntax" to qemu-options.hx. It's enclosed in STEXI..ETEXI, thus affects only qemu-options.texi, not --help. It appears as a subsection under section "Invocation". Similarly, qemu.1 has it as a subsection under "OPTIONS". Commit f9dadc9 (v1.1.0)

[Qemu-block] [PATCH 4/8] qemu-options: Move -iscsi under "Block device options"

2017-10-02 Thread Markus Armbruster
-iscsi ended up under the "Device URL Syntax" heading by a sequence of errors, as explained in the previous commit. Move it under the "Block device options" heading. Nothing left under "Device URL Syntax"; drop the heading. Cc: Ronnie Sahlberg Cc: Kevin Wolf

Re: [Qemu-block] [PATCH v2 01/47] Replace all occurances of __FUNCTION__ with __func__

2017-10-02 Thread Stefan Hajnoczi
On Fri, Sep 29, 2017 at 05:14:58PM -0700, Alistair Francis wrote: > Replace all occurs of __FUNCTION__ except for the check in checkpatch > with the non GCC specific __func__. > > One line in hcd-musb.c was manually tweaked to pass checkpatch. > > Signed-off-by: Alistair Francis

Re: [Qemu-block] [PATCH v2 1/2] block: use internal filter node in backup

2017-10-02 Thread Kevin Wolf
Am 15.08.2017 um 10:18 hat Manos Pitsidianakis geschrieben: > block/backup.c currently uses before write notifiers on the targeted > node. We can create a filter node instead to intercept write requests > for the backup job on the BDS level, instead of the BlockBackend level. > > This is part of

Re: [Qemu-block] [PATCH v2 00/10] cleanup qemu-iotests

2017-10-02 Thread Paolo Bonzini
On 12/09/2017 16:44, Paolo Bonzini wrote: > The purpose of this series is to separate the "check" sources from > the tests. After these patches, common.config is reduced to simple > shell initialization, and common.rc is only included by the tests. > > Along the way, a lot of dead code is

Re: [Qemu-block] [Qemu-devel] [PATCH 0/4] block: Avoid copy-on-read assertions

2017-10-02 Thread Kevin Wolf
Am 01.10.2017 um 00:05 hat Eric Blake geschrieben: > On 09/30/2017 04:19 PM, no-re...@patchew.org wrote: > > Hi, > > > > This series failed build test on s390x host. Please find the details below. > > > > > /var/tmp/patchew-tester-tmp-a2p2tpcc/src/block/io.c: In function > >

[Qemu-block] [PATCH 2/5] backup: move from done_bitmap to copy_bitmap

2017-10-02 Thread Vladimir Sementsov-Ogievskiy
Use HBitmap copy_bitmap instead of done_bitmap. This is needed to improve incremental backup in following patches and to unify backup loop for full/incremental modes in future patches. Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Jeff Cody

[Qemu-block] [PATCH 3/5] backup: init copy_bitmap from sync_bitmap for incremental

2017-10-02 Thread Vladimir Sementsov-Ogievskiy
We should not copy non-dirty clusters in write notifiers. So, initialize copy_bitmap from sync_bitmap. Signed-off-by: Vladimir Sementsov-Ogievskiy --- block/backup.c | 45 - 1 file changed, 44 insertions(+), 1 deletion(-)

[Qemu-block] [PATCH 5/5] backup: use copy_bitmap in incremental backup

2017-10-02 Thread Vladimir Sementsov-Ogievskiy
We can use copy_bitmap instead of sync_bitmap. copy_bitmap is initialized from sync_bitmap and it is more informative: we will not try to process data, that is already in progress (by write notifier). Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Stefan

Re: [Qemu-block] [PATCH 1/4] qemu-io: Add -C for opening with copy-on-read

2017-10-02 Thread Kevin Wolf
Am 30.09.2017 um 21:53 hat Eric Blake geschrieben: > Make it easier to enable copy-on-read during iotests, by > exposing a new bool option to main and open. > > Signed-off-by: Eric Blake Reviewed-by: Kevin Wolf

[Qemu-block] [PATCH 0/5] backup improvements part 1

2017-10-02 Thread Vladimir Sementsov-Ogievskiy
Hi all. Here is a continuation of my "new backup architecture" series, The very first part, but it is meaningful itself. 01: was previously sent in other my series, but here is more correct version, one mistake is fixed. 02: only rebased to new byte-based interfaces (by Eric), r-bs saved 03:

Re: [Qemu-block] [PATCH 2/4] block: Add blkdebug hook for copy-on-read

2017-10-02 Thread Kevin Wolf
Am 30.09.2017 um 21:53 hat Eric Blake geschrieben: > Make it possible to inject errors on writes performed during a > read operation due to copy-on-read semantics. > > Signed-off-by: Eric Blake Reviewed-by: Kevin Wolf

Re: [Qemu-block] [Qemu-devel] [PATCH 0/4] block: Avoid copy-on-read assertions

2017-10-02 Thread Eric Blake
On 10/02/2017 09:50 AM, Kevin Wolf wrote: >> The warning is a false negative (the error message is actually pointing >> to a line in bdrv_co_do_copy_on_readv - but the compiler must have >> inlined it into bdrv_aligned_preadv) - the function is only ever called >> with non-zero bytes, and

Re: [Qemu-block] [Qemu-devel] [PATCH 3/8] qemu-options qemu-doc: Move "Device URL Syntax" to qemu-doc

2017-10-02 Thread Eric Blake
On 10/02/2017 09:03 AM, Markus Armbruster wrote: > Commit 0f5314a (v1.0) added section "Device URL Syntax" to > qemu-options.hx. It's enclosed in STEXI..ETEXI, thus affects only > qemu-options.texi, not --help. It appears as a subsection under > section "Invocation". Similarly, qemu.1 has it as

Re: [Qemu-block] [Qemu-devel] [PATCH 0/5] backup improvements part 1

2017-10-02 Thread Eric Blake
On 10/02/2017 09:39 AM, Vladimir Sementsov-Ogievskiy wrote: > Hi all. Here is a continuation of my "new backup architecture" series, > The very first part, but it is meaningful itself. > > 01: was previously sent in other my series, but here is more correct > version, one mistake is fixed. >

Re: [Qemu-block] [PATCH v10 00/20] make dirty-bitmap byte-based

2017-10-02 Thread Kevin Wolf
Am 25.09.2017 um 16:55 hat Eric Blake geschrieben: > There are patches floating around to add NBD_CMD_BLOCK_STATUS, > but NBD wants to report status on byte granularity (even if the > reporting will probably be naturally aligned to sectors or even > much higher levels). I've therefore started the

Re: [Qemu-block] blockdev-commit design

2017-10-02 Thread Kevin Wolf
Am 02.10.2017 um 17:01 hat Kashyap Chamarthy geschrieben: > On Tue, Sep 26, 2017 at 07:59:42PM +0200, Kevin Wolf wrote: > > [...] > > > In comparison with the old command, the important changes are: > > > > * top/base are node names instead of file names. > > > > * You don't need to

Re: [Qemu-block] [Qemu-devel] [PATCH 0/5] backup improvements part 1

2017-10-02 Thread Vladimir Sementsov-Ogievskiy
02.10.2017 18:38, Eric Blake wrote: On 10/02/2017 09:39 AM, Vladimir Sementsov-Ogievskiy wrote: Hi all. Here is a continuation of my "new backup architecture" series, The very first part, but it is meaningful itself. 01: was previously sent in other my series, but here is more correct

Re: [Qemu-block] [Qemu-devel] [PATCH 1/5] hbitmap: add next_zero function

2017-10-02 Thread Vladimir Sementsov-Ogievskiy
02.10.2017 18:43, Eric Blake wrote: On 10/02/2017 09:39 AM, Vladimir Sementsov-Ogievskiy wrote: The function searches for next zero bit. Also add interface for BdrvDirtyBitmap. Signed-off-by: Vladimir Sementsov-Ogievskiy --- include/block/dirty-bitmap.h | 1 +

Re: [Qemu-block] [Qemu-devel] [PATCH 1/4] qemu-io: Add -C for opening with copy-on-read

2017-10-02 Thread John Snow
On 09/30/2017 03:53 PM, Eric Blake wrote: > Make it easier to enable copy-on-read during iotests, by > exposing a new bool option to main and open. > > Signed-off-by: Eric Blake Reviewed-by: John Snow

Re: [Qemu-block] [PATCH 2/4] block: Add blkdebug hook for copy-on-read

2017-10-02 Thread John Snow
On 09/30/2017 03:53 PM, Eric Blake wrote: > Make it possible to inject errors on writes performed during a > read operation due to copy-on-read semantics. > > Signed-off-by: Eric Blake I suppose our docs DO say "ehh, see block-core.json" so I suppose no update is necessary

Re: [Qemu-block] [PATCH 1/4] qemu-io: Add -C for opening with copy-on-read

2017-10-02 Thread Stefan Hajnoczi
On Sat, Sep 30, 2017 at 02:53:42PM -0500, Eric Blake wrote: > Make it easier to enable copy-on-read during iotests, by > exposing a new bool option to main and open. > > Signed-off-by: Eric Blake > --- > qemu-io.c | 15 --- > 1 file changed, 12 insertions(+), 3

Re: [Qemu-block] [PATCH 2/4] block: Add blkdebug hook for copy-on-read

2017-10-02 Thread Stefan Hajnoczi
On Sat, Sep 30, 2017 at 02:53:43PM -0500, Eric Blake wrote: > Make it possible to inject errors on writes performed during a > read operation due to copy-on-read semantics. > > Signed-off-by: Eric Blake > --- > qapi/block-core.json | 5 - > block/io.c | 1 + > 2