Re: [Qemu-block] [Qemu-devel] [PATCH] raw-posix: Deprecate host floppy passthrough

2015-03-17 Thread Eric Blake
reprieve to host_floppy users. At any rate, I won't be sad to see it gone :) Reviewed-by: Eric Blake ebl...@redhat.com -- Eric Blake eblake redhat com+1-919-301-3266 Libvirt virtualization library http://libvirt.org signature.asc Description: OpenPGP digital signature

Re: [Qemu-block] [PATCH v5 11/13] block: Add blk_remove_all_bs()

2015-03-19 Thread Eric Blake
files changed, 14 insertions(+) Reviewed-by: Eric Blake ebl...@redhat.com -- Eric Blake eblake redhat com+1-919-301-3266 Libvirt virtualization library http://libvirt.org signature.asc Description: OpenPGP digital signature

Re: [Qemu-block] [Qemu-devel] [PATCH v2 2/3] block: Introduce BDS.growing

2015-03-19 Thread Eric Blake
| 2 ++ block/nbd.c | 2 ++ block/qcow2.c | 5 + block/quorum.c| 5 + block/raw_bsd.c | 1 + include/block/block_int.h | 3 +++ 9 files changed, 26 insertions(+) Reviewed-by: Eric Blake ebl...@redhat.com -- Eric Blake

Re: [Qemu-block] [PATCH v5 05/13] block: Move BDS close notifiers into BB

2015-03-19 Thread Eric Blake
| 10 ++ include/sysemu/block-backend.h | 3 +- nbd.c | 13 +++ 10 files changed, 159 insertions(+), 68 deletions(-) Reviewed-by: Eric Blake ebl...@redhat.com -- Eric Blake eblake redhat com+1-919-301-3266 Libvirt virtualization library http

Re: [Qemu-block] [PATCH v5 09/13] block: Add list of all BlockDriverStates

2015-03-19 Thread Eric Blake
good enough for: Reviewed-by: Eric Blake ebl...@redhat.com -- Eric Blake eblake redhat com+1-919-301-3266 Libvirt virtualization library http://libvirt.org signature.asc Description: OpenPGP digital signature

Re: [Qemu-block] [Qemu-devel] [PATCH v2 1/3] iotests: Make nested read in 072 and 089 read-only

2015-03-19 Thread Eric Blake
can be allocated for the inner one). Signed-off-by: Max Reitz mre...@redhat.com --- tests/qemu-iotests/072 | 2 +- tests/qemu-iotests/089 | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) Reviewed-by: Eric Blake ebl...@redhat.com -- Eric Blake eblake redhat com+1-919-301-3266

Re: [Qemu-block] [Qemu-devel] [PATCH v2 3/3] block: Introduce BlockDriver.requires_growing_file

2015-03-19 Thread Eric Blake
9 files changed, 31 insertions(+) Reviewed-by: Eric Blake ebl...@redhat.com -- Eric Blake eblake redhat com+1-919-301-3266 Libvirt virtualization library http://libvirt.org signature.asc Description: OpenPGP digital signature

Re: [Qemu-block] [Qemu-devel] [PATCH for-2.3 1/1] block: New command line option --misc format-probing=off

2015-03-24 Thread Eric Blake
uniformly used. I'm okay if this topic proves too controversial to add into 2.3 at this late in the cycle, even though I'm in favor of adding it. -- Eric Blake eblake redhat com+1-919-301-3266 Libvirt virtualization library http://libvirt.org signature.asc Description: OpenPGP digital

Re: [Qemu-block] [RFC PATCH COLO v2 01/13] docs: block replication's description

2015-03-26 Thread Eric Blake
), and cover all files in the repo in one go, without affecting this series. Such a patch by a copyright owner would have no problem being accepted, if it is wanted. -- Eric Blake eblake redhat com+1-919-301-3266 Libvirt virtualization library http://libvirt.org signature.asc Description

Re: [Qemu-block] [Qemu-devel] [PATCH 3/3] MAINTAINERS: Add Fam Zheng as Null block driver maintainer

2015-03-30 Thread Eric Blake
: block/gluster.c T: git git://github.com/codyprime/qemu-kvm-jtc.git block +Null I wonder if Null Block Driver would be any easier to read. +M: Fam Zheng f...@redhat.com +L: qemu-block@nongnu.org +S: Supported +F: block/null.c Reviewed-by: Eric Blake ebl...@redhat.com + Bootdevice

Re: [Qemu-block] [Qemu-devel] [PATCH 2/3] block/null: Support reopen

2015-03-30 Thread Eric Blake
...@redhat.com --- block/null.c | 8 1 file changed, 8 insertions(+) Reviewed-by: Eric Blake ebl...@redhat.com -- Eric Blake eblake redhat com+1-919-301-3266 Libvirt virtualization library http://libvirt.org signature.asc Description: OpenPGP digital signature

Re: [Qemu-block] [Qemu-devel] qemu-img behavior for locating backing files

2015-04-01 Thread Eric Blake
and create no image. Sounds like a bug fix, not a regression. Since this is a change in behavior for the pending release, is this the correct/desired behavior? Yes, I think so. -- Eric Blake eblake redhat com+1-919-301-3266 Libvirt virtualization library http://libvirt.org signature.asc

Re: [Qemu-block] block-commit dropping privs

2015-04-02 Thread Eric Blake
A-C 1233 Bug #5 - QMP commit doesn't offer a way to rewrite chain when committing across multiple images -- Eric Blake eblake redhat com+1-919-301-3266 Libvirt virtualization library http://libvirt.org signature.asc Description: OpenPGP digital signature

Re: [Qemu-block] [PATCH v6 00/21] block: transactionless incremental backup series

2015-04-23 Thread Eric Blake
#FreeDocumentationLicenses although this is probably not the right list to get a definitive answer from a lawyer familiar with the various copyright licenses and laws. Sorry for /actually/ being difficult; but Eric Blake was urging me to select a license instead of relying on the implicit GPL, so I did go out

Re: [Qemu-block] [Qemu-devel] [PATCH COLO v3 04/14] Add new block driver interfaces to control block replication

2015-04-22 Thread Eric Blake
to secondary QEMU. +# +# @secondary: Secondary mode, receive the vm's state from primary QEMU. +# +# Since: 2.4 +## +{ 'enum' : 'ReplicationMode', ...doesn't match type name. + 'data' : ['unprotected', 'primary', 'secondary']} + -- Eric Blake eblake redhat com+1-919-301-3266 Libvirt

Re: [Qemu-block] [PATCH v6 01/21] docs: incremental backup documentation

2015-04-22 Thread Eric Blake
On 04/17/2015 05:49 PM, John Snow wrote: Signed-off-by: John Snow js...@redhat.com --- docs/bitmaps.md | 352 1 file changed, 352 insertions(+) create mode 100644 docs/bitmaps.md Reviewed-by: Eric Blake ebl...@redhat.com

Re: [Qemu-block] [PATCH 8/8] qemu-iotests: test streaming to an intermediate layer

2015-04-22 Thread Eric Blake
that were not changed in C but were changed in D). But such a test could be a separate patch, so I don't see anything wrong with this new test as-is. -- Eric Blake eblake redhat com+1-919-301-3266 Libvirt virtualization library http://libvirt.org signature.asc Description: OpenPGP digital

Re: [Qemu-block] [PATCH 1/8] block: keep a list of block jobs

2015-04-22 Thread Eric Blake
| 13 + include/block/blockjob.h | 14 ++ 3 files changed, 35 insertions(+), 11 deletions(-) Reviewed-by: Eric Blake ebl...@redhat.com -- Eric Blake eblake redhat com+1-919-301-3266 Libvirt virtualization library http://libvirt.org signature.asc

Re: [Qemu-block] [PATCH v3 01/10] qapi: Add transaction support to block-dirty-bitmap operations

2015-04-22 Thread Eric Blake
to as-if it were new, which can also be used alongside a full backup to accomplish a clean synchronization point. Signed-off-by: Fam Zheng f...@redhat.com Signed-off-by: John Snow js...@redhat.com Reviewed-by: Max Reitz mre...@redhat.com Reviewed-by: Eric Blake ebl...@redhat.com --- +++ b

Re: [Qemu-block] [PATCH v6 07/21] hbitmap: add hbitmap_merge

2015-04-22 Thread Eric Blake
--- include/qemu/hbitmap.h | 13 + util/hbitmap.c | 33 + 2 files changed, 46 insertions(+) Reviewed-by: Eric Blake ebl...@redhat.com -- Eric Blake eblake redhat com+1-919-301-3266 Libvirt virtualization library http://libvirt.org

Re: [Qemu-block] [PATCH v6 10/21] qmp: Add support of dirty-bitmap sync mode for drive-backup

2015-04-22 Thread Eric Blake
...@redhat.com Signed-off-by: John Snow js...@redhat.com --- Reviewed-by: Eric Blake ebl...@redhat.com -- Eric Blake eblake redhat com+1-919-301-3266 Libvirt virtualization library http://libvirt.org signature.asc Description: OpenPGP digital signature

Re: [Qemu-block] [PATCH v6 12/21] qmp: Add dirty bitmap status field in query-block

2015-04-22 Thread Eric Blake
...@redhat.com Reviewed-by: Eric Blake ebl...@redhat.com --- block.c | 1 + qapi/block-core.json | 5 - 2 files changed, 5 insertions(+), 1 deletion(-) +++ b/qapi/block-core.json @@ -336,10 +336,13 @@ # # @granularity: granularity of the dirty bitmap in bytes (since 1.4

Re: [Qemu-block] [PATCH 2/8] block: allow block jobs in any arbitrary node

2015-04-22 Thread Eric Blake
worth changing, and I could live with the patch as-is, so: Reviewed-by: Eric Blake ebl...@redhat.com -- Eric Blake eblake redhat com+1-919-301-3266 Libvirt virtualization library http://libvirt.org signature.asc Description: OpenPGP digital signature

Re: [Qemu-block] [PATCH 5/8] block: Add QMP support for streaming to an intermediate layer

2015-04-22 Thread Eric Blake
-core.json | 10 +++--- tests/qemu-iotests/030 | 2 +- 3 files changed, 18 insertions(+), 14 deletions(-) Reviewed-by: Eric Blake ebl...@redhat.com -- Eric Blake eblake redhat com+1-919-301-3266 Libvirt virtualization library http://libvirt.org signature.asc Description: OpenPGP

Re: [Qemu-block] [Qemu-devel] [PATCH 1/6] qcow2: use one single memory block for the L2/refcount cache tables

2015-04-30 Thread Eric Blake
-table_size); Are we sure this won't overflow? -- Eric Blake eblake redhat com+1-919-301-3266 Libvirt virtualization library http://libvirt.org signature.asc Description: OpenPGP digital signature

Re: [Qemu-block] [Qemu-devel] [PATCH 1/1] vl.c: Since the help says that 'disk_image' is a raw hard disk image, pass format=raw

2015-04-30 Thread Eric Blake
hard disk 0 Standard options: ... Signed-off-by: Don Slutz dsl...@verizon.com --- vl.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) Reviewed-by: Eric Blake ebl...@redhat.com Without this, qemu will try to probe formats. It is arguably is more convenient when using

Re: [Qemu-block] [Qemu-devel] [PATCH 1/1] vl.c: Since the help says that 'disk_image' is a raw hard disk image, pass format=raw

2015-04-30 Thread Eric Blake
On 04/30/2015 01:15 PM, Eric Blake wrote: [adding qemu-block] On 04/30/2015 12:23 PM, Don Slutz wrote: ~/qemu/out/master/x86_64-softmmu/qemu-system-x86_64 -h | head QEMU emulator version 2.3.50, Copyright (c) 2003-2008 Fabrice Bellard usage: qemu-system-x86_64 [options] [disk_image

Re: [Qemu-block] [PATCH v4 13/17] qcow2/overlaps: Add memory limit reached event

2015-05-04 Thread Eric Blake
, +data: { reference: virtio0, start: 805306368, + length: 268435456 }, s/805306368/805306368/ and likewise for length (a json-int does not use quotes). Otherwise seems okay. -- Eric Blake eblake redhat com+1-919-301-3266 Libvirt virtualization library http://libvirt.org

Re: [Qemu-block] [PULL 76/76] block: move I/O request processing to block/io.c

2015-04-28 Thread Eric Blake
/Contribute/SubmitAPatch mentions this as a hint for a nicer setup. At any rate, you've already sent the pull request, so I'm probably too late; but for the record, here's why I would add: Reviewed-by: Eric Blake ebl...@redhat.com when reviewing Stefan's version of the patch (the two versions give the same

Re: [Qemu-block] [Qemu-devel] [PATCH 2/6] qcow2: simplify qcow2_cache_put() and qcow2_cache_entry_mark_dirty()

2015-05-05 Thread Eric Blake
= 0; i c-size; i++) { -if (table_addr(c, i) == table) { -goto found; -} -} -abort(); - -found: +int i = (table - c-table_array) / c-table_size; and again. +assert(c-entries[i].offset != 0); c-entries[i].dirty = true; } -- Eric Blake

Re: [Qemu-block] [Qemu-devel] [PATCH 2/4] block: Remove bdrv_reset_dirty

2015-05-05 Thread Eric Blake
Zheng f...@redhat.com --- block.c | 12 include/block/block_int.h | 2 -- 2 files changed, 14 deletions(-) Reviewed-by Eric Blake ebl...@redhat.com -- Eric Blake eblake redhat com+1-919-301-3266 Libvirt virtualization library http://libvirt.org

Re: [Qemu-block] [Qemu-devel] [PATCH v3 01/10] qapi: Add transaction support to block-dirty-bitmap operations

2015-05-08 Thread Eric Blake
cause the internal snapshot to live in a.qcow2. -- Eric Blake eblake redhat com+1-919-301-3266 Libvirt virtualization library http://libvirt.org signature.asc Description: OpenPGP digital signature

Re: [Qemu-block] [Qemu-devel] [PATCH 01/34] qdict: Add qdict_array_entries()

2015-05-11 Thread Eric Blake
and change both functions. I'm not strongly opposed to keeping snprintf, but agree that if you want to clean it up to g_strdup_printf(), a separate patch hitting multiple uses would be cleaner than respinning this patch. -- Eric Blake eblake redhat com+1-919-301-3266 Libvirt virtualization

Re: [Qemu-block] [Qemu-devel] [PATCH 2/2] block: align bounce buffers to page

2015-05-11 Thread Eric Blake
style issues. -- Eric Blake eblake redhat com+1-919-301-3266 Libvirt virtualization library http://libvirt.org signature.asc Description: OpenPGP digital signature

Re: [Qemu-block] [PATCH v4 16/17] qapi: Expose new qcow2 overlap check options

2015-05-04 Thread Eric Blake
', '*overlap-check': 'Qcow2OverlapChecks', +'*overlap-structures': 'Qcow2OverlapStructures', '*cache-size': 'int', '*l2-cache-size': 'int', '*refcount-cache-size': 'int' } } -- Eric Blake eblake redhat com+1-919-301-3266 Libvirt

Re: [Qemu-block] [Qemu-devel] [PATCH 01/34] qdict: Add qdict_array_entries()

2015-05-08 Thread Eric Blake
of on your behalf. -- Eric Blake eblake redhat com+1-919-301-3266 Libvirt virtualization library http://libvirt.org signature.asc Description: OpenPGP digital signature

Re: [Qemu-block] [Qemu-devel] [PATCH 02/34] qdict: Add qdict_{set, copy}_default()

2015-05-08 Thread Eric Blake
. -- Eric Blake eblake redhat com+1-919-301-3266 Libvirt virtualization library http://libvirt.org signature.asc Description: OpenPGP digital signature

Re: [Qemu-block] [Qemu-devel] [PATCH 03/34] quorum: Use bdrv_open_image()

2015-05-08 Thread Eric Blake
--- block/quorum.c | 51 +++ 1 file changed, 11 insertions(+), 40 deletions(-) Reviewed-by: Eric Blake ebl...@redhat.com -- Eric Blake eblake redhat com+1-919-301-3266 Libvirt virtualization library http://libvirt.org signature.asc

Re: [Qemu-block] [Qemu-devel] [PATCH v2 3/5] raw-posix: DPRINTF instead of DEBUG_BLOCK_PRINT

2015-05-11 Thread Eric Blake
On 05/08/2015 02:10 PM, Eric Blake wrote: On 05/08/2015 11:47 AM, Dimitris Aragiorgis wrote: Building the QEMU tools fails if we #define DEBUG_BLOCK inside block/raw-posix.c. Here instead of adding qemu-log.o in block-obj-y so that DEBUG_BLOCK_PRINT can be used, we substitute the latter

Re: [Qemu-block] [Qemu-devel] [PATCH 07/34] block: Move flag inheritance to bdrv_open_inherited()

2015-05-08 Thread Eric Blake
++- include/block/block_int.h | 7 + 7 files changed, 78 insertions(+), 22 deletions(-) Took me a while to follow the flow of information, but looks correct. Reviewed-by: Eric Blake ebl...@redhat.com -- Eric Blake eblake redhat com+1-919-301-3266 Libvirt virtualization library http

Re: [Qemu-block] [Qemu-devel] [PATCH 04/34] vmdk: Use bdrv_open_image()

2015-05-08 Thread Eric Blake
. Signed-off-by: Kevin Wolf kw...@redhat.com --- block/vmdk.c | 34 +- 1 file changed, 21 insertions(+), 13 deletions(-) Reviewed-by: Eric Blake ebl...@redhat.com -- Eric Blake eblake redhat com+1-919-301-3266 Libvirt virtualization library http

Re: [Qemu-block] [Qemu-devel] [PATCH 05/34] block: Use macro for cache option names

2015-05-08 Thread Eric Blake
On 05/08/2015 11:21 AM, Kevin Wolf wrote: Signed-off-by: Kevin Wolf kw...@redhat.com --- blockdev.c| 24 include/block/block.h | 8 2 files changed, 20 insertions(+), 12 deletions(-) Reviewed-by: Eric Blake ebl...@redhat.com -- Eric Blake

Re: [Qemu-block] [Qemu-devel] [PATCH 06/34] block: Use QemuOpts in bdrv_open_common()

2015-05-08 Thread Eric Blake
-coding everything. s/managable/manageable/ Signed-off-by: Kevin Wolf kw...@redhat.com --- block.c | 37 - 1 file changed, 32 insertions(+), 5 deletions(-) Reviewed-by: Eric Blake ebl...@redhat.com -- Eric Blake eblake redhat com+1-919-301-3266

Re: [Qemu-block] [Qemu-devel] [PATCH 08/34] block: Add list of children to BlockDriverState

2015-05-08 Thread Eric Blake
+++ include/block/block_int.h | 8 2 files changed, 35 insertions(+) Reviewed-by: Eric Blake ebl...@redhat.com and now I'm starting to see why you passed a well-named instance of a struct that contains only a single function pointer, rather than the function

Re: [Qemu-block] [PATCH v3] block/vdi: Use bdrv_flush after metadata updates

2015-05-07 Thread Eric Blake
to attribute both for signing patches and for sending email). It is also acceptable to use UTF-8 to spell your name in native characters, or even a combination of native name (ascii counterpart) -- Eric Blake eblake redhat com+1-919-301-3266 Libvirt virtualization library http://libvirt.org

Re: [Qemu-block] [PATCH 3/7] qcow2: use an LRU algorithm to replace entries from the L2 cache

2015-05-07 Thread Eric Blake
the table some hits for the start so that it won't be replaced * immediately. The number 32 is completely arbitrary. */ -c-entries[i].cache_hits = 32; c-entries[i].offset = offset; The comment is now dead. -- Eric Blake eblake redhat com+1-919-301-3266 Libvirt virtualization

Re: [Qemu-block] [Qemu-devel] [PATCH 09/34] block: Add BlockDriverState.inherits_from

2015-05-08 Thread Eric Blake
--- block.c | 17 + include/block/block_int.h | 4 2 files changed, 21 insertions(+) Reviewed-by: Eric Blake ebl...@redhat.com -- Eric Blake eblake redhat com+1-919-301-3266 Libvirt virtualization library http://libvirt.org signature.asc Description

Re: [Qemu-block] [Qemu-devel] [PATCH v2 3/5] raw-posix: DPRINTF instead of DEBUG_BLOCK_PRINT

2015-05-08 Thread Eric Blake
0 #endif #define DPRINTF(fmt, ...) \ do \ if (DEBUG_BLOCK_PRINT) { \ printf(fmt, ## __VA_ARGS__); \ while (0) that way, the compiler checks that the printf format arguments are valid while still optimizing out the if(0) code. -- Eric Blake eblake redhat com+1-919-301-3266

Re: [Qemu-block] [Qemu-devel] [PATCH 2/5] util: move read_password method out of qemu-img into osdep/oslib

2015-05-12 Thread Eric Blake
os_mem_prealloc(int fd, char *area, size_t sz); +int qemu_read_password(char *buf, int buf_size); Should we fix it to use size_t buf_size while at it? (or as a followup, to keep this one limited to code motion) Reviewed-by: Eric Blake ebl...@redhat.com -- Eric Blake eblake redhat com+1-919-301-3266

Re: [Qemu-block] [Qemu-devel] [PATCH 1/5] qcow2/qcow: protect against uninitialized encryption key

2015-05-12 Thread Eric Blake
changed, 21 insertions(+), 10 deletions(-) Reviewed-by: Eric Blake ebl...@redhat.com -- Eric Blake eblake redhat com+1-919-301-3266 Libvirt virtualization library http://libvirt.org signature.asc Description: OpenPGP digital signature

Re: [Qemu-block] [Qemu-devel] [PATCH 3/5] util: allow \n to terminate password input

2015-05-12 Thread Eric Blake
case we must look for \n to terminate password input. Signed-off-by: Daniel P. Berrange berra...@redhat.com --- util/oslib-posix.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) Reviewed-by: Eric Blake ebl...@redhat.com -- Eric Blake eblake redhat com+1-919-301-3266 Libvirt

Re: [Qemu-block] [Qemu-devel] [PATCH 5/5] tests: add test case for encrypted qcow2 read/write

2015-05-12 Thread Eric Blake
. (Unless we want to play the Who gets merged first? game.) That's the sort of conflict that I expect a maintainer can clean up, if there is no other reason for a respin (although it is not always easy to coax git into understanding that a patch would be valid if the file is renamed. -- Eric Blake

Re: [Qemu-block] [Qemu-devel] [PATCH 14/34] qcow2: Factor out qcow2_update_options()

2015-05-12 Thread Eric Blake
: + none, constant, cached, all, opt_overlap_check); Pre-existing due to code motion, but I find s/either/any/ easier to read. Reviewed-by: Eric Blake ebl...@redhat.com -- Eric Blake eblake redhat com+1-919-301-3266 Libvirt virtualization library http://libvirt.org signature.asc Description

Re: [Qemu-block] [Qemu-devel] [PATCH 16/34] qcow2: Move rest of option handling to qcow2_update_options()

2015-05-12 Thread Eric Blake
+- 1 file changed, 55 insertions(+), 54 deletions(-) Reviewed-by: Eric Blake ebl...@redhat.com -- Eric Blake eblake redhat com+1-919-301-3266 Libvirt virtualization library http://libvirt.org signature.asc Description: OpenPGP digital signature

Re: [Qemu-block] [Qemu-devel] [PATCH 18/34] qcow2: Fix memory leak in qcow2_update_options() error path

2015-05-12 Thread Eric Blake
On 05/08/2015 11:21 AM, Kevin Wolf wrote: Signed-off-by: Kevin Wolf kw...@redhat.com --- block/qcow2.c | 12 ++-- 1 file changed, 10 insertions(+), 2 deletions(-) Reviewed-by: Eric Blake ebl...@redhat.com -- Eric Blake eblake redhat com+1-919-301-3266 Libvirt virtualization

Re: [Qemu-block] [Qemu-devel] [PATCH 20/34] qcow2: Support updating driver-specific options in reopen

2015-05-12 Thread Eric Blake
: +qcow2_update_options_abort(state-bs, r); +return ret; Doesn't this leak r? That is, you only free r if _commit or _abort is reached, but my understanding of transaction semantics is that we only guarantee that one of those is reached if _prepare succeeded. -- Eric Blake eblake redhat com+1-919

Re: [Qemu-block] [Qemu-devel] [PATCH 15/34] qcow2: Move qcow2_update_options() call up

2015-05-12 Thread Eric Blake
(). Signed-off-by: Kevin Wolf kw...@redhat.com --- block/qcow2.c | 18 +- 1 file changed, 9 insertions(+), 9 deletions(-) Reviewed-by: Eric Blake ebl...@redhat.com -- Eric Blake eblake redhat com+1-919-301-3266 Libvirt virtualization library http://libvirt.org signature.asc

Re: [Qemu-block] [Qemu-devel] [PATCH 17/34] qcow2: Leave s unchanged on qcow2_update_options() failure

2015-05-12 Thread Eric Blake
1 file changed, 32 insertions(+), 20 deletions(-) Reviewed-by: Eric Blake ebl...@redhat.com -- Eric Blake eblake redhat com+1-919-301-3266 Libvirt virtualization library http://libvirt.org signature.asc Description: OpenPGP digital signature

Re: [Qemu-block] [Qemu-devel] [PATCH 19/34] qcow2: Make qcow2_update_options() suitable for transactions

2015-05-12 Thread Eric Blake
++ 1 file changed, 67 insertions(+), 34 deletions(-) In isolation, it looks like a valid conversion, so: Reviewed-by: Eric Blake ebl...@redhat.com However, given that we are having a conversation on another thread about semantics for prepare vs. commit being the action that actually

Re: [Qemu-block] [PATCH v3 3/5] raw-posix: DPRINTF instead of DEBUG_BLOCK_PRINT

2015-05-14 Thread Eric Blake
, XFS_IOC_UNRESVSP64, fl) 0) { -DEBUG_BLOCK_PRINT(cannot punch hole (%s)\n, strerror(errno)); +DPRINTF(cannot punch hole (%s)\n, strerror(errno)); return -errno; Here too. -- Eric Blake eblake redhat com+1-919-301-3266 Libvirt virtualization library http://libvirt.org

Re: [Qemu-block] [Qemu-devel] [PATCH 21/34] block: Consider all block layer options in append_open_options

2015-05-12 Thread Eric Blake
complexity, at a future date. Reviewed-by: Eric Blake ebl...@redhat.com -- Eric Blake eblake redhat com+1-919-301-3266 Libvirt virtualization library http://libvirt.org signature.asc Description: OpenPGP digital signature

Re: [Qemu-block] [Qemu-devel] [PATCH 31/34] block: Move cache options into options QDict

2015-05-15 Thread Eric Blake
to see how hard it would be to modernize a bit, since I've already been touching in that area (the recent addition of qnull copied heavily from qbool). -- Eric Blake eblake redhat com+1-919-301-3266 Libvirt virtualization library http://libvirt.org signature.asc Description: OpenPGP digital

Re: [Qemu-block] [Qemu-devel] [PATCH 14/34] qcow2: Factor out qcow2_update_options()

2015-05-13 Thread Eric Blake
On 05/13/2015 03:11 AM, Kevin Wolf wrote: Am 12.05.2015 um 22:04 hat Eric Blake geschrieben: On 05/08/2015 11:21 AM, Kevin Wolf wrote: Eventually we want to be able to change options at runtime. As a first step towards that goal, separate some option handling code from the general

Re: [Qemu-block] [Qemu-devel] [PATCH 10/34] block: Fix reopen flag inheritance

2015-05-12 Thread Eric Blake
. Signed-off-by: Kevin Wolf kw...@redhat.com --- block.c | 13 +++-- block/vmdk.c | 28 ++-- 2 files changed, 13 insertions(+), 28 deletions(-) Reviewed-by: Eric Blake ebl...@redhat.com -- Eric Blake eblake redhat com+1-919-301-3266 Libvirt

Re: [Qemu-block] [Qemu-devel] [PATCH 13/34] qemu-io: Add command 'reopen'

2015-05-12 Thread Eric Blake
or upper case, so you added one of each :) -- Eric Blake eblake redhat com+1-919-301-3266 Libvirt virtualization library http://libvirt.org signature.asc Description: OpenPGP digital signature

[Qemu-block] [PATCH] qemu-io: Use getopt() correctly

2015-05-12 Thread Eric Blake
POSIX says getopt() returns -1 on completion. While Linux happens to define EOF as -1, this definition is not required by POSIX, and there may be platforms where checking for EOF instead of -1 would lead to an infinite loop. Signed-off-by: Eric Blake ebl...@redhat.com --- qemu-io-cmds.c | 16

Re: [Qemu-block] [Qemu-devel] [PATCH 12/34] block: Allow specifying driver-specific options to reopen

2015-05-12 Thread Eric Blake
+ * (the BlockReopenQueue takes the ownership) 'takes ownership' reads a bit more idiomatically, but what you have is not wrong. -- Eric Blake eblake redhat com+1-919-301-3266 Libvirt virtualization library http://libvirt.org signature.asc Description: OpenPGP digital signature

Re: [Qemu-block] [PATCH v2 01/11] qapi: Add transaction support to block-dirty-bitmap operations

2015-04-17 Thread Eric Blake
-schema.json | 6 +++- 2 files changed, 105 insertions(+), 1 deletion(-) Reviewed-by: Eric Blake ebl...@redhat.com -- Eric Blake eblake redhat com+1-919-301-3266 Libvirt virtualization library http://libvirt.org signature.asc Description: OpenPGP digital signature

Re: [Qemu-block] [PATCH v5 04/21] qmp: Add block-dirty-bitmap-add and block-dirty-bitmap-remove

2015-04-17 Thread Eric Blake
| 56 6 files changed, 250 insertions(+), 9 deletions(-) Reviewed-by: Eric Blake ebl...@redhat.com -- Eric Blake eblake redhat com+1-919-301-3266 Libvirt virtualization library http://libvirt.org signature.asc Description: OpenPGP digital signature

Re: [Qemu-block] [PATCH v5 01/21] docs: incremental backup documentation

2015-04-17 Thread Eric Blake
assuming that [PATCH v2 00/11] block: incremental backup transactions is incomplete, because it forgot to clean this up as part of adding transaction support. + +5. Retry the command after fixing the underlaying problem, s/underlaying/underlying/ -- Eric Blake eblake redhat com+1-919-301

Re: [Qemu-block] [PATCH 3/3] block: add 'node-name' field to BLOCK_IMAGE_CORRUPTED

2015-04-08 Thread Eric Blake
that is reserved for the qcow2 header - but we CAN encounter a read error while reading the qcow2 header). Reviewed-by: Eric Blake ebl...@redhat.com -- Eric Blake eblake redhat com+1-919-301-3266 Libvirt virtualization library http://libvirt.org

Re: [Qemu-block] [PATCH v2 08/11] block: move transactions beneath qmp interfaces

2015-04-17 Thread Eric Blake
movement. Max -- Eric Blake eblake redhat com+1-919-301-3266 Libvirt virtualization library http://libvirt.org signature.asc Description: OpenPGP digital signature

Re: [Qemu-block] [PATCH v5 01/21] docs: incremental backup documentation

2015-04-17 Thread Eric Blake
On 04/17/2015 09:50 AM, John Snow wrote: On 04/17/2015 11:06 AM, Eric Blake wrote: On 04/08/2015 04:19 PM, John Snow wrote: Reviewed-by: Max Reitz mre...@redhat.com Signed-off-by: John Snow js...@redhat.com --- docs/bitmaps.md | 311

Re: [Qemu-block] [PATCH v5 12/21] qmp: Add dirty bitmap status field in query-block

2015-04-17 Thread Eric Blake
...@redhat.com --- block.c | 1 + qapi/block-core.json | 5 - 2 files changed, 5 insertions(+), 1 deletion(-) Reviewed-by: Eric Blake ebl...@redhat.com -- Eric Blake eblake redhat com+1-919-301-3266 Libvirt virtualization library http://libvirt.org signature.asc

Re: [Qemu-block] [PATCH v5 09/21] block: Add bitmap successors

2015-04-17 Thread Eric Blake
with capitals after comma, Even with a line break, Look weird. (s/Delete/delete/) + +/** + * In cases of failure where we can no longer safely delete the parent, + * We may wish to re-join the parent and child/successor. and again (s/We/we/) Grammar fixes are minor, so: Reviewed-by: Eric Blake

Re: [Qemu-block] [PATCH v5 10/21] qmp: Add support of dirty-bitmap sync mode for drive-backup

2015-04-17 Thread Eric Blake
for anonymous inline types is not there yet). -- Eric Blake eblake redhat com+1-919-301-3266 Libvirt virtualization library http://libvirt.org signature.asc Description: OpenPGP digital signature

Re: [Qemu-block] [PATCH v5 10/21] qmp: Add support of dirty-bitmap sync mode for drive-backup

2015-04-17 Thread Eric Blake
. Is it an error if bitmap is supplied, but mode is not dirty-bitmap? Likewise, if mode is dirty-bitmap but bitmap is not supplied? -- Eric Blake eblake redhat com+1-919-301-3266 Libvirt virtualization library http://libvirt.org signature.asc Description: OpenPGP digital signature

Re: [Qemu-block] [PATCH v5 11/21] qmp: add block-dirty-bitmap-clear

2015-04-17 Thread Eric Blake
...@redhat.com Reviewed-by: Max Reitz mre...@redhat.com Reviewed-by: Stefan Hajnoczi stefa...@redhat.com --- Reviewed-by: Eric Blake ebl...@redhat.com -- Eric Blake eblake redhat com+1-919-301-3266 Libvirt virtualization library http://libvirt.org signature.asc Description: OpenPGP

Re: [Qemu-block] [Qemu-devel] block-commit dropping privs

2015-04-03 Thread Eric Blake
] (empty) So I think it makes sense to provide an option even for the non-active layer block commit case to empty the topmost committed overlay, while dropping the other intermediates. At any rate, I'm glad I've got you thinking about it. -- -- Eric Blake eblake redhat com

Re: [Qemu-block] [Qemu-devel] [PATCH for-2.3 v2] qcow2: Fix header update with overridden backing file

2015-04-07 Thread Eric Blake
insertions(+), 7 deletions(-) create mode 100755 tests/qemu-iotests/130 create mode 100644 tests/qemu-iotests/130.out Reviewed-by: Eric Blake ebl...@redhat.com -- Eric Blake eblake redhat com+1-919-301-3266 Libvirt virtualization library http://libvirt.org signature.asc Description

Re: [Qemu-block] [PATCH 2/3] block: use bdrv_get_device_or_node_name() in error messages

2015-04-08 Thread Eric Blake
(errp, Block format '%s' used by device '%s' + does not support internal snapshots, + bs-drv-format_name, device); but this is probably another one where node may be better. But it's already a strict improvement, so I can live with: Reviewed-by: Eric Blake ebl

Re: [Qemu-block] [Qemu-devel] [RFC] Intermediate block mirroring

2015-04-02 Thread Eric Blake
something worth having. The devil may be in the details, but we can get there when you post proposed patches. Thanks, Berto -- Eric Blake eblake redhat com+1-919-301-3266 Libvirt virtualization library http://libvirt.org signature.asc Description: OpenPGP digital signature

Re: [Qemu-block] [Qemu-devel] [PATCH] MAINTAINERS: Split Block QAPI, monitor, command line off core

2015-05-20 Thread Eric Blake
On 05/20/2015 05:23 AM, Markus Armbruster wrote: Kevin and Stefan asked me to take care of this part. Signed-off-by: Markus Armbruster arm...@redhat.com --- MAINTAINERS | 8 1 file changed, 8 insertions(+) Reviewed-by: Eric Blake ebl...@redhat.com diff --git a/MAINTAINERS b

Re: [Qemu-block] [PATCH v3 08/38] block: Invoke change media CB before NULLing drv

2015-06-03 Thread Eric Blake
deletions(-) Reviewed-by: Eric Blake ebl...@redhat.com -- Eric Blake eblake redhat com+1-919-301-3266 Libvirt virtualization library http://libvirt.org signature.asc Description: OpenPGP digital signature

Re: [Qemu-block] [PATCH v3 13/38] block: Remove wr_highest_sector from BlockAcctStats

2015-06-03 Thread Eric Blake
block/io.c | 4 +++- block/qapi.c | 4 ++-- include/block/accounting.h | 3 --- include/block/block_int.h | 3 +++ qmp-commands.hx| 4 ++-- 6 files changed, 10 insertions(+), 16 deletions(-) Reviewed-by: Eric Blake ebl...@redhat.com -- Eric

Re: [Qemu-block] [PATCH v3 18/38] block: Fail requests to empty BlockBackend

2015-06-03 Thread Eric Blake
++- 1 file changed, 54 insertions(+), 1 deletion(-) Reviewed-by: Eric Blake ebl...@redhat.com -- Eric Blake eblake redhat com+1-919-301-3266 Libvirt virtualization library http://libvirt.org signature.asc Description: OpenPGP digital signature

Re: [Qemu-block] [PATCH v3 10/38] hw/usb-storage: Check whether BB is inserted

2015-06-03 Thread Eric Blake
error handling here (https://lists.gnu.org/archive/html/qemu-devel/2015-06/msg00431.html) Reviewed-by: Eric Blake ebl...@redhat.com -- Eric Blake eblake redhat com+1-919-301-3266 Libvirt virtualization library http://libvirt.org signature.asc Description: OpenPGP digital signature

Re: [Qemu-block] [PATCH v3 04/38] block: Make bdrv_is_inserted() return a bool

2015-06-03 Thread Eric Blake
On 06/03/2015 01:43 PM, Max Reitz wrote: Make bdrv_is_inserted(), blk_is_inserted(), and the callback BlockDriver.bdrv_is_inserted() return a bool. Suggested-by: Eric Blake ebl...@redhat.com Signed-off-by: Max Reitz mre...@redhat.com --- block.c| 12

Re: [Qemu-block] [PATCH v3 01/38] block: Remove host floppy support

2015-06-03 Thread Eric Blake
insertions(+), 226 deletions(-) Dropping is not backwards-compatible, but that was the whole point of deprecating it to make it obvious that we planned to do it. Reviewed-by: Eric Blake ebl...@redhat.com @@ -2283,14 +2221,13 @@ static int hdev_create(const char *filename, QemuOpts *opts, int64_t

Re: [Qemu-block] [PATCH v3 02/38] blockdev: Allow creation of BDS trees without BB

2015-06-03 Thread Eric Blake
+++- qapi/block-core.json | 13 + tests/qemu-iotests/087 | 2 +- tests/qemu-iotests/087.out | 4 ++-- 4 files changed, 43 insertions(+), 20 deletions(-) Reviewed-by: Eric Blake ebl...@redhat.com -- Eric Blake eblake redhat com+1-919-301-3266 Libvirt virtualization

Re: [Qemu-block] [PATCH v3 09/38] hw/block/fdc: Implement tray status

2015-06-03 Thread Eric Blake
, but does not have to be this series. Reviewed-by: Eric Blake ebl...@redhat.com -- Eric Blake eblake redhat com+1-919-301-3266 Libvirt virtualization library http://libvirt.org signature.asc Description: OpenPGP digital signature

Re: [Qemu-block] [PATCH 1/9] qapi: Rename 'dirty-bitmap' mode to 'incremental'

2015-06-04 Thread Eric Blake
| 8 include/block/block_int.h | 2 +- qapi/block-core.json | 8 qmp-commands.hx | 6 +++--- tests/qemu-iotests/124| 10 +- 7 files changed, 24 insertions(+), 24 deletions(-) Reviewed-by: Eric Blake ebl...@redhat.com -- Eric Blake

Re: [Qemu-block] [PATCH 4/9] qapi: add Copy data type for bitmaps

2015-06-04 Thread Eric Blake
insertions(+) Reviewed-by: Eric Blake ebl...@redhat.com Might be okay to squash this with a patch that starts using it; but I'm also okay leaving it as-is. Up to you. -- Eric Blake eblake redhat com+1-919-301-3266 Libvirt virtualization library http://libvirt.org signature.asc Description

Re: [Qemu-block] [PATCH 2/9] hbitmap: add hbitmap_copy

2015-06-04 Thread Eric Blake
/hbitmap.h | 9 + util/hbitmap.c | 17 + 2 files changed, 26 insertions(+) Reviewed-by: Eric Blake ebl...@redhat.com -- Eric Blake eblake redhat com+1-919-301-3266 Libvirt virtualization library http://libvirt.org signature.asc Description: OpenPGP digital

Re: [Qemu-block] [PATCH 5/9] qmp: add qmp cmd block-dirty-bitmap-copy

2015-06-04 Thread Eric Blake
small enough, even if you leave it in, that I don't mind giving: Reviewed-by: Eric Blake ebl...@redhat.com -- Eric Blake eblake redhat com+1-919-301-3266 Libvirt virtualization library http://libvirt.org signature.asc Description: OpenPGP digital signature

Re: [Qemu-block] [PATCH v3 26/38] blockdev: Add blockdev-open-tray

2015-06-03 Thread Eric Blake
On 06/03/2015 01:44 PM, Max Reitz wrote: Signed-off-by: Max Reitz mre...@redhat.com Reviewed-by: Eric Blake ebl...@redhat.com --- blockdev.c | 48 qapi/block-core.json | 23 +++ qmp-commands.hx | 39

Re: [Qemu-block] [PATCH v3 33/38] qmp: Introduce blockdev-change-medium

2015-06-03 Thread Eric Blake
...@redhat.com Reviewed-by: Eric Blake ebl...@redhat.com --- blockdev.c| 7 --- include/sysemu/blockdev.h | 2 -- qapi-schema.json | 6 -- qapi/block-core.json | 23 +++ qmp-commands.hx | 31

Re: [Qemu-block] [PATCH v8 07/10] qcow2: Add function for refcount order amendment

2015-06-03 Thread Eric Blake
| 4 + 2 files changed, 451 insertions(+) Reviewed-by: Eric Blake ebl...@redhat.com -- Eric Blake eblake redhat com+1-919-301-3266 Libvirt virtualization library http://libvirt.org signature.asc Description: OpenPGP digital signature

Re: [Qemu-block] [PATCH v3 38/38] iotests: Add test for change-related QMP commands

2015-06-03 Thread Eric Blake
@@ -121,6 +121,7 @@ 114 rw auto quick 115 rw auto 116 rw auto quick +118 rw auto 121 rw auto Wow - we've got several placeholders pending review :) Reviewed-by: Eric Blake ebl...@redhat.com -- Eric Blake eblake redhat com+1-919-301-3266 Libvirt virtualization library http://libvirt.org

Re: [Qemu-block] [PATCH v3 31/38] blockdev: Implement change with basic operations

2015-06-03 Thread Eric Blake
--- blockdev.c | 185 + 1 file changed, 77 insertions(+), 108 deletions(-) Reviewed-by: Eric Blake ebl...@redhat.com -- Eric Blake eblake redhat com+1-919-301-3266 Libvirt virtualization library http://libvirt.org signature.asc

  1   2   3   4   5   6   7   8   9   10   >