On 16/04/2015 14:18, Peter Lieven wrote:
We need this to support SCSI_STATUS_TASK_SET_FULL.
Any reason apart from the missing constant?
Paolo
Signed-off-by: Peter Lieven p...@kamp.de
---
configure | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/configure
Am 16.04.2015 um 14:33 schrieb Paolo Bonzini:
On 16/04/2015 14:18, Peter Lieven wrote:
We need this to support SCSI_STATUS_TASK_SET_FULL.
Any reason apart from the missing constant?
No, but I wanted to avoid starting checking for constants that were added
shortly after this.
You can't
Signed-off-by: Peter Lieven p...@kamp.de
---
block/iscsi.c | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/block/iscsi.c b/block/iscsi.c
index 6cf7e99..221c9fc 100644
--- a/block/iscsi.c
+++ b/block/iscsi.c
@@ -1253,11 +1253,11 @@ static void
Am 16.04.2015 um 14:42 schrieb Paolo Bonzini:
On 16/04/2015 14:18, Peter Lieven wrote:
SCSI allowes to tell the target to not return from a write command
if the date is not written to the disk. Use this so called FUA
bit if it is supported to optimize WRITE commands if writeback is
not
Signed-off-by: Peter Lieven p...@kamp.de
---
block/iscsi.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/block/iscsi.c b/block/iscsi.c
index 3d0ffeb..04c1309 100644
--- a/block/iscsi.c
+++ b/block/iscsi.c
@@ -2,7 +2,7 @@
* QEMU Block driver for iSCSI images
*
*
On Thu 16 Apr 2015 02:27:39 PM CEST, Eric Blake wrote:
+orig_bs_flags = bdrv_get_flags(bs);
+if (!(orig_bs_flags BDRV_O_RDWR)) {
I feel like we don't want to do this if we're not streaming to an
intermediate layer but to the top layer (because that means there is
some reason for
On 16/04/2015 15:02, Peter Lieven wrote:
Also, I think it is iscsi_co_generic_cb that should set
force_next_flush, so that it is only set on failure. Not really for the
optimization value, but because it's clearer.
I don't get what you mean with it should only set on failure.
My
This makes sure that the image we are steaming into is open in
read-write mode during the operation.
Operation blockers are also set in all intermediate nodes, since they
will be removed from the chain afterwards.
Finally, this also unblocks the stream operation in backing files.
Signed-off-by:
New series.
As I wrote in a separate e-mail, we don't need to have any additional
checks on the top image before reopening it in R/W mode since
bdrv_reopen_prepare() already takes care of checking the
BDRV_O_ALLOW_RDWR flag, which serves our purpose.
v4:
- Refactor find_block_job to use the
We need to call stream_complete() in order to do all the necessary
clean-ups, even if there's an early failure. At the moment it's only
useful to make sure that s-backing_file_str is not leaked, but it
will become more important as we introduce support for streaming to
any intermediate node.
Signed-off-by: Alberto Garcia be...@igalia.com
---
docs/live-block-ops.txt | 30 +++---
1 file changed, 19 insertions(+), 11 deletions(-)
diff --git a/docs/live-block-ops.txt b/docs/live-block-ops.txt
index a257087..3bf86be 100644
--- a/docs/live-block-ops.txt
+++
SCSI allowes to tell the target to not return from a write command
if the date is not written to the disk. Use this so called FUA
bit if it is supported to optimize WRITE commands if writeback is
not allowed.
In this case qemu always issues a WRITE followed by a FLUSH. This
is 2 round trip times.
v1-v2: - removed the requirement for libiscsi 1.10.0 [Paolo]
- reworked to force_next_flush logic [Paolo]
Peter Lieven (9):
block/iscsi: do not forget to logout from target
block/iscsi: change all iscsilun properties from uint8_t to bool
block/iscsi: rename iscsi_write_protected and
the allocationmap has only a hint character. The driver always
double checks that blocks marked unallocated in the cache are
still unallocated before taking the fast path and return zeroes.
So using the allocationmap is migration safe and can
also be enabled with cache.direct=on.
Signed-off-by:
14 matches
Mail list logo
