NCQ commands are LBA48 by definition.
See SATA 3.2 13.6.4.1 READ FPDMA QUEUED, or
SATA 3.2 13.6.5.1 WRITE FPDMA QUEUED.
Signed-off-by: John Snow js...@redhat.com
---
tests/libqos/ahci.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tests/libqos/ahci.c
NCQ frames are generated a little differently than
their non-NCQ cousins. Add support for them.
Signed-off-by: John Snow js...@redhat.com
---
tests/libqos/ahci.c | 44 +++-
tests/libqos/ahci.h | 29 -
2 files changed, 63
Signed-off-by: John Snow js...@redhat.com
---
tests/ahci-test.c | 15 +--
1 file changed, 13 insertions(+), 2 deletions(-)
diff --git a/tests/ahci-test.c b/tests/ahci-test.c
index 941e0dd..206e6bb 100644
--- a/tests/ahci-test.c
+++ b/tests/ahci-test.c
@@ -1140,9 +1140,9 @@ static
Test the NCQ pathways for a simple IO RW test.
Also, test that libqos doesn't explode when
running NCQ commands :)
Signed-off-by: John Snow js...@redhat.com
---
tests/ahci-test.c | 13 +
tests/libqos/ahci.c | 46 +-
tests/libqos/ahci.h |
Trivial cleanup that I didn't want to tack-on to anything else.
Signed-off-by: John Snow js...@redhat.com
---
hw/ide/ahci.c | 18 ++
1 file changed, 10 insertions(+), 8 deletions(-)
diff --git a/hw/ide/ahci.c b/hw/ide/ahci.c
index 26df2ca..14eccb8 100644
--- a/hw/ide/ahci.c
+++
NCQ commands have the concept of a TAG that they need to set,
but in the AHCI world, it is mandated that the TAG always match
the command slot that you executed the NCQ from.
See AHCI 9.3.1.1.5.2 Native Queued Commands.
Signed-off-by: John Snow js...@redhat.com
---
tests/libqos/ahci.c | 5 +
Most of the time, these bits can be safely ignored. For the purposes
of debugging however, it's nice to know that they're not being used.
Signed-off-by: John Snow js...@redhat.com
---
hw/ide/ahci.c | 25 +
1 file changed, 25 insertions(+)
diff --git a/hw/ide/ahci.c
The legacy ide command execution layer will clear any errors outstanding
before execution, but the NCQ layer doesn't.
Even on success, this register will remain clogged.
Clear it out before each NCQ command so the guest can tell if the
error code produced after completion is meaningful or not.
There's no real reason to have it bundled together, and this way
is a little nicer to follow if you have the AHCI spec pulled up.
Signed-off-by: John Snow js...@redhat.com
---
hw/ide/ahci.c | 23 ---
hw/ide/ahci.h | 3 ++-
2 files changed, 14 insertions(+), 12 deletions(-)
NCQ commands should not / do not update the byte count
in the command header post command, so this field is
meaningless for NCQ tests.
Signed-off-by: John Snow js...@redhat.com
---
tests/libqos/ahci.c | 46 --
tests/libqos/ahci.h | 3 +--
2 files
This value should not be size-corrected, 0 sectors does not imply
1 sector(s). This is just debug information, but it's misleading!
Signed-off-by: John Snow js...@redhat.com
---
hw/ide/ahci.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/hw/ide/ahci.c b/hw/ide/ahci.c
At 2015/6/19 18:49, Stefan Hajnoczi Wrote:
On Fri, Jun 19, 2015 at 08:54:56AM +0800, Wen Congyang wrote:
On 06/19/2015 12:06 AM, Stefan Hajnoczi wrote:
On Thu, Jun 18, 2015 at 10:36:39PM +0800, Wen Congyang wrote:
At 2015/6/18 20:55, Stefan Hajnoczi Wrote:
On Thu, Jun 18, 2015 at 04:49:12PM
The wait command should check to make sure SACT is clear as well
as the Command Issue register.
Signed-off-by: John Snow js...@redhat.com
---
tests/libqos/ahci.c | 10 +++---
1 file changed, 7 insertions(+), 3 deletions(-)
diff --git a/tests/libqos/ahci.c b/tests/libqos/ahci.c
index
On Wed, May 20, 2015 at 12:57:38PM +0300, Dimitris Aragiorgis wrote:
Get rid of several #ifdef DEBUG_FLOPPY and substitute them with
DPRINTF.
Signed-off-by: Dimitris Aragiorgis dim...@arrikto.com
---
block/raw-posix.c | 22 +-
1 file changed, 5 insertions(+), 17
On Wed, May 20, 2015 at 12:57:35PM +0300, Dimitris Aragiorgis wrote:
Instead of checking bs-sg use bdrv_is_sg() consistently throughout
the code.
Signed-off-by: Dimitris Aragiorgis dim...@arrikto.com
Reviewed-by: Paolo Bonzini pbonz...@redhat.com
---
block.c |6 +++---
On 06/19/15 09:01, Markus Armbruster wrote:
Michael S. Tsirkin m...@redhat.com writes:
From: Laszlo Ersek ler...@redhat.com
It is Very annoying to carry forward an outdatEd coNtroller with a mOdern
Machine type.
Hence, let us not instantiate the FDC when all of the following apply:
- the
On Wed, May 20, 2015 at 12:57:39PM +0300, Dimitris Aragiorgis wrote:
This is very fragile, e.g. it fails with symlinks or relative paths.
This is not true since realpath(3) is used to resolve symlinks and
product an absolute path.
Is this patch really necessary?
pgp6OGy1HAkUi.pgp
Description:
Michael S. Tsirkin m...@redhat.com writes:
From: Laszlo Ersek ler...@redhat.com
It is Very annoying to carry forward an outdatEd coNtroller with a mOdern
Machine type.
Hence, let us not instantiate the FDC when all of the following apply:
- the machine type is pc-q35-2.4 or later,
-
Replace uses of g_test_add_data_func() for QTest test cases.
It is still valid to use it for any non-QTest test cases,
which are not run for multiple target binaries.
Suggested-by: John Snow js...@redhat.com
Reviewed-by: John Snow js...@redhat.com
Signed-off-by: Andreas Färber afaer...@suse.de
With Eduardo's recent patch (473a49460db0a90bfda046b8f3662b49f94098eb),
q35 machtypes earlier than 2.4 work as expected. Also, pc-q35-2.4 works
fine in the default case (no board-default FDC, which is what we want),
and the traditional option -drive if=floppy,... also works as expected.
However,
On 06/19/2015 02:17 PM, Laszlo Ersek wrote:
With Eduardo's recent patch (473a49460db0a90bfda046b8f3662b49f94098eb),
q35 machtypes earlier than 2.4 work as expected. Also, pc-q35-2.4 works
fine in the default case (no board-default FDC, which is what we want),
and the traditional option
21 matches
Mail list logo
