Re: [Qemu-block] [PATCH v2] iscsi: Fix divide-by-zero regression on raw SG devices

2016-09-08 Thread Holger Schranz
Hi Eric, Thanks a lot, it seems the patch works. The VM starting. Unfortunately we run into the next issue. By the accessing the megasas controller we got a SIGSEGV. See the trave below. Best regards Holger === Thread 4

[Qemu-block] [PATCH v4 1/1] block: improve error handling in raw_open

2016-09-08 Thread Halil Pasic
Make raw_open for POSIX more consistent in handling errors by setting the error object also when qemu_open fails. The error object was set generally set in case of errors, but I guess this case was overlooked. Do the same for win32. Signed-off-by: Halil Pasic

Re: [Qemu-block] [PATCH v2] iscsi: Fix divide-by-zero regression on raw SG devices

2016-09-08 Thread Eric Blake
On 09/08/2016 09:27 AM, Holger Schranz wrote: > Hi Eric, > > Thanks a lot, it seems the patch works. The VM starting. Should I take that as a Tested-by: line? > Unfortunately we run into the next issue. By the accessing the > megasas controller we got a SIGSEGV. Seems unrelated, let's figure

Re: [Qemu-block] [PATCH RFC v2 09/22] block/pcache: separation AIOCB on requests

2016-09-08 Thread Pavel Butsykin
On 02.09.2016 12:10, Kevin Wolf wrote: Am 29.08.2016 um 19:10 hat Pavel Butsykin geschrieben: for case when the cache partially covers request we are part of the request is filled from the cache, and the other part request from disk. Also add reference counting for nodes, as way to maintain

Re: [Qemu-block] [PATCH RFC v2 04/22] block/pcache: add pcache debug build

2016-09-08 Thread Eric Blake
On 08/29/2016 12:10 PM, Pavel Butsykin wrote: > Signed-off-by: Pavel Butsykin > --- > block/pcache.c | 9 + > 1 file changed, 9 insertions(+) > > diff --git a/block/pcache.c b/block/pcache.c > index 74a4bc4..7f221d6 100644 > --- a/block/pcache.c > +++

Re: [Qemu-block] [PATCH RFC v2 04/22] block/pcache: add pcache debug build

2016-09-08 Thread Eric Blake
On 09/08/2016 11:05 AM, Pavel Butsykin wrote: >>> >>> #ifdef PCACHE_DEBUG >>> # define PCACHE_DEBUG_PRINT 1 >>> #else >>> # define PCACHE_DEBUG_PRINT 0 >>> #endif >>> #define DPRINTF(fmt, ...) \ >>> do { \ >>> if (PCACHE_DEBUG_PRINT) { \ >>> fprintf(stderr, ...

Re: [Qemu-block] [PATCH RFC v2 08/22] block/pcache: implement pickup parts of the cache

2016-09-08 Thread Pavel Butsykin
On 02.09.2016 11:59, Kevin Wolf wrote: Am 29.08.2016 um 19:10 hat Pavel Butsykin geschrieben: Implementation of obtaining fragments of the cache belonging to one area of request. This will allow to handle the case when a request is partially hits the cache. Signed-off-by: Pavel Butsykin

Re: [Qemu-block] [PATCH v2] iscsi: Fix divide-by-zero regression on raw SG devices

2016-09-08 Thread Holger Schranz
Hi Eric, Am 08.09.2016 um 17:25 schrieb Eric Blake: On 09/08/2016 09:27 AM, Holger Schranz wrote: Hi Eric, Thanks a lot, it seems the patch works. The VM starting. Should I take that as a Tested-by: line? The test was: 1) login as root 2) cd to workdir 3) start virt-viewer: "virt-viewer