Re: [Qemu-block] [PATCH v8 06/12] crypto: Switch to QEMU UUID API

On Sun, Sep 18, 2016 at 12:25:26PM +0800, Fam Zheng wrote: > The uuid generation doesn't return error, so update the function > signature and calling code accordingly. > > Signed-off-by: Fam Zheng > Reviewed-by: Eric Blake > --- > crypto/block-luks.c | 26

Re: [Qemu-block] [Qemu-devel] [PATCH v8 05/12] vpc: Use QEMU UUID API

On Sun, Sep 18, 2016 at 12:25:25PM +0800, Fam Zheng wrote: > Previously we conditionally generated footer->uuid, when libuuid was > available. Now that we have a built-in implementation, we can switch to > it. > > Signed-off-by: Fam Zheng > Reviewed-by: Eric Blake

Re: [Qemu-block] [PATCH v8 07/12] tests: No longer dependent on CONFIG_UUID

On Sun, Sep 18, 2016 at 12:25:27PM +0800, Fam Zheng wrote: > crypto now uses built-in uuid implementation, so this check is not > needed. > > Signed-off-by: Fam Zheng > Reviewed-by: Eric Blake > --- > tests/test-crypto-block.c | 2 +- > 1 file changed, 1

Re: [Qemu-block] [Qemu-devel] [PATCH v8 09/12] vl: Switch qemu_uuid to QemuUUID

On Sun, Sep 18, 2016 at 12:25:29PM +0800, Fam Zheng wrote: > Update all qemu_uuid users as well, especially get rid of the duplicated > low level g_strdup_printf, sscanf and snprintf calls with QEMU UUID API. > > Since qemu_uuid_parse is quite tangled with qemu_uuid, its switching to > QemuUUID

Re: [Qemu-block] [PATCH v8 03/12] vhdx: Use QEMU UUID API

On Sun, Sep 18, 2016 at 12:25:23PM +0800, Fam Zheng wrote: > This removes our dependency to libuuid, so that the driver can always be > built. > > Similar to how we handled data plane configure options, --enable-vhdx > and --disable-vhdx are also changed to a nop with a message saying it's >

Re: [Qemu-block] [Qemu-devel] [PATCH v8 10/12] uuid: Tighten uuid parse

On Sun, Sep 18, 2016 at 12:25:30PM +0800, Fam Zheng wrote: > sscanf is relatively loose (tolerate) on some invalid formats that we > should fail instead of generating a wrong uuid structure, like with > whitespaces and short strings. > > Add and use a helper function to first check the format. >

Re: [Qemu-block] [PATCH v8 12/12] Add UUID files to MAINTAINERS

On Sun, Sep 18, 2016 at 12:25:32PM +0800, Fam Zheng wrote: > I understand that we've been keeping eyes on the uncovered files. Since > I'm adding some more files I volunteer to look after them in the futuer. > > Signed-off-by: Fam Zheng > --- > MAINTAINERS | 6 ++ > 1 file

Re: [Qemu-block] [Qemu-devel] [PATCH v3 1/2] block: sync bdrv_co_get_block_status_above() with bdrv_is_allocated_above()

On Thu, 09/15 19:34, Denis V. Lunev wrote: > They should work very similar, covering same areas if backing store is > shorter than the image. This change is necessary for the followup patch > switching to bdrv_get_block_status_above() in mirror to avoid assert > in check_block. > > This change

Re: [Qemu-block] [Qemu-devel] [PATCH v3 1/2] block: sync bdrv_co_get_block_status_above() with bdrv_is_allocated_above()

On 09/19/2016 04:21 AM, Fam Zheng wrote: > On Thu, 09/15 19:34, Denis V. Lunev wrote: >> They should work very similar, covering same areas if backing store is >> shorter than the image. This change is necessary for the followup patch >> switching to bdrv_get_block_status_above() in mirror to

Re: [Qemu-block] [PATCH v8 08/12] configure: Remove detection code for UUID

On Sun, Sep 18, 2016 at 12:25:28PM +0800, Fam Zheng wrote: > All code now uses built-in UUID implementation. Remove the code of > libuuid and make --enable-uuid and --disable-uuid only print a message. > > Signed-off-by: Fam Zheng > Reviewed-by: Eric Blake >

Re: [Qemu-block] [Qemu-devel] [PATCH v8 04/12] vdi: Use QEMU UUID API

On Sun, Sep 18, 2016 at 12:25:24PM +0800, Fam Zheng wrote: > The UUID operations we need from libuuid are fully supported by QEMU UUID > implementation. Use it, and remove the unused code. > > Signed-off-by: Fam Zheng > Reviewed-by: Eric Blake > --- >

Re: [Qemu-block] [PATCH v8 02/12] uuid: Make null_uuid static

On Sun, Sep 18, 2016 at 12:25:22PM +0800, Fam Zheng wrote: > So that it doesn't have to be zeroed at each call. > > Suggested-by: Eric Blake > Signed-off-by: Fam Zheng > --- > util/uuid.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff

Re: [Qemu-block] [Qemu-devel] [PATCH v8 01/12] util: Add UUID API

On Sun, Sep 18, 2016 at 12:25:21PM +0800, Fam Zheng wrote: > A number of different places across the code base use CONFIG_UUID. Some > of them are soft dependency, some are not built if libuuid is not > available, some come with dummy fallback, some throws runtime error. > > It is hard to