Re: [Qemu-block] [PATCH 09/22] block: introduce persistent dirty bitmaps

2016-10-12 Thread Max Reitz
On 11.10.2016 15:11, Vladimir Sementsov-Ogievskiy wrote: > On 07.10.2016 20:54, Max Reitz wrote: >> On 30.09.2016 12:53, Vladimir Sementsov-Ogievskiy wrote: >>> New field BdrvDirtyBitmap.persistent means, that bitmap should be saved >>> on bdrv_close, using format driver. Format driver should

Re: [Qemu-block] [PATCH 06/22] qcow2: add dirty bitmaps extension

2016-10-12 Thread Max Reitz
On 11.10.2016 14:09, Vladimir Sementsov-Ogievskiy wrote: > On 01.10.2016 17:46, Max Reitz wrote: >> On 30.09.2016 12:53, Vladimir Sementsov-Ogievskiy wrote: >>> Add dirty bitmap extension as specified in docs/specs/qcow2.txt. >>> For now, just mirror extension header into Qcow2 state and check >>>

Re: [Qemu-block] [Qemu-devel] [PATCH v14 11/21] qapi: add integer range support for QObjectInputVisitor

2016-10-12 Thread Markus Armbruster
Kevin Wolf writes: > Am 12.10.2016 um 17:50 hat Markus Armbruster geschrieben: >> "Daniel P. Berrange" writes: >> >> > The traditional CLI arg syntax allows two ways to specify >> > integer lists, either one value per key, or a range of >> > values per

Re: [Qemu-block] [PATCH 05/22] qcow2-bitmap: structs and consts

2016-10-12 Thread Max Reitz
On 11.10.2016 13:50, Vladimir Sementsov-Ogievskiy wrote: > On 01.10.2016 17:34, Max Reitz wrote: >> On 30.09.2016 12:53, Vladimir Sementsov-Ogievskiy wrote: >>> Create block/qcow2-bitmap.c >>> Add data structures and constraints accordingly to docs/specs/qcow2.txt >>> >>> Signed-off-by: Vladimir

Re: [Qemu-block] [PATCH 09/22] block: introduce persistent dirty bitmaps

2016-10-12 Thread Max Reitz
On 12.10.2016 14:30, Vladimir Sementsov-Ogievskiy wrote: > On 12.10.2016 14:38, Vladimir Sementsov-Ogievskiy wrote: >> On 07.10.2016 22:28, Max Reitz wrote: >>> On 30.09.2016 12:53, Vladimir Sementsov-Ogievskiy wrote: New field BdrvDirtyBitmap.persistent means, that bitmap should be saved

Re: [Qemu-block] [PATCH v4 0/3] iotests: Fix test 162

2016-10-12 Thread Max Reitz
On 12.10.2016 10:55, Hao QingFeng wrote: > Max, > > Just a common question for this case, if sshx block driver wasn't built > into qemu-img, this case would fail as below: Good point, and thanks for bringing it up, but it's not directly linked to this series other than by its subject, of course,

[Qemu-block] [PATCH 0/3] iotests: Skip 162 if there is no SSH support

2016-10-12 Thread Max Reitz
As reported by Hao QingFeng, iotest 162 is currently executed even if qemu does not have any SSH support (which makes it fail, naturally). Fixing that is not so trivial, because qemu-img currently does not report modules, and SSH can be compiled as a module, so that needs to be fixed first. While

[Qemu-block] [PATCH 1/3] block: Fix bdrv_iterate_format() sorting

2016-10-12 Thread Max Reitz
bdrv_iterate_format() did not actually sort the formats by name but by "pointer interpreted as string". That is probably not what we intended to do, so fix it (by changing qsort_strcmp() so it matches the example from qsort()'s manual page). Signed-off-by: Max Reitz ---

[Qemu-block] [PATCH 3/3] iotests: Skip test 162 if there is no SSH support

2016-10-12 Thread Max Reitz
Signed-off-by: Max Reitz --- tests/qemu-iotests/162 | 3 +++ 1 file changed, 3 insertions(+) diff --git a/tests/qemu-iotests/162 b/tests/qemu-iotests/162 index f8eecb3..cad2bd7 100755 --- a/tests/qemu-iotests/162 +++ b/tests/qemu-iotests/162 @@ -35,6 +35,9 @@ status=1 #

[Qemu-block] [PATCH 2/3] block: Emit modules in bdrv_iterate_format()

2016-10-12 Thread Max Reitz
Some block drivers may not be loaded yet, but qemu supports them nonetheless. bdrv_iterate_format() should report them, too. Signed-off-by: Max Reitz --- block.c | 18 ++ 1 file changed, 18 insertions(+) diff --git a/block.c b/block.c index e46e4b2..88a1ea5

Re: [Qemu-block] [Qemu-devel] [PATCH 1/3] block: Fix bdrv_iterate_format() sorting

2016-10-12 Thread Eric Blake
On 10/12/2016 03:49 PM, Max Reitz wrote: > bdrv_iterate_format() did not actually sort the formats by name but by > "pointer interpreted as string". That is probably not what we intended > to do, so fix it (by changing qsort_strcmp() so it matches the example > from qsort()'s manual page). > >

Re: [Qemu-block] [PATCH 0/4] Allow blockdev-add for SSH

2016-10-12 Thread Ashijeet Acharya
On Tue, Oct 11, 2016 at 1:07 PM, Ashijeet Acharya wrote: > This series adds blockdev-add support for SSH block driver. > > Patch 1 prepares the code for the addition of a new option prefix, > which is "server.". This is accomplished by adding a >

Re: [Qemu-block] [PATCH v2 07/11] blockjob: add .clean property

2016-10-12 Thread Vladimir Sementsov-Ogievskiy
On 01.10.2016 01:00, John Snow wrote: Cleaning up after we have deferred to the main thread but before the transaction has converged can be dangerous and result in deadlocks if the job cleanup invokes any BH polling loops. A job may attempt to begin cleaning up, but may induce another job to

Re: [Qemu-block] [PATCH v2 11/11] iotests: add transactional failure race test

2016-10-12 Thread Vladimir Sementsov-Ogievskiy
it is almost a duplication of test_transaction_failure, I think it would be better to make separate do_test_transaction_failure with parameter and two wrappers On 01.10.2016 01:00, John Snow wrote: Add a regression test for the case found by Vladimir. Reported-by: Vladimir

Re: [Qemu-block] [PATCH 09/22] block: introduce persistent dirty bitmaps

2016-10-12 Thread Vladimir Sementsov-Ogievskiy
On 07.10.2016 22:28, Max Reitz wrote: On 30.09.2016 12:53, Vladimir Sementsov-Ogievskiy wrote: New field BdrvDirtyBitmap.persistent means, that bitmap should be saved on bdrv_close, using format driver. Format driver should maintain bitmap storing. Signed-off-by: Vladimir Sementsov-Ogievskiy

Re: [Qemu-block] [Qemu-devel] [PATCH] qcow2: Support BDRV_REQ_MAY_UNMAP

2016-10-12 Thread Kevin Wolf
Am 12.10.2016 um 03:14 hat Fam Zheng geschrieben: > On Wed, 09/28 15:04, Fam Zheng wrote: > > Handling this is similar to what is done to the L2 entry in the case of > > compressed clusters. > > Kevin, Max, is there anything else I need to do before this patch can be > applied? Hm, actually, it

Re: [Qemu-block] [Qemu-devel] [PATCH v10 09/16] block: Add QMP support for streaming to an intermediate layer

2016-10-12 Thread Alberto Garcia
On Tue 11 Oct 2016 06:50:27 PM CEST, Markus Armbruster wrote: > * Is the extended command still a sane interface? If writing clear > documentation for it is hard, it perhaps isn't. Pay special > attention to failure modes. Overloaded arguments are prone to > confusing errors. This is

Re: [Qemu-block] [Qemu-devel] [PATCH v14 09/21] qapi: permit auto-creating single element lists

2016-10-12 Thread Markus Armbruster
"Daniel P. Berrange" writes: > When converting QemuOpts to a QObject, there is no information > about compound types available, Yes, that's a drawback of splitting the conversion into a QemuOpts -> QObject part that is oblivious of types, and a QObject -> QAPI object part

[Qemu-block] [PATCH] nbd: Use CoQueue for free_sema instead of CoMutex

2016-10-12 Thread Changlong Xie
NBD is using the CoMutex in a way that wasn't anticipated. For example, if there are N(N=26, MAX_NBD_REQUESTS=16) nbd write requests, so we will invoke nbd_client_co_pwritev N times. time request Actions 1

Re: [Qemu-block] [PATCH 0/4] Allow blockdev-add for SSH

2016-10-12 Thread Kevin Wolf
Am 12.10.2016 um 10:09 hat Ashijeet Acharya geschrieben: > I received a mail saying my series failed the automatic build test but > it builds completely fine (after applying Dan's patch obviously) in my > local environment. The reason why patchew fails to build your series is because it doesn't

Re: [Qemu-block] [PATCH 0/4] Allow blockdev-add for SSH

2016-10-12 Thread Ashijeet Acharya
> I received a mail saying my series failed the automatic build test but > it builds completely fine (after applying Dan's patch obviously) in my > local environment. > > Going through the config output of the test script, I see that the > supporting library for SSH which is "libssh2" seems to be

Re: [Qemu-block] [PATCH v4 0/3] iotests: Fix test 162

2016-10-12 Thread Hao QingFeng
Max, Just a common question for this case, if sshx block driver wasn't built into qemu-img, this case would fail as below: exec /home/haoqf/KVMonz/qemu/tests/qemu-iotests/../../qemu-img info --image-opts driver=ssh,host=localhost,port=0.42,path=/foo qemu-img: Could not open

Re: [Qemu-block] [Qemu-devel] [PATCH v3] block: Remove "options" indirection from blockdev-add

2016-10-12 Thread Fam Zheng
On Tue, 10/11 15:27, Kevin Wolf wrote: > Now that QAPI supports boxed types, we can have unions at the top level > of a command, so let's put our real options directly there for > blockdev-add instead of having a single "options" dict that contains the > real arguments. > > blockdev-add is still

Re: [Qemu-block] [Qemu-devel] [PATCH v14 08/21] qapi: allow QObjectInputVisitor to be created with QemuOpts

2016-10-12 Thread Markus Armbruster
"Daniel P. Berrange" writes: > Instead of requiring all callers to go through the mutli-step multi-step > process of turning QemuOpts into a suitable QObject for visiting, > add a new constructor that encapsulates this logic. This will > allow QObjectInputVisitor to be a

Re: [Qemu-block] [PATCH 0/4] Allow blockdev-add for SSH

2016-10-12 Thread Kevin Wolf
Am 12.10.2016 um 10:37 hat Ashijeet Acharya geschrieben: > On Wed, Oct 12, 2016 at 1:52 PM, Kevin Wolf wrote: > > Am 12.10.2016 um 10:09 hat Ashijeet Acharya geschrieben: > > > Of course, we must be able to build qemu correctly both with ssh enabled > > and disabled, so if you

Re: [Qemu-block] [Qemu-devel] [PATCH v10 09/16] block: Add QMP support for streaming to an intermediate layer

2016-10-12 Thread Alberto Garcia
On Tue 11 Oct 2016 06:32:39 PM CEST, Markus Armbruster wrote: >>> 3) QEMU could advertise that feature to the client. This is probably >>> simpler than trying to figure it out from the API. I guess that's >>> the idea of 'qmp_capabilities'? >> >> I think that was the idea, though it was never

Re: [Qemu-block] [PATCH 1/3] block: add BDS field to count in-flight requests

2016-10-12 Thread Paolo Bonzini
On 12/10/2016 11:50, Kevin Wolf wrote: > > (By the way, I need to repost this series anyway, but let's finish the > > discussion first to understand what you'd like to have in 2.8). > > I'm still not completely sold on the order in which we should do things, > but you've been insisting enough

Re: [Qemu-block] [Qemu-devel] [PATCH] nbd: Use CoQueue for free_sema instead of CoMutex

2016-10-12 Thread Changlong Xie
On 10/12/2016 06:18 PM, Changlong Xie wrote: time request Actions 29 15(most case) in_flight=15, Coroutine=C15, free_sema->holder=C17, mutex->locked=false

Re: [Qemu-block] [PATCH] nbd: Use CoQueue for free_sema instead of CoMutex

2016-10-12 Thread Paolo Bonzini
On 12/10/2016 12:18, Changlong Xie wrote: > +if (s->in_flight == MAX_NBD_REQUESTS) { > +qemu_co_queue_wait(>free_sema); > assert(s->in_flight < MAX_NBD_REQUESTS); > } I was wondering if this should be a while loop instead, but the assertion protects against that. So:

Re: [Qemu-block] [PATCH 00/18] Dirty bitmaps postcopy migration

2016-10-12 Thread Vladimir Sementsov-Ogievskiy
ping For now there are some notes mostly about accessory patches. What about migration itself? Is it ok? On 16.08.2016 13:25, Vladimir Sementsov-Ogievskiy wrote: v2: some bugs fixed, iotests a bit changed and merged into one test. based on block-next

Re: [Qemu-block] [PATCH 1/3] block: add BDS field to count in-flight requests

2016-10-12 Thread Kevin Wolf
Am 11.10.2016 um 18:45 hat Paolo Bonzini geschrieben: > > I think my point was that you don't have to count requests at the BB > > level if you know that there are no requests pending on the BB level > > that haven't reached the BDS level yet. > > I need to count requests at the BB level because

Re: [Qemu-block] [Qemu-devel] [PATCH v10 09/16] block: Add QMP support for streaming to an intermediate layer

2016-10-12 Thread Kevin Wolf
Am 11.10.2016 um 18:50 hat Markus Armbruster geschrieben: > Eric Blake writes: > > > On 10/11/2016 09:57 AM, Kevin Wolf wrote: > >> Should we introduce a new, clean blockdev-stream command that fixes this > >> and matches the common name pattern? Of course, block-stream vs. >

Re: [Qemu-block] [Qemu-devel] [PATCH 1/2] dma-helpers: explicitly pass alignment into dma-helpers

2016-10-12 Thread Kevin Wolf
Am 11.10.2016 um 17:47 hat John Snow geschrieben: > On 10/10/2016 03:23 PM, Mark Cave-Ayland wrote: > >On 10/10/16 17:34, Eric Blake wrote: > > > >>On 10/09/2016 11:43 AM, Mark Cave-Ayland wrote: > >>>The hard-coded default alignment is BDRV_SECTOR_SIZE, however this is not > >>>necessarily the

Re: [Qemu-block] [PATCH 0/4] Allow blockdev-add for SSH

2016-10-12 Thread Ashijeet Acharya
On Wed, Oct 12, 2016 at 1:52 PM, Kevin Wolf wrote: > Am 12.10.2016 um 10:09 hat Ashijeet Acharya geschrieben: > Of course, we must be able to build qemu correctly both with ssh enabled > and disabled, so if you can indeed see a (different) build error with > disabled libssh2,

Re: [Qemu-block] [PATCH v10 08/16] block: Support streaming to an intermediate layer

2016-10-12 Thread Alberto Garcia
On Wed 12 Oct 2016 04:23:05 PM CEST, Kevin Wolf wrote: >> +/* Block all intermediate nodes between bs and base, because they >> + * will disappear from the chain after this operation */ >> +for (iter = backing_bs(bs); iter && iter != base; iter = >>

Re: [Qemu-block] [PATCH v10 10/16] docs: Document how to stream to an intermediate layer

2016-10-12 Thread Kevin Wolf
Am 06.10.2016 um 15:02 hat Alberto Garcia geschrieben: > Signed-off-by: Alberto Garcia > --- > docs/live-block-ops.txt | 31 --- > 1 file changed, 20 insertions(+), 11 deletions(-) > > diff --git a/docs/live-block-ops.txt b/docs/live-block-ops.txt >

Re: [Qemu-block] [PATCH v10 05/16] block: Check blockers in all nodes involved in a block-commit job

2016-10-12 Thread Kevin Wolf
Am 06.10.2016 um 15:02 hat Alberto Garcia geschrieben: > qmp_block_commit() checks for op blockers in the active and > destination (base) images. However all nodes between top_bs and base > are also involved, and they are removed from the chain afterwards. > > In addition to that, if top_bs is

Re: [Qemu-block] [PATCH v10 07/16] block: Block all intermediate nodes in commit_active_start()

2016-10-12 Thread Kevin Wolf
Am 06.10.2016 um 15:02 hat Alberto Garcia geschrieben: > When block-commit is launched without the top parameter, it uses > internally a mirror block job. In that case all intermediate nodes > between the active and base nodes must be blocked as well. > > Signed-off-by: Alberto Garcia

Re: [Qemu-block] [PATCH v10 09/16] block: Add QMP support for streaming to an intermediate layer

2016-10-12 Thread Kevin Wolf
Am 06.10.2016 um 15:02 hat Alberto Garcia geschrieben: > This patch makes the 'device' parameter of the 'block-stream' command > accept a node name that is not a root node. > > In addition to that, operation blockers will be checked in all > intermediate nodes between the top and the base node. >

Re: [Qemu-block] [Qemu-devel] [PATCH v14 07/21] qapi: permit scalar type conversions in QObjectInputVisitor

2016-10-12 Thread Markus Armbruster
Markus Armbruster writes: > "Daniel P. Berrange" writes: > >> Currently the QObjectInputVisitor assumes that all scalar >> values are directly represented as the final types declared >> by the thing being visited. ie it assumes an 'int' is using > > i.e.

Re: [Qemu-block] [PATCH v10 08/16] block: Support streaming to an intermediate layer

2016-10-12 Thread Kevin Wolf
Am 12.10.2016 um 16:33 hat Alberto Garcia geschrieben: > On Wed 12 Oct 2016 04:23:05 PM CEST, Kevin Wolf wrote: > >> +/* Block all intermediate nodes between bs and base, because they > >> + * will disappear from the chain after this operation */ > >> +for (iter =

Re: [Qemu-block] [PATCH v10 09/16] block: Add QMP support for streaming to an intermediate layer

2016-10-12 Thread Alberto Garcia
On Wed 12 Oct 2016 04:30:27 PM CEST, Kevin Wolf wrote: >> if (bdrv_op_is_blocked(bs, BLOCK_OP_TYPE_STREAM, errp)) { >> goto out; >> } > > Added a bit more context. > > This check is redundant now... > >> if (has_base) { >> base_bs =

Re: [Qemu-block] [Qemu-devel] [PATCH v14 07/21] qapi: permit scalar type conversions in QObjectInputVisitor

2016-10-12 Thread Markus Armbruster
Markus Armbruster writes: > Markus Armbruster writes: > >> Markus Armbruster writes: >> >>> "Daniel P. Berrange" writes: >>> Currently the QObjectInputVisitor assumes that all scalar values are directly

Re: [Qemu-block] [Qemu-devel] [PATCH] hw/block/nvme: Simplify if-statements a little bit

2016-10-12 Thread Peter Maydell
On 12 October 2016 at 16:18, Thomas Huth wrote: > The condition '!A || (A && B)' is equivalent to '!A || B'. > > Buglink: https://bugs.launchpad.net/qemu/+bug/1464611 > Signed-off-by: Thomas Huth > --- > hw/block/nvme.c | 4 ++-- > 1 file changed, 2

Re: [Qemu-block] [PATCH v10 08/16] block: Support streaming to an intermediate layer

2016-10-12 Thread Kevin Wolf
Am 06.10.2016 um 15:02 hat Alberto Garcia geschrieben: > This makes sure that the image we are streaming into is open in > read-write mode during the operation. > > Operation blockers are also set in all intermediate nodes, since they > will be removed from the chain afterwards. > > Finally,

Re: [Qemu-block] [Qemu-devel] [PATCH v14 07/21] qapi: permit scalar type conversions in QObjectInputVisitor

2016-10-12 Thread Markus Armbruster
Markus Armbruster writes: > Markus Armbruster writes: > >> "Daniel P. Berrange" writes: >> >>> Currently the QObjectInputVisitor assumes that all scalar >>> values are directly represented as the final types declared >>> by the thing

Re: [Qemu-block] [Qemu-devel] [PATCH v14 10/21] qapi: permit auto-creating nested structs

2016-10-12 Thread Markus Armbruster
"Daniel P. Berrange" writes: > On Thu, Oct 06, 2016 at 05:51:57PM +0200, Kevin Wolf wrote: >> Am 06.10.2016 um 17:39 hat Daniel P. Berrange geschrieben: >> > On Thu, Oct 06, 2016 at 05:30:05PM +0200, Kevin Wolf wrote: >> > > Am 06.10.2016 um 17:18 hat Daniel P. Berrange

Re: [Qemu-block] [Qemu-devel] [PATCH v14 10/21] qapi: permit auto-creating nested structs

2016-10-12 Thread Markus Armbruster
"Daniel P. Berrange" writes: > Some of the historical command line opts that had their > keys in in a completely flat namespace are now represented > by QAPI schemas that use a nested structs. When converting > the QemuOpts to QObject, there is no information about >

Re: [Qemu-block] [Qemu-devel] [PATCH v10 09/16] block: Add QMP support for streaming to an intermediate layer

2016-10-12 Thread Markus Armbruster
Alberto Garcia writes: > On Tue 11 Oct 2016 06:32:39 PM CEST, Markus Armbruster wrote: > 3) QEMU could advertise that feature to the client. This is probably simpler than trying to figure it out from the API. I guess that's the idea of 'qmp_capabilities'? >>> >>>

Re: [Qemu-block] [PATCH v10 04/16] block: Use block_job_add_bdrv() in backup_start()

2016-10-12 Thread Kevin Wolf
Am 06.10.2016 um 15:02 hat Alberto Garcia geschrieben: > Use block_job_add_bdrv() instead of blocking all operations in > backup_start() and unblocking them in backup_run(). > > Signed-off-by: Alberto Garcia This has the same problem as mirror (dataplane must be blocked).

Re: [Qemu-block] [PATCH v10 04/16] block: Use block_job_add_bdrv() in backup_start()

2016-10-12 Thread Alberto Garcia
On Wed 12 Oct 2016 03:47:34 PM CEST, Kevin Wolf wrote: > Am 06.10.2016 um 15:02 hat Alberto Garcia geschrieben: >> Use block_job_add_bdrv() instead of blocking all operations in >> backup_start() and unblocking them in backup_run(). >> >> Signed-off-by: Alberto Garcia

Re: [Qemu-block] [PATCH v10 06/16] block: Block all nodes involved in the block-commit operation

2016-10-12 Thread Kevin Wolf
Am 06.10.2016 um 15:02 hat Alberto Garcia geschrieben: > After a successful block-commit operation all nodes between top and > base are removed from the backing chain, and top's overlay needs to > be updated to point to base. Because of that we should prevent other > block jobs from messing with

Re: [Qemu-block] [PATCH 09/22] block: introduce persistent dirty bitmaps

2016-10-12 Thread Vladimir Sementsov-Ogievskiy
On 12.10.2016 14:38, Vladimir Sementsov-Ogievskiy wrote: On 07.10.2016 22:28, Max Reitz wrote: On 30.09.2016 12:53, Vladimir Sementsov-Ogievskiy wrote: New field BdrvDirtyBitmap.persistent means, that bitmap should be saved on bdrv_close, using format driver. Format driver should maintain

Re: [Qemu-block] [PATCH 2/4] block/ssh: Add InetSocketAddress and accept it

2016-10-12 Thread Kevin Wolf
Am 11.10.2016 um 09:37 hat Ashijeet Acharya geschrieben: > Add InetSocketAddress compatibility to SSH driver. > > Add a new option "server" to the SSH block driver which then accepts > a InetSocketAddress. > > "host" and "port" are supported as legacy options and are mapped to > their

Re: [Qemu-block] [Qemu-devel] [PATCH 2/3] block: Emit modules in bdrv_iterate_format()

2016-10-12 Thread Eric Blake
On 10/12/2016 03:49 PM, Max Reitz wrote: > Some block drivers may not be loaded yet, but qemu supports them > nonetheless. bdrv_iterate_format() should report them, too. > > Signed-off-by: Max Reitz > --- > block.c | 18 ++ > 1 file changed, 18 insertions(+) >

Re: [Qemu-block] [Qemu-devel] [PATCH 0/3] iotests: Skip 162 if there is no SSH support

2016-10-12 Thread no-reply
Hi, Your series failed automatic build test. Please find the testing commands and their output below. If you have docker installed, you can probably reproduce it locally. Message-id: 20161012204907.25941-1-mre...@redhat.com Subject: [Qemu-devel] [PATCH 0/3] iotests: Skip 162 if there is no SSH

Re: [Qemu-block] [Qemu-devel] [PATCH 3/3] iotests: Skip test 162 if there is no SSH support

2016-10-12 Thread Eric Blake
On 10/12/2016 03:49 PM, Max Reitz wrote: > Signed-off-by: Max Reitz > --- > tests/qemu-iotests/162 | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/tests/qemu-iotests/162 b/tests/qemu-iotests/162 > index f8eecb3..cad2bd7 100755 > --- a/tests/qemu-iotests/162 > +++

Re: [Qemu-block] [Qemu-devel] [PATCH v14 11/21] qapi: add integer range support for QObjectInputVisitor

2016-10-12 Thread Kevin Wolf
Am 12.10.2016 um 17:50 hat Markus Armbruster geschrieben: > "Daniel P. Berrange" writes: > > > The traditional CLI arg syntax allows two ways to specify > > integer lists, either one value per key, or a range of > > values per key. eg the following are identical: > > > >

Re: [Qemu-block] [Qemu-devel] [PATCH 1/2] dma-helpers: explicitly pass alignment into dma-helpers

2016-10-12 Thread John Snow
On 10/12/2016 06:22 AM, Kevin Wolf wrote: Am 11.10.2016 um 17:47 hat John Snow geschrieben: On 10/10/2016 03:23 PM, Mark Cave-Ayland wrote: On 10/10/16 17:34, Eric Blake wrote: On 10/09/2016 11:43 AM, Mark Cave-Ayland wrote: The hard-coded default alignment is BDRV_SECTOR_SIZE, however

Re: [Qemu-block] [PATCH 0/4] Allow blockdev-add for SSH

2016-10-12 Thread Ashijeet Acharya
On Wed, Oct 12, 2016 at 9:31 PM, Kevin Wolf wrote: > Am 11.10.2016 um 09:37 hat Ashijeet Acharya geschrieben: >> This series adds blockdev-add support for SSH block driver. >> >> Patch 1 prepares the code for the addition of a new option prefix, >> which is "server.". This is

Re: [Qemu-block] [PATCH 2/4] block/ssh: Add InetSocketAddress and accept it

2016-10-12 Thread Ashijeet Acharya
On Wed, Oct 12, 2016 at 9:21 PM, Kevin Wolf wrote: > Am 11.10.2016 um 09:37 hat Ashijeet Acharya geschrieben: >> Add InetSocketAddress compatibility to SSH driver. >> >> Add a new option "server" to the SSH block driver which then accepts >> a InetSocketAddress. >> >> "host" and

Re: [Qemu-block] [Qemu-devel] [PATCH v14 12/21] option: allow qemu_opts_to_qdict to merge repeated options

2016-10-12 Thread Markus Armbruster
"Daniel P. Berrange" writes: > If given an option string such as > > size=1024,nodes=10,nodes=4-5,nodes=1-2,policy=bind > > the qemu_opts_to_qdict() method will currently overwrite > the values for repeated option keys, so only the last > value is in the returned dict: > >

Re: [Qemu-block] [Qemu-devel] [PATCH v14 11/21] qapi: add integer range support for QObjectInputVisitor

2016-10-12 Thread Markus Armbruster
"Daniel P. Berrange" writes: > The traditional CLI arg syntax allows two ways to specify > integer lists, either one value per key, or a range of > values per key. eg the following are identical: > > -arg foo=5,foo=6,foo=7 > -arg foo=5-7 > > This extends the

Re: [Qemu-block] [Qemu-devel] [PATCH v2 11/11] iotests: add transactional failure race test

2016-10-12 Thread John Snow
On 10/12/2016 07:26 AM, Vladimir Sementsov-Ogievskiy wrote: it is almost a duplication of test_transaction_failure, I think it would be better to make separate do_test_transaction_failure with parameter and two wrappers Yes, sorry -- I missed that for this iteration, but I'll act on it for

Re: [Qemu-block] [PATCH 0/4] Allow blockdev-add for SSH

2016-10-12 Thread Kevin Wolf
Am 11.10.2016 um 09:37 hat Ashijeet Acharya geschrieben: > This series adds blockdev-add support for SSH block driver. > > Patch 1 prepares the code for the addition of a new option prefix, > which is "server.". This is accomplished by adding a > ssh_has_filename_options_conflict() function which

Re: [Qemu-block] [PATCH 0/4] Allow blockdev-add for SSH

2016-10-12 Thread Kevin Wolf
Am 12.10.2016 um 18:20 hat Ashijeet Acharya geschrieben: > On Wed, Oct 12, 2016 at 9:31 PM, Kevin Wolf wrote: > > Am 11.10.2016 um 09:37 hat Ashijeet Acharya geschrieben: > >> This series adds blockdev-add support for SSH block driver. > >> > >> Patch 1 prepares the code for the

Re: [Qemu-block] [PATCH 0/4] Allow blockdev-add for SSH

2016-10-12 Thread Ashijeet Acharya
On Wed, Oct 12, 2016 at 10:10 PM, Kevin Wolf wrote: > Am 12.10.2016 um 18:20 hat Ashijeet Acharya geschrieben: >> On Wed, Oct 12, 2016 at 9:31 PM, Kevin Wolf wrote: >> > Am 11.10.2016 um 09:37 hat Ashijeet Acharya geschrieben: >> >> This series adds

[Qemu-block] [PATCH] hw/block/nvme: Simplify if-statements a little bit

2016-10-12 Thread Thomas Huth
The condition '!A || (A && B)' is equivalent to '!A || B'. Buglink: https://bugs.launchpad.net/qemu/+bug/1464611 Signed-off-by: Thomas Huth --- hw/block/nvme.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/block/nvme.c b/hw/block/nvme.c index

Re: [Qemu-block] [Qemu-devel] [PATCH v2 04/11] blockjobs: Always use block_job_get_aio_context

2016-10-12 Thread John Snow
As context to everyone else as to why I'm going down the rabbit hole of trying to remove external references to AioContext at all, see https://lists.gnu.org/archive/html/qemu-devel/2016-10/msg00795.html On 10/07/2016 03:49 AM, Paolo Bonzini wrote: On 06/10/2016 22:22, John Snow wrote:

Re: [Qemu-block] [PATCH v4 0/3] iotests: Fix test 162

2016-10-12 Thread Hao QingFeng
在 2016-10-13 3:46, Max Reitz 写道: On 12.10.2016 10:55, Hao QingFeng wrote: Max, Just a common question for this case, if sshx block driver wasn't built into qemu-img, this case would fail as below: Good point, and thanks for bringing it up, but it's not directly linked to this series other