Re: [Qemu-block] [Qemu-devel] [PATCH v3 4/4] qemu-iotests: Test creating floppy drives

2016-10-19 Thread Kevin Wolf
Am 18.10.2016 um 21:53 hat Eric Blake geschrieben: > On 10/18/2016 02:45 PM, John Snow wrote: > > > > > > On 10/18/2016 06:22 AM, Kevin Wolf wrote: > >> This tests the different supported methods to create floppy drives and > >> how they interact. > >> > > >> +function check_floppy_qtree() > >>

Re: [Qemu-block] [Qemu-devel] [PATCH v14 13/21] qdict: allow qdict_crumple to accept compound types as values

2016-10-19 Thread Kevin Wolf
Am 18.10.2016 um 17:35 hat Markus Armbruster geschrieben: > Kevin Wolf writes: > > Of course, you could argue that flat QDicts are the wrong data structure > > in the first place and instead of flatting everything we should have > > done the equivalent of qdict_crumple from the beginning, but they

Re: [Qemu-block] [Qemu-devel] [PATCH v14 13/21] qdict: allow qdict_crumple to accept compound types as values

2016-10-19 Thread Daniel P. Berrange
On Wed, Oct 19, 2016 at 11:25:27AM +0200, Kevin Wolf wrote: > Am 18.10.2016 um 17:35 hat Markus Armbruster geschrieben: > > Kevin Wolf writes: > > > Of course, you could argue that flat QDicts are the wrong data structure > > > in the first place and instead of flatting everything we should have >

Re: [Qemu-block] [PATCH 16/20] qemu-img: call aio_context_acquire/release around block job

2016-10-19 Thread Paolo Bonzini
On 19/10/2016 02:54, Fam Zheng wrote: > On Mon, 10/17 15:54, Paolo Bonzini wrote: >> This will be needed by bdrv_reopen_multiple, which calls >> bdrv_drain_all and thus will *release* the AioContext. > > Looks okay, but I wonder how bdrv_drain_all releasing AioContext break > anything? If you

[Qemu-block] [PATCH v3] Add 'offset' and 'size' options

2016-10-19 Thread Tomáš Golembiovský
v2 -> v3: - changed overflow check to make it clearer - produce error instead of warning when size is not multiple of sector size v1 -> v2: - options were moved from 'file' driver into 'raw' driver as suggested - added support for writing, reopen and truncate when possible Tomáš Golembiovský (1

[Qemu-block] [PATCH v3] raw_bsd: add offset and size options

2016-10-19 Thread Tomáš Golembiovský
Added two new options 'offset' and 'size'. This makes it possible to use only part of the file as a device. This can be used e.g. to limit the access only to single partition in a disk image or use a disk inside a tar archive (like OVA). When 'size' is specified we do our best to honour it. Signe

Re: [Qemu-block] [Qemu-devel] [PATCH v3] raw_bsd: add offset and size options

2016-10-19 Thread no-reply
Hi, Your series failed automatic build test. Please find the testing commands and their output below. If you have docker installed, you can probably reproduce it locally. Type: series Message-id: 3b5b149eb55b2d31551f6f8b6b2a1349a9452526.1476876311.git.tgole...@redhat.com Subject: [Qemu-devel] [P

Re: [Qemu-block] [Qemu-devel] [PATCH v3] raw_bsd: add offset and size options

2016-10-19 Thread no-reply
Hi, Your series seems to have some coding style problems. See output below for more information: Type: series Message-id: 3b5b149eb55b2d31551f6f8b6b2a1349a9452526.1476876311.git.tgole...@redhat.com Subject: [Qemu-devel] [PATCH v3] raw_bsd: add offset and size options === TEST SCRIPT BEGIN === #

[Qemu-block] [PATCH v4] raw_bsd: add offset and size options

2016-10-19 Thread Tomáš Golembiovský
Added two new options 'offset' and 'size'. This makes it possible to use only part of the file as a device. This can be used e.g. to limit the access only to single partition in a disk image or use a disk inside a tar archive (like OVA). When 'size' is specified we do our best to honour it. Signe

[Qemu-block] [PATCH 0/2] allow blockdev-add for NFS

2016-10-19 Thread Ashijeet Acharya
This series adds blockdev-add support for NFS block driver. Patch 1 helps to prepare NFS driver to make use of several runtime_opts as they appear in the URI. This will make NFS to do things similar to the way other drivers available in the block layer do. Patch 2 helps to allow blockdev-add supp

[Qemu-block] [PATCH 1/2] block/nfs: Introduce runtime_opts in NFS

2016-10-19 Thread Ashijeet Acharya
Make NFS block driver use various fine grained runtime_opts. Set .bdrv_parse_filename() to nfs_parse_filename() and introduce two new functions nfs_parse_filename() and nfs_parse_uri() to help parsing the URI. This will help us to prepare the NFS for blockdev-add. Signed-off-by: Ashijeet Acharya

[Qemu-block] [PATCH 2/2] qapi: allow blockdev-add for NFS

2016-10-19 Thread Ashijeet Acharya
Introduce new object 'BlockdevOptionsNFS' in qapi/block-core.json to support blockdev-add for NFS network protocol driver. Also make a new struct NFSServer to support tcp connection. Signed-off-by: Ashijeet Acharya --- qapi/block-core.json | 56 ---

[Qemu-block] [PATCH v4] Add 'offset' and 'size' options

2016-10-19 Thread Tomáš Golembiovský
v3 -> v4: - fix stupid compilation error and formatting issue v2 -> v3: - changed overflow check to make it clearer - produce error instead of warning when size is not multiple of sector size v1 -> v2: - options were moved from 'file' driver into 'raw' driver as suggested - added support for wr

Re: [Qemu-block] [Qemu-devel] [PATCH v14 13/21] qdict: allow qdict_crumple to accept compound types as values

2016-10-19 Thread Eric Blake
On 10/18/2016 10:35 AM, Markus Armbruster wrote: But even if I realised that QemuOpts support this syntax, I think we would still have to use the dotted syntax because it's explicit about the index and we need that because the list can contains dicts. Compare this: >>

Re: [Qemu-block] [Qemu-devel] [PATCH v3 4/4] qemu-iotests: Test creating floppy drives

2016-10-19 Thread John Snow
On 10/19/2016 03:37 AM, Kevin Wolf wrote: Am 18.10.2016 um 21:53 hat Eric Blake geschrieben: On 10/18/2016 02:45 PM, John Snow wrote: On 10/18/2016 06:22 AM, Kevin Wolf wrote: This tests the different supported methods to create floppy drives and how they interact. +function check_flop

Re: [Qemu-block] [Qemu-devel] [PATCH v3 4/4] qemu-iotests: Test creating floppy drives

2016-10-19 Thread Kevin Wolf
Am 19.10.2016 um 15:47 hat John Snow geschrieben: > > > On 10/19/2016 03:37 AM, Kevin Wolf wrote: > >Am 18.10.2016 um 21:53 hat Eric Blake geschrieben: > >>On 10/18/2016 02:45 PM, John Snow wrote: > >>> > >>> > >>>On 10/18/2016 06:22 AM, Kevin Wolf wrote: > This tests the different supported

Re: [Qemu-block] [PATCH v4] raw_bsd: add offset and size options

2016-10-19 Thread Eric Blake
On 10/19/2016 07:27 AM, Tomáš Golembiovský wrote: > Added two new options 'offset' and 'size'. This makes it possible to use > only part of the file as a device. This can be used e.g. to limit the > access only to single partition in a disk image or use a disk inside a > tar archive (like OVA). >

Re: [Qemu-block] [PATCH v4] raw_bsd: add offset and size options

2016-10-19 Thread Kevin Wolf
Am 19.10.2016 um 17:38 hat Eric Blake geschrieben: > On 10/19/2016 07:27 AM, Tomáš Golembiovský wrote: > > Added two new options 'offset' and 'size'. This makes it possible to use > > only part of the file as a device. This can be used e.g. to limit the > > access only to single partition in a disk

Re: [Qemu-block] [PATCH] qcow2: Optimize L2 table cache size based on image and cluster sizes

2016-10-19 Thread Frank Myhr
On 10/18/2016 11:25 AM, Alberto Garcia wrote: > On Fri 07 Oct 2016 03:58:29 PM CEST, Ed Swierk wrote: >> Same here, using libvirt. l2-cache-size=max would be ideal. Or if >> there were a cache-coverage-size option that takes an absolute number, >> libvirt could set it to the image size. > > I can

Re: [Qemu-block] [Qemu-devel] [PATCH v14 15/21] qom: support non-scalar properties with -object

2016-10-19 Thread Markus Armbruster
"Daniel P. Berrange" writes: > The current -object command line syntax only allows for > creation of objects with scalar properties, or a list > with a fixed scalar element type. Objects which have > properties that are represented as structs in the QAPI > schema cannot be created using -object.

Re: [Qemu-block] [PATCH v11 01/19] block: Add bdrv_drain_all_{begin, end}()

2016-10-19 Thread Kevin Wolf
Am 14.10.2016 um 15:08 hat Alberto Garcia geschrieben: > bdrv_drain_all() doesn't allow the caller to do anything after all > pending requests have been completed but before block jobs are > resumed. > > This patch splits bdrv_drain_all() into _begin() and _end() for that > purpose. It also adds a

[Qemu-block] [PATCH 1/2] block: Rename raw_bsd to raw.c

2016-10-19 Thread Eric Blake
The file has nothing to do with the BSD operating system, but is rather dealing with the raw data format as a BDS. Simplify the name to avoid further confusion. [Plus I hate typing _ in file names - the shift key slows things down] Suggested-by: Daniel P. Berrange Signed-off-by: Eric Blake ---

[Qemu-block] [PATCH 0/2] less confusing block file names

2016-10-19 Thread Eric Blake
Based on a suggestion here: https://lists.gnu.org/archive/html/qemu-devel/2016-10/msg00350.html Eric Blake (2): block: Rename raw_bsd to raw.c block: rename raw-{posix,win32} to file-*.c include/block/block_int.h | 2 +- block/{raw-posix.c => file-posix.c} | 0 block/{raw-win32.c =

[Qemu-block] [PATCH 2/2] block: rename raw-{posix, win32} to file-*.c

2016-10-19 Thread Eric Blake
These files deal with the file protocol, not the raw format (the file protocol is often used with other formats, and the raw protocol is not forced to use the file format). Rename things to make it a bit easier to follow. Suggested-by: Daniel P. Berrange Signed-off-by: Eric Blake --- include/b

Re: [Qemu-block] [Qemu-devel] [PATCH v14 16/21] hmp: support non-scalar properties with object_add

2016-10-19 Thread Markus Armbruster
"Daniel P. Berrange" writes: > The current object_add HMP syntax only allows for > creation of objects with scalar properties, or a list > with a fixed scalar element type. Objects which have > properties that are represented as structs in the QAPI > schema cannot be created using -object. > > Th

Re: [Qemu-block] [Qemu-devel] [PATCH v14 17/21] numa: convert to use QObjectInputVisitor for -numa

2016-10-19 Thread Markus Armbruster
"Daniel P. Berrange" writes: > Switch away from using OptsVisitor to parse the -numa > argument processing. This enables use of the modern > list syntax for specifying CPUs. e.g. the old syntax > > -numa node,nodeid=0,cpus=0-3,cpus=8-11,mem=107 > > is equivalent to > > -numa node,nodeid=0,cpu