Re: [Qemu-block] [Qemu-devel] [PATCH 3/3] ide: abort TRIM operation for invalid range

On 8/12/2017 10:51 PM, John Snow wrote: Looks about right, just remember that this flow won't call block_acct_invalid because you're bypassing the return to ide_dma_cb. I assume you'll get to that in your next series. Yes; I meant to keep the trim accounting in ide_issue_trim_cb() For now,

Re: [Qemu-block] [Qemu-devel] [PATCH V3] pci: removed the is_express field since a uniform interface was inserted

On Mon, Dec 11, 2017 at 03:11:39PM +0200, Yoni Bettan wrote: > > > On 12/07/2017 10:58 PM, Eduardo Habkost wrote: > > On Tue, Dec 05, 2017 at 07:17:06PM +0200, Yoni Bettan wrote: > > > * according to Eduardo Habkost's commit > > >fd3b02c8896d597dd8b9e053dec579cf0386aee1 > >

Re: [Qemu-block] [Qemu-devel] [PATCH V3] pci: removed the is_express field since a uniform interface was inserted

On 12/07/2017 10:58 PM, Eduardo Habkost wrote: On Tue, Dec 05, 2017 at 07:17:06PM +0200, Yoni Bettan wrote: * according to Eduardo Habkost's commit fd3b02c8896d597dd8b9e053dec579cf0386aee1 * since all PCIEs now implement INTERFACE_PCIE_DEVICE we don't

Re: [Qemu-block] [Qemu-devel] [PATCH for-2.12 0/4] qmp dirty bitmap API

Am 09.12.2017 um 01:57 hat John Snow geschrieben: > Here's an idea of what this API might look like without revealing > explicit merge/split primitives. > > A new bitmap property that lets us set retention: > > :: block-dirty-bitmap-set-retention bitmap=foo slices=10 > > Or something similar,

Re: [Qemu-block] [Qemu-devel] qemu process crash: Assertion failed: QLIST_EMPTY(>tracked_requests)

On Thu, Dec 07, 2017 at 10:18:52AM +, Fernando Casas Schössow wrote: > Hi there, > > > Last night while doing a backup of a guest using the live snapshot mechanism > the qemu process for the guest seem to had crashed. > > The snapshot succeeded then the backup of the VM disk had place and

Re: [Qemu-block] [Qemu-devel] [PATCH for-2.12 0/4] qmp dirty bitmap API

11.12.2017 14:15, Kevin Wolf wrote: Am 09.12.2017 um 01:57 hat John Snow geschrieben: Here's an idea of what this API might look like without revealing explicit merge/split primitives. A new bitmap property that lets us set retention: :: block-dirty-bitmap-set-retention bitmap=foo slices=10

Re: [Qemu-block] [Qemu-devel] [PATCH v2] qemu-img: Document --force-share / -U

On Fri, 12/08 09:54, Stefan Hajnoczi wrote: > On Fri, Dec 08, 2017 at 09:44:56AM +0800, Fam Zheng wrote: > > +@item --force-share (-U) > > + > > +If specified, @code{qemu-img} will open the image with shared permissions, > > +which makes it less likely to conflict with a running guest's

[Qemu-block] [PATCH v3] qemu-img: Document --force-share / -U

Signed-off-by: Fam Zheng --- v3: Document that the option is not allowed for read-write. [Stefan] v2: - "code{qemu-img}". [Kashyap, Eric] - "etc.." -> "etc.". --- qemu-img.texi | 9 + 1 file changed, 9 insertions(+) diff --git a/qemu-img.texi b/qemu-img.texi

Re: [Qemu-block] [PATCH v6 09/20] parallels: Switch to .bdrv_co_block_status()

09.12.2017 19:39, Eric Blake wrote: On 12/09/2017 06:31 AM, Vladimir Sementsov-Ogievskiy wrote: 07.12.2017 23:30, Eric Blake wrote: We are gradually moving away from sector-based interfaces, towards byte-based.  Update the parallels driver accordingly.  Note that the internal function

Re: [Qemu-block] [PATCH v3] qemu-img: Document --force-share / -U

Am 11.12.2017 um 10:33 hat Fam Zheng geschrieben: > Signed-off-by: Fam Zheng > > --- > > v3: Document that the option is not allowed for read-write. [Stefan] > > v2: - "code{qemu-img}". [Kashyap, Eric] > - "etc.." -> "etc.". > --- > qemu-img.texi | 9 + > 1 file

Re: [Qemu-block] [Qemu-devel] QEMU not honouring bootorder

On Thu, 12/07 13:10, Michal Privoznik wrote: > Dear list, > > I've encountered the following problem. I have two disks: > > /var/lib/libvirt/images/fedora.qcow2 (which contains OS) > /dev/sde (iSCSI dummy disk just for testing) > > Now, when I configure QEMU to start with both of them,

Re: [Qemu-block] QEMU not honouring bootorder

On 12/07/2017 01:10 PM, Michal Privoznik wrote: > Dear list, > Ping. Is there anything I can help you with to have this sorted out? Michal

Re: [Qemu-block] [PATCH v2 0/2] virtio-blk: miscellaneous changes

On Fri, Dec 08, 2017 at 09:57:25AM -0600, Mark Kanda wrote: > v2: add check for maximum queue size [Stefan] > > This series is for two minor virtio-blk changes. The first patch > makes the virtio-blk queue size user configurable. The second patch > rejects logical block size > physical block

Re: [Qemu-block] [Qemu-devel] [PATCH v3] qemu-img: Document --force-share / -U

On Mon, 12/11 10:50, Kevin Wolf wrote: > Am 11.12.2017 um 10:33 hat Fam Zheng geschrieben: > > Signed-off-by: Fam Zheng > > > > --- > > > > v3: Document that the option is not allowed for read-write. [Stefan] > > > > v2: - "code{qemu-img}". [Kashyap, Eric] > > - "etc.." ->

Re: [Qemu-block] [Qemu-devel] QEMU not honouring bootorder

On 12/11/2017 12:41 PM, Fam Zheng wrote: > On Thu, 12/07 13:10, Michal Privoznik wrote: >> Dear list, >> >> I've encountered the following problem. I have two disks: >> >> /var/lib/libvirt/images/fedora.qcow2 (which contains OS) >> /dev/sde (iSCSI dummy disk just for testing) >> >> Now, when

Re: [Qemu-block] [PATCH v2] qemu-img: Document --force-share / -U

On Fri, Dec 08, 2017 at 09:44:56AM +0800, Fam Zheng wrote: > Signed-off-by: Fam Zheng > > --- > v2: - "code{qemu-img}". [Kashyap, Eric] > - "etc.." -> "etc.". > --- > qemu-img.texi | 9 + > 1 file changed, 9 insertions(+) Reviewed-by: Kashyap Chamarthy

Re: [Qemu-block] [Qemu-devel] [PATCH for-2.12 0/4] qmp dirty bitmap API

On 12/09/2017 03:57 AM, John Snow wrote: > This is going to be a long one. Maybe go get a cup of coffee. > > On 12/07/2017 04:39 AM, Vladimir Sementsov-Ogievskiy wrote: >> 07.12.2017 03:38, John Snow wrote: >>> I'm sorry, I don't think I understand. >>> >>> "customers needs a possibility to create

Re: [Qemu-block] [Qemu-devel] [PATCH] blockdev-backup: enable non-root nodes for backup

On 12/11/2017 11:31 AM, Max Reitz wrote: > On 2017-12-08 18:09, John Snow wrote: >> >> >> On 12/08/2017 09:30 AM, Max Reitz wrote: >>> On 2017-12-05 01:48, John Snow wrote: On 12/04/2017 05:21 PM, Max Reitz wrote: > On 2017-12-04 23:15, John Snow wrote: >> >> >> On

Re: [Qemu-block] [Qemu-devel] [PATCH V3] pci: removed the is_express field since a uniform interface was inserted

On 12/11/2017 04:19 PM, Eduardo Habkost wrote: On Mon, Dec 11, 2017 at 03:11:39PM +0200, Yoni Bettan wrote: On 12/07/2017 10:58 PM, Eduardo Habkost wrote: On Tue, Dec 05, 2017 at 07:17:06PM +0200, Yoni Bettan wrote: * according to Eduardo Habkost's commit

Re: [Qemu-block] [PATCH 3/7] scsi: store unmap offset and nb_sectors in request struct

On Mon 20 Nov 2017 05:51:00 PM CET, Anton Nefedov wrote: > it allows to report it in the error handler > > Signed-off-by: Anton Nefedov > Reviewed-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Alberto Garcia Berto

[Qemu-block] [PATCH v2 0/2] virtio-blk: miscellaneous changes

v2: add check for maximum queue size [Stefan] This series is for two minor virtio-blk changes. The first patch makes the virtio-blk queue size user configurable. The second patch rejects logical block size > physical block configurations (similar to a recent change in virtio-scsi). Mark Kanda

Re: [Qemu-block] [Qemu-devel] qemu process crash: Assertion failed: QLIST_EMPTY(>tracked_requests)

Hello Stefan, Thanks for your reply. Fortunately I didn’t have the problem again and it’s not clear how it can be consistently reproduced. Daily backups are running as usual at the moment. If there is anything I can do from my side or if you have any ideas to try to reproduce it let me know.

Re: [Qemu-block] [PATCH v6 09/20] parallels: Switch to .bdrv_co_block_status()

09.12.2017 19:39, Eric Blake wrote: On 12/09/2017 06:31 AM, Vladimir Sementsov-Ogievskiy wrote: 07.12.2017 23:30, Eric Blake wrote: We are gradually moving away from sector-based interfaces, towards byte-based.  Update the parallels driver accordingly.  Note that the internal function

Re: [Qemu-block] [PATCH v7 for-2.12 05/25] block: Respect backing bs in bdrv_refresh_filename

On Mon 20 Nov 2017 09:09:44 PM CET, Max Reitz wrote: > Basically, bdrv_refresh_filename() should respect all children of a > BlockDriverState. However, generally those children are driver-specific, > so this function cannot handle the general case. On the other hand, > there are only few drivers

[Qemu-block] [PATCH v2 2/2] virtio-blk: reject configs with logical block size > physical block size

virtio-blk logical block size should never be larger than physical block size because it doesn't make sense to have such configurations. QEMU doesn't have a way to effectively express this condition; the best it can do is report the physical block exponent as 0 - indicating the logical block size

[Qemu-block] [PATCH v2 1/2] virtio-blk: make queue size configurable

Depending on the configuration, it can be beneficial to adjust the virtio-blk queue size to something other than the current default of 128. Add a new property to make the queue size configurable. Signed-off-by: Mark Kanda Reviewed-by: Karl Heubaum

Re: [Qemu-block] [PATCH v2 0/2] virtio-blk: miscellaneous changes

On 12/11/2017 4:30 AM, Stefan Hajnoczi wrote: Hi Mark, Please resend as a top level email thread so the continuous integration and patch management tools will detect your patch series. Apologies. I've just resent the series. Thanks, -Mark

Re: [Qemu-block] [Qemu-devel] [PATCH] blockdev-backup: enable non-root nodes for backup

On 2017-12-08 18:09, John Snow wrote: > > > On 12/08/2017 09:30 AM, Max Reitz wrote: >> On 2017-12-05 01:48, John Snow wrote: >>> >>> >>> On 12/04/2017 05:21 PM, Max Reitz wrote: On 2017-12-04 23:15, John Snow wrote: > > > On 12/01/2017 02:41 PM, Max Reitz wrote: >> ((By the

Re: [Qemu-block] [Qemu-devel] [PATCH] blockdev-backup: enable non-root nodes for backup

On 2017-12-11 17:47, John Snow wrote: > > > On 12/11/2017 11:31 AM, Max Reitz wrote: >> On 2017-12-08 18:09, John Snow wrote: >>> >>> >>> On 12/08/2017 09:30 AM, Max Reitz wrote: On 2017-12-05 01:48, John Snow wrote: > > > On 12/04/2017 05:21 PM, Max Reitz wrote: >> On

Re: [Qemu-block] [Qemu-devel] [PATCH] blockdev-backup: enable non-root nodes for backup

On 12/11/2017 12:05 PM, Max Reitz wrote: > On 2017-12-11 17:47, John Snow wrote: >> On 12/11/2017 11:31 AM, Max Reitz wrote: >>> On 2017-12-08 18:09, John Snow wrote: On 12/08/2017 09:30 AM, Max Reitz wrote: > On 2017-12-05 01:48, John Snow wrote: >> >> I would say that a bitmap

Re: [Qemu-block] import thin provisioned disks with image upload

On 2017-12-08 21:56, Nir Soffer wrote: > On Fri, Dec 8, 2017 at 5:23 PM Max Reitz > wrote: [...] > What "stat" reports as "size" I'd call the length (what qemu-img info > calls "virtual size" for raw images).  > > > raw images are not an

Re: [Qemu-block] [Qemu-devel] [PATCH 08/17] iotests: Skip 103 for refcount_bits=1

On 2017-12-09 02:36, John Snow wrote: > > > On 11/30/2017 08:23 AM, Max Reitz wrote: >> On 2017-11-30 04:18, Fam Zheng wrote: >>> On Thu, 11/23 03:08, Max Reitz wrote: Signed-off-by: Max Reitz --- tests/qemu-iotests/103 | 2 ++ 1 file changed, 2

Re: [Qemu-block] [Qemu-devel] [PATCH 08/17] iotests: Skip 103 for refcount_bits=1

On 12/11/2017 12:17 PM, Max Reitz wrote: > On 2017-12-09 02:36, John Snow wrote: >> >> >> On 11/30/2017 08:23 AM, Max Reitz wrote: >>> On 2017-11-30 04:18, Fam Zheng wrote: On Thu, 11/23 03:08, Max Reitz wrote: > Signed-off-by: Max Reitz > --- >

Re: [Qemu-block] [Qemu-devel] [PATCH for-2.12 0/4] qmp dirty bitmap API

On 12/11/2017 06:15 AM, Kevin Wolf wrote: > Am 09.12.2017 um 01:57 hat John Snow geschrieben: >> Here's an idea of what this API might look like without revealing >> explicit merge/split primitives. >> >> A new bitmap property that lets us set retention: >> >> :: block-dirty-bitmap-set-retention

Re: [Qemu-block] [PATCH] blockjob: kick jobs on set-speed

On Mon, Dec 11, 2017 at 06:46:09PM -0500, John Snow wrote: > If users set an unreasonably low speed (like one byte per second), the > calculated delay may exceed many hours. While we like to punish users > for asking for stupid things, we do also like to allow users to correct > their wicked ways.

[Qemu-block] [PATCH] blockjob: kick jobs on set-speed

If users set an unreasonably low speed (like one byte per second), the calculated delay may exceed many hours. While we like to punish users for asking for stupid things, we do also like to allow users to correct their wicked ways. When a user provides a new speed, kick the job to allow it to

[Qemu-block] [PATCH v4] qemu-img: Document --force-share / -U

Signed-off-by: Fam Zheng --- v4: "images". [Kevin] v3: Document that the option is not allowed for read-write. [Stefan] v2: - "code{qemu-img}". [Kashyap, Eric] - "etc.." -> "etc.". --- qemu-img.texi | 9 + 1 file changed, 9 insertions(+) diff --git

[Qemu-block] [PATCH V4] pci: removed the is_express field since a uniform interface was inserted

* according to Eduardo Habkost's commit fd3b02c8896d597dd8b9e053dec579cf0386aee1 * since all PCIEs now implement INTERFACE_PCIE_DEVICE we don't need this field anymore * Devices that where only INTERFACE_PCIE_DEVICE (is_express == 1) or