On 10/02/2018 00:07, John Snow wrote:
>> +/* Early check to avoid creating target */
>> +if (bdrv_op_is_blocked(bs, BLOCK_OP_TYPE_MIRROR_SOURCE, errp)) {
>> +return;
>> +}
>> +
>> aio_context = bdrv_get_aio_context(bs);
>> aio_context_acquire(aio_context);
>>
>>
> Wh
On Mon, Feb 12, 2018 at 10:58:31AM +0100, Paolo Bonzini wrote:
> On 10/02/2018 00:07, John Snow wrote:
> >> +/* Early check to avoid creating target */
> >> +if (bdrv_op_is_blocked(bs, BLOCK_OP_TYPE_MIRROR_SOURCE, errp)) {
> >> +return;
> >> +}
> >> +
> >> aio_context = bdr
On 01/23/2018 03:01 PM, Kevin Wolf wrote:
> From: Max Reitz
>
> In some cases, these commands still use the deprecated @device
> parameter. Fix that so we can later drop that parameter from their
> interface.
>
> Signed-off-by: Max Reitz
> Message-id: 20171110224302.14424-2-mre...@redhat.com
Adding Max and Alberto,
I think the issue is that on s390 you cannot add a floppy
On 02/12/2018 12:16 PM, Christian Borntraeger wrote:
>
> On 01/23/2018 03:01 PM, Kevin Wolf wrote:
>> From: Max Reitz
>>
>> In some cases, these commands still use the deprecated @device
>> parameter. Fix that s
On 2018-02-12 12:33, Christian Borntraeger wrote:
> Adding Max and Alberto,
>
> I think the issue is that on s390 you cannot add a floppy
Thanks for letting me know. I don't know why I resorted to floppy when
virtio would have worked (in this test) just as well...
Max
signature.asc
Descripti
Am 12.02.2018 um 11:02 hat Daniel P. Berrangé geschrieben:
> On Mon, Feb 12, 2018 at 10:58:31AM +0100, Paolo Bonzini wrote:
> > On 10/02/2018 00:07, John Snow wrote:
> > >> +/* Early check to avoid creating target */
> > >> +if (bdrv_op_is_blocked(bs, BLOCK_OP_TYPE_MIRROR_SOURCE, errp)) {
>
Only a few select machine types support floppy drives and there is
actually nothing preventing us from using virtio here, so let's do it.
Reported-by: Christian Borntraeger
Signed-off-by: Max Reitz
---
tests/qemu-iotests/155 | 14 +-
1 file changed, 9 insertions(+), 5 deletions(-)
On Mon, Feb 12, 2018 at 01:42:11PM +0100, Kevin Wolf wrote:
> Am 12.02.2018 um 11:02 hat Daniel P. Berrangé geschrieben:
> > On Mon, Feb 12, 2018 at 10:58:31AM +0100, Paolo Bonzini wrote:
> > > On 10/02/2018 00:07, John Snow wrote:
> > > >> +/* Early check to avoid creating target */
> > > >> +
On 02/12/2018 01:47 PM, Max Reitz wrote:
> Only a few select machine types support floppy drives and there is
> actually nothing preventing us from using virtio here, so let's do it.
>
> Reported-by: Christian Borntraeger
> Signed-off-by: Max Reitz
Tested-by: Christian Borntraeger
> ---
>
v2:
patch 1: commit message fixed
test added (patch 2)
v1: http://lists.nongnu.org/archive/html/qemu-devel/2018-02/msg00131.html
Anton Nefedov (2):
iotest 033: add misaligned write-zeroes test via truncate
block: fix write with zero flag set and iovector provided
block/io.c
This new test case only makes sense for qcow2 while iotest 033 is generic;
however it matches the test purpose perfectly and also 033 contains those
do_test() tricks to pass the alignment, which won't look nice being
duplicated in other tests or moved to the common code.
Signed-off-by: Anton Nefed
The normal bdrv_co_pwritev() use is either
- BDRV_REQ_ZERO_WRITE clear and iovector provided
- BDRV_REQ_ZERO_WRITE set and iovector == NULL
while
- the flag clear and iovector == NULL is an assertion failure
in bdrv_co_do_zero_pwritev()
- the flag set and iovector provided is in fact a
Am 12.02.2018 um 13:47 hat Max Reitz geschrieben:
> Only a few select machine types support floppy drives and there is
> actually nothing preventing us from using virtio here, so let's do it.
>
> Reported-by: Christian Borntraeger
> Signed-off-by: Max Reitz
Thanks, applied to the block branch.
Hello,
As I got no answer here, maybe someone could advise me a better place to
find some hints about this qemu qcow2 corruption issue?
Thank you
--
Nicolas Ecarnot
Le 07/02/2018 à 18:06, Nicolas Ecarnot a écrit :
Hello,
TL; DR : qcow2 images keep getting corrupted. Any workaround?
Long v
On 2018-02-08 20:23, Kevin Wolf wrote:
> This adds a synchronous x-blockdev-create QMP command that can create
> qcow2 images on a given node name.
>
> We don't want to block while creating an image, so this is not the final
> interface in all aspects, but BlockdevCreateOptionsQcow2 and
> .bdrv_co
Hello,
Juan Quintela writes:
> "Daniel P. Berrange" wrote:
>> On Thu, Jan 11, 2018 at 01:23:05PM +, Dr. David Alan Gilbert wrote:
>>> * Daniel P. Berrange (berra...@redhat.com) wrote:
>>> > On Thu, Jan 11, 2018 at 01:46:38PM +0100, Max Reitz wrote:
>>> > > On 2018-01-08 14:52, Eric Blake wro
Am 08.02.2018 um 11:42 hat Paolo Bonzini geschrieben:
> On 08/02/2018 02:35, Fam Zheng wrote:
> > On Wed, 02/07 17:36, Paolo Bonzini wrote:
> >> @@ -2626,6 +2656,36 @@ static void scsi_block_realize(SCSIDevice *dev,
> >> Error **errp)
> >>
> >> scsi_realize(&s->qdev, errp);
> >> scsi_g
On 2018-02-08 20:23, Kevin Wolf wrote:
> This adds the .bdrv_co_create driver callback to file, which enables
> image creation over QMP.
>
> Signed-off-by: Kevin Wolf
> ---
> qapi/block-core.json | 20 +-
> block/file-posix.c | 77
> +---
On 2018-02-08 20:23, Kevin Wolf wrote:
> This adds the .bdrv_co_create driver callback to file-win32, which
> enables image creation over QMP.
>
> Signed-off-by: Kevin Wolf
> ---
> block/file-win32.c | 45 +
> 1 file changed, 37 insertions(+), 8 deleti
On 12/02/2018 14:52, Kevin Wolf wrote:
> Am 08.02.2018 um 11:42 hat Paolo Bonzini geschrieben:
>> On 08/02/2018 02:35, Fam Zheng wrote:
>>> On Wed, 02/07 17:36, Paolo Bonzini wrote:
@@ -2626,6 +2656,36 @@ static void scsi_block_realize(SCSIDevice *dev,
Error **errp)
scsi
On 2018-02-08 20:23, Kevin Wolf wrote:
> Once qcow2_create2() can be called directly on an already existing node,
> we must provide the 'full' and 'falloc' preallocation modes outside of
> creating the image on the protocol layer. Fortunately, we have
> preallocated truncate now which can provide t
On 2018-02-08 20:23, Kevin Wolf wrote:
> This adds the .bdrv_co_create driver callback to gluster, which enables
> image creation over QMP.
>
> Signed-off-by: Kevin Wolf
> ---
> qapi/block-core.json | 18 ++-
> block/gluster.c | 149
> +-
Am 12.02.2018 um 15:00 hat Paolo Bonzini geschrieben:
> On 12/02/2018 14:52, Kevin Wolf wrote:
> > Am 08.02.2018 um 11:42 hat Paolo Bonzini geschrieben:
> >> On 08/02/2018 02:35, Fam Zheng wrote:
> >>> On Wed, 02/07 17:36, Paolo Bonzini wrote:
> @@ -2626,6 +2656,36 @@ static void scsi_block_re
On 12/02/2018 15:30, Kevin Wolf wrote:
>>> We shouldn't be adding new instances of BLOCK_OP_* at all. I couldn't
>>> find the time yet to remove the existing ones, but any new protections
>>> should be using the permission system.
>> I agree. But does this include not fixing bugs wherever clients
Am 12.02.2018 um 15:32 hat Paolo Bonzini geschrieben:
> On 12/02/2018 15:30, Kevin Wolf wrote:
> >>> We shouldn't be adding new instances of BLOCK_OP_* at all. I couldn't
> >>> find the time yet to remove the existing ones, but any new protections
> >>> should be using the permission system.
> >> I
On 12/02/2018 15:48, Kevin Wolf wrote:
> Am 12.02.2018 um 15:32 hat Paolo Bonzini geschrieben:
>> Okay, we are in agreement about this and you expressed very well why I
>> (at the gut feeling level) didn't like the old op blockers. But you
>> bypassed the real question, which is: should I send a p
On Mon 12 Feb 2018 02:14:01 PM CET, Anton Nefedov wrote:
> The normal bdrv_co_pwritev() use is either
> - BDRV_REQ_ZERO_WRITE clear and iovector provided
> - BDRV_REQ_ZERO_WRITE set and iovector == NULL
>
> while
> - the flag clear and iovector == NULL is an assertion failure
> in bdrv_co
On 2018-02-08 20:23, Kevin Wolf wrote:
> This adds the .bdrv_co_create driver callback to rbd, which enables
> image creation over QMP.
>
> Signed-off-by: Kevin Wolf
> ---
> qapi/block-core.json | 20 +++-
> block/rbd.c | 137
> +--
>
On 2018-02-08 20:23, Kevin Wolf wrote:
> Using the QAPI visitor to turn all options into QAPI BlockdevOptionsNfs
> simplifies the code a lot. It will also be useful for implementing the
> QAPI based .bdrv_co_create callback.
>
> Signed-off-by: Kevin Wolf
> ---
> block/nfs.c | 176
>
On Mon 12 Feb 2018 02:14:00 PM CET, Anton Nefedov wrote:
> +# Trigger truncate that would shrink qcow2 L1 table, which is done by
> +# clearing one entry (8 bytes) with bdrv_co_pwrite_zeroes()
> +
> +echo
> +echo "=== Test misaligned write zeroes via truncate ==="
> +echo
> +
> +CLUSTER_SIZE=$((6
On 12/2/2018 6:03 PM, Alberto Garcia wrote:
On Mon 12 Feb 2018 02:14:01 PM CET, Anton Nefedov wrote:
The normal bdrv_co_pwritev() use is either
- BDRV_REQ_ZERO_WRITE clear and iovector provided
- BDRV_REQ_ZERO_WRITE set and iovector == NULL
while
- the flag clear and iovector == NULL
On 2018-02-08 20:23, Kevin Wolf wrote:
> This adds the .bdrv_co_create driver callback to nfs, which enables
> image creation over QMP.
>
> Signed-off-by: Kevin Wolf
> ---
> qapi/block-core.json | 16 +++-
> block/nfs.c | 74
> +--
On 6/2/2018 4:12 PM, Alberto Garcia wrote:
On Fri 19 Jan 2018 01:50:00 PM CET, Anton Nefedov wrote:
Make the stat fields definition slightly more readable.
Cosmetic change only.
Signed-off-by: Anton Nefedov
---
qapi/block-core.json | 24 ++--
1 file changed, 18 inserti
On 7/2/2018 6:10 PM, Alberto Garcia wrote:
On Fri 19 Jan 2018 01:50:06 PM CET, Anton Nefedov wrote:
This will help to identify how many of the user-issued discard operations
(accounted on a device level) have actually suceeded down on the host file
(even though the numbers will not be exactly
On 2018-02-08 20:23, Kevin Wolf wrote:
> The "redundacy" option for Sheepdog image creation is currently a string
> that can encode one or two integers depending on its format, which at
> the same time implicitly selects a mode.
>
> This patch turns it into a QAPI union and converts the string int
On 12/2/2018 6:54 PM, Alberto Garcia wrote:
On Mon 12 Feb 2018 02:14:00 PM CET, Anton Nefedov wrote:
+# Trigger truncate that would shrink qcow2 L1 table, which is done by
+# clearing one entry (8 bytes) with bdrv_co_pwrite_zeroes()
+
+echo
+echo "=== Test misaligned write zeroes via truncat
On 2018-02-08 20:23, Kevin Wolf wrote:
> This adds the .bdrv_co_create driver callback to sheepdog, which enables
> image creation over QMP.
>
> Signed-off-by: Kevin Wolf
> ---
> qapi/block-core.json | 24 +-
> block/sheepdog.c | 209
> --
On 3/2/2018 6:59 PM, Markus Armbruster wrote:
Eric Blake writes:
On 01/19/2018 06:50 AM, Anton Nefedov wrote:
+
+##
+# @BlockDriverStats:
+#
+# Statistics of a block driver (driver-specific)
+#
+# Since: 2.12
+##
+{ 'union': 'BlockDriverStats',
+ 'data': {
+ 'file': 'BlockDriverStatsF
On 2018-02-08 20:23, Kevin Wolf wrote:
> Create a BlockdevOptionsSsh object in connect_to_ssh() and take the
> options from there. 'host_key_check' is still processed separately
> because it's not in the schema yet.
>
> Signed-off-by: Kevin Wolf
> ---
> block/ssh.c | 136
> +
On 2018-02-08 20:23, Kevin Wolf wrote:
> This makes the host-key-check option available in blockdev-add.
>
> Signed-off-by: Kevin Wolf
> ---
> qapi/block-core.json | 63 +++--
> block/ssh.c | 88
> +---
> 2
18.01.2018 13:09, Paolo Bonzini wrote:
On 18/01/2018 10:55, Vladimir Sementsov-Ogievskiy wrote:
Most functions that looks at the list are "called with BQL taken".
Functions that write to the list are "called with BQL taken" and call
bdrv_dirty_bitmaps_lock/bdrv_dirty_bitmaps_unlock themselves.
On 2018-02-08 20:23, Kevin Wolf wrote:
> Move the parsing of the QDict options up to the callers, in preparation
> for the .bdrv_co_create implementation that directly gets a QAPI type.
>
> Signed-off-by: Kevin Wolf
> ---
> block/ssh.c | 34 +-
> 1 file changed, 2
On 2018-02-08 20:23, Kevin Wolf wrote:
> This adds the .bdrv_co_create driver callback to ssh, which enables
> image creation over QMP.
>
> Signed-off-by: Kevin Wolf
> ---
> qapi/block-core.json | 16 -
> block/ssh.c | 92
> +---
>
On 2018-02-08 20:23, Kevin Wolf wrote:
> If bdrv_truncate() is called, but the requested size is the same as
> before, don't call posix_fallocate(), which returns -EINVAL for length
> zero and would therefore make bdrv_truncate() fail.
>
> The problem can be triggered by creating a zero-sized raw
On 2018-02-08 20:23, Kevin Wolf wrote:
> Most callers have their own checks, but something like this should also
> be checked centrally. As it happens, x-blockdev-create can pass negative
> image sizes to format drivers (because there is no QAPI type that would
> reject negative numbers) and trigge
On 02/10/2018 03:29 AM, Wang King wrote:
> Empty IDE CD-ROM configured on the VM:
>
>
>
>
>
>
> Make migration for this VM, then qemu aborted in ide_restart_bh. IDEState
> expect
> end_transfer_func equal to ide_atapi_cmd, but it refer to
> ide_dummy_transf
Re-ping.
On Thu, Jan 25, 2018 at 05:05:01PM +, Daniel P. Berrangé wrote:
> ping, does any block maintainer want to queue this one ?
>
> On Fri, Dec 08, 2017 at 01:34:16PM +, Daniel P. Berrange wrote:
> > qemu-io puts the TTY into non-canonical mode, which means no EOF processing
> > is
>
On 2018-02-08 20:23, Kevin Wolf wrote:
> Signed-off-by: Kevin Wolf
> ---
> tests/qemu-iotests/206 | 436
> +
> tests/qemu-iotests/206.out | 209 ++
> tests/qemu-iotests/group | 1 +
> 3 files changed, 646 insertions(+)
> cr
On 2018-02-08 20:23, Kevin Wolf wrote:
> Signed-off-by: Kevin Wolf
> ---
> tests/qemu-iotests/207 | 261
> +
> tests/qemu-iotests/207.out | 75 +
> tests/qemu-iotests/group | 1 +
> 3 files changed, 337 insertions(+)
> create mode
Am 08.12.2017 um 14:34 hat Daniel P. Berrange geschrieben:
> qemu-io puts the TTY into non-canonical mode, which means no EOF processing is
> done and thus getchar() will never return the EOF constant. Instead we have to
> query the TTY attributes to determine the configured EOF character (usually
From: "Daniel P. Berrange"
qemu-io puts the TTY into non-canonical mode, which means no EOF processing is
done and thus getchar() will never return the EOF constant. Instead we have to
query the TTY attributes to determine the configured EOF character (usually
Ctrl-D / 0x4), and then explicitly c
Am 12.02.2018 um 19:48 hat Daniel P. Berrangé geschrieben:
> From: "Daniel P. Berrange"
>
> qemu-io puts the TTY into non-canonical mode, which means no EOF processing is
> done and thus getchar() will never return the EOF constant. Instead we have to
> query the TTY attributes to determine the c
On 02/12/2018 12:48 PM, Daniel P. Berrangé wrote:
From: "Daniel P. Berrange"
qemu-io puts the TTY into non-canonical mode, which means no EOF processing is
done and thus getchar() will never return the EOF constant. Instead we have to
query the TTY attributes to determine the configured EOF cha
From: Paolo Bonzini
1) string not null terminated in sysfs_find_group_file
2) NULL pointer dereference and dead local variable in nvme_init.
Signed-off-by: Paolo Bonzini
Signed-off-by: Fam Zheng
---
v2: Fix error path.
---
block/nvme.c| 10 +++---
util/vfio-helpers.c | 2 +-
2
On 12/02/2018 18:30, Vladimir Sementsov-Ogievskiy wrote:
> 18.01.2018 13:09, Paolo Bonzini wrote:>> We have three cases:
>>
>> 1) monitor creates and destroy bitmaps.
>>
>> 2) monitor also has to read the list. We know it operates with BQL.
>>
>> 3) users such as mirror.c create a dirty bitmap in
55 matches
Mail list logo
