13.02.2018 21:48, Eric Blake wrote:
On 02/13/2018 11:36 AM, Vladimir Sementsov-Ogievskiy wrote:
Hi Eric!
I'm now testing my nbd block status realization (block_status part,
not about dirty bitmaps), and faced into the following effect.
I created empty qcow2 image and wrote to the first secto
Am 13.02.2018 um 21:26 hat Eric Blake geschrieben:
> We are gradually moving away from sector-based interfaces, towards
> byte-based. Update the iscsi driver accordingly. In this case,
> it is handy to teach iscsi_co_block_status() to handle a NULL map
> and file parameter, even though the block
Am 13.02.2018 um 21:26 hat Eric Blake geschrieben:
> We are gradually moving away from sector-based interfaces, towards
> byte-based. Update the null driver accordingly.
>
> Signed-off-by: Eric Blake
> Reviewed-by: Vladimir Sementsov-Ogievskiy
> Reviewed-by: Fam Zheng
>
> ---
> v6-v7: no chan
Am 13.02.2018 um 21:26 hat Eric Blake geschrieben:
> We are gradually moving away from sector-based interfaces, towards
> byte-based. Update the vpc driver accordingly.
>
> Signed-off-by: Eric Blake
> Reviewed-by: Vladimir Sementsov-Ogievskiy
> Reviewed-by: Fam Zheng
>
> ---
> v7: tweak commi
Am 13.02.2018 um 21:27 hat Eric Blake geschrieben:
> We are gradually moving away from sector-based interfaces, towards
> byte-based. Update the vvfat driver accordingly. Note that we
> can rely on the block driver having already clamped limits to our
> block size, and simplify accordingly.
>
>
On 02/14/2018 05:53 AM, Kevin Wolf wrote:
Am 13.02.2018 um 21:26 hat Eric Blake geschrieben:
We are gradually moving away from sector-based interfaces, towards
byte-based. Update the iscsi driver accordingly. In this case,
it is handy to teach iscsi_co_block_status() to handle a NULL map
and f
Hi all.
Just note: looks like we allow zero-sized metadata context name. Is it ok?
*
|NBD_REP_META_CONTEXT| (4)
A description of a metadata context. Data:
o 32 bits, NBD metadata context ID.
o String, name of the metadata context. This is not required to be
a human-rea
On 02/14/2018 06:05 AM, Kevin Wolf wrote:
Am 13.02.2018 um 21:26 hat Eric Blake geschrieben:
We are gradually moving away from sector-based interfaces, towards
byte-based. Update the null driver accordingly.
Signed-off-by: Eric Blake
Reviewed-by: Vladimir Sementsov-Ogievskiy
Reviewed-by: Fam
On 02/14/2018 07:12 AM, Kevin Wolf wrote:
Am 13.02.2018 um 21:27 hat Eric Blake geschrieben:
We are gradually moving away from sector-based interfaces, towards
byte-based. Update the vvfat driver accordingly. Note that we
can rely on the block driver having already clamped limits to our
block
https://framadrop.org/r/Lvvr392QZo#/wOeYUUlHQAtkUw1E+x2YdqTqq21Pbic6OPBIH0TjZE=
Le 14/02/2018 à 00:01, John Snow a écrit :
On 02/13/2018 04:41 AM, Kevin Wolf wrote:
Am 07.02.2018 um 18:06 hat Nicolas Ecarnot geschrieben:
TL; DR : qcow2 images keep getting corrupted. Any workaround?
Not w
On 02/14/2018 07:08 AM, Kevin Wolf wrote:
Am 13.02.2018 um 21:26 hat Eric Blake geschrieben:
We are gradually moving away from sector-based interfaces, towards
byte-based. Update the vpc driver accordingly.
Signed-off-by: Eric Blake
Reviewed-by: Vladimir Sementsov-Ogievskiy
Reviewed-by: Fam
Am 14.02.2018 um 15:44 hat Eric Blake geschrieben:
> On 02/14/2018 06:05 AM, Kevin Wolf wrote:
> > Am 13.02.2018 um 21:26 hat Eric Blake geschrieben:
> > > We are gradually moving away from sector-based interfaces, towards
> > > byte-based. Update the null driver accordingly.
> > >
> > > Signed-o
[using the updated nbd list email]
On 02/14/2018 08:35 AM, Vladimir Sementsov-Ogievskiy wrote:
Hi all.
Just note: looks like we allow zero-sized metadata context name. Is it ok?
*
|NBD_REP_META_CONTEXT| (4)
A description of a metadata context. Data:
o 32 bits, NBD metadata c
Am 14.02.2018 um 15:50 hat Eric Blake geschrieben:
> On 02/14/2018 07:12 AM, Kevin Wolf wrote:
> > Am 13.02.2018 um 21:27 hat Eric Blake geschrieben:
> > > We are gradually moving away from sector-based interfaces, towards
> > > byte-based. Update the vvfat driver accordingly. Note that we
> > >
14.02.2018 17:56, Eric Blake wrote:
[using the updated nbd list email]
On 02/14/2018 08:35 AM, Vladimir Sementsov-Ogievskiy wrote:
Hi all.
Just note: looks like we allow zero-sized metadata context name. Is
it ok?
*
|NBD_REP_META_CONTEXT| (4)
A description of a metadata context.
The normal bdrv_co_pwritev() use is either
- BDRV_REQ_ZERO_WRITE clear and iovector provided
- BDRV_REQ_ZERO_WRITE set and iovector == NULL
while
- the flag clear and iovector == NULL is an assertion failure
in bdrv_co_do_zero_pwritev()
- the flag set and iovector provided is in fact a
v3: patch 1: image cluster size reduced to get away with a smaller test image
(the cluster size can be as small as 512 bytes for qcow2,
but the test runs for all generic formats and minimum for qed is 4k)
v2: http://lists.nongnu.org/archive/html/qemu-devel/2018-02/msg03016.html
Anton Nef
This new test case only makes sense for qcow2 while iotest 033 is generic;
however it matches the test purpose perfectly and also 033 contains those
do_test() tricks to pass the alignment, which won't look nice being
duplicated in other tests or moved to the common code.
Signed-off-by: Anton Nefed
Am 13.02.2018 um 21:26 hat Eric Blake geschrieben:
> There are patches floating around to add NBD_CMD_BLOCK_STATUS,
> but NBD wants to report status on byte granularity (even if the
> reporting will probably be naturally aligned to sectors or even
> much higher levels). I've therefore started the
Am 14.02.2018 um 17:09 hat Anton Nefedov geschrieben:
> v3: patch 1: image cluster size reduced to get away with a smaller test image
> (the cluster size can be as small as 512 bytes for qcow2,
> but the test runs for all generic formats and minimum for qed is 4k)
Thanks, applied to the b
On 02/13/2018 05:26 PM, Eric Blake wrote:
> Commit bdd6a90 has a bug: drivers should never directly set
> BDRV_BLOCK_ALLOCATED, but only io.c should do that (as needed).
Doesn't "pointless" in subject hide this is a bugfix?
> Instead, drivers should report BDRV_BLOCK_DATA if it knows that
> data
On 02/14/2018 10:09 AM, Anton Nefedov wrote:
This new test case only makes sense for qcow2 while iotest 033 is generic;
however it matches the test purpose perfectly and also 033 contains those
do_test() tricks to pass the alignment, which won't look nice being
duplicated in other tests or moved
> On 3 Feb 2018, at 06:16, Stefan Hajnoczi wrote:
>
> iscsi_aio_cancel() does not increment the request's reference count,
> causing a use-after-free when ABORT TASK finishes after the request has
> already completed.
>
> There are some additional issues with iscsi_aio_cancel():
> 1. Several AB
For (x-)blockdev-create, all protocol drivers that support image
creation also need to offer a .bdrv_truncate() implementation that
matches in features. A previous series of mine brought gluster's and
sheepdog's implementation up to par regarding preallocated truncation;
but I forgot about drivers
If we ever want to offer even rudimentary truncation functionality for
ssh, we should put the respective code into a reusable function.
Signed-off-by: Max Reitz
---
block/ssh.c | 30 ++
1 file changed, 22 insertions(+), 8 deletions(-)
diff --git a/block/ssh.c b/block
libssh2 does not seem to offer real truncation support, so we can only
grow files -- but that is better than nothing.
Signed-off-by: Max Reitz
---
block/ssh.c | 24
1 file changed, 24 insertions(+)
diff --git a/block/ssh.c b/block/ssh.c
index ff8576f21e..c235eec255 1006
At runtime (that is, during a future ssh_truncate()), the SSH session is
non-blocking. However, ssh_truncate() (or rather, bdrv_truncate() in
general) is not a coroutine, so this resize operation needs to block.
For ssh_create(), that is fine, too; the session is never set to
non-blocking anyway.
On 2018-02-14 00:33, Eric Blake wrote:
> I mentioned this while reviewing Berto's series on L2 slice handling;
> this is a first cut at patches that I think are worth doing throughout
> the qcow2 code base if we like the idea.
I like the idea. :-)
The patches look good to me.
Max
> Eric Blake (
On 02/14/2018 02:49 PM, Max Reitz wrote:
If we ever want to offer even rudimentary truncation functionality for
ssh, we should put the respective code into a reusable function.
Signed-off-by: Max Reitz
---
block/ssh.c | 30 ++
1 file changed, 22 insertions(+), 8 d
On 02/14/2018 02:49 PM, Max Reitz wrote:
libssh2 does not seem to offer real truncation support, so we can only
grow files -- but that is better than nothing.
Signed-off-by: Max Reitz
---
block/ssh.c | 24
1 file changed, 24 insertions(+)
Reviewed-by: Eric Blake
On 02/14/2018 02:49 PM, Max Reitz wrote:
At runtime (that is, during a future ssh_truncate()), the SSH session is
non-blocking. However, ssh_truncate() (or rather, bdrv_truncate() in
general) is not a coroutine, so this resize operation needs to block.
For ssh_create(), that is fine, too; the s
On 2018-02-14 22:11, Eric Blake wrote:
> On 02/14/2018 02:49 PM, Max Reitz wrote:
>> At runtime (that is, during a future ssh_truncate()), the SSH session is
>> non-blocking. However, ssh_truncate() (or rather, bdrv_truncate() in
>> general) is not a coroutine, so this resize operation needs to bl
Commit 79ba8c98 (v2.7) changed the setting of request_alignment
to occur only during bdrv_refresh_limits(), rather than at at
bdrv_open() time; but at the time, NBD was unaffected, because
it still used sector-based callbacks, so the block layer
defaulted NBD to use 512 request_alignment.
Later, c
where it is used.
Signed-off-by: Philippe Mathieu-Daudé
---
hw/block/nvme.h | 1 -
hw/block/nvme.c | 1 +
2 files changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/block/nvme.h b/hw/block/nvme.h
index 8f3981121d..cabcf20c32 100644
--- a/hw/block/nvme.h
+++ b/hw/block/nvme.h
@@ -1,6 +1,5 @@
It ease code review, unit is explicit.
Signed-off-by: Philippe Mathieu-Daudé
---
hw/block/tc58128.c | 2 +-
hw/sh4/r2d.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/hw/block/tc58128.c b/hw/block/tc58128.c
index 1d9f7ee000..3e658d509f 100644
--- a/hw/block/tc58128
It ease code review, unit is explicit.
Signed-off-by: Philippe Mathieu-Daudé
---
hw/block/xen_disk.c| 4 ++--
hw/xenpv/xen_domainbuild.c | 10 +-
2 files changed, 7 insertions(+), 7 deletions(-)
diff --git a/hw/block/xen_disk.c b/hw/block/xen_disk.c
index f74fcd42d1..557005b5e5
On 15.02.2018 05:28, Philippe Mathieu-Daudé wrote:
> where it is used.
>
> Signed-off-by: Philippe Mathieu-Daudé
> ---
> hw/block/nvme.h | 1 -
> hw/block/nvme.c | 1 +
> 2 files changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/hw/block/nvme.h b/hw/block/nvme.h
> index 8f3981121d..cabcf2
37 matches
Mail list logo