[Qemu-block] [PATCH v3 5/7] qapi: Make more of qobject_to()

This patch reworks some places which use either qobject_type() checks plus qobject_to(), where the latter alone is sufficient, or NULL checks plus qobject_type() checks where we can simply do a qobject_to() != NULL check. Signed-off-by: Max Reitz Reviewed-by: Alberto Garcia

[Qemu-block] [PATCH v3 6/7] block: Handle null backing link

Instead of converting all "backing": null instances into "backing": "", handle a null value directly in bdrv_open_inherit(). This enables explicitly null backing links for json:{} filenames. Signed-off-by: Max Reitz Reviewed-by: Alberto Garcia --- block.c

Re: [Qemu-block] [PATCH v2 00/16] block/mirror: Add active-sync mirroring

Pïng On 2018-01-22 23:07, Max Reitz wrote: > This series implements an active and synchronous mirroring mode. > > Currently, the mirror block job is passive an asynchronous: Depending on > your start conditions, some part of the source disk starts as "dirty". > Then, the block job will (as a

[Qemu-block] [PATCH v3 3/7] qapi: Replace qobject_to_X(o) by qobject_to(o, X)

This patch was generated using the following Coccinelle script: @@ expression Obj; @@ ( - qobject_to_qnum(Obj) + qobject_to(Obj, QNum) | - qobject_to_qstring(Obj) + qobject_to(Obj, QString) | - qobject_to_qdict(Obj) + qobject_to(Obj, QDict) | - qobject_to_qlist(Obj) + qobject_to(Obj, QList) | -

[Qemu-block] [PATCH v3 4/7] qapi: Remove qobject_to_X() functions

They are no longer needed now. Signed-off-by: Max Reitz Reviewed-by: Alberto Garcia --- include/qapi/qmp/qbool.h | 1 - include/qapi/qmp/qdict.h | 1 - include/qapi/qmp/qlist.h | 1 - include/qapi/qmp/qnum.h| 1 - include/qapi/qmp/qstring.h |

[Qemu-block] [PATCH v3 1/7] compiler: Add QEMU_BUILD_BUG_MSG() macro

_Static_assert() allows us to specify messages, and that may come in handy. Even without _Static_assert(), encouraging developers to put a helpful message next to the QEMU_BUILD_BUG_* may make debugging easier whenever it breaks. Signed-off-by: Max Reitz ---

[Qemu-block] [PATCH v3 2/7] qapi: Add qobject_to()

This is a dynamic casting macro that, given a QObject type, returns an object as that type or NULL if the object is of a different type (or NULL itself). The macro uses lower-case letters because: 1. There does not seem to be a hard rule on whether qemu macros have to be upper-cased, 2. The

[Qemu-block] [PATCH v3 0/7] block: Handle null backing link

Currently, we try to rewrite every occurrence of "backing": null into "backing": "" in qmp_blockdev_add(). However, that breaks using the same "backing": null construction in json:{} file names (which do not go through qmp_blockdev_add()). Currently, these then just behave as if the option has

[Qemu-block] [PATCH v3 7/7] block: Deprecate "backing": ""

We have a clear replacement, so let's deprecate it. Signed-off-by: Max Reitz Reviewed-by: Eric Blake Reviewed-by: Alberto Garcia --- qapi/block-core.json | 4 ++-- block.c | 4 qemu-doc.texi| 7 +++

Re: [Qemu-block] [Qemu-devel] [PATCH v3 0/7] block: Handle null backing link

Hi, This series failed build test on s390x host. Please find the details below. Type: series Message-id: 20180224154033.29559-1-mre...@redhat.com Subject: [Qemu-devel] [PATCH v3 0/7] block: Handle null backing link === TEST SCRIPT BEGIN === #!/bin/bash # Testing script will be invoked under the

Re: [Qemu-block] [Qemu-devel] [PATCH] migration: do not transfer ram during bulk storage migration

Hi, This series failed docker-build@min-glib build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. Type: series Message-id: 1519139403-2646-1-git-send-email...@kamp.de Subject: [Qemu-devel] [PATCH] migration: do

Re: [Qemu-block] [Qemu-devel] [RFC v4 00/21] blockjobs: add explicit job management

Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20180223235142.21501-1-js...@redhat.com Subject: [Qemu-devel] [RFC v4 00/21] blockjobs: add explicit job management === TEST SCRIPT BEGIN === #!/bin/bash BASE=base n=1

Re: [Qemu-block] [PATCH v3 3/7] qapi: Replace qobject_to_X(o) by qobject_to(o, X)

On 02/24/2018 09:40 AM, Max Reitz wrote: This patch was generated using the following Coccinelle script: and a bit of manual fix-up for overly long lines and three places in tests/check-qjson.c that Coccinelle did not find. Signed-off-by: Max Reitz Reviewed-by: Alberto

Re: [Qemu-block] [Qemu-devel] [PATCH v3 0/7] block: Handle null backing link

Hi, This series failed docker-mingw@fedora build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. Type: series Message-id: 20180224154033.29559-1-mre...@redhat.com Subject: [Qemu-devel] [PATCH v3 0/7] block:

Re: [Qemu-block] [PATCH v3 1/7] compiler: Add QEMU_BUILD_BUG_MSG() macro

On 02/24/2018 09:40 AM, Max Reitz wrote: _Static_assert() allows us to specify messages, and that may come in handy. Even without _Static_assert(), encouraging developers to put a helpful message next to the QEMU_BUILD_BUG_* may make debugging easier whenever it breaks. Signed-off-by: Max

Re: [Qemu-block] [Qemu-devel] [PATCH v3 0/7] block: Handle null backing link

Hi, This series failed docker-quick@centos6 build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. Type: series Message-id: 20180224154033.29559-1-mre...@redhat.com Subject: [Qemu-devel] [PATCH v3 0/7] block:

Re: [Qemu-block] [PATCH v3 2/7] qapi: Add qobject_to()

On 02/24/2018 09:40 AM, Max Reitz wrote: This is a dynamic casting macro that, given a QObject type, returns an object as that type or NULL if the object is of a different type (or NULL itself). The macro uses lower-case letters because: 1. There does not seem to be a hard rule on whether qemu

Re: [Qemu-block] [PATCH v3 4/7] qapi: Remove qobject_to_X() functions

On 02/24/2018 09:40 AM, Max Reitz wrote: They are no longer needed now. Signed-off-by: Max Reitz Reviewed-by: Alberto Garcia --- include/qapi/qmp/qbool.h | 1 - include/qapi/qmp/qdict.h | 1 - include/qapi/qmp/qlist.h | 1 -

Re: [Qemu-block] [PATCH v3 6/7] block: Handle null backing link

On 02/24/2018 09:40 AM, Max Reitz wrote: Instead of converting all "backing": null instances into "backing": "", handle a null value directly in bdrv_open_inherit(). This enables explicitly null backing links for json:{} filenames. Signed-off-by: Max Reitz Reviewed-by:

Re: [Qemu-block] [PATCH v3 5/7] qapi: Make more of qobject_to()

On 02/24/2018 09:40 AM, Max Reitz wrote: This patch reworks some places which use either qobject_type() checks plus qobject_to(), where the latter alone is sufficient, or NULL checks plus qobject_type() checks where we can simply do a qobject_to() != NULL check. Signed-off-by: Max Reitz

Re: [Qemu-block] [Qemu-devel] [PATCH v3 0/7] block: Handle null backing link

Hi, This series failed docker-build@min-glib build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. Type: series Message-id: 20180224154033.29559-1-mre...@redhat.com Subject: [Qemu-devel] [PATCH v3 0/7] block: