Re: [Qemu-block] [PATCH] block: remove bdrv_dirty_bitmap_make_anon

On Fri, Mar 23, 2018 at 05:42:53PM +0100, Paolo Bonzini wrote: > All this function is doing will be repeated by > bdrv_do_release_matching_dirty_bitmap_locked, except > resetting bm->persistent. But even that does not matter > because the bitmap will be freed. > > Signed-off-by: Paolo Bonzini

Re: [Qemu-block] [Qemu-devel] [PATCH for-2.12] block: handle invalid lseek returns gracefully

On 04/02/2018 11:37 PM, Jeff Cody wrote: > In commit 223a23c198787328ae75bc65d84edf5fde33c0b6, we implemented a > workaround in the gluster driver to handle invalid values returned for > SEEK_DATA or SEEK_HOLE. > > In some instances, these same invalid values can be seen in the posix > file

Re: [Qemu-block] [PATCH v2 1/1] qemu-iotests: Use ppc64 qemu_arch on ppc64le host

Am 29.03.2018 um 16:31 hat Max Reitz geschrieben: > On 2018-03-29 13:20, Lukáš Doktor wrote: > > The qemu target does not always correspond to the host machine type. For > > example ppc64le machine target is ppc64. Let's introduce "qemu_arch" > > variable to store the matching qemu architecture

[Qemu-block] [PATCH for-2.12] gluster: Fix blockdev-add with server.N.type=unix

The legacy command line interface gets the socket path from an option called 'socket'. QAPI in contract uses SocketAddress, where the corresponding option is called 'path'. Fix the gluster block driver to accept both 'socket' and 'path', with 'path' being the preferred syntax.

Re: [Qemu-block] [Qemu-devel] [PATCH v2 1/1] iotests: fix test case 185

On Tue, Mar 27, 2018 at 11:32:00AM +0800, QingFeng Hao wrote: > > 在 2018/3/23 18:04, Stefan Hajnoczi 写道: > > On Fri, Mar 23, 2018 at 3:43 AM, QingFeng Hao > > wrote: > > > Test case 185 failed since commit 4486e89c219 --- "vl: introduce > > > vm_shutdown()". > > >

Re: [Qemu-block] [PATCH 3/3] iotests: blacklist bochs and cloop for 205 and 208

Am 30.03.2018 um 17:16 hat Vladimir Sementsov-Ogievskiy geschrieben: > Blacklist these formats, as they don't support image creation, as they > say: > > ./qemu-img create -f bochs x 1m > qemu-img: x: Format driver 'bochs' does not support image creation > > > ./qemu-img create -f

Re: [Qemu-block] [PATCH for-2.12] gluster: Fix blockdev-add with server.N.type=unix

On Tue, Apr 03, 2018 at 01:08:10PM +0200, Kevin Wolf wrote: > The legacy command line interface gets the socket path from an option > called 'socket'. QAPI in contract uses SocketAddress, where the > corresponding option is called 'path'. > > Fix the gluster block driver to accept both 'socket'

Re: [Qemu-block] [PATCH for-2.12] gluster: Fix blockdev-add with server.N.type=unix

On Tue, Apr 03, 2018 at 01:08:10PM +0200, Kevin Wolf wrote: > The legacy command line interface gets the socket path from an option > called 'socket'. QAPI in contract uses SocketAddress, where the > corresponding option is called 'path'. > > Fix the gluster block driver to accept both 'socket'

Re: [Qemu-block] [PATCH for-2.12] block: handle invalid lseek returns gracefully

Am 03.04.2018 um 06:37 hat Jeff Cody geschrieben: > In commit 223a23c198787328ae75bc65d84edf5fde33c0b6, we implemented a > workaround in the gluster driver to handle invalid values returned for > SEEK_DATA or SEEK_HOLE. > > In some instances, these same invalid values can be seen in the posix >

Re: [Qemu-block] [PATCH for-2.12] gluster: Fix blockdev-add with server.N.type=unix

On 04/03/2018 06:08 AM, Kevin Wolf wrote: > The legacy command line interface gets the socket path from an option > called 'socket'. QAPI in contract uses SocketAddress, where the > corresponding option is called 'path'. > > Fix the gluster block driver to accept both 'socket' and 'path', with >

[Qemu-block] [PATCH] qemu-iotests: update 185 output

Commit 4486e89c219c0d1b9bd8dfa0b1dd5b0d51ff2268 ("vl: introduce vm_shutdown()") added a bdrv_drain_all() call. As a side-effect of the drain operation the block job iterates one more time than before. The 185 output no longer matches and the test is failing now. It may be possible to avoid the

Re: [Qemu-block] [Qemu-devel] [PATCH for-2.12 v4 0/2] Update output of some iotests

Am 22.03.2018 um 15:45 hat Alberto Garcia geschrieben: > I sent a patch a few days ago correction the output of iotests 051 and > 186. I wanted to resend it again but I noticed that 186 needs now more > changes due to commit ac64273c66ab136c44043259162, so I'm including > those changes too. [ Cc:

Re: [Qemu-block] [PATCH v4 for 2.12 0/3] fix bitmaps migration through shared storage

On 2018-03-30 17:32, Vladimir Sementsov-Ogievskiy wrote: > 30.03.2018 16:31, Vladimir Sementsov-Ogievskiy wrote: >> 29.03.2018 18:09, Vladimir Sementsov-Ogievskiy wrote: >>> 29.03.2018 17:03, Max Reitz wrote: On 2018-03-29 10:08, Vladimir Sementsov-Ogievskiy wrote: > 28.03.2018 17:53, Max

[Qemu-block] [PULL 3/9] iotests: Update 051 and 186 after commit 1454509726719e0933c

From: Alberto Garcia SCSI controllers are no longer created automatically for -drive if=scsi, so this patch updates the tests that relied on that. Signed-off-by: Alberto Garcia Reviewed-by: Eric Blake Cc: Thomas Huth

Re: [Qemu-block] [PATCH 1/3] iotests.py: improve verify_image_format helper

Am 30.03.2018 um 17:16 hat Vladimir Sementsov-Ogievskiy geschrieben: > Add an assert (we don't want set both arguments) and remove > duplication. > > Signed-off-by: Vladimir Sementsov-Ogievskiy > --- > tests/qemu-iotests/iotests.py | 6 +++--- > 1 file changed, 3

Re: [Qemu-block] [Qemu-devel] [PATCH for-2.12] block: handle invalid lseek returns gracefully

On Tue, Apr 03, 2018 at 07:57:14AM -0500, Eric Blake wrote: > On 04/02/2018 11:37 PM, Jeff Cody wrote: > > In commit 223a23c198787328ae75bc65d84edf5fde33c0b6, we implemented a > > workaround in the gluster driver to handle invalid values returned for > > SEEK_DATA or SEEK_HOLE. > > > > In some

[Qemu-block] [PULL 3/3] gluster: Fix blockdev-add with server.N.type=unix

From: Kevin Wolf The legacy command line interface gets the socket path from an option called 'socket'. QAPI in contract uses SocketAddress, where the corresponding option is called 'path'. Fix the gluster block driver to accept both 'socket' and 'path', with 'path' being the

[Qemu-block] [PULL 2/3] blockjob: use qapi enum helpers

From: Marc-André Lureau QAPI generator provide #define helpers for looking up enum string. Signed-off-by: Marc-André Lureau Reviewed-by: John Snow Message-id: 20180327153011.29569-1-marcandre.lur...@redhat.com

[Qemu-block] [PULL 1/3] blockjob: leak fix, remove from txn when failing early

From: Marc-André Lureau This fixes leaks found by ASAN such as: GTESTER tests/test-blockjob = ==31442==ERROR: LeakSanitizer: detected memory leaks Direct leak of 24 byte(s) in 1 object(s) allocated

[Qemu-block] [PULL 0/3] Block patches for 2.12-rc2

The following changes since commit f184de7553272223d6af731d7d623a7cebf710b5: Merge remote-tracking branch 'remotes/riscv/tags/riscv-qemu-2.12-critical-fixes' into staging (2018-03-31 09:42:33 +0100) are available in the git repository at: git://github.com/codyprime/qemu-kvm-jtc.git

Re: [Qemu-block] [PATCH for 2.12] iotests: fix 208 for luks format

Am 30.03.2018 um 16:44 hat Vladimir Sementsov-Ogievskiy geschrieben: > Support luks images creatins like in 205 > > Signed-off-by: Vladimir Sementsov-Ogievskiy Thanks, applied to the block branch. Kevin

[Qemu-block] [PULL 2/9] block: handle invalid lseek returns gracefully

From: Jeff Cody In commit 223a23c198787328ae75bc65d84edf5fde33c0b6, we implemented a workaround in the gluster driver to handle invalid values returned for SEEK_DATA or SEEK_HOLE. In some instances, these same invalid values can be seen in the posix file handler as well - for

[Qemu-block] [PULL 0/9] Block layer patches for 2.12.0-rc2

The following changes since commit f184de7553272223d6af731d7d623a7cebf710b5: Merge remote-tracking branch 'remotes/riscv/tags/riscv-qemu-2.12-critical-fixes' into staging (2018-03-31 09:42:33 +0100) are available in the git repository at: git://repo.or.cz/qemu/kevin.git tags/for-upstream

[Qemu-block] [PULL 4/9] iotests: Update 186 after commit ac64273c66ab136c44043259162

From: Alberto Garcia Commit ac64273c66ab136c44 modified the output of iotest 186, changing the QOM path of floppy drives from /machine/unattached/device[17] to /machine/unattached/device[13]. Instead of updating the test output to reflect this change, this patch adds a new

[Qemu-block] [PULL 6/9] block/file-posix: Fix fully preallocated truncate

From: Max Reitz Storing the lseek() result in an int results in it overflowing when the file is at least 2 GB big. Then, we have a 50 % chance of the result being "negative" and thus thinking an error occurred when actually everything went just fine. So we should use the

[Qemu-block] [PULL 1/9] gluster: Fix blockdev-add with server.N.type=unix

The legacy command line interface gets the socket path from an option called 'socket'. QAPI in contract uses SocketAddress, where the corresponding option is called 'path'. Fix the gluster block driver to accept both 'socket' and 'path', with 'path' being the preferred syntax.

Re: [Qemu-block] [PATCH] iotests: fix 169

On 2018-03-30 18:10, Vladimir Sementsov-Ogievskiy wrote: > Use MIGRATION events instead of RESUME. Also, make a TODO: enable > dirty-bitmaps capability for offline case. > > This (likely) fixes racy faults at least of the following types: > > - timeout on waiting for RESUME event > -

[Qemu-block] [PULL 9/9] iotests: Test abnormally large size in compressed cluster descriptor

From: Alberto Garcia L2 entries for compressed clusters have a field that indicates the number of sectors used to store the data in the image. That's however not the size of the compressed data itself, just the number of sectors where that data is located. The actual data size

Re: [Qemu-block] [Qemu-devel] [PATCH] iotests: fix 169

On 04/03/2018 12:23 PM, Max Reitz wrote: > On 2018-03-30 18:10, Vladimir Sementsov-Ogievskiy wrote: >> Use MIGRATION events instead of RESUME. Also, make a TODO: enable >> dirty-bitmaps capability for offline case. >> >> This (likely) fixes racy faults at least of the following types: >> >>

Re: [Qemu-block] [Qemu-devel] [PULL 1/9] gluster: Fix blockdev-add with server.N.type=unix

On Tue, Apr 03, 2018 at 06:33:52PM +0200, Kevin Wolf wrote: > The legacy command line interface gets the socket path from an option > called 'socket'. QAPI in contract uses SocketAddress, where the > corresponding option is called 'path'. > > Fix the gluster block driver to accept both 'socket'