[Qemu-block] [PULL 1/5] vhost-user-blk: set config ops before vhost-user init

2018-04-09 Thread Michael S. Tsirkin
From: Maxime Coquelin As soon as vhost-user init is done, the backend may send VHOST_USER_SLAVE_CONFIG_CHANGE_MSG, so let's set the notification callback before it. Also, it will be used to know whether the device supports the config feature to advertize it or not.

Re: [Qemu-block] [Qemu-discuss] qemu-img convert stuck

2018-04-09 Thread Stefan Hajnoczi
On Sun, Apr 08, 2018 at 10:35:16PM +0300, Benny Zlotnik wrote: What type of storage are the source and destination images? (e.g. source is a local qcow2 file on xfs, destination is a raw file on NFS) > $ gdb -p 13024 -batch -ex "thread apply all bt" > [Thread debugging using libthread_db

Re: [Qemu-block] [PATCH] iotests: Split 214 off of 122

2018-04-09 Thread Alberto Garcia
On Fri 06 Apr 2018 06:41:08 PM CEST, Max Reitz wrote: > Commit abd3622cc03cf41ed542126a540385f30a4c0175 added a case to 122 > regarding how the qcow2 driver handles an incorrect compressed data > length value. This does not really fit into 122, as that file is > supposed to

Re: [Qemu-block] [PATCH for-2.12] hw/block/pflash_cfi: fix off-by-one error

2018-04-09 Thread Kevin Wolf
Am 05.04.2018 um 01:32 hat Philippe Mathieu-Daudé geschrieben: > ASAN reported: > > hw/block/pflash_cfi02.c:245:33: runtime error: index 82 out of bounds for > type 'uint8_t [82]' > > Since the 'cfi_len' member is not used, remove it to keep the code safer. > > Reported-by:

Re: [Qemu-block] block-stream/commit and mixing internal and external snapshots

2018-04-09 Thread Kevin Wolf
Am 07.04.2018 um 00:16 hat Eric Blake geschrieben: > Perhaps others have already known this, but I just realized that if you > mix internal and external snapshots, you can set yourself up for massive > failures when trying to use block-stream or block-commit to consolidate > data across the

Re: [Qemu-block] [PATCH for-2.12 v2] qemu-iotests: update 185 output

2018-04-09 Thread Stefan Hajnoczi
On Wed, Apr 04, 2018 at 06:16:12PM +0200, Max Reitz wrote: > On 2018-04-04 17:01, Stefan Hajnoczi wrote: > > Commit 4486e89c219c0d1b9bd8dfa0b1dd5b0d51ff2268 ("vl: introduce > > vm_shutdown()") added a bdrv_drain_all() call. As a side-effect of the > > drain operation the block job iterates one

Re: [Qemu-block] [Qemu-discuss] qemu-img convert stuck

2018-04-09 Thread Benny Zlotnik
source: qcow2 on NFS target: raw on NFS source: $ qemu-img info /rhev/data-center/bb422fac-81c5-4fea-8782-3498bb5c8a59/26989331-2c39-4b34-a7ed-d7dd7703646c/images/597e12b6-19f5-45bd-868f-767600c7115e/62a5492e-e120-4c25-898e-9f5f5629853e image:

Re: [Qemu-block] [RFC PATCH 4/8] file-posix: Implement bdrv_co_copy_range

2018-04-09 Thread Fam Zheng
On Wed, 04/04 14:20, Stefan Hajnoczi wrote: > On Thu, Mar 29, 2018 at 07:09:10PM +0800, Fam Zheng wrote: > > +static ssize_t handle_aiocb_copy_range(RawPosixAIOData *aiocb) > > +{ > > +#ifndef HAS_COPY_FILE_RANGE > > +return -ENOTSUP; > > +#else > > +uint64_t bytes = aiocb->aio_nbytes; > >

Re: [Qemu-block] [PATCH 3/3] iotests: blacklist bochs and cloop for 205 and 208

2018-04-09 Thread Vladimir Sementsov-Ogievskiy
03.04.2018 16:36, Kevin Wolf wrote: Am 30.03.2018 um 17:16 hat Vladimir Sementsov-Ogievskiy geschrieben: Blacklist these formats, as they don't support image creation, as they say: > ./qemu-img create -f bochs x 1m qemu-img: x: Format driver 'bochs' does not support image creation

[Qemu-block] [PATCH v2 0/2] iotests: blacklist bochs and cloop for 205 and 208

2018-04-09 Thread Vladimir Sementsov-Ogievskiy
v2: move from unsupported_fmts to support "generic", like in bash tests. Vladimir Sementsov-Ogievskiy (2): iotests.py: improve verify_image_format helper iotests: blacklist bochs and cloop for 205 and 208 tests/qemu-iotests/205| 2 +- tests/qemu-iotests/208| 2 ++

[Qemu-block] [PATCH v2 2/2] iotests: blacklist bochs and cloop for 205 and 208

2018-04-09 Thread Vladimir Sementsov-Ogievskiy
Blacklist these formats, as they don't support image creation, as they say: > ./qemu-img create -f bochs x 1m qemu-img: x: Format driver 'bochs' does not support image creation > ./qemu-img create -f cloop x 1m qemu-img: x: Format driver 'cloop' does not support image creation

[Qemu-block] [PATCH v2 1/2] iotests.py: improve verify_image_format helper

2018-04-09 Thread Vladimir Sementsov-Ogievskiy
Support "generic" formats like in bash tests with their _supported_fmt generic The test, supporting "generic" formats will run if IMGFMT_GENERIC = true, which is default, except for bochs and cloop. However, you can use verify_image_format(['generic', 'bochs']), which will run for all except

Re: [Qemu-block] block-stream/commit and mixing internal and external snapshots

2018-04-09 Thread Eric Blake
On 04/09/2018 04:11 AM, Kevin Wolf wrote: > Am 07.04.2018 um 00:16 hat Eric Blake geschrieben: >> Perhaps others have already known this, but I just realized that if you >> mix internal and external snapshots, you can set yourself up for massive >> failures when trying to use block-stream or

Re: [Qemu-block] [PATCH 3/3] iotests: blacklist bochs and cloop for 205 and 208

2018-04-09 Thread Kevin Wolf
Am 09.04.2018 um 13:30 hat Vladimir Sementsov-Ogievskiy geschrieben: > 03.04.2018 16:36, Kevin Wolf wrote: > > Am 30.03.2018 um 17:16 hat Vladimir Sementsov-Ogievskiy geschrieben: > > > Blacklist these formats, as they don't support image creation, as they > > > say: > > > > ./qemu-img create