On Wed, Apr 04, 2018 at 06:16:12PM +0200, Max Reitz wrote:
> On 2018-04-04 17:01, Stefan Hajnoczi wrote:
> === Start mirror job and exit qemu ===
>
> This seems to be independent of whether there is actually data on
> TEST_IMG (the commit source), so something doesn't seem quite right with
> the
Am 09.04.2018 um 13:44 hat Vladimir Sementsov-Ogievskiy geschrieben:
> v2: move from unsupported_fmts to support "generic", like in bash tests.
Thanks, applied to the block branch.
Kevin
qemu-iotests doesn't support dmg, and the dmg block driver doesn't
support image creation. Two test cases declare dmg as supported, but
that's obviously wrong for both reasons. Remove the declaration.
Signed-off-by: Kevin Wolf
---
tests/qemu-iotests/183 | 2 +-
tests/qemu-iotests/194 | 2 +-
2 f
Streaming and the commit block job only want to apply throttling when
they actually copied data instead of skipping it, so they made the
calculation of delay_ns conditional. However, delay_ns isn't reset when
skipping some sectors, so instead of not waiting, the old delay is
applied again.
Properl
On 04/10/2018 03:42 AM, Kevin Wolf wrote:
> qemu-iotests doesn't support dmg, and the dmg block driver doesn't
> support image creation. Two test cases declare dmg as supported, but
> that's obviously wrong for both reasons. Remove the declaration.
>
> Signed-off-by: Kevin Wolf
> ---
> tests/qem
On 04/10/2018 03:58 AM, Kevin Wolf wrote:
> Streaming and the commit block job only want to apply throttling when
> they actually copied data instead of skipping it, so they made the
> calculation of delay_ns conditional. However, delay_ns isn't reset when
> skipping some sectors, so instead of not
On Tue, Apr 10, 2018 at 1:44 PM Richard W.M. Jones
wrote:
> We now have true zeroing support in oVirt imageio, thanks for that.
>
> However a problem is that ‘qemu-img convert’ issues zero requests for
> the whole disk before starting the transfer. It does this using 32 MB
> requests which take
From: Peter Xu
If there are more than one events, wait_until_completed() might return
the 2nd event even if the 1st event is JOB_COMPLETED, since the for loop
will continue to run even if completed is set to True.
It never happened before, but it can be triggered when OOB is enabled
due to the R
Am 10.04.2018 um 15:03 hat Nir Soffer geschrieben:
> On Tue, Apr 10, 2018 at 1:44 PM Richard W.M. Jones
> wrote:
>
> > We now have true zeroing support in oVirt imageio, thanks for that.
> >
> > However a problem is that ‘qemu-img convert’ issues zero requests for
> > the whole disk before starti
On Tue, Apr 10, 2018 at 4:48 PM Kevin Wolf wrote:
> Am 10.04.2018 um 15:03 hat Nir Soffer geschrieben:
> > On Tue, Apr 10, 2018 at 1:44 PM Richard W.M. Jones
> > wrote:
> >
> > > We now have true zeroing support in oVirt imageio, thanks for that.
> > >
> > > However a problem is that ‘qemu-img c
On Tue, Apr 10, 2018 at 03:48:11PM +0200, Kevin Wolf wrote:
> Am 10.04.2018 um 15:03 hat Nir Soffer geschrieben:
> > On Tue, Apr 10, 2018 at 1:44 PM Richard W.M. Jones
> > wrote:
> >
> > > We now have true zeroing support in oVirt imageio, thanks for that.
> > >
> > > However a problem is that ‘q
Am 10.04.2018 um 10:11 hat Stefan Hajnoczi geschrieben:
> On Wed, Apr 04, 2018 at 06:16:12PM +0200, Max Reitz wrote:
> > On 2018-04-04 17:01, Stefan Hajnoczi wrote:
> > === Start mirror job and exit qemu ===
> >
> > This seems to be independent of whether there is actually data on
> > TEST_IMG (t
On Tue, Apr 10, 2018 at 02:07:33PM +, Nir Soffer wrote:
> This makes sense if the device is backed by a block device on oVirt side,
> and the NBD support efficient zeroing. But in this case the device is backed
> by an empty sparse file on NFS, and oVirt does not support yet efficient
> zeroing
On 04/10/2018 09:07 AM, Nir Soffer wrote:
> On Tue, Apr 10, 2018 at 4:48 PM Kevin Wolf wrote:
>
>> Am 10.04.2018 um 15:03 hat Nir Soffer geschrieben:
>>> On Tue, Apr 10, 2018 at 1:44 PM Richard W.M. Jones
>>> wrote:
>>>
We now have true zeroing support in oVirt imageio, thanks for that.
>>>
On 04/10/2018 09:40 AM, Richard W.M. Jones wrote:
>> When the destination is a block device we cannot avoid zeroing since a block
>> device may contain junk data (we usually get dirty empty images from our
>> local
>> xtremio server).
>
> (Off topic for qemu-block but ...) We don't have enough in
On Tue, Apr 10, 2018 at 5:50 PM Richard W.M. Jones
wrote:
> On Tue, Apr 10, 2018 at 02:07:33PM +, Nir Soffer wrote:
> > This makes sense if the device is backed by a block device on oVirt side,
> > and the NBD support efficient zeroing. But in this case the device is
> backed
> > by an empty
On Tue, Apr 10, 2018 at 6:00 PM Eric Blake wrote:
> On 04/10/2018 09:40 AM, Richard W.M. Jones wrote:
> >> When the destination is a block device we cannot avoid zeroing since a
> block
> >> device may contain junk data (we usually get dirty empty images from our
> >> local
> >> xtremio server).
From: Vladimir Sementsov-Ogievskiy
Support "generic" formats like in bash tests with their
_supported_fmt generic
The test, supporting "generic" formats will run if IMGFMT_GENERIC =
true, which is default, except for bochs and cloop. However, you can
use verify_image_format(['generic', 'bochs'
From: Vladimir Sementsov-Ogievskiy
Blacklist these formats, as they don't support image creation, as they
say:
> ./qemu-img create -f bochs x 1m
qemu-img: x: Format driver 'bochs' does not support image creation
> ./qemu-img create -f cloop x 1m
qemu-img: x: Format driver 'cloop'
From: Philippe Mathieu-Daudé
ASAN reported:
hw/block/pflash_cfi02.c:245:33: runtime error: index 82 out of bounds for
type 'uint8_t [82]'
Since the 'cfi_len' member is not used, remove it to keep the code safer.
Cc: qemu-sta...@nongnu.org
Reported-by: AddressSanitizer
Signed-off-by: Phili
Streaming and the commit block job only want to apply throttling when
they actually copied data instead of skipping it, so they made the
calculation of delay_ns conditional. However, delay_ns isn't reset when
skipping some sectors, so instead of not waiting, the old delay is
applied again.
Properl
qemu-iotests doesn't support dmg, and the dmg block driver doesn't
support image creation. Two test cases declare dmg as supported, but
that's obviously wrong for both reasons. Remove the declaration.
Signed-off-by: Kevin Wolf
Reviewed-by: Eric Blake
---
tests/qemu-iotests/183 | 2 +-
tests/qem
From: Stefan Hajnoczi
Commit 4486e89c219c0d1b9bd8dfa0b1dd5b0d51ff2268 ("vl: introduce
vm_shutdown()") added a bdrv_drain_all() call. As a side-effect of the
drain operation the block job iterates one more time than before. The
185 output no longer matches and the test is failing now.
It may be
The following changes since commit df6378eb0e6cfd58a22a1c3ff8fa4a9039f1eaa8:
Merge remote-tracking branch 'remotes/kraxel/tags/ui-20180410-pull-request'
into staging (2018-04-10 14:04:27 +0100)
are available in the git repository at:
git://repo.or.cz/qemu/kevin.git tags/for-ups
From: Vladimir Sementsov-Ogievskiy
Signed-off-by: Vladimir Sementsov-Ogievskiy
Signed-off-by: Kevin Wolf
---
tests/qemu-iotests/iotests.py | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/tests/qemu-iotests/iotests.py b/tests/qemu-iotests/iotests.py
index b5d7945af8..16
On Tue, Apr 10, 2018 at 09:52:40AM -0500, Eric Blake wrote:
> Didn't Rich already try to do that?
>
> +def emulate_zero(h, count, offset):
> +# qemu-img convert starts by trying to zero/trim the whole device.
> +# Since we've just created a new disk it's safe to ignore these
> +# reque
On Tue, Apr 10, 2018 at 03:25:47PM +, Nir Soffer wrote:
> On Tue, Apr 10, 2018 at 5:50 PM Richard W.M. Jones
> wrote:
>
> > On Tue, Apr 10, 2018 at 02:07:33PM +, Nir Soffer wrote:
> > > This makes sense if the device is backed by a block device on oVirt side,
> > > and the NBD support eff
Compressed clusters are not supposed to have the COPIED bit set, but
this is not made explicit in the specs, so let's document it.
Signed-off-by: Alberto Garcia
---
docs/interop/qcow2.txt | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/docs/interop/qcow2.txt b/docs/in
Compressed clusters are not supposed to have the COPIED bit set.
"qemu-img check" detects that and prints an error message reporting
the number of the affected host cluster. This doesn't make much sense
because compressed clusters are not aligned to host clusters, so it
would be better to report th
Hi,
while reviewing one previous patch about data corruption and
compressed clusters we discussed that the documentation doesn't
clarify that L2 entries for compressed clusters are not supposed to
have the OFLAG_COPIED bit set.
Here's a patch to update the documentation and another one to fix the
On 04/10/2018 11:05 AM, Alberto Garcia wrote:
> Compressed clusters are not supposed to have the COPIED bit set.
> "qemu-img check" detects that and prints an error message reporting
> the number of the affected host cluster. This doesn't make much sense
> because compressed clusters are not aligne
On 04/10/2018 11:05 AM, Alberto Garcia wrote:
> Compressed clusters are not supposed to have the COPIED bit set, but
> this is not made explicit in the specs, so let's document it.
>
> Signed-off-by: Alberto Garcia
> ---
> docs/interop/qcow2.txt | 8
> 1 file changed, 4 insertions(+), 4
On Tue 10 Apr 2018 06:18:28 PM CEST, Eric Blake wrote:
> On 04/10/2018 11:05 AM, Alberto Garcia wrote:
>> Compressed clusters are not supposed to have the COPIED bit set.
>> "qemu-img check" detects that and prints an error message reporting
>> the number of the affected host cluster. This doesn't
On Tue, Apr 10, 2018 at 10:58:09AM +0200, Kevin Wolf wrote:
> Streaming and the commit block job only want to apply throttling when
> they actually copied data instead of skipping it, so they made the
> calculation of delay_ns conditional. However, delay_ns isn't reset when
> skipping some sectors,
34 matches
Mail list logo
