Hi,
This series seems to have some coding style problems. See output below for
more information:
Type: series
Message-id: 20181103015821.30074-1-lbl...@janustech.com
Subject: [Qemu-devel] [PATCH] include: Add a comment to explain the origin of
sizes' lookup table
=== TEST SCRIPT BEGIN ===
Hi,
This series seems to have some coding style problems. See output below for
more information:
Type: series
Message-id: 20181102152257.20637-1-mark.cave-ayl...@ilande.co.uk
Subject: [Qemu-devel] [PATCH v6 00/10] hw/m68k: add Apple Machintosh Quadra 800
machine
=== TEST SCRIPT BEGIN ===
On 04/11/2018 06:53, no-re...@patchew.org wrote:
> Hi,
>
> This series seems to have some coding style problems. See output below for
> more information:
>
> Type: series
> Message-id: 20181102152257.20637-1-mark.cave-ayl...@ilande.co.uk
> Subject: [Qemu-devel] [PATCH v6 00/10] hw/m68k: add
Hi,
This series failed docker-quick@centos7 build test. Please find the testing
commands and
their output below. If you have Docker installed, you can probably reproduce it
locally.
Type: series
Message-id: 20181103014831.29889-1-lbl...@janustech.com
Subject: [Qemu-devel] [PATCH] vdi: Use a
> This changes the data type, so a fix is needed for a format string in
> line 434.
Yes, I saw, thanks! Will do.
>
> Regards
> Stefan
>
Please see the commit message for the rationale.
Difference from v1:
* Tabs removed from the code indentation of the sample code in the
comment, in order to pass checkpatch.
Leonid Bloch (1):
include: Add a comment to explain the origin of sizes' lookup table
include/qemu/units.h | 18
The lookup table for power-of-two sizes was added in commit 540b8492618eb
for the purpose of having convenient shortcuts for these sizes in cases
when the literal number has to be present at compile time, and
expressions as '(1 * KiB)' can not be used. One such case is the
stringification of
Please see the commit message for the rationale.
Difference from v1:
* Format string is fixed.
Leonid Bloch (1):
vdi: Use a literal number of bytes for DEFAULT_CLUSTER_SIZE
block/vdi.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
--
2.17.1
If an expression is used to define DEFAULT_CLUSTER_SIZE, when compiled,
it will be embedded as a literal expression in the binary (as the
default value) because it is stringified to mark the size of the default
value. Now this is fixed by using a defined number to define this value.
On 04.11.18 19:09, Leonid Bloch wrote:
> If an expression is used to define DEFAULT_CLUSTER_SIZE, when compiled,
> it will be embedded as a literal expression in the binary (as the
> default value) because it is stringified to mark the size of the default
> value. Now this is fixed by using a
Kevin Wolf 于2018年11月2日周五 下午11:42写道：
> Am 02.11.2018 um 16:22 hat Li Qiang geschrieben:
> > Hello Kevin,
> >
> > Kevin Wolf 于2018年11月2日周五 下午6:54写道：
> >
> > > Am 02.11.2018 um 02:22 hat Li Qiang geschrieben:
> > > > Currently, the nvme_cmb_ops mr doesn't check the addr and size.
> > > > This can
Keith Busch 于2018年11月2日周五 下午11:42写道：
> On Thu, Nov 01, 2018 at 06:22:43PM -0700, Li Qiang wrote:
> > Currently, the nvme_cmb_ops mr doesn't check the addr and size.
> > This can lead an oob access issue. This is triggerable in the guest.
> > Add check to avoid this issue.
> >
> > Fixes
Function block_latency_histogram_set may return error, but qapi ignore this.
This can be reproduced easily by qmp command:
virsh qemu-monitor-command INSTANCE '{"execute":"x-block-latency-histogram-set",
"arguments":{"device":"drive-virtio-disk1","boundaries":[10,200,40]}}'
In fact this command
On 02/11/2018 14:33, Peter Maydell wrote:
> On 9 October 2018 at 12:16, Paolo Bonzini wrote:
>> On 08/10/2018 18:40, Kevin Wolf wrote:
I'm pretty confident this analysis of the problem is correct:
unfortunately I have no idea what the right way to fix it is...
>>> Yes, I agree with
On 19.10.18 13:34, Markus Armbruster wrote:
> From: Jeff Cody
>
> This adds configure options to control the following block drivers:
>
> * Bochs
> * Cloop
> * Dmg
> * Qcow (V1)
> * Vdi
> * Vvfat
> * qed
> * parallels
> * sheepdog
>
> Each of these defaults to being enabled.
>
>
On 19.10.18 22:39, Liam Merwick wrote:
> The dev_id returned by the call to blk_get_attached_dev_id() in
> blk_root_get_parent_desc() can be NULL (an internal call to
> object_get_canonical_path may have returned NULL).
>
> Instead of just checking this case before before dereferencing,
> adjust
On 19.10.18 22:39, Liam Merwick wrote:
> Although the function block_job_get() can return NULL, it would be a
> serious bug if it did so (because the job yields before executing anything
> (if it started successfully); but otherwise, commit_active_start() would
> have returned an error). However,
On 19.10.18 22:39, Liam Merwick wrote:
> A NULL 'list' passed into function dump_qlist() isn't correctly
> validated and can be passed to qlist_first() where it is dereferenced.
>
> Given that dump_qlist() is static, and callers already do the right
> thing, just add an assert to catch future
On 19.10.18 22:39, Liam Merwick wrote:
> The calls to find_mapping_for_cluster() may return NULL but it
> isn't always checked for before dereferencing the value returned.
> Additionally, add some asserts to cover cases where NULL can't
> be returned but which might not be obvious at first glance.
Ping. I don't quite want the help output to change in 3.1 only to
change it to something else in 3.2.
(And at some point into freeze we have to consider just merging one of
the many simple 082 reference output "fixes", which I really don't want,
because I still consider the test "broken for a
On 03.11.18 02:48, Leonid Bloch wrote:
> If an expression is used to define DEFAULT_CLUSTER_SIZE, when compiled,
> it will be embedded as a literal expression in the binary (as the
> default value) because it is stringified to mark the size of the default
> value. Now this is fixed by using a
21 matches
Mail list logo
