Re: [Qemu-block] [PATCH v6 25/42] mirror: Deal with filters

2019-08-31 Thread Vladimir Sementsov-Ogievskiy
09.08.2019 19:13, Max Reitz wrote: > This includes some permission limiting (for example, we only need to > take the RESIZE permission for active commits where the base is smaller > than the top). > > Signed-off-by: Max Reitz > --- > block/mirror.c | 117

Re: [Qemu-block] [PATCH v6 27/42] commit: Deal with filters

2019-08-31 Thread Vladimir Sementsov-Ogievskiy
09.08.2019 19:13, Max Reitz wrote: > This includes some permission limiting (for example, we only need to > take the RESIZE permission if the base is smaller than the top). > > Signed-off-by: Max Reitz > --- > block/block-backend.c | 16 +--- > block/commit.c| 96

Re: [Qemu-block] [PATCH v6 39/42] iotests: Add filter commit test cases

2019-08-31 Thread Vladimir Sementsov-Ogievskiy
09.08.2019 19:14, Max Reitz wrote: > This patch adds some tests on how commit copes with filter nodes. > > Signed-off-by: Max Reitz > --- > tests/qemu-iotests/040 | 177 + > tests/qemu-iotests/040.out | 4 +- > 2 files changed, 179 insertions(+), 2

Re: [Qemu-block] [PATCH v6 40/42] iotests: Add filter mirror test cases

2019-08-31 Thread Vladimir Sementsov-Ogievskiy
09.08.2019 19:14, Max Reitz wrote: > This patch adds some test cases how mirroring relates to filters. One > of them tests what happens when you mirror off a filtered COW node, two > others use the mirror filter node as basically our only example of an > implicitly created filter node so far

Re: [Qemu-block] [PATCH v6 39/42] iotests: Add filter commit test cases

2019-08-31 Thread Vladimir Sementsov-Ogievskiy
09.08.2019 19:14, Max Reitz wrote: > This patch adds some tests on how commit copes with filter nodes. > > Signed-off-by: Max Reitz > --- > tests/qemu-iotests/040 | 177 + > tests/qemu-iotests/040.out | 4 +- > 2 files changed, 179 insertions(+), 2

Re: [Qemu-block] [Qemu-devel] [PATCH 2/5] nbd: Prepare for NBD_CMD_FLAG_FAST_ZERO

2019-08-31 Thread Vladimir Sementsov-Ogievskiy
31.08.2019 2:37, Eric Blake wrote: > On 8/30/19 1:07 PM, Vladimir Sementsov-Ogievskiy wrote: >> 23.08.2019 17:37, Eric Blake wrote: >>> Commit fe0480d6 and friends added BDRV_REQ_NO_FALLBACK as a way to >>> avoid wasting time on a preliminary write-zero request that will later >>> be rewritten by

Re: [Qemu-block] [Qemu-devel] [PATCH 2/5] nbd: Prepare for NBD_CMD_FLAG_FAST_ZERO

2019-08-31 Thread Vladimir Sementsov-Ogievskiy
23.08.2019 17:37, Eric Blake wrote: > Commit fe0480d6 and friends added BDRV_REQ_NO_FALLBACK as a way to > avoid wasting time on a preliminary write-zero request that will later > be rewritten by actual data, if it is known that the write-zero > request will use a slow fallback; but in doing so,