Re: [Qemu-block] [PATCH v6 09/42] block: Include filters when freezing backing chain

On 05.09.19 15:05, Kevin Wolf wrote: > Am 09.08.2019 um 18:13 hat Max Reitz geschrieben: >> In order to make filters work in backing chains, the associated >> functions must be able to deal with them and freeze all filter links, be >> they COW or R/W filter links. >> >> In the process, rename

Re: [Qemu-block] [PATCH v6 25/42] mirror: Deal with filters

On 03.09.19 10:32, Vladimir Sementsov-Ogievskiy wrote: > 02.09.2019 17:35, Max Reitz wrote: >> On 31.08.19 11:57, Vladimir Sementsov-Ogievskiy wrote: >>> 09.08.2019 19:13, Max Reitz wrote: This includes some permission limiting (for example, we only need to take the RESIZE permission for

Re: [Qemu-block] [PATCH] nbd/client: Add hint when TLS is missing

On Sat, Sep 07, 2019 at 12:20:55PM -0500, Eric Blake wrote: > I received an off-list report of failure to connect to an NBD server > expecting an x509 certificate, when the client was attempting something > similar to this command line: > > $ ./x86_64-softmmu/qemu-system-x86_64 -name 'blah'

Re: [Qemu-block] [Qemu-devel] [PATCH 2/2] block/nvme: add support for discard

On 05.09.19 19:27, John Snow wrote: [...] > You also probably require review (or at least an ACK) from Keith Busch > who maintains this file. Keith actually maintains the NVMe guest device; technically, Fam is the NVMe block driver maintainer. Max signature.asc Description: OpenPGP digital

Re: [Qemu-block] [PATCH v6 04/42] block: Add child access functions

On 04.09.19 18:16, Kevin Wolf wrote: > Am 09.08.2019 um 18:13 hat Max Reitz geschrieben: >> There are BDS children that the general block layer code can access, >> namely bs->file and bs->backing. Since the introduction of filters and >> external data files, their meaning is not quite clear.

Re: [Qemu-block] [PATCH v6 16/42] block: Flush all children in generic code

On 05.09.19 18:24, Kevin Wolf wrote: > Am 12.08.2019 um 14:58 hat Max Reitz geschrieben: >> On 10.08.19 17:36, Vladimir Sementsov-Ogievskiy wrote: >>> 09.08.2019 19:13, Max Reitz wrote: If the driver does not support .bdrv_co_flush() so bdrv_co_flush() itself has to flush the children of

Re: [Qemu-block] [PATCH v6 04/42] block: Add child access functions

Am 09.09.2019 um 09:56 hat Max Reitz geschrieben: > On 04.09.19 18:16, Kevin Wolf wrote: > > Am 09.08.2019 um 18:13 hat Max Reitz geschrieben: > >> There are BDS children that the general block layer code can access, > >> namely bs->file and bs->backing. Since the introduction of filters and > >>

Re: [Qemu-block] [PATCH v7 1/4] block: Add zoned device model property

On Sat, Sep 07, 2019 at 06:38:38PM -0400, Dmitry Fomichev wrote: > This commit adds Zoned Device Model (as defined in T10 ZBC and > T13 ZAC standards) as a block driver property, along with some > useful access functions. > > A new backend driver permission, BLK_PERM_SUPPORT_HM_ZONED, is also >

Re: [Qemu-block] [PATCH v6 11/42] block: Add bdrv_supports_compressed_writes()

On 05.09.19 15:11, Kevin Wolf wrote: > Am 09.08.2019 um 18:13 hat Max Reitz geschrieben: >> Filters cannot compress data themselves but they have to implement >> .bdrv_co_pwritev_compressed() still (or they cannot forward compressed >> writes). Therefore, checking whether >>

Re: [Qemu-block] [PATCH v6 14/42] block: Use CAFs when working with backing chains

On 05.09.19 16:05, Kevin Wolf wrote: > Am 09.08.2019 um 18:13 hat Max Reitz geschrieben: >> Use child access functions when iterating through backing chains so >> filters do not break the chain. >> >> Signed-off-by: Max Reitz >> --- >> block.c | 40 >> 1

Re: [Qemu-block] [PATCH v6 09/42] block: Include filters when freezing backing chain

Am 09.09.2019 um 10:02 hat Max Reitz geschrieben: > On 05.09.19 15:05, Kevin Wolf wrote: > > Am 09.08.2019 um 18:13 hat Max Reitz geschrieben: > >> In order to make filters work in backing chains, the associated > >> functions must be able to deal with them and freeze all filter links, be > >>

Re: [Qemu-block] [PATCH v6 14/42] block: Use CAFs when working with backing chains

Am 09.09.2019 um 10:25 hat Max Reitz geschrieben: > On 05.09.19 16:05, Kevin Wolf wrote: > > Am 09.08.2019 um 18:13 hat Max Reitz geschrieben: > >> Use child access functions when iterating through backing chains so > >> filters do not break the chain. > >> > >> Signed-off-by: Max Reitz > >> ---

Re: [Qemu-block] [PATCH v2 1/3] iotests: add script_initialize

On 29.07.19 23:35, John Snow wrote: > Like script_main, but doesn't require a single point of entry. > Replace all existing initialization sections with this drop-in replacement. > > This brings debug support to all existing script-style iotests. > > Note: supported_oses=['linux'] was omitted,

Re: [Qemu-block] qcow2 lock

Am 09.09.2019 um 12:13 hat Vladimir Sementsov-Ogievskiy geschrieben: > Hi! > > I have a (may be stupid) question: what is BDRVQcow2State.lock for and when > should it be locked? > > > I faced SIGSEGV here: > > #0 qcow2_process_discards (bs=bs@entry=0x564b93bc8000, ret=ret@entry=0) at >

Re: [Qemu-block] [PATCH v10 02/14] block/backup: split shareable copying part from backup_do_cow

On 30.08.19 18:12, Vladimir Sementsov-Ogievskiy wrote: > Split copying logic which will be shared with backup-top filter. > > Signed-off-by: Vladimir Sementsov-Ogievskiy > --- > block/backup.c | 47 --- > 1 file changed, 32 insertions(+), 15

Re: [Qemu-block] [Qemu-devel] [PATCH 2/3] block/qcow2: fix the corruption when rebasing luks encrypted files

Am 06.09.2019 um 21:17 hat Eric Blake geschrieben: > > -assert((offset_in_cluster & ~BDRV_SECTOR_MASK) == 0); > > +assert((guest_offset & ~BDRV_SECTOR_MASK) == 0); > > +assert((host_offset & ~BDRV_SECTOR_MASK) == 0); > > assert((bytes & ~BDRV_SECTOR_MASK) == 0); >

Re: [Qemu-block] [PATCH v10 03/14] block/backup: improve comment about image fleecing

On 30.08.19 18:12, Vladimir Sementsov-Ogievskiy wrote: > Signed-off-by: Vladimir Sementsov-Ogievskiy > --- > block/backup.c | 15 --- > 1 file changed, 12 insertions(+), 3 deletions(-) Reviewed-by: Max Reitz signature.asc Description: OpenPGP digital signature

Re: [Qemu-block] [PATCH v10 08/14] iotests: prepare 124 and 257 bitmap querying for backup-top filter

On 30.08.19 18:12, Vladimir Sementsov-Ogievskiy wrote: > After backup-top filter appearing it's not possible to see dirty > bitmaps in top node, so use node-name instead. > > Signed-off-by: Vladimir Sementsov-Ogievskiy > --- > tests/qemu-iotests/124| 83 >

Re: [Qemu-block] [PATCH v6 16/42] block: Flush all children in generic code

Am 09.09.2019 um 10:31 hat Max Reitz geschrieben: > On 05.09.19 18:24, Kevin Wolf wrote: > > Am 12.08.2019 um 14:58 hat Max Reitz geschrieben: > >> On 10.08.19 17:36, Vladimir Sementsov-Ogievskiy wrote: > >>> 09.08.2019 19:13, Max Reitz wrote: > If the driver does not support .bdrv_co_flush()

[Qemu-block] qcow2 lock

Hi! I have a (may be stupid) question: what is BDRVQcow2State.lock for and when should it be locked? I faced SIGSEGV here: #0 qcow2_process_discards (bs=bs@entry=0x564b93bc8000, ret=ret@entry=0) at block/qcow2-refcount.c:737 #1 0x564b90e9f15f in qcow2_cluster_discard

Re: [Qemu-block] [PATCH v2 3/3] qemu-iotests: Add test for bz #1745922

On Fri, Sep 06, 2019 at 10:57:50PM +0300, Maxim Levitsky wrote: > Signed-off-by: Maxim Levitsky > --- > tests/qemu-iotests/263 | 75 ++ > tests/qemu-iotests/263.out | 19 ++ > tests/qemu-iotests/group | 1 + > 3 files changed, 95 insertions(+) >

Re: [Qemu-block] [PATCH v10 05/14] block/backup: fix block-comment style

On 30.08.19 18:12, Vladimir Sementsov-Ogievskiy wrote: > We need to fix comment style around block-copy functions before further > moving them to separate file to satisfy checkpatch. But do more: fix > all comments style. Also, seems like doubled first asterisk is not > forbidden, but drop it too

Re: [Qemu-block] [PATCH v2 3/3] iotests: use python logging for iotests.log()

On 29.07.19 23:35, John Snow wrote: > We can turn logging on/off globally instead of per-function. > > Remove use_log from run_job, and use python logging to turn on > diffable output when we run through a script entry point. > > iotest 245 changes output order due to buffering reasons. > >

Re: [Qemu-block] qcow2 lock

Am 09.09.2019 um 14:16 hat Vladimir Sementsov-Ogievskiy geschrieben: > 09.09.2019 13:47, Kevin Wolf wrote: > > Am 09.09.2019 um 12:13 hat Vladimir Sementsov-Ogievskiy geschrieben: > >> Hi! > >> > >> I have a (may be stupid) question: what is BDRVQcow2State.lock for and > >> when should it be

Re: [Qemu-block] [PATCH v10 04/14] block/backup: introduce BlockCopyState

On 30.08.19 18:12, Vladimir Sementsov-Ogievskiy wrote: > Split copying code part from backup to "block-copy", including separate > state structure and function renaming. This is needed to share it with > backup-top filter driver in further commits. > > Notes: > > 1. As BlockCopyState keeps own

Re: [Qemu-block] [PATCH v2 2/3] iotests: add protocol support to initialization info

On 29.07.19 23:35, John Snow wrote: > This will add supported_protocols and unsupported_protocols to all of > iotests.main, iotests.script_main, and iotests.script_initialize. > > Signed-off-by: John Snow > --- > tests/qemu-iotests/207| 4 ++-- > tests/qemu-iotests/210| 4 ++-- >

Re: [Qemu-block] qcow2 lock

09.09.2019 13:47, Kevin Wolf wrote: > Am 09.09.2019 um 12:13 hat Vladimir Sementsov-Ogievskiy geschrieben: >> Hi! >> >> I have a (may be stupid) question: what is BDRVQcow2State.lock for and when >> should it be locked? >> >> >> I faced SIGSEGV here: >> >> #0 qcow2_process_discards

Re: [Qemu-block] qcow2 lock

09.09.2019 13:47, Kevin Wolf wrote: > Am 09.09.2019 um 12:13 hat Vladimir Sementsov-Ogievskiy geschrieben: >> Hi! >> >> I have a (may be stupid) question: what is BDRVQcow2State.lock for and when >> should it be locked? >> >> >> I faced SIGSEGV here: >> >> #0 qcow2_process_discards

Re: [Qemu-block] [Qemu-devel] [PATCH v9 8/9] hw/m68k: add a dummy SWIM floppy controller

Le 09/09/2019 à 18:32, Aleksandar Markovic a écrit : > > 09.09.2019. 18.03, "Laurent Vivier" > је написао/ла: >> >> Co-developed-by: Mark Cave-Ayland > >> Signed-off-by: Mark Cave-Ayland > >>

Re: [Qemu-block] [Qemu-devel] [PATCH v9 8/9] hw/m68k: add a dummy SWIM floppy controller

09.09.2019. 18.32, "Aleksandar Markovic" је написао/ла: > > > 09.09.2019. 18.03, "Laurent Vivier" је написао/ла: > > > > Co-developed-by: Mark Cave-Ayland > > Signed-off-by: Mark Cave-Ayland > > Signed-off-by: Laurent Vivier > > Reviewed-by: Hervé Poussineau > > --- > > Laurent, hi! > > I am

Re: [Qemu-block] [PATCH v9 13/13] block/backup: use backup-top instead of write notifiers

On 03.09.19 10:06, Vladimir Sementsov-Ogievskiy wrote: > 02.09.2019 19:34, Max Reitz wrote: [...] >> I’m not saying that we need to abandon having BBs right now, but I think >> there are a couple of cases which show why I say it’s uglier than using >> BdrvChildren instead. >> > > OK. I'd prefer

Re: [Qemu-block] [PATCH] nbd/client: Add hint when TLS is missing

On 9/9/19 4:13 AM, Daniel P. Berrangé wrote: > On Sat, Sep 07, 2019 at 12:20:55PM -0500, Eric Blake wrote: >> I received an off-list report of failure to connect to an NBD server >> expecting an x509 certificate, when the client was attempting something >> similar to this command line: >> >> +++

Re: [Qemu-block] qcow2 lock

09.09.2019 15:57, Kevin Wolf wrote: > Am 09.09.2019 um 14:16 hat Vladimir Sementsov-Ogievskiy geschrieben: >> 09.09.2019 13:47, Kevin Wolf wrote: >>> Am 09.09.2019 um 12:13 hat Vladimir Sementsov-Ogievskiy geschrieben: Hi! I have a (may be stupid) question: what is

Re: [Qemu-block] [PATCH v2 2/3] iotests: add protocol support to initialization info

On 9/9/19 6:09 AM, Max Reitz wrote: > On 29.07.19 23:35, John Snow wrote: >> This will add supported_protocols and unsupported_protocols to all of >> iotests.main, iotests.script_main, and iotests.script_initialize. >> >> Signed-off-by: John Snow >> --- >> tests/qemu-iotests/207| 4

Re: [Qemu-block] [Qemu-devel] [PATCH v9 8/9] hw/m68k: add a dummy SWIM floppy controller

Le 09/09/2019 à 18:18, Dr. David Alan Gilbert a écrit : > * Peter Maydell (peter.mayd...@linaro.org) wrote: >> On Mon, 9 Sep 2019 at 17:05, Laurent Vivier wrote: >>> >>> Co-developed-by: Mark Cave-Ayland >>> Signed-off-by: Mark Cave-Ayland >>> Signed-off-by: Laurent Vivier >>> Reviewed-by:

Re: [Qemu-block] [Qemu-devel] [PATCH v9 0/9] hw/m68k: add Apple Machintosh Quadra 800 machine

Patchew URL: https://patchew.org/QEMU/20190909155813.27760-1-laur...@vivier.eu/ Hi, This series seems to have some coding style problems. See output below for more information: Subject: [Qemu-devel] [PATCH v9 0/9] hw/m68k: add Apple Machintosh Quadra 800 machine Message-id:

Re: [Qemu-block] [PULL v2 01/16] qemu-io: add pattern file for write command

On Tue, 3 Sep 2019 at 14:35, Max Reitz wrote: > > From: Denis Plotnikov > > The patch allows to provide a pattern file for write > command. There was no similar ability before. > > Signed-off-by: Denis Plotnikov > Message-id: 20190820164616.4072-1-dplotni...@virtuozzo.com > Reviewed-by: Eric

Re: [Qemu-block] [Qemu-devel] [PATCH v9 0/9] hw/m68k: add Apple Machintosh Quadra 800 machine

Patchew URL: https://patchew.org/QEMU/20190909155813.27760-1-laur...@vivier.eu/ Hi, This series seems to have some coding style problems. See output below for more information: Subject: [Qemu-devel] [PATCH v9 0/9] hw/m68k: add Apple Machintosh Quadra 800 machine Message-id:

Re: [Qemu-block] [PATCH v2 1/3] iotests: add script_initialize

On 9/9/19 6:06 AM, Max Reitz wrote: > On 29.07.19 23:35, John Snow wrote: >> Like script_main, but doesn't require a single point of entry. >> Replace all existing initialization sections with this drop-in replacement. >> >> This brings debug support to all existing script-style iotests. >> >>

Re: [Qemu-block] [Qemu-devel] [PATCH v9 8/9] hw/m68k: add a dummy SWIM floppy controller

On Mon, 9 Sep 2019 at 17:18, Dr. David Alan Gilbert wrote: > > * Peter Maydell (peter.mayd...@linaro.org) wrote: > > Missing reset and VMState for migration. These should be > > baseline requirements for adding new device models to the > > tree, because in an ideal world every device would

Re: [Qemu-block] [Qemu-devel] [PATCH v9 8/9] hw/m68k: add a dummy SWIM floppy controller

09.09.2019. 18.03, "Laurent Vivier" је написао/ла: > > Co-developed-by: Mark Cave-Ayland > Signed-off-by: Mark Cave-Ayland > Signed-off-by: Laurent Vivier > Reviewed-by: Hervé Poussineau > --- Laurent, hi! I am not sure how "Co-developed-by:" fits in our workflow. There was some recent talk

Re: [Qemu-block] [Qemu-devel] [PATCH] tests/Makefile: Do not print the name of the check-block.sh shell script

On 9/6/19 7:35 AM, Thomas Huth wrote: > The check script is already printing out which iotest is currently > running, so printing out the name of the check-block.sh shell script > looks superfluous here. > > Signed-off-by: Thomas Huth Makes sense. Acked-by: John Snow > --- >

Re: [Qemu-block] [Qemu-devel] [PATCH] tests/qemu-iotests/check: Replace "tests" with "iotests" in final status text

On 9/6/19 7:39 AM, Thomas Huth wrote: > When running "make check -j8" or something similar, the iotests are > running in parallel with the other tests. So when they are printing > out "Passed all xx tests" or a similar status message at the end, > it might not be quite clear that this message

Re: [Qemu-block] [Qemu-devel] [PATCH 2/2] block/nvme: add support for discard

On 9/9/19 5:25 AM, Max Reitz wrote: > On 05.09.19 19:27, John Snow wrote: > > [...] > >> You also probably require review (or at least an ACK) from Keith Busch >> who maintains this file. > > Keith actually maintains the NVMe guest device; technically, Fam is the > NVMe block driver

Re: [Qemu-block] [Qemu-devel] IOTEST 162

On 9/6/19 1:25 PM, Maxim Levitsky wrote: > Hi! > > I just had a very fun rabbit hole dive, and I want to share it with you. > > I notice for some time that iotest 162 fails with that: > > -qemu-img: Could not open 'json:{"driver": "nbd", "host": 42}': Failed to > connect socket: Invalid

Re: [Qemu-block] [Qemu-devel] [PATCH] ahci: enable pci bus master MemoryRegion before loading ahci engines

On 9/9/19 1:18 PM, andychiu via Qemu-devel wrote: > If Windows 10 guests have enabled 'turn off hard disk after idle' > option in power settings, and the guest has a SATA disk plugged in, > the SATA disk will be turned off after a specified idle time. > If the guest is live migrated or

Re: [Qemu-block] [Qemu-devel] [PATCH v9 8/9] hw/m68k: add a dummy SWIM floppy controller

Le 09/09/2019 à 18:11, Peter Maydell a écrit : > On Mon, 9 Sep 2019 at 17:05, Laurent Vivier wrote: >> >> Co-developed-by: Mark Cave-Ayland >> Signed-off-by: Mark Cave-Ayland >> Signed-off-by: Laurent Vivier >> Reviewed-by: Hervé Poussineau > >> +static void

Re: [Qemu-block] [Qemu-devel] [PATCH v9 0/9] hw/m68k: add Apple Machintosh Quadra 800 machine

Patchew URL: https://patchew.org/QEMU/20190909155813.27760-1-laur...@vivier.eu/ Hi, This series seems to have some coding style problems. See output below for more information: Subject: [Qemu-devel] [PATCH v9 0/9] hw/m68k: add Apple Machintosh Quadra 800 machine Message-id:

Re: [Qemu-block] [PULL 01/12] util/iov: introduce qemu_iovec_init_extended

On Tue, 27 Aug 2019 at 21:16, Stefan Hajnoczi wrote: > > From: Vladimir Sementsov-Ogievskiy > > Introduce new initialization API, to create requests with padding. Will > be used in the following patch. New API uses qemu_iovec_init_buf if > resulting io vector has only one element, to avoid extra

Re: [Qemu-block] [Qemu-devel] [PATCH] ahci: enable pci bus master MemoryRegion before loading ahci engines

Patchew URL: https://patchew.org/QEMU/1568049517-10261-1-git-send-email-andyc...@synology.com/ Hi, This series seems to have some coding style problems. See output below for more information: Subject: [Qemu-devel] [PATCH] ahci: enable pci bus master MemoryRegion before loading ahci engines

Re: [Qemu-block] [PATCH v10 08/14] iotests: prepare 124 and 257 bitmap querying for backup-top filter

09.09.2019 16:25, Max Reitz wrote: > On 30.08.19 18:12, Vladimir Sementsov-Ogievskiy wrote: >> After backup-top filter appearing it's not possible to see dirty >> bitmaps in top node, so use node-name instead. >> >> Signed-off-by: Vladimir Sementsov-Ogievskiy >> --- >> tests/qemu-iotests/124

[Qemu-block] [PATCH v9 5/9] hw/m68k: add macfb video card

Co-developed-by: Mark Cave-Ayland Signed-off-by: Mark Cave-Ayland Signed-off-by: Laurent Vivier Reviewed-by: Hervé Poussineau Reviewed-by: Thomas Huth --- arch_init.c| 4 + hw/display/Kconfig | 3 + hw/display/Makefile.objs | 1 + hw/display/macfb.c |

[Qemu-block] [PATCH v9 8/9] hw/m68k: add a dummy SWIM floppy controller

Co-developed-by: Mark Cave-Ayland Signed-off-by: Mark Cave-Ayland Signed-off-by: Laurent Vivier Reviewed-by: Hervé Poussineau --- hw/block/Kconfig| 3 + hw/block/Makefile.objs | 1 + hw/block/swim.c | 421 include/hw/block/swim.h |

[Qemu-block] [PATCH v9 6/9] hw/m68k: add Nubus support

Co-developed-by: Mark Cave-Ayland Signed-off-by: Mark Cave-Ayland Signed-off-by: Laurent Vivier Reviewed-by: Thomas Huth --- hw/Kconfig | 1 + hw/Makefile.objs| 1 + hw/nubus/Kconfig| 2 + hw/nubus/Makefile.objs

Re: [Qemu-block] [PATCH v10 04/14] block/backup: introduce BlockCopyState

On 09.09.19 16:12, Vladimir Sementsov-Ogievskiy wrote: > 09.09.2019 15:59, Max Reitz wrote: >> On 30.08.19 18:12, Vladimir Sementsov-Ogievskiy wrote: >>> Split copying code part from backup to "block-copy", including separate >>> state structure and function renaming. This is needed to share it

[Qemu-block] [PATCH v9 3/9] hw/m68k: add via support

Co-developed-by: Mark Cave-Ayland Signed-off-by: Mark Cave-Ayland Signed-off-by: Laurent Vivier Reviewed-by: Hervé Poussineau --- hw/misc/Kconfig | 4 + hw/misc/Makefile.objs | 1 + hw/misc/mac_via.c | 692 ++

Re: [Qemu-block] [PATCH v6 04/42] block: Add child access functions

On 09.09.19 11:36, Kevin Wolf wrote: > Am 09.09.2019 um 09:56 hat Max Reitz geschrieben: >> On 04.09.19 18:16, Kevin Wolf wrote: >>> Am 09.08.2019 um 18:13 hat Max Reitz geschrieben: There are BDS children that the general block layer code can access, namely bs->file and bs->backing.

Re: [Qemu-block] [PATCH v10 04/14] block/backup: introduce BlockCopyState

09.09.2019 17:24, Max Reitz wrote: > On 09.09.19 16:12, Vladimir Sementsov-Ogievskiy wrote: >> 09.09.2019 15:59, Max Reitz wrote: >>> On 30.08.19 18:12, Vladimir Sementsov-Ogievskiy wrote: Split copying code part from backup to "block-copy", including separate state structure and

Re: [Qemu-block] [PATCH v10 13/14] block: introduce backup-top filter driver

On 30.08.19 18:12, Vladimir Sementsov-Ogievskiy wrote: > Backup-top filter caches write operations and does copy-before-write > operations. > > The driver will be used in backup instead of write-notifiers. > > Signed-off-by: Vladimir Sementsov-Ogievskiy > --- > block/backup-top.h | 37

Re: [Qemu-block] [PATCH v10 14/14] block/backup: use backup-top instead of write notifiers

On 30.08.19 18:12, Vladimir Sementsov-Ogievskiy wrote: > Drop write notifiers and use filter node instead. > > = Changes = > > 1. Add filter-node-name argument for backup qmp api. We have to do it > in this commit, as 257 needs to be fixed. > > 2. There are no more write notifiers here, so

Re: [Qemu-block] [PATCH v10 04/14] block/backup: introduce BlockCopyState

09.09.2019 15:59, Max Reitz wrote: > On 30.08.19 18:12, Vladimir Sementsov-Ogievskiy wrote: >> Split copying code part from backup to "block-copy", including separate >> state structure and function renaming. This is needed to share it with >> backup-top filter driver in further commits. >> >>

[Qemu-block] [PATCH v9 4/9] hw/m68k: implement ADB bus support for via

Co-developed-by: Mark Cave-Ayland Signed-off-by: Mark Cave-Ayland Signed-off-by: Laurent Vivier Reviewed-by: Hervé Poussineau Reviewed-by: Thomas Huth --- hw/misc/mac_via.c | 190 ++ include/hw/misc/mac_via.h | 7 ++ 2 files changed, 197

[Qemu-block] [PATCH v9 2/9] dp8393x: manage big endian bus

This is needed by Quadra 800, this card can run on little-endian or big-endian bus. Signed-off-by: Laurent Vivier Tested-by: Hervé Poussineau Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Hervé Poussineau --- hw/net/dp8393x.c | 88 +++- 1 file

[Qemu-block] [PATCH v9 1/9] esp: add pseudo-DMA as used by Macintosh

There is no DMA in Quadra 800, so the CPU reads/writes the data from the PDMA register (offset 0x100, ESP_PDMA in hw/m68k/q800.c) and copies them to/from the memory. There is a nice assembly loop in the kernel to do that, see linux/drivers/scsi/mac_esp.c:MAC_ESP_PDMA_LOOP(). The start of the

[Qemu-block] [PATCH v9 7/9] hw/m68k: add Nubus support for macfb video card

From: Mark Cave-Ayland Co-developed-by: Mark Cave-Ayland Signed-off-by: Mark Cave-Ayland Signed-off-by: Laurent Vivier Reviewed-by: Hervé Poussineau --- hw/display/Kconfig | 1 + hw/display/macfb.c | 56 ++ include/hw/display/macfb.h | 21

[Qemu-block] [PATCH v9 0/9] hw/m68k: add Apple Machintosh Quadra 800 machine

I'm rebasing some of these patches for seven years now, too many years... if you want to test the machine, I'm sorry, it doesn't boot a MacROM, but you can boot a linux kernel from the command line. You can install your own disk using debian-installer, with: ... -M q800 \ -serial

Re: [Qemu-block] [PATCH v6 04/42] block: Add child access functions

Am 09.09.2019 um 16:04 hat Max Reitz geschrieben: > On 09.09.19 11:36, Kevin Wolf wrote: > > Am 09.09.2019 um 09:56 hat Max Reitz geschrieben: > >> On 04.09.19 18:16, Kevin Wolf wrote: > >>> Am 09.08.2019 um 18:13 hat Max Reitz geschrieben: > There are BDS children that the general block

Re: [Qemu-block] [Qemu-devel] [PATCH v9 8/9] hw/m68k: add a dummy SWIM floppy controller

On Mon, 9 Sep 2019 at 17:05, Laurent Vivier wrote: > > Co-developed-by: Mark Cave-Ayland > Signed-off-by: Mark Cave-Ayland > Signed-off-by: Laurent Vivier > Reviewed-by: Hervé Poussineau > +static void sysbus_swim_class_init(ObjectClass *oc, void *data) > +{ > +DeviceClass *dc =

Re: [Qemu-block] [PATCH v6 16/42] block: Flush all children in generic code

On 09.09.19 12:01, Kevin Wolf wrote: > Am 09.09.2019 um 10:31 hat Max Reitz geschrieben: >> On 05.09.19 18:24, Kevin Wolf wrote: >>> Am 12.08.2019 um 14:58 hat Max Reitz geschrieben: On 10.08.19 17:36, Vladimir Sementsov-Ogievskiy wrote: > 09.08.2019 19:13, Max Reitz wrote: >> If the

Re: [Qemu-block] [PATCH v10 08/14] iotests: prepare 124 and 257 bitmap querying for backup-top filter

On 09.09.19 15:49, Vladimir Sementsov-Ogievskiy wrote: > 09.09.2019 16:25, Max Reitz wrote: >> On 30.08.19 18:12, Vladimir Sementsov-Ogievskiy wrote: >>> After backup-top filter appearing it's not possible to see dirty >>> bitmaps in top node, so use node-name instead. >>> >>> Signed-off-by:

Re: [Qemu-block] [PATCH v9 3/9] block: add empty account cookie type

On Fri 06 Sep 2019 06:01:14 PM CEST, Anton Nefedov wrote: > This adds some protection from accounting uninitialized cookie. > That is, block_acct_failed/done without previous block_acct_start; > in that case, cookie probably holds values from previous operation. > > (Note: it might also be

Re: [Qemu-block] [Qemu-devel] [PATCH v9 8/9] hw/m68k: add a dummy SWIM floppy controller

* Peter Maydell (peter.mayd...@linaro.org) wrote: > On Mon, 9 Sep 2019 at 17:05, Laurent Vivier wrote: > > > > Co-developed-by: Mark Cave-Ayland > > Signed-off-by: Mark Cave-Ayland > > Signed-off-by: Laurent Vivier > > Reviewed-by: Hervé Poussineau > > > +static void

Re: [Qemu-block] [PATCH v6 14/42] block: Use CAFs when working with backing chains

On 09.09.19 11:55, Kevin Wolf wrote: > Am 09.09.2019 um 10:25 hat Max Reitz geschrieben: >> On 05.09.19 16:05, Kevin Wolf wrote: >>> Am 09.08.2019 um 18:13 hat Max Reitz geschrieben: Use child access functions when iterating through backing chains so filters do not break the chain.

[Qemu-block] [PATCH v9 9/9] hw/m68k: define Macintosh Quadra 800

If you want to test the machine, it doesn't yet boot a MacROM, but you can boot a linux kernel from the command line. You can install your own disk using debian-installer with: ./qemu-system-m68k \ -M q800 \ -serial none -serial mon:stdio \ -m 1000M -drive

Re: [Qemu-block] [PATCH 4/6] curl: Report only ready sockets

On 8/27/19 12:34 PM, Max Reitz wrote: > Instead of reporting all sockets to cURL, only report the one that has > caused curl_multi_do_locked() to be called. This lets us get rid of the > QLIST_FOREACH_SAFE() list, which was actually wrong: SAFE foreaches are > only safe when the current

Re: [Qemu-block] [PATCH 5/6] curl: Handle success in multi_check_completion

On 8/27/19 12:34 PM, Max Reitz wrote: > Background: As of cURL 7.59.0, it verifies that several functions are > not called from within a callback. Among these functions is > curl_multi_add_handle(). > > curl_read_cb() is a callback from cURL and not a coroutine. Waking up > acb->co will lead

Re: [Qemu-block] [PATCH 2/6] curl: Keep *socket until the end of curl_sock_cb()

On 8/27/19 12:34 PM, Max Reitz wrote: > This does not really change anything, but it makes the code a bit easier > to follow once we use @socket as the opaque pointer for > aio_set_fd_handler(). > > (Also, this change stops us from creating new CURLSocket objects when > the cURL library just

Re: [Qemu-block] [PATCH 3/6] curl: Pass CURLSocket to curl_multi_{do, read}()

On 8/27/19 12:34 PM, Max Reitz wrote: > curl_multi_do_locked() currently marks all sockets as ready. That is > not only inefficient, but in fact unsafe (the loop is). A follow-up > patch will change that, but to do so, curl_multi_do_locked() needs to > know exactly which socket is ready; and

Re: [Qemu-block] [Qemu-devel] [PATCH v9 0/9] hw/m68k: add Apple Machintosh Quadra 800 machine

Patchew URL: https://patchew.org/QEMU/20190909155813.27760-1-laur...@vivier.eu/ Hi, This series seems to have some coding style problems. See output below for more information: Subject: [Qemu-devel] [PATCH v9 0/9] hw/m68k: add Apple Machintosh Quadra 800 machine Message-id:

Re: [Qemu-block] [Qemu-devel] [PATCH v9 0/9] hw/m68k: add Apple Machintosh Quadra 800 machine

Patchew URL: https://patchew.org/QEMU/20190909155813.27760-1-laur...@vivier.eu/ Hi, This series seems to have some coding style problems. See output below for more information: Subject: [Qemu-devel] [PATCH v9 0/9] hw/m68k: add Apple Machintosh Quadra 800 machine Message-id:

Re: [Qemu-block] [PATCH 1/6] curl: Keep pointer to the CURLState in CURLSocket

On 8/27/19 12:34 PM, Max Reitz wrote: > A follow-up patch will make curl_multi_do() and curl_multi_read() take a > CURLSocket instead of the CURLState. They still need the latter, > though, so add a pointer to it to the former. > > Cc: qemu-sta...@nongnu.org > Signed-off-by: Max Reitz > ---

Re: [Qemu-block] [PATCH 6/6] curl: Check curl_multi_add_handle()'s return code

On 8/27/19 12:34 PM, Max Reitz wrote: > If we had done that all along, debugging would have been much simpler. > (Also, I/O errors are better than hangs.) > > Signed-off-by: Max Reitz > --- > block/curl.c | 8 +++- > 1 file changed, 7 insertions(+), 1 deletion(-) > > diff --git

[Qemu-block] [PATCH] ahci: enable pci bus master MemoryRegion before loading ahci engines

If Windows 10 guests have enabled 'turn off hard disk after idle' option in power settings, and the guest has a SATA disk plugged in, the SATA disk will be turned off after a specified idle time. If the guest is live migrated or saved/loaded with its SATA disk turned off, the following error will

Re: [Qemu-block] [PATCH v4 1/5] tests/qemu-iotests: Fix qemu-io related output in 026.out.nocache

On 8/16/19 11:30 AM, Vladimir Sementsov-Ogievskiy wrote: > qemu-io now prefixes its error and warnings with "qemu-io:". > 36b9986b08787019e fixed a lot of iotests output but forget about > 026.out.nocache. Fix it too. > > Fixes: 99e98d7c9fc1a1639fad ("qemu-io: Use error_[gs]et_progname()") >