Re: [PATCH 1/3] iotests: Provide a function for checking the creation of huge files

2019-12-03 Thread Alex Bennée
Thomas Huth writes: > Some tests create huge (but sparse) files, and to be able to run those > tests in certain limited environments (like CI containers), we have to > check for the possibility to create such files first. Thus let's introduce > a common function to check for large files, and re

Re: [PATCH 0/3] iotests: Check for the possibility to create large files

2019-12-03 Thread Alex Bennée
Thomas Huth writes: > Travis recently added the possibility to test on ppc64le, arm64 and s390x > hosts, too. However, the containers are very restricted there and do not > allow the creation of large files, so that the tests 060 and 079 are > currently failing there. So let's add some proper c

Re: [PATCH v2 05/15] stubs: add stubs for io_uring interface

2019-12-03 Thread Stefan Hajnoczi
On Mon, Nov 11, 2019 at 12:13:47PM +0100, Kevin Wolf wrote: > Am 25.10.2019 um 18:04 hat Stefan Hajnoczi geschrieben: > > From: Aarushi Mehta > > > > Signed-off-by: Aarushi Mehta > > Signed-off-by: Stefan Hajnoczi > > This commit message needs to answer at least where these stubs are > actuall

Re: [PATCH for-5.0 v2 17/23] iotests: Use skip_if_unsupported decorator in 041

2019-12-03 Thread Vladimir Sementsov-Ogievskiy
11.11.2019 19:02, Max Reitz wrote: > We can use this decorator above TestRepairQuorum.setUp() to skip all > quorum tests with a single line. > > Signed-off-by: Max Reitz Reviewed-by: Vladimir Sementsov-Ogievskiy -- Best regards, Vladimir

Re: [PATCH for-5.0 v2 18/23] iotests: Add VM.assert_block_path()

2019-12-03 Thread Vladimir Sementsov-Ogievskiy
11.11.2019 19:02, Max Reitz wrote: > Signed-off-by: Max Reitz > --- > tests/qemu-iotests/iotests.py | 59 +++ > 1 file changed, 59 insertions(+) > > diff --git a/tests/qemu-iotests/iotests.py b/tests/qemu-iotests/iotests.py > index d34305ce69..3e03320ce3 100644

Re: [PATCH for-5.0 v2 19/23] iotests: Resolve TODOs in 041

2019-12-03 Thread Vladimir Sementsov-Ogievskiy
11.11.2019 19:02, Max Reitz wrote: > Signed-off-by: Max Reitz Reviewed-by: Vladimir Sementsov-Ogievskiy -- Best regards, Vladimir

Re: [PATCH for-5.0 v2 19/23] iotests: Resolve TODOs in 041

2019-12-03 Thread Vladimir Sementsov-Ogievskiy
03.12.2019 16:32, Vladimir Sementsov-Ogievskiy wrote: > 11.11.2019 19:02, Max Reitz wrote: >> Signed-off-by: Max Reitz > > > Reviewed-by: Vladimir Sementsov-Ogievskiy > Oops, stop. Why do you remove line "self.vm.shutdown()" ? -- Best regards, Vladimir

Re: [PATCH v2 05/15] stubs: add stubs for io_uring interface

2019-12-03 Thread Kevin Wolf
Am 03.12.2019 um 12:16 hat Stefan Hajnoczi geschrieben: > On Mon, Nov 11, 2019 at 12:13:47PM +0100, Kevin Wolf wrote: > > Am 25.10.2019 um 18:04 hat Stefan Hajnoczi geschrieben: > > > From: Aarushi Mehta > > > > > > Signed-off-by: Aarushi Mehta > > > Signed-off-by: Stefan Hajnoczi > > > > This

Re: [PATCH for-5.0 v2 21/23] iotests: Add tests for invalid Quorum @replaces

2019-12-03 Thread Vladimir Sementsov-Ogievskiy
11.11.2019 19:02, Max Reitz wrote: > Add two tests to see that you cannot replace a Quorum child with the > mirror job while the child is in use by a different parent. > > Signed-off-by: Max Reitz Reviewed-by: Vladimir Sementsov-Ogievskiy -- Best regards, Vladimir

Re: [PATCH for-5.0 v2 22/23] iotests: Check that @replaces can replace filters

2019-12-03 Thread Vladimir Sementsov-Ogievskiy
11.11.2019 19:02, Max Reitz wrote: > Signed-off-by: Max Reitz > --- > tests/qemu-iotests/041 | 46 ++ > tests/qemu-iotests/041.out | 4 ++-- > 2 files changed, 48 insertions(+), 2 deletions(-) > > diff --git a/tests/qemu-iotests/041 b/tests/qemu-iotest

Re: [PATCH v2 05/15] stubs: add stubs for io_uring interface

2019-12-03 Thread Paolo Bonzini
On 03/12/19 15:28, Kevin Wolf wrote: >> * It's possible to argue against this and personally I'm not that >> convinced by stubs for this scenario. But io_uring.o should be >> consistent with how things work today with linux-aio.o. If you feel >> strongly against having stubs then the linux-aio.o

Re: [PATCH V3 1/2] block/nbd: extract the common cleanup code

2019-12-03 Thread Vladimir Sementsov-Ogievskiy
Hi! First, please, when sending more than one patch, create a cover-letter. Also, summarize (in cover letter) what was changed since previous version. 29.11.2019 10:25, pannengy...@huawei.com wrote: > From: PanNengyuan Strange line. Check you git preferences. Such line appears (and make sense)

Re: [PATCH for-5.0 v2 23/23] iotests: Mirror must not attempt to create loops

2019-12-03 Thread Vladimir Sementsov-Ogievskiy
11.11.2019 19:02, Max Reitz wrote: > Signed-off-by: Max Reitz > --- > tests/qemu-iotests/041 | 235 + > tests/qemu-iotests/041.out | 4 +- > 2 files changed, 237 insertions(+), 2 deletions(-) > > diff --git a/tests/qemu-iotests/041 b/tests/qemu-iotest

for 4.2 ??? Re: [PATCH V3 2/2] block/nbd: fix memory leak in nbd_open()

2019-12-03 Thread Vladimir Sementsov-Ogievskiy
It's just a memory leak, but it's a regression in 4.2. Should we take it into 4.2? 29.11.2019 10:25, pannengy...@huawei.com wrote: > From: PanNengyuan > > In currently implementation there will be a memory leak when > nbd_client_connect() returns error status. Here is an easy way to > reproduc

Re: [PATCH V3 1/2] block/nbd: extract the common cleanup code

2019-12-03 Thread Eric Blake
On 11/29/19 1:25 AM, pannengy...@huawei.com wrote: From: PanNengyuan The BDRVNBDState cleanup code is common in two places, add nbd_free_bdrvstate_prop() function to do these cleanups (suggested by Stefano Garzarella). Signed-off-by: PanNengyuan --- block/nbd.c | 23 +--

Re: for 4.2 ??? Re: [PATCH V3 2/2] block/nbd: fix memory leak in nbd_open()

2019-12-03 Thread Eric Blake
On 12/3/19 11:52 AM, Vladimir Sementsov-Ogievskiy wrote: It's just a memory leak, but it's a regression in 4.2. Should we take it into 4.2? Sorry, I was on holiday and then jury service, so I missed any chance at getting this into -rc3. The memory leak only happens on failure, and you'd hav

Review of onboard block device configuration with -drive

2019-12-03 Thread Markus Armbruster
To the best of my knowledge, -blockdev can fully replace -drive if=none. Replacing other interface types takes more than just -blockdev, because they additionally instruct the board code to create a block frontend. -blockdev is *only* about backends, so something else needs to replace the frontend

Re: for 4.2 ??? Re: [PATCH V3 2/2] block/nbd: fix memory leak in nbd_open()

2019-12-03 Thread Eric Blake
On 12/3/19 12:54 PM, Eric Blake wrote: On 12/3/19 11:52 AM, Vladimir Sementsov-Ogievskiy wrote: It's just a memory leak, but it's a regression in 4.2. Should we take it into 4.2? Sorry, I was on holiday and then jury service, so I missed any chance at getting this into -rc3.  The memory leak

Re: [PATCH V3 1/2] block/nbd: extract the common cleanup code

2019-12-03 Thread pannengyuan
On 2019/12/4 1:38, Vladimir Sementsov-Ogievskiy wrote: > Hi! > > First, please, when sending more than one patch, create a cover-letter. Also, > summarize (in cover letter) what was changed since previous version. In previous version, I only send one patch(2/2 in this version), so I only add a

Re: [PATCH V3 1/2] block/nbd: extract the common cleanup code

2019-12-03 Thread pannengyuan
On 2019/12/4 3:00, Eric Blake wrote: > On 11/29/19 1:25 AM, pannengy...@huawei.com wrote: >> From: PanNengyuan >> >> The BDRVNBDState cleanup code is common in two places, add >> nbd_free_bdrvstate_prop() function to do these cleanups (suggested by >> Stefano Garzarella). >> >> Signed-off-by: P

Re: for 4.2 ??? Re: [PATCH V3 2/2] block/nbd: fix memory leak in nbd_open()

2019-12-03 Thread pannengyuan
On 2019/12/4 2:54, Eric Blake wrote: > On 12/3/19 11:52 AM, Vladimir Sementsov-Ogievskiy wrote: >> It's just a memory leak, but it's a regression in 4.2. >> >> Should we take it into 4.2? > > Sorry, I was on holiday and then jury service, so I missed any chance at > getting this into -rc3.  The

Re: [PATCH V3 1/2] block/nbd: extract the common cleanup code

2019-12-03 Thread Vladimir Sementsov-Ogievskiy
04.12.2019 6:12, pannengyuan wrote: > > > On 2019/12/4 1:38, Vladimir Sementsov-Ogievskiy wrote: >> Hi! >> >> First, please, when sending more than one patch, create a cover-letter. Also, >> summarize (in cover letter) what was changed since previous version. > In previous version, I only send on

Re: [PATCH V3 1/2] block/nbd: extract the common cleanup code

2019-12-03 Thread Pan Nengyuan
On 2019/12/4 15:19, Vladimir Sementsov-Ogievskiy wrote: > 04.12.2019 6:12, pannengyuan wrote: >> >> >> On 2019/12/4 1:38, Vladimir Sementsov-Ogievskiy wrote: >>> Hi! >>> >>> First, please, when sending more than one patch, create a cover-letter. >>> Also, >>> summarize (in cover letter) what wa

Re: virtiofsd: Where should it live?

2019-12-03 Thread Markus Armbruster
Daniel P. Berrangé writes: > On Tue, Dec 03, 2019 at 11:06:44AM +, Peter Maydell wrote: >> On Tue, 3 Dec 2019 at 10:53, Dr. David Alan Gilbert >> wrote: >> > >> > We seem to be coming to the conclusion something that: >> > >> > a) It should live in the qemu tree >> > b) It shouldn't liv