[PATCH v6 10/11] nbd: introduce ERRP_AUTO_PROPAGATE

2020-01-10 Thread Vladimir Sementsov-Ogievskiy
If we want to add some info to errp (by error_prepend() or error_append_hint()), we must use the ERRP_AUTO_PROPAGATE macro. Otherwise, this info will not be added when errp == _fatal (the program will exit prior to the error_append_hint() or error_prepend() call). Fix such cases. If we want to

[PATCH v6 11/11] xen: introduce ERRP_AUTO_PROPAGATE

2020-01-10 Thread Vladimir Sementsov-Ogievskiy
If we want to add some info to errp (by error_prepend() or error_append_hint()), we must use the ERRP_AUTO_PROPAGATE macro. Otherwise, this info will not be added when errp == _fatal (the program will exit prior to the error_append_hint() or error_prepend() call). Fix such cases. If we want to

Re: [PATCH 1/4] qapi: Add a 'coroutine' flag for commands

2020-01-10 Thread Eric Blake
On 1/9/20 12:35 PM, Kevin Wolf wrote: This patch adds a new 'coroutine' flag to QMP command definitions that tells the QMP dispatcher than the command handler is safe to be run in a s/than/that/ coroutine. Signed-off-by: Kevin Wolf --- tests/qapi-schema/qapi-schema-test.json | 1 +

Re: [PATCH] block: Use a GString in bdrv_perm_names()

2020-01-10 Thread Eric Blake
On 1/10/20 11:15 AM, Alberto Garcia wrote: This is a bit more efficient than having to allocate and free memory for each new permission. The default size (30) is enough for "consistent read, write, resize". Signed-off-by: Alberto Garcia --- block.c | 11 ++- 1 file changed, 6

[PATCH v6 01/11] qapi/error: add (Error **errp) cleaning APIs

2020-01-10 Thread Vladimir Sementsov-Ogievskiy
Signed-off-by: Vladimir Sementsov-Ogievskiy --- CC: Cornelia Huck CC: Eric Blake CC: Kevin Wolf CC: Max Reitz CC: Greg Kurz CC: Stefan Hajnoczi CC: Stefano Stabellini CC: Anthony Perard CC: Paul Durrant CC: "Philippe Mathieu-Daudé" CC: Laszlo Ersek CC: Gerd Hoffmann CC: Stefan Berger

[PATCH v6 03/11] scripts: add coccinelle script to use auto propagated errp

2020-01-10 Thread Vladimir Sementsov-Ogievskiy
Signed-off-by: Vladimir Sementsov-Ogievskiy --- CC: Cornelia Huck CC: Eric Blake CC: Kevin Wolf CC: Max Reitz CC: Greg Kurz CC: Stefan Hajnoczi CC: Stefano Stabellini CC: Anthony Perard CC: Paul Durrant CC: "Philippe Mathieu-Daudé" CC: Laszlo Ersek CC: Gerd Hoffmann CC: Stefan Berger

[PATCH v6 00/11] error: auto propagated local_err part I

2020-01-10 Thread Vladimir Sementsov-Ogievskiy
Hi all! Now, when preparations from [RFC v5 000/126] error: auto propagated local_err https://lists.gnu.org/archive/html/qemu-devel/2019-10/msg02771.html https://src.openvz.org/scm/~vsementsov/qemu.git #tag up-auto-local-err-v5 , after some iterations, are finally merged, let's proceed with

Re: [Xen-devel] [PATCH v6 00/11] error: auto propagated local_err part I

2020-01-10 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20200110194158.14190-1-vsement...@virtuozzo.com/ Hi, This series seems to have some coding style problems. See output below for more information: Subject: [Xen-devel] [PATCH v6 00/11] error: auto propagated local_err part I Type: series Message-id:

[PATCH v6 02/11] error: auto propagated local_err

2020-01-10 Thread Vladimir Sementsov-Ogievskiy
Here is introduced ERRP_AUTO_PROPAGATE macro, to be used at start of functions with errp OUT parameter. It has three goals: 1. Fix issue with error_fatal & error_prepend/error_append_hint: user can't see this additional information, because exit() happens in error_setg earlier than information

[PATCH v6 06/11] pflash: introduce ERRP_AUTO_PROPAGATE

2020-01-10 Thread Vladimir Sementsov-Ogievskiy
If we want to add some info to errp (by error_prepend() or error_append_hint()), we must use the ERRP_AUTO_PROPAGATE macro. Otherwise, this info will not be added when errp == _fatal (the program will exit prior to the error_append_hint() or error_prepend() call). Fix such cases. If we want to

Re: [PATCH v3 00/15] io_uring: add Linux io_uring AIO engine

2020-01-10 Thread Stefan Hajnoczi
On Wed, Dec 18, 2019 at 04:32:13PM +, Stefan Hajnoczi wrote: > v12: > * Reword BlockdevAioOptions QAPI schema commit description [Markus] > * Increase QAPI "Since: 4.2" to "Since: 5.0" > * Explain rationale for io_uring stubs in commit description [Kevin] > * Tried to use file.aio=io_uring

Re: [PATCH v2 3/4] qcow2: Tighten cluster_offset alignment assertions

2020-01-10 Thread Alberto Garcia
On Thu 09 Jan 2020 08:13:01 PM CET, Alberto Garcia wrote: > -assert((cluster_offset & 511) == 0); > +assert(QEMU_IS_ALIGNED(cluster_offset, s->cluster_size)); On second thoughts this patch could also use the (probably more efficient) offset_into_cluster() call instead. I can

Re: Priority of -accel (was: [PATCH] tests/qemu-iotests: Update tests to recent desugarized -accel option)

2020-01-10 Thread Peter Maydell
On Wed, 8 Jan 2020 at 11:00, Peter Maydell wrote: > > On Wed, 8 Jan 2020 at 10:40, Alex Bennée wrote: > > Thomas Huth writes: > > > What about "-accel any" or "-accel fastest" or something similar? > > > > "any" is just ambiguous, "fastest" is just begging for me to find a > > micro-benchmark

[PATCH] block: Use a GString in bdrv_perm_names()

2020-01-10 Thread Alberto Garcia
This is a bit more efficient than having to allocate and free memory for each new permission. The default size (30) is enough for "consistent read, write, resize". Signed-off-by: Alberto Garcia --- block.c | 11 ++- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/block.c