[PATCH v2 1/5] iotests: QemuIoInteractive: use qemu_io_args_no_fmt

2020-07-01 Thread Vladimir Sementsov-Ogievskiy
The only user (iotest 205) of QemuIoInteractive provides -f argument, so it's a bit inefficient to use qemu_io_args, which contains -f too. And we are going to add one more test, which wants to specify -f by hand. Let's use qemu_io_args_no_fmt. Signed-off-by: Vladimir Sementsov-Ogievskiy

[PATCH v2 3/5] nbd: make nbd_export_close_all() synchronous

2020-07-01 Thread Vladimir Sementsov-Ogievskiy
Consider nbd_export_close_all(). The call-stack looks like this: nbd_export_close_all() -> nbd_export_close -> call client_close() for each client. client_close() doesn't guarantee that client is closed: nbd_trip() keeps reference to it. So, nbd_export_close_all() just reduce reference counter

[PATCH v2 5/5] iotests: test shutdown when bitmap is exported through NBD

2020-07-01 Thread Vladimir Sementsov-Ogievskiy
Test shutdown when bitmap is exported through NBD and active client exists. The previous patch fixes a crash, provoked by this scenario. Signed-off-by: Vladimir Sementsov-Ogievskiy --- tests/qemu-iotests/299 | 65 ++ tests/qemu-iotests/299.out | 10 ++

Re: [PATCH 1/2] pci: pass along the return value of dma_memory_rw

2020-07-01 Thread Michael S. Tsirkin
On Mon, Jun 29, 2020 at 10:20:52PM +0200, Klaus Jensen wrote: > From: Klaus Jensen > > Some devices might want to know the return value of dma_memory_rw, so > pass it along instead of ignoring it. > > There are no existing users of the return value, so this patch should be > safe. > >

Re: [PATCH 1/4] migration: Prevent memleak by ...params_test_apply

2020-07-01 Thread Vladimir Sementsov-Ogievskiy
30.06.2020 11:45, Max Reitz wrote: The created structure is not really a proper QAPI object, so we cannot and will not free its members. Strings therein should therefore not be duplicated, or we will leak them. Signed-off-by: Max Reitz Reviewed-by: Vladimir Sementsov-Ogievskiy -- Best

Re: [PATCH v2 14/18] hw/block/nvme: Generate zone AENs

2020-07-01 Thread Klaus Jensen
On Jun 18 06:34, Dmitry Fomichev wrote: > Added an optional Boolean "zone_async_events" property to the driver. > Once it's turned on, the namespace will be sending "Zone Descriptor > Changed" asynchronous events to the host in particular situations > defined by the protocol. In order to clear

Re: nvme emulation merge process (was: Re: [PATCH 00/10] hw/block/nvme: namespace types and zoned namespaces)

2020-07-01 Thread Klaus Jensen
On Jul 1 12:34, Kevin Wolf wrote: > Am 30.06.2020 um 22:36 hat Klaus Jensen geschrieben: > > On Jun 30 08:42, Keith Busch wrote: > > > On Tue, Jun 30, 2020 at 04:09:46PM +0200, Philippe Mathieu-Daudé wrote: > > > > What I see doable for the following days is: > > > > - hw/block/nvme: Fix I/O BAR

[PATCH v2 4/5] iotests.py: filter_testfiles(): filter SOCK_DIR too

2020-07-01 Thread Vladimir Sementsov-Ogievskiy
Signed-off-by: Vladimir Sementsov-Ogievskiy --- tests/qemu-iotests/iotests.py | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/tests/qemu-iotests/iotests.py b/tests/qemu-iotests/iotests.py index ac9d199a1e..31d4b105ca 100644 --- a/tests/qemu-iotests/iotests.py +++

[PATCH v2 0/5] Fix crash due to NBD export leak

2020-07-01 Thread Vladimir Sementsov-Ogievskiy
Hi all! We've faced crash bug, which is reproducing on master branch as well. The case is described in 03, where fix is suggested. New iotest in 05 crashes without that fix. v2: 01: reword commit msg, add Eric's r-b 02: fix type in commit msg, add Eric's r-b 03: rewrite v1:04 split into 04

[PATCH v2 2/5] iotests.py: QemuIoInteractive: print output on failure

2020-07-01 Thread Vladimir Sementsov-Ogievskiy
Make it simpler to debug when qemu-io fails due to wrong arguments or environment. Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Eric Blake --- tests/qemu-iotests/iotests.py | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/tests/qemu-iotests/iotests.py

Re: [PATCH v9 11/34] qcow2: Add offset_into_subcluster() and size_to_subclusters()

2020-07-01 Thread Max Reitz
On 28.06.20 13:02, Alberto Garcia wrote: > Like offset_into_cluster() and size_to_clusters(), but for > subclusters. > > Signed-off-by: Alberto Garcia > Reviewed-by: Eric Blake > --- > block/qcow2.h | 10 ++ > 1 file changed, 10 insertions(+) Reviewed-by: Max Reitz signature.asc

Re: [PATCH v9 14/34] qcow2: Add QCow2SubclusterType and qcow2_get_subcluster_type()

2020-07-01 Thread Max Reitz
On 28.06.20 13:02, Alberto Garcia wrote: > This patch adds QCow2SubclusterType, which is the subcluster-level > version of QCow2ClusterType. All QCOW2_SUBCLUSTER_* values have the > the same meaning as their QCOW2_CLUSTER_* equivalents (when they > exist). See below for details and caveats. > >

Re: [PATCH 3/4] nbd: make client_close synchronous

2020-07-01 Thread Vladimir Sementsov-Ogievskiy
29.06.2020 16:56, Stefan Hajnoczi wrote: On Mon, Jun 29, 2020 at 10:55:06AM +0300, Vladimir Sementsov-Ogievskiy wrote: Also, why in block/io.c we kick the main context, but not bs->aio_context? From AIO_WAIT_WHILE(): * The caller's thread must be the IOThread that owns @ctx or the main

Re: [PATCH 2/2] iscsi: return -EIO when sense fields are meaningless

2020-07-01 Thread Paolo Bonzini
On 01/07/20 12:54, Xie Yongji wrote: > When an I/O request failed, now we only return correct > value on scsi check condition. We should also have a > default errno such as -EIO in other case. > > Signed-off-by: Xie Yongji > --- > block/iscsi.c | 2 ++ > 1 file changed, 2 insertions(+) > >

nvme emulation merge process (was: Re: [PATCH 00/10] hw/block/nvme: namespace types and zoned namespaces)

2020-07-01 Thread Kevin Wolf
Am 30.06.2020 um 22:36 hat Klaus Jensen geschrieben: > On Jun 30 08:42, Keith Busch wrote: > > On Tue, Jun 30, 2020 at 04:09:46PM +0200, Philippe Mathieu-Daudé wrote: > > > What I see doable for the following days is: > > > - hw/block/nvme: Fix I/O BAR structure [3] > > > - hw/block/nvme: handle

Re: [PATCH 2/4] migration: Add block-bitmap-mapping parameter

2020-07-01 Thread Max Reitz
On 30.06.20 12:51, Dr. David Alan Gilbert wrote: > * Max Reitz (mre...@redhat.com) wrote: >> This migration parameter allows mapping block node names and bitmap >> names to aliases for the purpose of block dirty bitmap migration. >> >> This way, management tools can use different node and bitmap

Re: [PATCH v9 13/34] qcow2: Update get/set_l2_entry() and add get/set_l2_bitmap()

2020-07-01 Thread Max Reitz
On 28.06.20 13:02, Alberto Garcia wrote: > Extended L2 entries are 128-bit wide: 64 bits for the entry itself and > 64 bits for the subcluster allocation bitmap. > > In order to support them correctly get/set_l2_entry() need to be > updated so they take the entry width into account in order to >

Re: [PATCH 0/2] hw/block/nvme: handle transient dma errors

2020-07-01 Thread Philippe Mathieu-Daudé
On 6/29/20 11:34 PM, Klaus Jensen wrote: > On Jun 29 14:07, no-re...@patchew.org wrote: >> Patchew URL: >> https://patchew.org/QEMU/20200629202053.1223342-1-...@irrelevant.dk/ >> --- /tmp/qemu-test/src/tests/qemu-iotests/040.out 2020-06-29 >> 20:12:10.0 + >> +++

[PATCH v4 02/40] iotests: Fix 051 output after qdev_init_nofail() removal

2020-07-01 Thread Alex Bennée
From: Philippe Mathieu-Daudé Commit 96927c744 replaced qdev_init_nofail() call by isa_realize_and_unref() which has a different error message. Update the test output accordingly. Gitlab CI error after merging b77b5b3dc7: https://gitlab.com/qemu-project/qemu/-/jobs/597414772#L4375 Reported-by:

[PATCH 1/3] util: validate whether O_DIRECT is supported after failure

2020-07-01 Thread Daniel P . Berrangé
Currently we suggest that a filesystem may not support O_DIRECT after seeing an EINVAL. Other things can cause EINVAL though, so it is better to do an explicit check, and then report a definitive error message. Signed-off-by: Daniel P. Berrangé --- util/osdep.c | 13 +++-- 1 file

[PATCH 2/3] util: support detailed error reporting for qemu_open

2020-07-01 Thread Daniel P . Berrangé
Create a "qemu_open_err" method which does the same as "qemu_open", but with a "Error **errp" for error reporting. There should be no behavioural difference for existing callers at this stage. Signed-off-by: Daniel P. Berrangé --- include/qemu/osdep.h | 1 + util/osdep.c | 71

Re: [PATCH 1/4] migration: Prevent memleak by ...params_test_apply

2020-07-01 Thread Eric Blake
On 6/30/20 3:45 AM, Max Reitz wrote: The created structure is not really a proper QAPI object, so we cannot and will not free its members. Strings therein should therefore not be duplicated, or we will leak them. This seems fragile to me; having to code QAPI usage differently depending on

Re: [PATCH v2 02/12] block/nvme: Avoid further processing if trace event not enabled

2020-07-01 Thread Stefan Hajnoczi
On Tue, Jun 30, 2020 at 09:13:08PM +0200, Philippe Mathieu-Daudé wrote: > Avoid further processing if TRACE_NVME_SUBMIT_COMMAND_RAW is > not enabled. This is an untested intend of performance optimization. > > Signed-off-by: Philippe Mathieu-Daudé > --- > block/nvme.c | 3 +++ > 1 file changed,

Re: [PATCH v2 01/12] block/nvme: Replace magic value by SCALE_MS definition

2020-07-01 Thread Stefan Hajnoczi
On Tue, Jun 30, 2020 at 09:13:07PM +0200, Philippe Mathieu-Daudé wrote: > Use self-explicit SCALE_MS definition instead of magic value. > > Signed-off-by: Philippe Mathieu-Daudé > --- > block/nvme.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-by: Stefan Hajnoczi

[PATCH 1/2] iscsi: handle check condition status in retry loop

2020-07-01 Thread Xie Yongji
The handling of check condition was incorrect because we would only do it after retries exceed maximum. Fixes: 8c460269aa ("iscsi: base all handling of check condition on scsi_sense_to_errno") Signed-off-by: Xie Yongji --- block/iscsi.c | 20 ++-- 1 file changed, 10

[PATCH 2/2] iscsi: return -EIO when sense fields are meaningless

2020-07-01 Thread Xie Yongji
When an I/O request failed, now we only return correct value on scsi check condition. We should also have a default errno such as -EIO in other case. Signed-off-by: Xie Yongji --- block/iscsi.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/block/iscsi.c b/block/iscsi.c index

Re: [PATCH v2 05/12] block/nvme: Rename local variable

2020-07-01 Thread Stefan Hajnoczi
On Tue, Jun 30, 2020 at 09:13:11PM +0200, Philippe Mathieu-Daudé wrote: > We are going to modify the code in the next commit. Renaming > the 'resp' variable to 'id' first makes the next commit easier > to review. No logical changes. > > Signed-off-by: Philippe Mathieu-Daudé > --- > block/nvme.c

Re: [PATCH v2 08/12] block/nvme: Replace qemu_try_blockalign(bs) by qemu_try_memalign(pg_sz)

2020-07-01 Thread Stefan Hajnoczi
On Tue, Jun 30, 2020 at 09:13:14PM +0200, Philippe Mathieu-Daudé wrote: > qemu_try_blockalign() is a generic API that call back to the > block driver to return its page alignment. As we call from > within the very same driver, we already know to page alignment > stored in our state. Remove

Re: [PATCH v2 06/12] block/nvme: Use union of NvmeIdCtrl / NvmeIdNs structures

2020-07-01 Thread Stefan Hajnoczi
On Tue, Jun 30, 2020 at 09:13:12PM +0200, Philippe Mathieu-Daudé wrote: > We allocate an unique chunk of memory then use it for two > different structures. By using an union, we make it clear > the data is overlapping (and we can remove the casts). > > Suggested-by: Stefan Hajnoczi >

Re: [PATCH v9 14/34] qcow2: Add QCow2SubclusterType and qcow2_get_subcluster_type()

2020-07-01 Thread Alberto Garcia
On Wed 01 Jul 2020 02:52:14 PM CEST, Max Reitz wrote: >> if (l2_entry & QCOW_OFLAG_COMPRESSED) { >> return QCOW2_CLUSTER_COMPRESSED; >> -} else if (l2_entry & QCOW_OFLAG_ZERO) { >> +} else if ((l2_entry & QCOW_OFLAG_ZERO) && !has_subclusters(s)) { > > OK, so now

Re: [PATCH 0/3] block: improve error reporting for unsupported O_DIRECT

2020-07-01 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20200701160509.1523847-1-berra...@redhat.com/ Hi, This series failed the docker-quick@centos7 build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. === TEST SCRIPT BEGIN

Re: [PATCH v9 15/34] qcow2: Add qcow2_get_subcluster_range_type()

2020-07-01 Thread Max Reitz
On 28.06.20 13:02, Alberto Garcia wrote: > There are situations in which we want to know how many contiguous > subclusters of the same type there are in a given cluster. This can be > done by simply iterating over the subclusters and repeatedly calling > qcow2_get_subcluster_type() for each one of

Re: nvme emulation merge process (was: Re: [PATCH 00/10] hw/block/nvme: namespace types and zoned namespaces)

2020-07-01 Thread Keith Busch
On Wed, Jul 01, 2020 at 03:57:27PM +0200, Philippe Mathieu-Daudé wrote: > On 7/1/20 3:18 PM, Klaus Jensen wrote: > > We've also seen good patches from Andrzej linger on the list for quite a > > while, prompting a number of RESENDs. I only recently allocated more > > time and upped my review game,

Re: [PATCH] MAINTAINERS: Cover "block/nvme.h" file

2020-07-01 Thread Klaus Jensen
On Jul 1 16:06, Philippe Mathieu-Daudé wrote: > The "block/nvme.h" header is shared by both the NVMe block > driver and the NVMe emulated device. Add the 'F:' entry on > both sections, so all maintainers/reviewers are notified > when it is changed. > > Signed-off-by: Philippe Mathieu-Daudé

Re: [PATCH v2 15/18] hw/block/nvme: Support Zone Descriptor Extensions

2020-07-01 Thread Klaus Jensen
On Jun 18 06:34, Dmitry Fomichev wrote: > Zone Descriptor Extension is a label that can be assigned to a zone. > It can be set to an Empty zone and it stays assigned until the zone > is reset. > > This commit adds a new optional property, "zone_descr_ext_size", to > the driver. Its value must be

[PATCH 0/3] block: improve error reporting for unsupported O_DIRECT

2020-07-01 Thread Daniel P . Berrangé
To repeat the commit message from patch 3... Currently at startup if using cache=none on a filesystem lacking O_DIRECT such as tmpfs, at startup QEMU prints qemu-system-x86_64: -drive file=/tmp/foo.img,cache=none: file system may not support O_DIRECT qemu-system-x86_64: -drive

Re: nvme emulation merge process (was: Re: [PATCH 00/10] hw/block/nvme: namespace types and zoned namespaces)

2020-07-01 Thread Maxim Levitsky
On Wed, 2020-07-01 at 15:18 +0200, Klaus Jensen wrote: > On Jul 1 12:34, Kevin Wolf wrote: > > Am 30.06.2020 um 22:36 hat Klaus Jensen geschrieben: > > > On Jun 30 08:42, Keith Busch wrote: > > > > On Tue, Jun 30, 2020 at 04:09:46PM +0200, Philippe Mathieu-Daudé wrote: > > > > > What I see

Re: [PATCH v9 16/34] qcow2: Add qcow2_cluster_is_allocated()

2020-07-01 Thread Max Reitz
On 28.06.20 13:02, Alberto Garcia wrote: > This helper function tells us if a cluster is allocated (that is, > there is an associated host offset for it). > > Signed-off-by: Alberto Garcia > Reviewed-by: Eric Blake > --- > block/qcow2.h | 6 ++ > 1 file changed, 6 insertions(+)

Re: nvme emulation merge process (was: Re: [PATCH 00/10] hw/block/nvme: namespace types and zoned namespaces)

2020-07-01 Thread Philippe Mathieu-Daudé
On 7/1/20 3:18 PM, Klaus Jensen wrote: > On Jul 1 12:34, Kevin Wolf wrote: >> Am 30.06.2020 um 22:36 hat Klaus Jensen geschrieben: >>> On Jun 30 08:42, Keith Busch wrote: On Tue, Jun 30, 2020 at 04:09:46PM +0200, Philippe Mathieu-Daudé wrote: > What I see doable for the following days

[PATCH] MAINTAINERS: Cover "block/nvme.h" file

2020-07-01 Thread Philippe Mathieu-Daudé
The "block/nvme.h" header is shared by both the NVMe block driver and the NVMe emulated device. Add the 'F:' entry on both sections, so all maintainers/reviewers are notified when it is changed. Signed-off-by: Philippe Mathieu-Daudé --- Cc: Fam Zheng Cc: Keith Busch Cc: Kevin Wolf Cc: Max

Re: [PATCH 2/4] migration: Add block-bitmap-mapping parameter

2020-07-01 Thread Vladimir Sementsov-Ogievskiy
30.06.2020 11:45, Max Reitz wrote: This migration parameter allows mapping block node names and bitmap names to aliases for the purpose of block dirty bitmap migration. This way, management tools can use different node and bitmap names on the source and destination and pass the mapping of how

[PATCH 3/3] block: switch to use qemu_open_err for improved errors

2020-07-01 Thread Daniel P . Berrangé
Currently at startup if using cache=none on a filesystem lacking O_DIRECT such as tmpfs, at startup QEMU prints qemu-system-x86_64: -drive file=/tmp/foo.img,cache=none: file system may not support O_DIRECT qemu-system-x86_64: -drive file=/tmp/foo.img,cache=none: Could not open '/tmp/foo.img':

Re: [PATCH v2 12/12] block/nvme: Use per-queue AIO context

2020-07-01 Thread Stefan Hajnoczi
On Tue, Jun 30, 2020 at 09:13:18PM +0200, Philippe Mathieu-Daudé wrote: > To be able to use multiple queues on the same hardware, > we need to have each queue able to receive IRQ notifications > in the correct AIO context. > The AIO context and the notification handler have to be proper > to each

Re: [PATCH v2 13/18] hw/block/nvme: Set Finish/Reset Zone Recommended attributes

2020-07-01 Thread Klaus Jensen
On Jun 18 06:34, Dmitry Fomichev wrote: > Added logic to set and reset FZR and RZR zone attributes. Four new > driver properties are added to control the timing of setting and > resetting these attributes. FZR/RZR delay lasts from the zone > operation and until when the corresponding zone

Re: [PATCH v2 17/18] hw/block/nvme: Use zone metadata file for persistence

2020-07-01 Thread Klaus Jensen
On Jun 18 06:34, Dmitry Fomichev wrote: > A ZNS drive that is emulated by this driver is currently initialized > with all zones Empty upon startup. However, actual ZNS SSDs save the > state and condition of all zones in their internal NVRAM in the event > of power loss. When such a drive is

Re: [PATCH v4 00/16] python: add mypy support to python/qemu

2020-07-01 Thread John Snow
On 6/29/20 10:30 AM, John Snow wrote: > > > On 6/29/20 4:26 AM, Philippe Mathieu-Daudé wrote: >> +Cleber/Wainer. >> >> On 6/26/20 10:41 PM, John Snow wrote: >>> Based-on: 20200626202350.11060-1-js...@redhat.com >>> >>> This series modifies the python/qemu library to comply with mypy --strict.

[PATCH v4] nvme: allow cmb and pmr emulation on same device

2020-07-01 Thread Andrzej Jakowski
Hi All, Resending series recently posted on mailing list related to nvme device extension with couple of fixes after review. This patch series does following: - Fixes problem where CMBS bit was not set in controller capabilities register, so support for CMB was not correctly advertised to

Re: [PATCH v3 3/4] hw/block/nvme: Fix pmrmsc register size

2020-07-01 Thread Andrzej Jakowski
On 6/30/20 9:45 AM, Klaus Jensen wrote: > On Jun 30 17:16, Philippe Mathieu-Daudé wrote: >> On 6/30/20 5:10 PM, Andrzej Jakowski wrote: >>> On 6/30/20 4:04 AM, Philippe Mathieu-Daudé wrote: The Persistent Memory Region Controller Memory Space Control register is 64-bit wide. See 'Figure

[PATCH v4 1/2] nvme: indicate CMB support through controller capabilities register

2020-07-01 Thread Andrzej Jakowski
This patch sets CMBS bit in controller capabilities register when user configures NVMe driver with CMB support, so capabilites are correctly reported to guest OS. Signed-off-by: Andrzej Jakowski Reviewed-by: Klaus Jensen --- hw/block/nvme.c | 2 +- include/block/nvme.h | 6 +- 2 files

[PATCH v4 2/2] nvme: allow cmb and pmr to be enabled on same device

2020-07-01 Thread Andrzej Jakowski
So far it was not possible to have CMB and PMR emulated on the same device, because BAR2 was used exclusively either of PMR or CMB. This patch places CMB at BAR4 offset so it not conflicts with MSI-X vectors. Signed-off-by: Andrzej Jakowski --- hw/block/nvme.c | 101

Re: [PATCH] block: Raise an error when backing file parameter is an empty string

2020-07-01 Thread Connor Kuehl
Hi Kevin & Max, Just pinging this patch for your consideration. Thank you, Connor On 6/17/20 11:27 AM, Connor Kuehl wrote: Providing an empty string for the backing file parameter like so: qemu-img create -f qcow2 -b '' /tmp/foo allows the flow of control to reach and subsequently

Re: [PATCH v2 12/18] hw/block/nvme: Simulate Zone Active excursions

2020-07-01 Thread Klaus Jensen
On Jun 18 06:34, Dmitry Fomichev wrote: > Added a Boolean flag to turn on simulation of Zone Active Excursions. > If the flag, "active_excursions", is set to true, the driver will try > to finish one of the currently open zone if max active zones limit is > going to get exceeded. > >

Re: [PATCH v2 11/18] hw/block/nvme: Introduce max active and open zone limits

2020-07-01 Thread Klaus Jensen
On Jun 18 06:34, Dmitry Fomichev wrote: > Added two module properties, "max_active" and "max_open" to control > the maximum number of zones that can be active or open. Once these > variables are set to non-default values, the driver checks these > limits during I/O and returns Too Many Active or

Re: [PATCH 2/3] util: support detailed error reporting for qemu_open

2020-07-01 Thread Markus Armbruster
Daniel P. Berrangé writes: > Create a "qemu_open_err" method which does the same as "qemu_open", > but with a "Error **errp" for error reporting. There should be no > behavioural difference for existing callers at this stage. > > Signed-off-by: Daniel P. Berrangé > --- > include/qemu/osdep.h |

Re: [PATCH 11/46] qemu-option: Make uses of find_desc_by_name() more similar

2020-07-01 Thread Markus Armbruster
Vladimir Sementsov-Ogievskiy writes: > 29.06.2020 12:36, Vladimir Sementsov-Ogievskiy wrote: >> 24.06.2020 19:43, Markus Armbruster wrote: >>> This is to make the next commit easier to review. >>> >>> Signed-off-by: Markus Armbruster >>> --- >>>   util/qemu-option.c | 32

Re: [PATCH 14/46] qemu-option: Factor out helper opt_create()

2020-07-01 Thread Markus Armbruster
Vladimir Sementsov-Ogievskiy writes: > 24.06.2020 19:43, Markus Armbruster wrote: >> There is just one use so far. The next commit will add more. >> >> Signed-off-by: Markus Armbruster >> --- >> util/qemu-option.c | 27 ++- >> 1 file changed, 18 insertions(+), 9

Re: [PATCH 10/46] qemu-option: Check return value instead of @err where convenient

2020-07-01 Thread Markus Armbruster
Vladimir Sementsov-Ogievskiy writes: > 24.06.2020 19:43, Markus Armbruster wrote: >> Convert uses like >> >> opts = qemu_opts_create(..., ); >> if (err) { >> ... >> } >> >> to >> >> opts = qemu_opts_create(..., ); >> if (!opts) { >> ... >> } >> >>

Re: [PATCH 15/46] qemu-option: Tidy up opt_set() not to free arguments on failure

2020-07-01 Thread Markus Armbruster
Vladimir Sementsov-Ogievskiy writes: > 24.06.2020 19:43, Markus Armbruster wrote: >> opt_set() frees its argument @value on failure. Slightly unclean; >> functions ideally do nothing on failure. >> >> To tidy this up, move opt_create() from opt_set() into its callers, >> along with the cleanup.

Re: [PATCH 34/46] qom: Don't handle impossible object_property_get_link() failure

2020-07-01 Thread Markus Armbruster
Philippe Mathieu-Daudé writes: > On 6/25/20 5:09 PM, Markus Armbruster wrote: >> Philippe Mathieu-Daudé writes: >> >>> On 6/24/20 6:43 PM, Markus Armbruster wrote: Don't handle object_property_get_link() failure that can't happen unless the programmer screwed up, pass _abort.