Re: [PATCH v2 15/36] block: use topological sort for permission update

2021-02-03 Thread Kevin Wolf
Am 28.01.2021 um 19:04 hat Vladimir Sementsov-Ogievskiy geschrieben: > 28.01.2021 20:13, Kevin Wolf wrote: > > Am 28.01.2021 um 10:34 hat Vladimir Sementsov-Ogievskiy geschrieben: > > > 27.01.2021 21:38, Kevin Wolf wrote: > > > > Am 27.11.2020 um 15:45 hat Vladimir Sementsov-Ogievskiy geschrieben:

[PATCH 0/4] Remove the deprecated pc-1.x machine types and related stuff

2021-02-03 Thread Thomas Huth
The pc-1.x machine types have been deprecated since QEMU v5.0 already, and nobody complained, so they can now be removed. While we're at it, also remove some compatibility switches and related code that are now not necessary anymore after these machine types have been removed. (We could maybe even

[PATCH 1/4] hw/i386: Remove the deprecated pc-1.x machine types

2021-02-03 Thread Thomas Huth
They have been deprecated since QEMU v5.0, time to remove them now. Signed-off-by: Thomas Huth --- docs/system/deprecated.rst | 6 -- docs/system/removed-features.rst | 6 ++ hw/i386/pc_piix.c| 94 3 files changed, 6 insertions(+), 100

Re: [PATCH v5 0/5] hw/block/nvme: add simple copy command

2021-02-03 Thread Keith Busch
Just had the one comment on patch 4, which is really no big deal. I need to integrate tooling and/or kernel support in order to properly test this, but just from code inspection, I think it's good. Reviewed-by: Keith Busch

Re: [PATCH v5 4/5] nvme: updated shared header for copy command

2021-02-03 Thread Klaus Jensen
On Feb 3 09:21, Keith Busch wrote: > On Fri, Jan 29, 2021 at 10:15:40AM +0100, Klaus Jensen wrote: > > From: Klaus Jensen > > > > Add new data structures and types for the Simple Copy command. > > > > Signed-off-by: Klaus Jensen > > Reviewed-by: Minwoo Im > > Acked-by: Stefan Hajnoczi > >

Re: [PATCH v2 20/36] block: add bdrv_attach_child_common() transaction action

2021-02-03 Thread Kevin Wolf
Am 27.11.2020 um 15:45 hat Vladimir Sementsov-Ogievskiy geschrieben: > Split out no-perm part of bdrv_root_attach_child() into separate > transaction action. bdrv_root_attach_child() now moves to new > permission update paradigm: first update graph relations then update > permissions. > >

[PATCH 3/4] hw/virtio/virtio-balloon: Remove the "class" property

2021-02-03 Thread Thomas Huth
This property was only required for compatibility reasons in the pc-1.0 machine type and earlier. Now that these machine types have been removed, the property is not useful anymore. Signed-off-by: Thomas Huth --- hw/virtio/virtio-balloon-pci.c | 11 +-- 1 file changed, 1 insertion(+),

Re: [PATCH v5 4/5] nvme: updated shared header for copy command

2021-02-03 Thread Keith Busch
On Fri, Jan 29, 2021 at 10:15:40AM +0100, Klaus Jensen wrote: > From: Klaus Jensen > > Add new data structures and types for the Simple Copy command. > > Signed-off-by: Klaus Jensen > Reviewed-by: Minwoo Im > Acked-by: Stefan Hajnoczi > --- > include/block/nvme.h | 45

[PATCH 4/4] hw/usb/bus: Remove the "full-path" property

2021-02-03 Thread Thomas Huth
This property was only required for the pc-1.0 and earlier machine types. Since these have been removed now, we can delete the property as well. Signed-off-by: Thomas Huth --- hw/usb/bus.c | 7 +-- include/hw/usb.h | 2 +- 2 files changed, 2 insertions(+), 7 deletions(-) diff --git

Re: [PATCH 1/4] hw/i386: Remove the deprecated pc-1.x machine types

2021-02-03 Thread Daniel P . Berrangé
On Wed, Feb 03, 2021 at 06:18:29PM +0100, Thomas Huth wrote: > They have been deprecated since QEMU v5.0, time to remove them now. > > Signed-off-by: Thomas Huth > --- > docs/system/deprecated.rst | 6 -- > docs/system/removed-features.rst | 6 ++ > hw/i386/pc_piix.c| 94

Re: [PATCH 3/4] hw/virtio/virtio-balloon: Remove the "class" property

2021-02-03 Thread David Hildenbrand
On 03.02.21 18:18, Thomas Huth wrote: This property was only required for compatibility reasons in the pc-1.0 machine type and earlier. Now that these machine types have been removed, the property is not useful anymore. Signed-off-by: Thomas Huth --- hw/virtio/virtio-balloon-pci.c | 11

Re: [PATCH v2 22/36] block: split out bdrv_replace_node_noperm()

2021-02-03 Thread Kevin Wolf
Am 27.11.2020 um 15:45 hat Vladimir Sementsov-Ogievskiy geschrieben: > Split part of bdrv_replace_node_common() to be used separately. > > Signed-off-by: Vladimir Sementsov-Ogievskiy > @@ -4909,7 +4936,6 @@ static int bdrv_replace_node_common(BlockDriverState > *from, >

[PATCH 2/4] hw/block/fdc: Remove the check_media_rate property

2021-02-03 Thread Thomas Huth
This was only required for the pc-1.0 and earlier machine types. Now that these have been removed, we can also drop the corresponding code from the FDC device. Signed-off-by: Thomas Huth --- hw/block/fdc.c | 17 ++--- tests/qemu-iotests/172.out | 35

Re: [PATCH v2 19/36] block: fix bdrv_replace_node_common

2021-02-03 Thread Kevin Wolf
Am 27.11.2020 um 15:45 hat Vladimir Sementsov-Ogievskiy geschrieben: > inore_children thing doesn't help to track all propagated permissions > of children we want to ignore. The simplest way to correctly update > permissions is update graph first and then do permission update. In > this case we

Re: [PATCH v5 0/5] hw/block/nvme: add simple copy command

2021-02-03 Thread Klaus Jensen
On Feb 3 09:27, Keith Busch wrote: > Just had the one comment on patch 4, which is really no big deal. I need > to integrate tooling and/or kernel support in order to properly test > this, but just from code inspection, I think it's good. > > Reviewed-by: Keith Busch > Thanks Keith!

Re: [PATCH v2 23/36] block: adapt bdrv_append() for inserting filters

2021-02-03 Thread Kevin Wolf
Am 27.11.2020 um 15:45 hat Vladimir Sementsov-Ogievskiy geschrieben: > bdrv_append is not very good for inserting filters: it does extra > permission update as part of bdrv_set_backing_hd(). During this update > filter may conflict with other parents of top_bs. > > Instead, let's first do all

Re: cdrom scsi passthough not working well

2021-02-03 Thread daggs
Greetings Philippe, > Sent: Wednesday, February 03, 2021 at 6:48 PM > From: "Philippe Mathieu-Daudé" > To: "daggs" , qemu-disc...@nongnu.org > Cc: "qemu-devel" , "Qemu-block" > Subject: Re: cdrom scsi passthough not working well > > Cc'ing qemu-block@ developers. > > On 10/28/20 6:18 AM, daggs

[PATCH] qemu-storage-daemon: Enable object-add

2021-02-03 Thread Kevin Wolf
As we don't have a fully QAPIfied version of object-add yet and it still has 'gen': false in the schema, it needs to be registered explicitly in init_qmp_commands() to be available for users. Fixes: 2af282ec51a27116d0402cab237b8970800f870c Signed-off-by: Kevin Wolf ---

Re: [PATCH v4 0/9] hw/sd: Support block read/write in SPI mode

2021-02-03 Thread Bin Meng
On Thu, Jan 28, 2021 at 2:30 PM Bin Meng wrote: > > From: Bin Meng > > This includes the previously v3 series [1], and one single patch [2]. > > Compared to v3, this fixed the following issue in patch [v3,6/6]: > - Keep the card state to SSI_SD_CMD instead of SSI_SD_RESPONSE after > receiving

Re: [PATCH v2 15/36] block: use topological sort for permission update

2021-02-03 Thread Vladimir Sementsov-Ogievskiy
03.02.2021 21:38, Kevin Wolf wrote: Am 28.01.2021 um 19:04 hat Vladimir Sementsov-Ogievskiy geschrieben: 28.01.2021 20:13, Kevin Wolf wrote: Am 28.01.2021 um 10:34 hat Vladimir Sementsov-Ogievskiy geschrieben: 27.01.2021 21:38, Kevin Wolf wrote: Am 27.11.2020 um 15:45 hat Vladimir

Re: [PATCH v2 19/36] block: fix bdrv_replace_node_common

2021-02-03 Thread Vladimir Sementsov-Ogievskiy
03.02.2021 21:23, Kevin Wolf wrote: Am 27.11.2020 um 15:45 hat Vladimir Sementsov-Ogievskiy geschrieben: inore_children thing doesn't help to track all propagated permissions of children we want to ignore. The simplest way to correctly update permissions is update graph first and then do

Re: [PATCH v2 20/36] block: add bdrv_attach_child_common() transaction action

2021-02-03 Thread Kevin Wolf
Am 04.02.2021 um 08:34 hat Vladimir Sementsov-Ogievskiy geschrieben: > 04.02.2021 00:01, Kevin Wolf wrote: > > Am 27.11.2020 um 15:45 hat Vladimir Sementsov-Ogievskiy geschrieben: > > > Split out no-perm part of bdrv_root_attach_child() into separate > > > transaction action.

Re: [PATCH v2 20/36] block: add bdrv_attach_child_common() transaction action

2021-02-03 Thread Vladimir Sementsov-Ogievskiy
04.02.2021 00:01, Kevin Wolf wrote: Am 27.11.2020 um 15:45 hat Vladimir Sementsov-Ogievskiy geschrieben: Split out no-perm part of bdrv_root_attach_child() into separate transaction action. bdrv_root_attach_child() now moves to new permission update paradigm: first update graph relations then

Re: [PATCH 03/12] qga: Replace '--blacklist' command line option by '--denylist'

2021-02-03 Thread Michael Roth
On Wed, Feb 03, 2021 at 04:47:08PM +0100, Kevin Wolf wrote: > Am 03.02.2021 um 13:45 hat BALATON Zoltan geschrieben: > > On Wed, 3 Feb 2021, Daniel P. Berrangé wrote: > > > On Tue, Feb 02, 2021 at 09:58:15PM +0100, Philippe Mathieu-Daudé wrote: > > > > Follow the inclusive terminology from the

Re: cdrom scsi passthough not working well

2021-02-03 Thread Philippe Mathieu-Daudé
Cc'ing qemu-block@ developers. On 10/28/20 6:18 AM, daggs wrote: > Greetings, > > I have a vm running under qemu 5.1.0 with a cdrom scsi passthough into it. > I can eject the device in and out but when I insert a disc, is isn't detected > and the dmesg on the guest is filled with these prints:

Re: [PATCH 1/1] docs: fix mistake in dirty bitmap feature description

2021-02-03 Thread Stefan Hajnoczi
On Wed, Feb 03, 2021 at 01:29:03PM +0300, Denis V. Lunev wrote: > On 2/3/21 2:08 AM, Eric Blake wrote: > > On 2/2/21 4:50 PM, Denis V. Lunev wrote: > >> On 2/3/21 1:15 AM, Eric Blake wrote: > >>> On 1/28/21 11:21 AM, Vladimir Sementsov-Ogievskiy wrote: > 28.01.2021 20:13, Denis V. Lunev

Re: [PATCH 01/12] ui: Replace the word 'whitelist'

2021-02-03 Thread Daniel P . Berrangé
On Tue, Feb 02, 2021 at 09:58:13PM +0100, Philippe Mathieu-Daudé wrote: > Follow the inclusive terminology from the "Conscious Language in your > Open Source Projects" guidelines [*] and replace the words "whitelist" > appropriately. > > [*]

Re: [PATCH 05/12] tools/virtiofsd: Replace the word 'whitelist'

2021-02-03 Thread Daniel P . Berrangé
On Tue, Feb 02, 2021 at 09:58:17PM +0100, Philippe Mathieu-Daudé wrote: > Follow the inclusive terminology from the "Conscious Language in your > Open Source Projects" guidelines [*] and replace the words "whitelist" > appropriately. > > [*]

Re: [PATCH] MAINTAINERS: suggest myself as co-maintainer for Block Jobs

2021-02-03 Thread Vladimir Sementsov-Ogievskiy
01.02.2021 19:20, Vladimir Sementsov-Ogievskiy wrote: 01.02.2021 17:50, Kevin Wolf wrote: Am 01.02.2021 um 12:03 hat Vladimir Sementsov-Ogievskiy geschrieben: 28.01.2021 18:28, John Snow wrote: On 1/28/21 10:09 AM, Markus Armbruster wrote: Vladimir Sementsov-Ogievskiy writes: I'm

Re: [PATCH 07/12] scripts/device-crash-test: Replace the word 'whitelist'

2021-02-03 Thread Philippe Mathieu-Daudé
On 2/2/21 9:58 PM, Philippe Mathieu-Daudé wrote: > Follow the inclusive terminology from the "Conscious Language in your > Open Source Projects" guidelines [*] and replace the word "whitelist" > appropriately. > > [*] https://github.com/conscious-lang/conscious-lang-docs/blob/main/faq.md > >

Re: [PATCH 01/12] ui: Replace the word 'whitelist'

2021-02-03 Thread Gerd Hoffmann
On Tue, Feb 02, 2021 at 09:58:13PM +0100, Philippe Mathieu-Daudé wrote: > Follow the inclusive terminology from the "Conscious Language in your > Open Source Projects" guidelines [*] and replace the words "whitelist" > appropriately. > > [*]

Re: [PATCH 04/12] qga: Replace the word 'blacklist'

2021-02-03 Thread Daniel P . Berrangé
On Tue, Feb 02, 2021 at 09:58:16PM +0100, Philippe Mathieu-Daudé wrote: > Follow the inclusive terminology from the "Conscious Language in your > Open Source Projects" guidelines [*] and replace the word "blacklist" > appropriately. > > [*]

Re: [PATCH 03/12] qga: Replace '--blacklist' command line option by '--denylist'

2021-02-03 Thread Daniel P . Berrangé
On Tue, Feb 02, 2021 at 09:58:15PM +0100, Philippe Mathieu-Daudé wrote: > Follow the inclusive terminology from the "Conscious Language in your > Open Source Projects" guidelines [*] and replace the word "blacklist" > appropriately. > > Keep the --blacklist available for backward compatibility. >

Re: [PATCH 05/12] tools/virtiofsd: Replace the word 'whitelist'

2021-02-03 Thread Dr. David Alan Gilbert
* Philippe Mathieu-Daudé (phi...@redhat.com) wrote: > Follow the inclusive terminology from the "Conscious Language in your > Open Source Projects" guidelines [*] and replace the words "whitelist" > appropriately. > > [*] https://github.com/conscious-lang/conscious-lang-docs/blob/main/faq.md > >

Re: [PATCH 11/12] tests/fp/fp-test: Replace the word 'blacklist'

2021-02-03 Thread Alex Bennée
Philippe Mathieu-Daudé writes: > Follow the inclusive terminology from the "Conscious Language in your > Open Source Projects" guidelines [*] and replace the word "blacklist" > appropriately. > > [*] https://github.com/conscious-lang/conscious-lang-docs/blob/main/faq.md > > Signed-off-by:

[PATCH 2/2] migration: dirty-bitmap: Allow control of bitmap persistence on destination

2021-02-03 Thread Peter Krempa
Bitmap's source persistence is transported over the migration stream and the destination mirrors it. In some cases the destination might want to persist bitmaps which are not persistent on the source (e.g. the result of merge of bitmaps from a number of layers on the source when migrating into a

Re: [PATCH 2/2] migration: dirty-bitmap: Allow control of bitmap persistence on destination

2021-02-03 Thread Peter Krempa
On Wed, Feb 03, 2021 at 14:27:49 +0100, Peter Krempa wrote: > On Wed, Feb 03, 2021 at 16:23:21 +0300, Vladimir Sementsov-Ogievskiy wrote: > > 03.02.2021 16:00, Peter Krempa wrote: > > > Bitmap's source persistence is transported over the migration stream and > > > the destination mirrors it. In

Re: [PATCH 03/12] qga: Replace '--blacklist' command line option by '--denylist'

2021-02-03 Thread BALATON Zoltan
On Wed, 3 Feb 2021, Daniel P. Berrangé wrote: On Tue, Feb 02, 2021 at 09:58:15PM +0100, Philippe Mathieu-Daudé wrote: Follow the inclusive terminology from the "Conscious Language in your Open Source Projects" guidelines [*] and replace the word "blacklist" appropriately. Keep the --blacklist

Re: [PATCH 1/4] block/nbd: fix drain dead-lock because of nbd reconnect-delay

2021-02-03 Thread Vladimir Sementsov-Ogievskiy
03.02.2021 13:53, Roman Kagan wrote: On Thu, Sep 03, 2020 at 10:02:58PM +0300, Vladimir Sementsov-Ogievskiy wrote: We pause reconnect process during drained section. So, if we have some requests, waiting for reconnect we should cancel them, otherwise they deadlock the drained section. How to

Re: [PATCH 2/2] migration: dirty-bitmap: Allow control of bitmap persistence on destination

2021-02-03 Thread Vladimir Sementsov-Ogievskiy
03.02.2021 16:00, Peter Krempa wrote: Bitmap's source persistence is transported over the migration stream and the destination mirrors it. In some cases the destination might want to persist bitmaps which are not persistent on the source (e.g. the result of merge of bitmaps from a number of

[PATCH 1/2] migration: dirty-bitmap: Convert alias map inner members to a struct

2021-02-03 Thread Peter Krempa
Currently the alias mapping hash stores just strings of the target objects internally. In further patches we'll be adding another member which will need to be stored in the map so convert the members to a struct. Signed-off-by: Peter Krempa --- migration/block-dirty-bitmap.c | 37

[PATCH 0/2] migration: dirty-bitmap: Allow control of bitmap persistence on destination

2021-02-03 Thread Peter Krempa
See 2/2 for explanation. Please let me know if I need to add any tests for this. Peter Krempa (2): migration: dirty-bitmap: Convert alias map inner members to a struct migration: dirty-bitmap: Allow control of bitmap persistence on destination migration/block-dirty-bitmap.c | 67

Re: [PATCH 2/2] migration: dirty-bitmap: Allow control of bitmap persistence on destination

2021-02-03 Thread Peter Krempa
On Wed, Feb 03, 2021 at 16:23:21 +0300, Vladimir Sementsov-Ogievskiy wrote: > 03.02.2021 16:00, Peter Krempa wrote: > > Bitmap's source persistence is transported over the migration stream and > > the destination mirrors it. In some cases the destination might want to > > persist bitmaps which are

Re: [PATCH 06/12] scripts/tracetool: Replace the word 'whitelist'

2021-02-03 Thread Daniel P . Berrangé
On Tue, Feb 02, 2021 at 09:58:18PM +0100, Philippe Mathieu-Daudé wrote: > Follow the inclusive terminology from the "Conscious Language in your > Open Source Projects" guidelines [*] and replace the words "whitelist" > appropriately. > > [*]

Re: [PATCH 09/12] qemu-options: Replace the word 'blacklist'

2021-02-03 Thread Daniel P . Berrangé
On Tue, Feb 02, 2021 at 09:58:21PM +0100, Philippe Mathieu-Daudé wrote: > Follow the inclusive terminology from the "Conscious Language in your > Open Source Projects" guidelines [*] and replace the word "blacklist" > appropriately. > > [*]

Re: [PATCH 07/12] scripts/device-crash-test: Replace the word 'whitelist'

2021-02-03 Thread Daniel P . Berrangé
On Tue, Feb 02, 2021 at 09:58:19PM +0100, Philippe Mathieu-Daudé wrote: > Follow the inclusive terminology from the "Conscious Language in your > Open Source Projects" guidelines [*] and replace the word "whitelist" > appropriately. > > [*]

Re: [PATCH 08/12] seccomp: Replace the word 'blacklist'

2021-02-03 Thread Daniel P . Berrangé
On Tue, Feb 02, 2021 at 09:58:20PM +0100, Philippe Mathieu-Daudé wrote: > Follow the inclusive terminology from the "Conscious Language in your > Open Source Projects" guidelines [*] and replace the word "blacklist" > appropriately. > > [*]

Re: [PATCH 10/12] tests/qemu-iotests: Replace the words 'blacklist/whitelist'

2021-02-03 Thread Daniel P . Berrangé
On Tue, Feb 02, 2021 at 09:58:22PM +0100, Philippe Mathieu-Daudé wrote: > Follow the inclusive terminology from the "Conscious Language in your > Open Source Projects" guidelines [*] and replace the words "blacklist" > and "whitelist" appropriately. > > [*]

Re: [PATCH 1/1] docs: fix mistake in dirty bitmap feature description

2021-02-03 Thread Denis V. Lunev
On 2/3/21 2:08 AM, Eric Blake wrote: > On 2/2/21 4:50 PM, Denis V. Lunev wrote: >> On 2/3/21 1:15 AM, Eric Blake wrote: >>> On 1/28/21 11:21 AM, Vladimir Sementsov-Ogievskiy wrote: 28.01.2021 20:13, Denis V. Lunev wrote: > Original specification says that l1 table size if 64 * l1_size,

Re: [PATCH 08/12] seccomp: Replace the word 'blacklist'

2021-02-03 Thread Eduardo Otubo
On 03/02/2021 - 10:15:55, Daniel P. Berrange wrote: > On Tue, Feb 02, 2021 at 09:58:20PM +0100, Philippe Mathieu-Daudé wrote: > > Follow the inclusive terminology from the "Conscious Language in your > > Open Source Projects" guidelines [*] and replace the word "blacklist" > > appropriately. > >

Re: [PATCH 02/12] qga: Rename config key 'blacklist' as 'denylist'

2021-02-03 Thread Daniel P . Berrangé
On Tue, Feb 02, 2021 at 09:58:14PM +0100, Philippe Mathieu-Daudé wrote: > Follow the inclusive terminology from the "Conscious Language in your > Open Source Projects" guidelines [*] and replace the word "blacklist" > appropriately. > > [*]

Re: [PATCH 12/12] hw/vfio/pci-quirks: Replace the word 'blacklist'

2021-02-03 Thread Daniel P . Berrangé
On Tue, Feb 02, 2021 at 09:58:24PM +0100, Philippe Mathieu-Daudé wrote: > Follow the inclusive terminology from the "Conscious Language in your > Open Source Projects" guidelines [*] and replace the word "blacklist" > appropriately. > > [*]

Re: [PATCH 11/12] tests/fp/fp-test: Replace the word 'blacklist'

2021-02-03 Thread Daniel P . Berrangé
On Tue, Feb 02, 2021 at 09:58:23PM +0100, Philippe Mathieu-Daudé wrote: > Follow the inclusive terminology from the "Conscious Language in your > Open Source Projects" guidelines [*] and replace the word "blacklist" > appropriately. > > [*]

Re: iotest failures in head [was: [PATCH v4 00/16] 64bit block-layer: part I]

2021-02-03 Thread Peter Maydell
On Tue, 2 Feb 2021 at 22:47, Peter Maydell wrote: > > On Tue, 2 Feb 2021 at 17:09, Vladimir Sementsov-Ogievskiy > wrote: > > Note that 30 is known to crash sometimes. Look at > > > > "[PATCH RFC 0/5] Fix accidental crash in iotest 30" > > > >

Re: [PATCH 1/4] block/nbd: fix drain dead-lock because of nbd reconnect-delay

2021-02-03 Thread Roman Kagan
On Thu, Sep 03, 2020 at 10:02:58PM +0300, Vladimir Sementsov-Ogievskiy wrote: > We pause reconnect process during drained section. So, if we have some > requests, waiting for reconnect we should cancel them, otherwise they > deadlock the drained section. > > How to reproduce: > > 1. Create an

Re: [PATCH 1/4] block/nbd: fix drain dead-lock because of nbd reconnect-delay

2021-02-03 Thread Roman Kagan
On Wed, Feb 03, 2021 at 05:44:34PM +0300, Vladimir Sementsov-Ogievskiy wrote: > 03.02.2021 17:21, Roman Kagan wrote: > > On Wed, Feb 03, 2021 at 04:10:41PM +0300, Vladimir Sementsov-Ogievskiy > > wrote: > > > 03.02.2021 13:53, Roman Kagan wrote: > > > > On Thu, Sep 03, 2020 at 10:02:58PM +0300,

Re: [PATCH 1/4] block/nbd: fix drain dead-lock because of nbd reconnect-delay

2021-02-03 Thread Roman Kagan
On Wed, Feb 03, 2021 at 04:10:41PM +0300, Vladimir Sementsov-Ogievskiy wrote: > 03.02.2021 13:53, Roman Kagan wrote: > > On Thu, Sep 03, 2020 at 10:02:58PM +0300, Vladimir Sementsov-Ogievskiy > > wrote: > > > We pause reconnect process during drained section. So, if we have some > > > requests,

[PULL v2 09/20] block: use int64_t as bytes type in tracked requests

2021-02-03 Thread Eric Blake
We are generally moving to int64_t for both offset and bytes parameters on all io paths. Main motivation is realization of 64-bit write_zeroes operation for fast zeroing large disk chunks, up to the whole disk. We chose signed type, to be consistent with off_t (which is signed) and with

[PULL v2 12/20] block/io: support int64_t bytes in bdrv_aligned_pwritev()

2021-02-03 Thread Eric Blake
From: Vladimir Sementsov-Ogievskiy We are generally moving to int64_t for both offset and bytes parameters on all io paths. Main motivation is realization of 64-bit write_zeroes operation for fast zeroing large disk chunks, up to the whole disk. We chose signed type, to be consistent with

Re: [PATCH 1/4] block/nbd: fix drain dead-lock because of nbd reconnect-delay

2021-02-03 Thread Vladimir Sementsov-Ogievskiy
03.02.2021 17:21, Roman Kagan wrote: On Wed, Feb 03, 2021 at 04:10:41PM +0300, Vladimir Sementsov-Ogievskiy wrote: 03.02.2021 13:53, Roman Kagan wrote: On Thu, Sep 03, 2020 at 10:02:58PM +0300, Vladimir Sementsov-Ogievskiy wrote: We pause reconnect process during drained section. So, if we

Re: [PATCH 2/2] migration: dirty-bitmap: Allow control of bitmap persistence on destination

2021-02-03 Thread Vladimir Sementsov-Ogievskiy
03.02.2021 16:39, Peter Krempa wrote: On Wed, Feb 03, 2021 at 14:27:49 +0100, Peter Krempa wrote: On Wed, Feb 03, 2021 at 16:23:21 +0300, Vladimir Sementsov-Ogievskiy wrote: 03.02.2021 16:00, Peter Krempa wrote: Bitmap's source persistence is transported over the migration stream and the

[PULL v2 05/20] block/io: refactor bdrv_pad_request(): move bdrv_pad_request() up

2021-02-03 Thread Eric Blake
From: Vladimir Sementsov-Ogievskiy Prepare for the following patch when bdrv_pad_request() will be able to fail. Update the comments. Signed-off-by: Vladimir Sementsov-Ogievskiy Message-Id: <20201211183934.169161-5-vsement...@virtuozzo.com> Reviewed-by: Eric Blake [eblake: grammar tweak]

Re: [PATCH 06/12] scripts/tracetool: Replace the word 'whitelist'

2021-02-03 Thread Stefan Hajnoczi
On Tue, Feb 02, 2021 at 09:58:18PM +0100, Philippe Mathieu-Daudé wrote: > Follow the inclusive terminology from the "Conscious Language in your > Open Source Projects" guidelines [*] and replace the words "whitelist" > appropriately. > > [*]

Re: [PATCH 03/12] qga: Replace '--blacklist' command line option by '--denylist'

2021-02-03 Thread Kevin Wolf
Am 03.02.2021 um 13:45 hat BALATON Zoltan geschrieben: > On Wed, 3 Feb 2021, Daniel P. Berrangé wrote: > > On Tue, Feb 02, 2021 at 09:58:15PM +0100, Philippe Mathieu-Daudé wrote: > > > Follow the inclusive terminology from the "Conscious Language in your > > > Open Source Projects" guidelines [*]

Re: [PATCH 10/12] tests/qemu-iotests: Replace the words 'blacklist/whitelist'

2021-02-03 Thread Daniel P . Berrangé
On Wed, Feb 03, 2021 at 04:41:33PM +0100, Kevin Wolf wrote: > Am 03.02.2021 um 11:28 hat Daniel P. Berrangé geschrieben: > > On Tue, Feb 02, 2021 at 09:58:22PM +0100, Philippe Mathieu-Daudé wrote: > > > Follow the inclusive terminology from the "Conscious Language in your > > > Open Source

Re: [PATCH] MAINTAINERS: suggest myself as co-maintainer for Block Jobs

2021-02-03 Thread John Snow
On 2/3/21 3:22 AM, Vladimir Sementsov-Ogievskiy wrote: 01.02.2021 19:20, Vladimir Sementsov-Ogievskiy wrote: 01.02.2021 17:50, Kevin Wolf wrote: Am 01.02.2021 um 12:03 hat Vladimir Sementsov-Ogievskiy geschrieben: 28.01.2021 18:28, John Snow wrote: On 1/28/21 10:09 AM, Markus Armbruster

Re: [PATCH 10/12] tests/qemu-iotests: Replace the words 'blacklist/whitelist'

2021-02-03 Thread Kevin Wolf
Am 03.02.2021 um 11:28 hat Daniel P. Berrangé geschrieben: > On Tue, Feb 02, 2021 at 09:58:22PM +0100, Philippe Mathieu-Daudé wrote: > > Follow the inclusive terminology from the "Conscious Language in your > > Open Source Projects" guidelines [*] and replace the words "blacklist" > > and