Re: [Qemu-block] [Qemu-devel] [PATCH] migration: flush the bdrv before stopping VM

2015-03-18 Thread Kevin Wolf
[ Cc: qemu-block ] Am 18.03.2015 um 04:19 hat Li, Liang Z geschrieben: This needs further review/changes on the block layer. First explanation, why I think this don't fix the full problem. Whith this patch, we fix the problem where we have a dirty block layer but basically nothing

Re: [Qemu-block] [PATCH] migration: flush the bdrv before stopping VM

2015-03-18 Thread Kevin Wolf
Am 18.03.2015 um 13:36 hat Juan Quintela geschrieben: Kevin Wolf kw...@redhat.com wrote: The problem is that the block layer really doesn't have an option to control what is getting synced once the data is cached outside of qemu. Essentially we can do an fdatasync() or we can leave

Re: [Qemu-block] [PATCH 0/2] Unbreak qemu-img error messages and iotests

2015-03-16 Thread Kevin Wolf
Am 14.03.2015 um 10:23 hat Markus Armbruster geschrieben: check -T -qcow2 now passes again. Sorry for the mess I made. Markus Armbruster (2): iotests: Update 051's reference output qemu-img: Fix convert, amend error messages for unknown options Thanks, applied to the block branch.

Re: [Qemu-block] [PATCH] block: Deprecate QCOW/QCOW2 encryption

2015-03-16 Thread Kevin Wolf
Am 13.03.2015 um 21:09 hat Markus Armbruster geschrieben: We've steered users away from QCOW/QCOW2 encryption for a while, because it's a flawed design (commit 136cd19 Describe flaws in qcow/qcow2 encryption in the docs). In addition to flawed crypto, we have comically bad usability, and

Re: [Qemu-block] [PATCH] block: Fix block-set-write-threshold not to use funky error class

2015-03-16 Thread Kevin Wolf
Am 13.03.2015 um 18:51 hat Markus Armbruster geschrieben: Error classes are a leftover from the days of rich error objects. New code should always use ERROR_CLASS_GENERIC_ERROR. Commit e246211 added a use of ERROR_CLASS_DEVICE_NOT_FOUND. Replace it. Signed-off-by: Markus Armbruster

[Qemu-block] [PULL 09/17] monitor: Convert bdrv_find to blk_by_name

2015-03-16 Thread Kevin Wolf
From: Fam Zheng f...@redhat.com Signed-off-by: Fam Zheng f...@redhat.com Message-id: 1425296209-1476-2-git-send-email-f...@redhat.com Reviewed-by: Max Reitz mre...@redhat.com Signed-off-by: Max Reitz mre...@redhat.com --- monitor.c | 9 + 1 file changed, 5 insertions(+), 4 deletions(-)

[Qemu-block] [PULL 06/17] qcow2: Respect new_block in alloc_refcount_block()

2015-03-16 Thread Kevin Wolf
...@redhat.com Reviewed-by: Kevin Wolf kw...@redhat.com Signed-off-by: Max Reitz mre...@redhat.com --- block/qcow2-refcount.c | 16 ++-- 1 file changed, 14 insertions(+), 2 deletions(-) diff --git a/block/qcow2-refcount.c b/block/qcow2-refcount.c index dc8d186..6cbae1d 100644 --- a/block/qcow2

[Qemu-block] [PULL 11/17] blockdev: Convert bdrv_find to blk_by_name

2015-03-16 Thread Kevin Wolf
From: Fam Zheng f...@redhat.com Signed-off-by: Fam Zheng f...@redhat.com Message-id: 1425296209-1476-4-git-send-email-f...@redhat.com Reviewed-by: Max Reitz mre...@redhat.com Signed-off-by: Max Reitz mre...@redhat.com --- blockdev.c | 92

[Qemu-block] [PULL 07/17] iotests: Add tests for refcount table growth

2015-03-16 Thread Kevin Wolf
From: Max Reitz mre...@redhat.com Signed-off-by: Max Reitz mre...@redhat.com Message-id: 1423598552-24301-3-git-send-email-mre...@redhat.com Reviewed-by: Eric Blake ebl...@redhat.com Reviewed-by: Kevin Wolf kw...@redhat.com Signed-off-by: Max Reitz mre...@redhat.com --- tests/qemu-iotests/121

[Qemu-block] [PULL 17/17] block/vpc: remove disabled code from get_sector_offset

2015-03-16 Thread Kevin Wolf
From: Peter Lieven p...@kamp.de The code to check the bitmap for the allocation status of each sector has been disabled by reason ever since the vpc driver existed. The reason might be that we might end up reading sector by sector in vpc_read if we really used it. This would be a performance

[Qemu-block] [PULL 12/17] block: Drop bdrv_find

2015-03-16 Thread Kevin Wolf
From: Fam Zheng f...@redhat.com All callers are converted, so drop it. Signed-off-by: Fam Zheng f...@redhat.com Message-id: 1425296209-1476-5-git-send-email-f...@redhat.com Reviewed-by: Max Reitz mre...@redhat.com Signed-off-by: Max Reitz mre...@redhat.com --- block.c | 9

[Qemu-block] [PULL 01/17] iotests: Update 051's reference output

2015-03-16 Thread Kevin Wolf
.out some more. Sorry! Signed-off-by: Markus Armbruster arm...@redhat.com Signed-off-by: Kevin Wolf kw...@redhat.com --- tests/qemu-iotests/051.out | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/tests/qemu-iotests/051.out b/tests/qemu-iotests/051.out index 09895e6..2890eac

[Qemu-block] [PULL 03/17] block: Deprecate QCOW/QCOW2 encryption

2015-03-16 Thread Kevin Wolf
...@redhat.com Signed-off-by: Kevin Wolf kw...@redhat.com --- block.c| 7 +++ qemu-doc.texi | 11 ++- tests/qemu-iotests/049.out | 6 ++ tests/qemu-iotests/087.out | 18 ++ 4 files changed, 37 insertions(+), 5 deletions(-) diff --git

[Qemu-block] [PULL 02/17] qemu-img: Fix convert, amend error messages for unknown options

2015-03-16 Thread Kevin Wolf
From: Markus Armbruster arm...@redhat.com Message quality regressed in commit dc523cd. Signed-off-by: Markus Armbruster arm...@redhat.com Signed-off-by: Kevin Wolf kw...@redhat.com --- qemu-img.c | 6 ++ tests/qemu-iotests/061.out | 1 - 2 files changed, 2 insertions(+), 5

[Qemu-block] [PULL 00/17] Block patches for 2.3.0-rc0

2015-03-16 Thread Kevin Wolf
Fam Zheng (4): monitor: Convert bdrv_find to blk_by_name migration: Convert bdrv_find to blk_by_name blockdev: Convert bdrv_find to blk_by_name block: Drop bdrv_find Kevin Wolf (2): vpc: Ignore geometry for large images Merge remote

Re: [Qemu-block] [PATCH] qemu-img: Avoid qerror_report_err() outside QMP handlers, again

2015-03-16 Thread Kevin Wolf
Am 12.03.2015 um 16:08 hat Markus Armbruster geschrieben: qerror_report_err() is a transitional interface to help with converting existing monitor commands to QMP. It should not be used elsewhere. Replace by error_report_err(). Commit 6936f29 cleaned that up in qemu-img.c, but two calls

Re: [Qemu-block] [PATCH] raw-posix: Deprecate host floppy passthrough

2015-03-19 Thread Kevin Wolf
Am 17.03.2015 um 17:02 hat Markus Armbruster geschrieben: Raise your hand if you have a physical floppy drive in a computer you've powered on in 2015. Okay, I see we got a few weirdos in the audience. That's okay, weirdos are welcome here. Kidding aside, media change detection doesn't

[Qemu-block] [PATCH for-2.3 v2] raw-posix: Deprecate aio=threads fallback without O_DIRECT

2015-03-19 Thread Kevin Wolf
Currently, if the user requests aio=native, but forgets to choose a cache mode that sets O_DIRECT, that request is silently ignored and raw falls back to aio=threads. Deprecate that behaviour so we can make it an error in future qemu versions. Signed-off-by: Kevin Wolf kw...@redhat.com --- v2

[Qemu-block] [PATCH v2 0/3] qemu-img convert: Rewrite copying logic

2015-03-19 Thread Kevin Wolf
of failing the conversion if bdrv_make_zero() returns an error [Max] - Set has_zero_init = true instead of 1 [Max] - Don't ignore error returns in a final blk_write_compressed() [Max] - Removed TODO comment after deciding that no change is needed - Many added tests Kevin Wolf (3): block-backend

Re: [Qemu-block] [PATCH] block: Fix blockdev-backup not to use funky error class

2015-03-19 Thread Kevin Wolf
Am 17.03.2015 um 08:36 hat Markus Armbruster geschrieben: Error classes are a leftover from the days of rich error objects. New code should always use ERROR_CLASS_GENERIC_ERROR. Commit b7b9d39..7c6a4ab added uses of ERROR_CLASS_DEVICE_NOT_FOUND. Replace them. Signed-off-by: Markus

Re: [Qemu-block] [Qemu-devel] block-commit dropping privs

2015-03-30 Thread Kevin Wolf
Am 27.03.2015 um 18:12 hat Eric Blake geschrieben: On 03/27/2015 09:36 AM, Michael Tokarev wrote: Wonder how to specify cache mode, or should I open these with proper O_DIRECT/O_SYNC/whatever? It looks like it's possible to change O_DIRECT at runtime but not O_SYNC. And the more

Re: [Qemu-block] block-commit dropping privs

2015-04-01 Thread Kevin Wolf
Am 01.04.2015 um 11:54 hat Michael Tokarev geschrieben: 01.04.2015 12:26, Michael Tokarev пишет: 30.03.2015 18:36, Kevin Wolf wrote: Am 27.03.2015 um 18:12 hat Eric Blake geschrieben: On 03/27/2015 09:36 AM, Michael Tokarev wrote: Wonder how to specify cache mode, or should I open

[Qemu-block] [PULL 1/3] raw-posix: Deprecate host floppy passthrough

2015-03-19 Thread Kevin Wolf
Reviewed-by: Max Reitz mre...@redhat.com Signed-off-by: Kevin Wolf kw...@redhat.com --- block/raw-posix.c| 2 ++ qapi/block-core.json | 2 ++ qemu-doc.texi| 5 +++-- qemu-options.hx | 3 +-- qmp-commands.hx | 2 +- 5 files changed, 9 insertions(+), 5 deletions(-) diff --git a/block

[Qemu-block] [PULL 3/3] block: Fix blockdev-backup not to use funky error class

2015-03-19 Thread Kevin Wolf
Reviewed-by: Eric Blake ebl...@redhat.com Signed-off-by: Kevin Wolf kw...@redhat.com --- blockdev.c | 8 qapi/block-core.json | 3 --- tests/qemu-iotests/055 | 11 +++ 3 files changed, 11 insertions(+), 11 deletions(-) diff --git a/blockdev.c b/blockdev.c index

Re: [Qemu-block] [PATCH] migration: flush the bdrv before stopping VM

2015-03-25 Thread Kevin Wolf
Am 25.03.2015 um 11:50 hat Juan Quintela geschrieben: Li, Liang Z liang.z...@intel.com wrote: Right now, we don't have an interface to detect that cases and got back to the iterative stage. How about go back to the iterative stage when detect that the pending_size is larger Than

Re: [Qemu-block] Enable debugging in a running vServer

2015-03-26 Thread Kevin Wolf
Am 26.03.2015 um 15:54 hat Peter Lieven geschrieben: Hi Block people, we recently observed some strange I/O stalls on some vServers. I suspect a bug in the target and already added some debugging output to libiscsi that could have helped to track the issue. However, to enable this

Re: [Qemu-block] qemu-img behavior for locating backing files

2015-04-02 Thread Kevin Wolf
Am 01.04.2015 um 18:16 hat John Snow geschrieben: Kevin, what's the correct behavior for qemu-img and relative paths when creating a new qcow2 file? Example: (in e.g. /home/qemu/build/ or anywhere not /home: ) qemu-img create -f qcow2 base.qcow2 32G qemu-img create -f qcow2 -F qcow2 -b

Re: [Qemu-block] [PATCH v2 0/3] qemu-img convert: Rewrite copying logic

2015-04-02 Thread Kevin Wolf
Am 19.03.2015 um 13:33 hat Kevin Wolf geschrieben: See the commit message of patch 2 for the background. v2: - Rebased. Commit f1d3cd79 changed many bdrv_* calls to blk_* calls. This version tries to keep those conversions and use BlockBackend where qemu.git master does or where

Re: [Qemu-block] block-commit dropping privs

2015-04-02 Thread Kevin Wolf
Am 02.04.2015 um 12:58 hat Michael Tokarev geschrieben: 01.04.2015 15:34, Kevin Wolf wrote: [] Overriding the backing file should work like this: -drive file=...,backing.file.filename=/dev/fdset/2 Oh-ok, this works. Sort of. Because after performing commit

Re: [Qemu-block] [PATCH] qmp: fill in the image field in BlockDeviceInfo

2015-04-21 Thread Kevin Wolf
Am 21.04.2015 um 15:28 hat Stefan Hajnoczi geschrieben: On Fri, Apr 17, 2015 at 02:52:43PM +0300, Alberto Garcia wrote: The image field in BlockDeviceInfo is supposed to contain an ImageInfo object. However that is being filled in by bdrv_query_info(), not by bdrv_block_device_info(), which

Re: [Qemu-block] [PATCH] qcow2: do lazy allocation of the L2 cache

2015-04-24 Thread Kevin Wolf
Am 24.04.2015 um 14:50 hat Alberto Garcia geschrieben: On Fri 24 Apr 2015 02:37:21 PM CEST, Stefan Hajnoczi wrote: I think it would be nice to have a way to free unused cache entries after a while. Do you think mmap plus a periodic timer would work? I'm hesitant about changes like

Re: [Qemu-block] [PATCH COLO v3 01/14] docs: block replication's description

2015-04-23 Thread Kevin Wolf
Am 23.04.2015 um 11:26 hat Paolo Bonzini geschrieben: On 23/04/2015 11:00, Kevin Wolf wrote: Because it may be the right design. If you're really worried about the test matrix, put a check in the filter block driver that its bs-file is qcow2. Of course, such an artificial

Re: [Qemu-block] [PATCH COLO v3 01/14] docs: block replication's description

2015-04-23 Thread Kevin Wolf
Am 23.04.2015 um 12:05 hat Paolo Bonzini geschrieben: On 23/04/2015 11:14, Wen Congyang wrote: The bs-file-driver should support backing file, and use backing reference already. What about the primary side? We should control when to connect to NBD server, not in nbd_open(). Why

Re: [Qemu-block] [PATCH COLO v3 01/14] docs: block replication's description

2015-04-23 Thread Kevin Wolf
Am 23.04.2015 um 12:33 hat Paolo Bonzini geschrieben: On 23/04/2015 12:17, Kevin Wolf wrote: Perhaps quorum is not a great match after all, and it's better to add a new colo driver similar to quorum but simpler and only using the read policy that you need for colo. The new driver would

Re: [Qemu-block] [PATCH COLO v3 01/14] docs: block replication's description

2015-04-23 Thread Kevin Wolf
Am 23.04.2015 um 12:44 hat Paolo Bonzini geschrieben: On 23/04/2015 12:40, Kevin Wolf wrote: The question that is still open for me is whether it would be a colo.c or an active-mirror.c, i.e. if this would be tied specifically to COLO or if it could be kept generic enough that it could

Re: [Qemu-block] [PATCH COLO v3 01/14] docs: block replication's description

2015-04-22 Thread Kevin Wolf
Am 21.04.2015 um 17:28 hat Paolo Bonzini geschrieben: On 21/04/2015 03:25, Wen Congyang wrote: Please do not introduce name+colo block drivers. This approach is invasive and makes block replication specific to only a few block drivers, e.g. NBD or qcow2. NBD is used to connect to

Re: [Qemu-block] [PULL 76/76] block: move I/O request processing to block/io.c

2015-04-29 Thread Kevin Wolf
Am 28.04.2015 um 19:15 hat Eric Blake geschrieben: On 04/28/2015 09:00 AM, Kevin Wolf wrote: From: Stefan Hajnoczi stefa...@redhat.com The block.c file has grown to over 6000 lines. It is time to split this file so there are fewer conflicts and the code is easier to maintain

[Qemu-block] [PULL 04/76] hw/arm/nseries: convert ffs(3) to ctz32()

2015-04-28 Thread Kevin Wolf
-send-email-stefa...@redhat.com Signed-off-by: Kevin Wolf kw...@redhat.com --- hw/arm/nseries.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/hw/arm/nseries.c b/hw/arm/nseries.c index 2a5406d..d243159 100644 --- a/hw/arm/nseries.c +++ b/hw/arm/nseries.c @@ -579,7 +579,10

[Qemu-block] [PULL 02/76] MAINTAINERS: Add myself as the maintainer of the Quorum driver

2015-04-28 Thread Kevin Wolf
From: Alberto Garcia be...@igalia.com Signed-off-by: Alberto Garcia be...@igalia.com Message-id: 1426522925-1-1-git-send-email-be...@igalia.com Signed-off-by: Stefan Hajnoczi stefa...@redhat.com Signed-off-by: Kevin Wolf kw...@redhat.com --- MAINTAINERS | 6 ++ 1 file changed, 6

[Qemu-block] [PULL 39/76] qmp: fill in the image field in BlockDeviceInfo

2015-04-28 Thread Kevin Wolf
-send-email-be...@igalia.com Signed-off-by: Stefan Hajnoczi stefa...@redhat.com Signed-off-by: Kevin Wolf kw...@redhat.com --- block.c | 9 +++-- block/qapi.c | 46 +- blockdev.c| 2 +- include/block/block.h | 2

[Qemu-block] [PULL 56/76] block: Add bitmap disabled status

2015-04-28 Thread Kevin Wolf
-by: Max Reitz mre...@redhat.com Reviewed-by: Stefan Hajnoczi stefa...@redhat.com Message-id: 1429314609-29776-9-git-send-email-js...@redhat.com Signed-off-by: Stefan Hajnoczi stefa...@redhat.com Signed-off-by: Kevin Wolf kw...@redhat.com --- block.c | 25

[Qemu-block] [PULL 51/76] qmp: Ensure consistent granularity type

2015-04-28 Thread Kevin Wolf
...@redhat.com Message-id: 1429314609-29776-4-git-send-email-js...@redhat.com Signed-off-by: Stefan Hajnoczi stefa...@redhat.com Signed-off-by: Kevin Wolf kw...@redhat.com --- block.c | 11 ++- block/mirror.c| 4 ++-- include/block/block.h | 2 +- include

[Qemu-block] [PULL 54/76] hbitmap: cache array lengths

2015-04-28 Thread Kevin Wolf
...@redhat.com Reviewed-by: Eric Blake ebl...@redhat.com Signed-off-by: John Snow js...@redhat.com Reviewed-by: Stefan Hajnoczi stefa...@redhat.com Message-id: 1429314609-29776-7-git-send-email-js...@redhat.com Signed-off-by: Stefan Hajnoczi stefa...@redhat.com Signed-off-by: Kevin Wolf kw...@redhat.com

[Qemu-block] [PULL 57/76] block: Add bitmap successors

2015-04-28 Thread Kevin Wolf
-id: 1429314609-29776-10-git-send-email-js...@redhat.com Signed-off-by: Stefan Hajnoczi stefa...@redhat.com Signed-off-by: Kevin Wolf kw...@redhat.com --- block.c | 104 +- blockdev.c| 7 include/block/block.h | 10

[Qemu-block] [PULL 55/76] hbitmap: add hbitmap_merge

2015-04-28 Thread Kevin Wolf
...@redhat.com Reviewed-by: Eric Blake ebl...@redhat.com Reviewed-by: Stefan Hajnoczi stefa...@redhat.com Message-id: 1429314609-29776-8-git-send-email-js...@redhat.com Signed-off-by: Stefan Hajnoczi stefa...@redhat.com Signed-off-by: Kevin Wolf kw...@redhat.com --- include/qemu/hbitmap.h | 13

[Qemu-block] [PULL 06/76] Convert (ffs(val) - 1) to ctz32(val)

2015-04-28 Thread Kevin Wolf
, asserts, etc). Therefore we don't need to worry about the fact that ctz32(0) == 32. Signed-off-by: Stefan Hajnoczi stefa...@redhat.com Message-id: 1427124571-28598-5-git-send-email-stefa...@redhat.com Signed-off-by: Kevin Wolf kw...@redhat.com --- block.c| 2 +- block/qcow2

[Qemu-block] [PULL 15/76] iothread: release iothread around aio_poll

2015-04-28 Thread Kevin Wolf
stefa...@redhat.com Signed-off-by: Kevin Wolf kw...@redhat.com --- async.c | 8 +--- iothread.c | 11 ++- tests/test-aio.c | 19 +++ 3 files changed, 14 insertions(+), 24 deletions(-) diff --git a/async.c b/async.c index 77d080d..46d9e63 100644

[Qemu-block] [PULL 27/76] block: Pause block jobs in bdrv_drain_all

2015-04-28 Thread Kevin Wolf
be...@igalia.com Message-id: 1428069921-2957-3-git-send-email-f...@redhat.com Signed-off-by: Stefan Hajnoczi stefa...@redhat.com Signed-off-by: Kevin Wolf kw...@redhat.com --- block.c | 20 1 file changed, 20 insertions(+) diff --git a/block.c b/block.c index 670d7e4..70aed80

[Qemu-block] [PULL 26/76] blockjob: Allow nested pause

2015-04-28 Thread Kevin Wolf
Reviewed-by: Alberto Garcia be...@igalia.com Message-id: 1428069921-2957-2-git-send-email-f...@redhat.com Signed-off-by: Stefan Hajnoczi stefa...@redhat.com Signed-off-by: Kevin Wolf kw...@redhat.com --- block/mirror.c | 2 +- blockdev.c | 8 +--- blockjob.c

[Qemu-block] [PULL 30/76] block: avoid unnecessary bottom halves

2015-04-28 Thread Kevin Wolf
-by: Stefan Hajnoczi stefa...@redhat.com Signed-off-by: Kevin Wolf kw...@redhat.com --- block.c | 43 ++- 1 file changed, 34 insertions(+), 9 deletions(-) diff --git a/block.c b/block.c index 70aed80..d13b2e7 100644 --- a/block.c +++ b/block.c @@ -4849,6 +4849,7

[Qemu-block] [PULL 28/76] qemu-iotests: Test that stop doesn't drain block jobs

2015-04-28 Thread Kevin Wolf
Hajnoczi stefa...@redhat.com Signed-off-by: Kevin Wolf kw...@redhat.com --- tests/qemu-iotests/129 | 86 ++ tests/qemu-iotests/129.out | 5 +++ tests/qemu-iotests/group | 1 + 3 files changed, 92 insertions(+) create mode 100644 tests/qemu

[Qemu-block] [PULL 61/76] block: add BdrvDirtyBitmap documentation

2015-04-28 Thread Kevin Wolf
-by: Kevin Wolf kw...@redhat.com --- block.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/block.c b/block.c index f0157d5..4121929 100644 --- a/block.c +++ b/block.c @@ -61,11 +61,11 @@ * or enabled. A frozen bitmap can only abdicate() or reclaim(). */ struct

[Qemu-block] [PULL 03/76] bt-sdp: fix broken uuids power-of-2 calculation

2015-04-28 Thread Kevin Wolf
...@redhat.com Signed-off-by: Kevin Wolf kw...@redhat.com --- hw/bt/sdp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/bt/sdp.c b/hw/bt/sdp.c index 218e075..c903747 100644 --- a/hw/bt/sdp.c +++ b/hw/bt/sdp.c @@ -707,7 +707,7 @@ static void sdp_service_record_build(struct

[Qemu-block] [PULL 29/76] blockjob: Update function name in comments

2015-04-28 Thread Kevin Wolf
Hajnoczi stefa...@redhat.com Signed-off-by: Kevin Wolf kw...@redhat.com --- block/backup.c | 2 +- block/mirror.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/block/backup.c b/block/backup.c index 1c535b1..3312476 100644 --- a/block/backup.c +++ b/block/backup.c @@ -287,7

[Qemu-block] [PULL 47/76] block/iscsi: bump year in copyright notice

2015-04-28 Thread Kevin Wolf
From: Peter Lieven p...@kamp.de Signed-off-by: Peter Lieven p...@kamp.de Message-id: 1429193313-4263-9-git-send-email...@kamp.de Signed-off-by: Stefan Hajnoczi stefa...@redhat.com Signed-off-by: Kevin Wolf kw...@redhat.com --- block/iscsi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion

[Qemu-block] [PULL 60/76] qmp: Add dirty bitmap status field in query-block

2015-04-28 Thread Kevin Wolf
Reviewed-by: Eric Blake ebl...@redhat.com Message-id: 1429314609-29776-13-git-send-email-js...@redhat.com Signed-off-by: Stefan Hajnoczi stefa...@redhat.com Signed-off-by: Kevin Wolf kw...@redhat.com --- block.c | 1 + qapi/block-core.json | 5 - 2 files changed, 5 insertions(+), 1

[Qemu-block] [PULL 65/76] iotests: add invalid input incremental backup tests

2015-04-28 Thread Kevin Wolf
-by: Kevin Wolf kw...@redhat.com --- tests/qemu-iotests/124 | 104 + tests/qemu-iotests/124.out | 5 +++ tests/qemu-iotests/group | 1 + 3 files changed, 110 insertions(+) create mode 100644 tests/qemu-iotests/124 create mode 100644 tests/qemu

[Qemu-block] [PULL 43/76] block/iscsi: store DPOFUA bit from the modesense command

2015-04-28 Thread Kevin Wolf
From: Peter Lieven p...@kamp.de Signed-off-by: Peter Lieven p...@kamp.de Message-id: 1429193313-4263-5-git-send-email...@kamp.de Signed-off-by: Stefan Hajnoczi stefa...@redhat.com Signed-off-by: Kevin Wolf kw...@redhat.com --- block/iscsi.c | 3 +++ 1 file changed, 3 insertions(+) diff --git

[Qemu-block] [PULL 46/76] block/iscsi: handle SCSI_STATUS_TASK_SET_FULL

2015-04-28 Thread Kevin Wolf
-off-by: Kevin Wolf kw...@redhat.com --- block/iscsi.c | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/block/iscsi.c b/block/iscsi.c index 5999f74..328907b 100644 --- a/block/iscsi.c +++ b/block/iscsi.c @@ -186,10 +186,13 @@ iscsi_co_generic_cb(struct iscsi_context *iscsi

[Qemu-block] [PULL 75/76] block: extract bdrv_setup_io_funcs()

2015-04-28 Thread Kevin Wolf
From: Stefan Hajnoczi stefa...@redhat.com Move the code to install coroutine and aio emulation function pointers in a BlockDriver to its own function. Signed-off-by: Stefan Hajnoczi stefa...@redhat.com Signed-off-by: Kevin Wolf kw...@redhat.com --- block.c | 7 ++- include

[Qemu-block] [PULL 66/76] iotests: add QMP event waiting queue

2015-04-28 Thread Kevin Wolf
but no events have occurred. Signed-off-by: John Snow js...@redhat.com Reviewed-by: Max Reitz mre...@redhat.com Reviewed-by: Stefan Hajnoczi stefa...@redhat.com Message-id: 1429314609-29776-19-git-send-email-js...@redhat.com Signed-off-by: Stefan Hajnoczi stefa...@redhat.com Signed-off-by: Kevin Wolf

[Qemu-block] [PULL 17/76] qemu-img convert: Rewrite copying logic

2015-04-28 Thread Kevin Wolf
-by: Kevin Wolf kw...@redhat.com Reviewed-by: Max Reitz mre...@redhat.com --- qemu-img.c | 516 + 1 file changed, 310 insertions(+), 206 deletions(-) diff --git a/qemu-img.c b/qemu-img.c index 9dddfbe..8d30e43 100644 --- a/qemu-img.c +++ b/qemu

[Qemu-block] [PULL 19/76] blkdebug: Add bdrv_truncate()

2015-04-28 Thread Kevin Wolf
This is, amongst others, required for qemu-iotests 033 to run as intended on VHDX, which uses explicit bdrv_truncate() calls to bs-file when allocating new blocks. Signed-off-by: Kevin Wolf kw...@redhat.com Reviewed-by: Jeff Cody jc...@redhat.com --- block/blkdebug.c | 6 ++ 1 file changed

[Qemu-block] [PULL 09/76] omap_intc: convert ffs(3) to ctz32() in omap_inth_sir_update()

2015-04-28 Thread Kevin Wolf
...@redhat.com Signed-off-by: Stefan Hajnoczi stefa...@redhat.com Message-id: 1427124571-28598-8-git-send-email-stefa...@redhat.com Signed-off-by: Kevin Wolf kw...@redhat.com --- hw/intc/omap_intc.c | 9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/hw/intc/omap_intc.c b/hw

[Qemu-block] [PULL 33/76] m25p80: fix s-blk usage before assignment

2015-04-28 Thread Kevin Wolf
-by: Paolo Bonzini pbonz...@redhat.com Message-id: 1429091024-25098-1-git-send-email-stefa...@redhat.com Signed-off-by: Kevin Wolf kw...@redhat.com --- hw/block/m25p80.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/hw/block/m25p80.c b/hw/block/m25p80.c index 728e384..efc43dd

[Qemu-block] [PULL 45/76] block/iscsi: increase retry count

2015-04-28 Thread Kevin Wolf
...@kamp.de Signed-off-by: Stefan Hajnoczi stefa...@redhat.com Signed-off-by: Kevin Wolf kw...@redhat.com --- block/iscsi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/block/iscsi.c b/block/iscsi.c index 600..5999f74 100644 --- a/block/iscsi.c +++ b/block/iscsi.c @@ -103,7

[Qemu-block] [PULL 48/76] block/iscsi: use the allocationmap also if cache.direct=on

2015-04-28 Thread Kevin Wolf
with cache.direct=on. Signed-off-by: Peter Lieven p...@kamp.de Message-id: 1429193313-4263-10-git-send-email...@kamp.de Signed-off-by: Stefan Hajnoczi stefa...@redhat.com Signed-off-by: Kevin Wolf kw...@redhat.com --- block/iscsi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[Qemu-block] [PULL 05/76] uninorth: convert ffs(3) to ctz32()

2015-04-28 Thread Kevin Wolf
-email-stefa...@redhat.com Signed-off-by: Kevin Wolf kw...@redhat.com --- hw/pci-host/uninorth.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/hw/pci-host/uninorth.c b/hw/pci-host/uninorth.c index 53f2b59..f0144eb 100644 --- a/hw/pci-host/uninorth.c +++ b/hw/pci-host

[Qemu-block] [PULL 20/76] vhdx: Fix zero-fill iov length

2015-04-28 Thread Kevin Wolf
-by: Kevin Wolf kw...@redhat.com Acked-by: Jeff Cody jc...@redhat.com --- block/vhdx.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/block/vhdx.c b/block/vhdx.c index bb3ed45..e24062f 100644 --- a/block/vhdx.c +++ b/block/vhdx.c @@ -1269,7 +1269,7 @@ static coroutine_fn int

[Qemu-block] [PULL 21/76] thread-pool: clean up thread_pool_completion_bh()

2015-04-28 Thread Kevin Wolf
. The QLIST_REMOVE() is duplicated down both branches of an if-else statement so that can be lifted out as well. Signed-off-by: Stefan Hajnoczi stefa...@redhat.com Reviewed-by: Paolo Bonzini pbonz...@redhat.com Message-id: 1427992762-10126-1-git-send-email-stefa...@redhat.com Signed-off-by: Kevin Wolf kw

[Qemu-block] [PULL 22/76] scripts: add 'qemu coroutine' command to qemu-gdb.py

2015-04-28 Thread Kevin Wolf
) at coroutine-ucontext.c:80 #3 0x708de000 in __start_context () at /lib64/libc.so.6 Signed-off-by: Stefan Hajnoczi stefa...@redhat.com Message-id: 1427409754-8556-1-git-send-email-stefa...@redhat.com Signed-off-by: Kevin Wolf kw...@redhat.com --- scripts/qemu-gdb.py | 75

[Qemu-block] [PULL 50/76] qapi: Add optional field name to block dirty bitmap

2015-04-28 Thread Kevin Wolf
...@redhat.com Reviewed-by: Max Reitz mre...@redhat.com Reviewed-by: Eric Blake ebl...@redhat.com Reviewed-by: Stefan Hajnoczi stefa...@redhat.com Message-id: 1429314609-29776-3-git-send-email-js...@redhat.com Signed-off-by: Stefan Hajnoczi stefa...@redhat.com Signed-off-by: Kevin Wolf kw...@redhat.com

[Qemu-block] [PULL 44/76] block/iscsi: optimize WRITE10/16 if cache.writeback is not set

2015-04-28 Thread Kevin Wolf
by a FLUSH. This is 2 round trip times. If we set the FUA bit we can ignore the following FLUSH. Signed-off-by: Peter Lieven p...@kamp.de Message-id: 1429193313-4263-6-git-send-email...@kamp.de Signed-off-by: Stefan Hajnoczi stefa...@redhat.com Signed-off-by: Kevin Wolf kw...@redhat.com --- block

[Qemu-block] [PULL 52/76] qmp: Add block-dirty-bitmap-add and block-dirty-bitmap-remove

2015-04-28 Thread Kevin Wolf
-by: Eric Blake ebl...@redhat.com Message-id: 1429314609-29776-5-git-send-email-js...@redhat.com Signed-off-by: Stefan Hajnoczi stefa...@redhat.com Signed-off-by: Kevin Wolf kw...@redhat.com --- block.c | 20 + block/mirror.c| 10 + blockdev.c| 117

[Qemu-block] [PULL 72/76] vmdk: Widen before shifting 32 bit header field

2015-04-28 Thread Kevin Wolf
From: Fam Zheng f...@redhat.com Coverity spotted this. The field is 32 bits, but if it's possible to overflow in 32 bit left shift. Signed-off-by: Fam Zheng f...@redhat.com Reviewed-by: John Snow js...@redhat.com Signed-off-by: Kevin Wolf kw...@redhat.com --- block/vmdk.c | 2 +- 1 file

[Qemu-block] [PULL 71/76] block/dmg: make it modular

2015-04-28 Thread Kevin Wolf
From: Michael Tokarev m...@tls.msk.ru dmg can optionally utilize libbz2, make it modular Signed-off-by: Michael Tokarev m...@tls.msk.ru Reviewed-by: Paolo Bonzini pbonz...@redhat.com Signed-off-by: Kevin Wolf kw...@redhat.com --- block/Makefile.objs | 3 ++- 1 file changed, 2 insertions(+), 1

[Qemu-block] [PULL 74/76] block: add bdrv_set_dirty()/bdrv_reset_dirty() to block_int.h

2015-04-28 Thread Kevin Wolf
From: Stefan Hajnoczi stefa...@redhat.com The dirty bitmap functions are called from the block I/O processing code. Make them visible to block_int.h users so they can be used outside block.c. Signed-off-by: Stefan Hajnoczi stefa...@redhat.com Signed-off-by: Kevin Wolf kw...@redhat.com

[Qemu-block] [PULL 13/76] aio-posix: move pollfds to thread-local storage

2015-04-28 Thread Kevin Wolf
(npfd == 0) assertion failure in pollfds_cleanup(). --Stefan] Signed-off-by: Paolo Bonzini pbonz...@redhat.com Reviewed-by: Stefan Hajnoczi stefa...@redhat.com Message-id: 1424449612-18215-2-git-send-email-pbonz...@redhat.com Signed-off-by: Stefan Hajnoczi stefa...@redhat.com Signed-off-by: Kevin

[Qemu-block] [PULL 14/76] AioContext: acquire/release AioContext during aio_poll

2015-04-28 Thread Kevin Wolf
-email-pbonz...@redhat.com Signed-off-by: Stefan Hajnoczi stefa...@redhat.com Signed-off-by: Kevin Wolf kw...@redhat.com --- aio-posix.c | 9 + aio-win32.c | 8 include/block/aio.h | 13 +++-- 3 files changed, 24 insertions(+), 6 deletions(-) diff --git

[Qemu-block] [PULL 10/76] os-win32: drop ffs(3) prototype

2015-04-28 Thread Kevin Wolf
to ctz32() there is no need for ffs(3). Signed-off-by: Stefan Hajnoczi stefa...@redhat.com Message-id: 1427124571-28598-9-git-send-email-stefa...@redhat.com Signed-off-by: Kevin Wolf kw...@redhat.com --- include/sysemu/os-win32.h | 3 --- 1 file changed, 3 deletions(-) diff --git a/include/sysemu

[Qemu-block] [PULL 25/76] MAINTAINERS: Add Fam Zheng as Null block driver maintainer

2015-04-28 Thread Kevin Wolf
From: Fam Zheng f...@redhat.com Signed-off-by: Fam Zheng f...@redhat.com Reviewed-by: Eric Blake ebl...@redhat.com Reviewed-by: Stefan Hajnoczi stefa...@redhat.com Message-id: 1427852740-24315-4-git-send-email-f...@redhat.com Signed-off-by: Stefan Hajnoczi stefa...@redhat.com Signed-off-by: Kevin

[Qemu-block] [PULL 35/76] block: add bdrv_get_device_or_node_name()

2015-04-28 Thread Kevin Wolf
: 4fa30aa8d61d9052ce266fd5429a59a14e941255.1428485266.git.be...@igalia.com Signed-off-by: Stefan Hajnoczi stefa...@redhat.com Signed-off-by: Kevin Wolf kw...@redhat.com --- block.c | 9 + block/quorum.c| 5 + include/block/block.h | 1 + 3 files changed, 11

[Qemu-block] [PULL 23/76] block/null: Latency simulation by adding new option latency-ns

2015-04-28 Thread Kevin Wolf
-email-f...@redhat.com Signed-off-by: Stefan Hajnoczi stefa...@redhat.com Signed-off-by: Kevin Wolf kw...@redhat.com --- block/null.c | 58 ++-- qapi/block-core.json | 5 - 2 files changed, 56 insertions(+), 7 deletions(-) diff --git

[Qemu-block] [PULL 53/76] block: Introduce bdrv_dirty_bitmap_granularity()

2015-04-28 Thread Kevin Wolf
-by: Stefan Hajnoczi stefa...@redhat.com Message-id: 1429314609-29776-6-git-send-email-js...@redhat.com Signed-off-by: Stefan Hajnoczi stefa...@redhat.com Signed-off-by: Kevin Wolf kw...@redhat.com --- block.c | 8 ++-- include/block/block.h | 1 + 2 files changed, 7 insertions(+), 2

[Qemu-block] [PULL 24/76] block/null: Support reopen

2015-04-28 Thread Kevin Wolf
-by: Eric Blake ebl...@redhat.com Reviewed-by: Stefan Hajnoczi stefa...@redhat.com Message-id: 1427852740-24315-3-git-send-email-f...@redhat.com Signed-off-by: Stefan Hajnoczi stefa...@redhat.com Signed-off-by: Kevin Wolf kw...@redhat.com --- block/null.c | 8 1 file changed, 8 insertions

[Qemu-block] [PULL 32/76] m25p80: add missing blk_attach_dev_nofail

2015-04-28 Thread Kevin Wolf
...@redhat.com Signed-off-by: Kevin Wolf kw...@redhat.com --- hw/block/m25p80.c | 1 + 1 file changed, 1 insertion(+) diff --git a/hw/block/m25p80.c b/hw/block/m25p80.c index afe243b..728e384 100644 --- a/hw/block/m25p80.c +++ b/hw/block/m25p80.c @@ -629,6 +629,7 @@ static int m25p80_init(SSISlave *ss

[Qemu-block] [PULL 34/76] block: document block-stream in qmp-commands.hx

2015-04-28 Thread Kevin Wolf
-by: Stefan Hajnoczi stefa...@redhat.com Reviewed-by: Eric Blake ebl...@redhat.com Reviewed-by: Max Reitz mre...@redhat.com Message-id: 1429094622-26218-1-git-send-email-stefa...@redhat.com Signed-off-by: Kevin Wolf kw...@redhat.com --- qmp-commands.hx | 37 + 1 file

[Qemu-block] [PULL 68/76] iotests: add incremental backup failure recovery test

2015-04-28 Thread Kevin Wolf
-by: Stefan Hajnoczi stefa...@redhat.com Signed-off-by: Kevin Wolf kw...@redhat.com --- tests/qemu-iotests/124 | 57 ++ tests/qemu-iotests/124.out | 4 ++-- 2 files changed, 59 insertions(+), 2 deletions(-) diff --git a/tests/qemu-iotests/124 b/tests/qemu

[Qemu-block] [PULL 73/76] block: replace bdrv_states iteration with bdrv_next()

2015-04-28 Thread Kevin Wolf
to the public bdrv_next() interface. Reviewed-by: Alberto Garcia be...@igalia.com Signed-off-by: Stefan Hajnoczi stefa...@redhat.com Signed-off-by: Kevin Wolf kw...@redhat.com --- block.c | 14 -- 1 file changed, 8 insertions(+), 6 deletions(-) diff --git a/block.c b/block.c index ec23594

[Qemu-block] [PULL 63/76] block: Resize bitmaps on bdrv_truncate

2015-04-28 Thread Kevin Wolf
-by: Kevin Wolf kw...@redhat.com --- block.c| 18 ++ include/qemu/hbitmap.h | 10 ++ util/hbitmap.c | 48 3 files changed, 76 insertions(+) diff --git a/block.c b/block.c index b7d6df5..ec23594 100644

[Qemu-block] [PULL 70/76] block/mirror: Always call block_job_sleep_ns()

2015-04-28 Thread Kevin Wolf
-by: Max Reitz mre...@redhat.com Reviewed-by: Fam Zheng f...@redhat.com Reviewed-by: Paolo Bonzini pbonz...@redhat.com Signed-off-by: Kevin Wolf kw...@redhat.com --- block/mirror.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/block/mirror.c b/block/mirror.c index d53e60e..58f391a 100644

[Qemu-block] [PULL 64/76] hbitmap: truncate tests

2015-04-28 Thread Kevin Wolf
-17-git-send-email-js...@redhat.com Signed-off-by: Stefan Hajnoczi stefa...@redhat.com Signed-off-by: Kevin Wolf kw...@redhat.com --- tests/test-hbitmap.c | 255 +++ 1 file changed, 255 insertions(+) diff --git a/tests/test-hbitmap.c b/tests/test

[Qemu-block] [PULL 62/76] block: Ensure consistent bitmap function prototypes

2015-04-28 Thread Kevin Wolf
-email-js...@redhat.com Signed-off-by: Stefan Hajnoczi stefa...@redhat.com Signed-off-by: Kevin Wolf kw...@redhat.com --- block.c | 13 ++--- block/backup.c| 2 +- block/mirror.c| 26 ++ blockdev.c| 2 +- include/block

[Qemu-block] [PULL 69/76] iotests: add incremental backup granularity tests

2015-04-28 Thread Kevin Wolf
-by: Stefan Hajnoczi stefa...@redhat.com Signed-off-by: Kevin Wolf kw...@redhat.com --- tests/qemu-iotests/124 | 58 +- tests/qemu-iotests/124.out | 4 ++-- 2 files changed, 49 insertions(+), 13 deletions(-) diff --git a/tests/qemu-iotests/124 b/tests

Re: [Qemu-block] [Qemu-devel] Question about block driver

2015-04-30 Thread Kevin Wolf
Am 30.04.2015 um 11:43 hat Wen Congyang geschrieben: On 04/30/2015 05:33 PM, Kevin Wolf wrote: [Cc: qemu-block] Am 30.04.2015 um 11:11 hat Wen Congyang geschrieben: Some drivers use bdrv_open, while the other dirvers use bdrv_file_open(). What is the difference between bdrv_open

[Qemu-block] [PATCH] MAINTAINERS: Add qemu-block list where missing

2015-04-30 Thread Kevin Wolf
Signed-off-by: Kevin Wolf kw...@redhat.com --- MAINTAINERS | 6 ++ 1 file changed, 6 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 25fd2b5..0b67c48 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -735,12 +735,14 @@ F: backends/rng*.c nvme M: Keith Busch keith.bu...@intel.com

Re: [Qemu-block] [PATCH v4 0/3] block: Fix unaligned bdrv_aio_write_zeroes

2015-04-30 Thread Kevin Wolf
Am 27.04.2015 um 15:18 hat Fam Zheng geschrieben: An unaligned zero write causes NULL deferencing in bdrv_co_do_pwritev. That path is reachable from bdrv_co_write_zeroes and bdrv_aio_write_zeroes. You can easily trigger through the former with qemu-io, as the test case added by 61815d6e0aa.

Re: [Qemu-block] [Qemu-devel] Question about block driver

2015-04-30 Thread Kevin Wolf
[Cc: qemu-block] Am 30.04.2015 um 11:11 hat Wen Congyang geschrieben: Some drivers use bdrv_open, while the other dirvers use bdrv_file_open(). What is the difference between bdrv_open() and bdrv_file_open()? bdrv_file_open() is used by protocol drivers that don't need any other driver to work

Re: [Qemu-block] [PATCH] Enable NVMe start controller for Windows guest.

2015-04-30 Thread Kevin Wolf
[Cc: qemu-block] Am 24.04.2015 um 21:19 hat Keith Busch geschrieben: On Fri, 24 Apr 2015, Daniel Stekloff wrote: Windows seems to send two separate calls to NVMe controller configuration. The first sends configuration info and the second the enable bit. I couldn't enable the Windows 8.1

[Qemu-block] [PULL 6/7] MAINTAINERS: Add qemu-block list where missing

2015-04-30 Thread Kevin Wolf
Signed-off-by: Kevin Wolf kw...@redhat.com --- MAINTAINERS | 6 ++ 1 file changed, 6 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 25fd2b5..0b67c48 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -735,12 +735,14 @@ F: backends/rng*.c nvme M: Keith Busch keith.bu...@intel.com

  1   2   3   4   5   6   7   8   9   10   >