Re: [Qemu-block] [PATCH] block: Fix blockdev-backup not to use funky error class

2015-03-17 Thread Markus Armbruster
I should mention that I hunted down all new instances of funky error classes since 2.2. This is the last one. The other two are: [PATCH] vnc: Fix QMP change not to use funky error class [PATCH] block: Fix block-set-write-threshold not to use funky error class

[Qemu-block] [PATCH] block: Fix blockdev-backup not to use funky error class

2015-03-17 Thread Markus Armbruster
Error classes are a leftover from the days of rich error objects. New code should always use ERROR_CLASS_GENERIC_ERROR. Commit b7b9d39..7c6a4ab added uses of ERROR_CLASS_DEVICE_NOT_FOUND. Replace them. Signed-off-by: Markus Armbruster arm...@redhat.com --- blockdev.c | 8

Re: [Qemu-block] [PATCH] raw-posix: Deprecate host floppy passthrough

2015-03-17 Thread Markus Armbruster
Forgot to mention: 1. For 2.3! 2. Testing without a physical floppy: # /dev/fd0 # chown armbru /dev/fd0 $ qemu-system-x86_64 -nodefaults -fda /dev/fd0 qemu-system-x86_64: -fda /dev/fd0: Host floppy pass-through is deprecated Support for it will be removed in a future

Re: [Qemu-block] [Qemu-devel] [PATCH] block: Fix blockdev-backup not to use funky error class

2015-03-19 Thread Markus Armbruster
Kevin Wolf kw...@redhat.com writes: Am 17.03.2015 um 08:36 hat Markus Armbruster geschrieben: Error classes are a leftover from the days of rich error objects. New code should always use ERROR_CLASS_GENERIC_ERROR. Commit b7b9d39..7c6a4ab added uses of ERROR_CLASS_DEVICE_NOT_FOUND. Replace

Re: [Qemu-block] [Qemu-devel] [PATCH v5 10/13] blockdev: Keep track of monitor-owned BDS

2015-03-20 Thread Markus Armbruster
Eric Blake ebl...@redhat.com writes: On 03/03/2015 01:13 PM, Max Reitz wrote: Signed-off-by: Max Reitz mre...@redhat.com --- block.c| 2 ++ blockdev.c | 18 ++ include/block/block_int.h | 4

[Qemu-block] [PATCH] block: Document blockdev-add's immaturity

2015-03-20 Thread Markus Armbruster
Signed-off-by: Markus Armbruster arm...@redhat.com --- qapi/block-core.json | 4 qmp-commands.hx | 4 2 files changed, 8 insertions(+) diff --git a/qapi/block-core.json b/qapi/block-core.json index f525b04..7873084 100644 --- a/qapi/block-core.json +++ b/qapi/block-core.json

[Qemu-block] [PATCH RFC for-2.3 0/1] block: New command line option --no-format-probing

2015-03-20 Thread Markus Armbruster
of it for another few months, I'm happy to drop the patch now and revisit the larger topic in the next cycle. I readily admit --no-format-probing is fugly. Better ideas are welcome. Markus Armbruster (1): block: New command line option --no-format-probing block.c | 9 - include

[Qemu-block] [PATCH RFC for-2.3 1/1] block: New command line option --no-format-probing

2015-03-20 Thread Markus Armbruster
think we could use a miscellaneous option group. Signed-off-by: Markus Armbruster arm...@redhat.com --- block.c | 9 - include/block/block.h | 2 +- qemu-options.hx | 12 vl.c | 6 +- 4 files changed, 26 insertions(+), 3 deletions

Re: [Qemu-block] [Qemu-devel] [PATCH] iotests: Fix 061's reference output

2015-03-14 Thread Markus Armbruster
Kevin Wolf kw...@redhat.com writes: Am 03.03.2015 um 20:57 hat Max Reitz geschrieben: As of commit dc523cd348c47372faa7271c9aab2030f94c290d, passing an unkown option name for image creation no longer results in that option's name printed. This affects iotest 061's output, fix it.

Re: [Qemu-block] [Qemu-devel] [PATCH RFC for-2.3 1/1] block: New command line option --no-format-probing

2015-03-25 Thread Markus Armbruster
Paolo Bonzini pbonz...@redhat.com writes: On 24/03/2015 17:49, Markus Armbruster wrote: But what about migration from newer to older QEMU? Libvirt even supports QEMU versions where the only way to specify disks is -hda XYZ, so it is _impossible_ to honor the format=raw specifier. If you

Re: [Qemu-block] [Qemu-devel] [PATCH RFC for-2.3? 0/8] prep: Fix pc87312 for -device usage

2015-03-30 Thread Markus Armbruster
Andreas Färber afaer...@suse.de writes: Hello Markus et al., This series attempts to fix the -device pc87312 issues you reported. I can't add alias properties for devices that don't get created before realize. Therefore this involves moving code for various ISA devices, to enable us to

Re: [Qemu-block] [Qemu-devel] [PATCH RFC for-2.3? 0/8] prep: Fix pc87312 for -device usage

2015-03-30 Thread Markus Armbruster
Paolo Bonzini pbonz...@redhat.com writes: On 30/03/2015 16:25, Markus Armbruster wrote: Andreas Färber afaer...@suse.de writes: Hello Markus et al., This series attempts to fix the -device pc87312 issues you reported. I can't add alias properties for devices that don't get created

Re: [Qemu-block] [Qemu-devel] [PATCH RFC for-2.3? 0/8] prep: Fix pc87312 for -device usage

2015-03-30 Thread Markus Armbruster
Andreas Färber afaer...@suse.de writes: Am 30.03.2015 um 18:12 schrieb Paolo Bonzini: On 30/03/2015 16:25, Markus Armbruster wrote: Andreas Färber afaer...@suse.de writes: Hello Markus et al., This series attempts to fix the -device pc87312 issues you reported. I can't add alias

Re: [Qemu-block] [Qemu-devel] [PATCH RFC for-2.3 1/1] block: New command line option --no-format-probing

2015-03-23 Thread Markus Armbruster
Paolo Bonzini pbonz...@redhat.com writes: On 23/03/2015 18:48, Eric Blake wrote: Why can't libvirt just add ,format=raw instead of leaving out the format key altogether? Libvirt DOES add format=raw. This patch is an extra insurance policy to guarantee that libvirt does not have any code

Re: [Qemu-block] [Qemu-devel] [PATCH 1/1] vl.c: Since the help says that 'disk_image' is a raw hard disk image, pass format=raw

2015-05-04 Thread Markus Armbruster
Kevin Wolf kw...@redhat.com writes: Am 01.05.2015 um 01:28 hat Don Slutz geschrieben: [...] So do you want a more complex patch that allows the format to be specified? Only for 'disk_image'? Include -hd* ? I'm afraid that there is no nice way to improve the plain 'disk_image' case.

Re: [Qemu-block] [Qemu-devel] [PATCH 4/5] qemu-io: prompt for encryption keys when required

2015-05-13 Thread Markus Armbruster
Daniel P. Berrange berra...@redhat.com writes: On Tue, May 12, 2015 at 12:32:53PM -0600, Eric Blake wrote: On 05/12/2015 10:09 AM, Daniel P. Berrange wrote: The qemu-io tool does not check if the image is encrypted so historically would silently corrupt the sectors by writing plain text

Re: [Qemu-block] [Qemu-devel] [PATCH 1/2] block: Detect multiplication overflow in bdrv_getlength

2015-05-15 Thread Markus Armbruster
Fam Zheng f...@redhat.com writes: Bogus image may have a large total_sectors that will overflow the multiplication. For cleanness, fix the return code so the error message will be meaningful. Reported-by: Richard W.M. Jones rjo...@redhat.com Signed-off-by: Fam Zheng f...@redhat.com ---

Re: [Qemu-block] [Qemu-devel] [PATCH v2 0/2] block: Fix error code for bdrv_getlength when the image is too big

2015-05-15 Thread Markus Armbruster
in bdrv_getlength (the big nagetive value is later truncated to 0x200). Fix it to return -EFBIG: qemu-img: Can't get size of device 'image': File too large Bug reported by Richard Jones in: https://bugzilla.redhat.com/show_bug.cgi?id=1221499 Series Reviewed-by: Markus Armbruster arm

[Qemu-block] [PATCH] MAINTAINERS: Split Block QAPI, monitor, command line off core

2015-05-20 Thread Markus Armbruster
Kevin and Stefan asked me to take care of this part. Signed-off-by: Markus Armbruster arm...@redhat.com --- MAINTAINERS | 8 1 file changed, 8 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index b3552b2..8df0c6a 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -812,6 +812,14 @@ F

[Qemu-block] [PULL v2 6/9] blkdebug: Simplify passing of Error through qemu_opts_foreach()

2015-06-08 Thread Markus Armbruster
Cc: Kevin Wolf kw...@redhat.com Cc: qemu-block@nongnu.org Signed-off-by: Markus Armbruster arm...@redhat.com Reviewed-by: Eric Blake ebl...@redhat.com Acked-by: Kevin Wolf kw...@redhat.com --- block/blkdebug.c | 10 -- 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/block

Re: [Qemu-block] [Qemu-devel] [PATCH 0/4] blockdev: Defer creation of implicit PCI devices for IF_VIRTIO drives

2015-06-08 Thread Markus Armbruster
Peter Maydell peter.mayd...@linaro.org writes: blockdev.c will create implicit virtio-blk-* devices for IF_VIRTIO drives. I want to turn this on for the ARM virt board (now it has PCI), so that users can use shorter and more comprehensible command lines. I had to read further until understood

[Qemu-block] [PATCH v2 6/9] blkdebug: Simplify passing of Error through qemu_opts_foreach()

2015-06-03 Thread Markus Armbruster
Cc: Kevin Wolf kw...@redhat.com Cc: qemu-block@nongnu.org Signed-off-by: Markus Armbruster arm...@redhat.com Reviewed-by: Eric Blake ebl...@redhat.com Acked-by: Kevin Wolf kw...@redhat.com --- block/blkdebug.c | 10 -- 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/block

Re: [Qemu-block] [Qemu-devel] [PATCH 1/4] block: Warn if an if=something drive was also connected manually

2015-06-22 Thread Markus Armbruster
Peter Maydell peter.mayd...@linaro.org writes: On 22 June 2015 at 10:59, Markus Armbruster arm...@redhat.com wrote: What about this instead: 1. When -device creation connects a qdev_prop_drive property to a backend, fail when the backend has a DriveInfo and the DriveInfo has type != IF_NONE

Re: [Qemu-block] [Qemu-devel] [PATCH v2 0/3] blockdev: Defer creation of implicit PCI devices for IF_VIRTIO drives

2015-06-20 Thread Markus Armbruster
Peter Maydell peter.mayd...@linaro.org writes: On 20 June 2015 at 16:00, Markus Armbruster arm...@redhat.com wrote: Peter Maydell peter.mayd...@linaro.org writes: I do definitely want to enable short-options for virt for 2.4... Enable short options = change virt's default block interface

Re: [Qemu-block] [Qemu-devel] [PATCH v2 0/3] blockdev: Defer creation of implicit PCI devices for IF_VIRTIO drives

2015-06-20 Thread Markus Armbruster
Peter Maydell peter.mayd...@linaro.org writes: On 9 June 2015 at 18:48, Peter Maydell peter.mayd...@linaro.org wrote: Patch 3 is the one-liner to change the default-drive-type. Unfortunately just doing that alone will break commandlines that currently work The other problem with taking patch

Re: [Qemu-block] [Qemu-devel] [PATCH 3/4] qdev-properties-system: Improve error message for drive assignment conflict

2015-06-22 Thread Markus Armbruster
Peter Maydell peter.mayd...@linaro.org writes: On 22 June 2015 at 10:12, Markus Armbruster arm...@redhat.com wrote: We generally do not end error messages with a period. The message for auto_claimed drives is of the form LOCATION: This went wrong. Advice on how to fix it. All in one

Re: [Qemu-block] [Qemu-devel] [PATCH 2/4] qdev-properties-system: Change set_pointer's parse callback to use Error

2015-06-22 Thread Markus Armbruster
Peter Maydell peter.mayd...@linaro.org writes: On 22 June 2015 at 10:39, Markus Armbruster arm...@redhat.com wrote: Peter Maydell peter.mayd...@linaro.org writes: Instead of having set_pointer() call a parse callback which returns an error number that we then convert to an Error string

Re: [Qemu-block] [Qemu-devel] [PATCH 1/4] block: Warn if an if=something drive was also connected manually

2015-06-22 Thread Markus Armbruster
Peter Maydell peter.mayd...@linaro.org writes: Improve the diagnosis of command line errors where the user requested an automatic connection of a drive (via if=something, or by not setting if= and using the board-default-if). We already fail this case if the board actually handles

Re: [Qemu-block] [Qemu-devel] [PATCH 2/4] qdev-properties-system: Change set_pointer's parse callback to use Error

2015-06-22 Thread Markus Armbruster
Peter Maydell peter.mayd...@linaro.org writes: Instead of having set_pointer() call a parse callback which returns an error number that we then convert to an Error string with error_set_from_qdev_prop_error(), make the parse callback take an Error** and set the error itself. This will allow

Re: [Qemu-block] [Qemu-devel] [PATCH v2 for-2.4 0/3] block: Improve warnings for doubly-connected drives

2015-06-25 Thread Markus Armbruster
Peter Maydell peter.mayd...@linaro.org writes: On 25 June 2015 at 10:26, Markus Armbruster arm...@redhat.com wrote: Peter Maydell peter.mayd...@linaro.org writes: This patchset attempts to improve the warning and error messages for bad user command lines that attempt to connect a drive up

Re: [Qemu-block] [Qemu-devel] [PATCH] block.c: fix real cdrom detection

2015-06-25 Thread Markus Armbruster
Programmingkid programmingk...@gmail.com writes: On Jun 23, 2015, at 2:06 PM, John Snow wrote: On 06/23/2015 01:56 PM, Programmingkid wrote: Fix real cdrom detection so that a real cdrom can actually be used. signed-off-by: John Arbuckle programmingk...@gmail.com

Re: [Qemu-block] [Qemu-devel] [PATCH v2 for-2.4 0/3] block: Improve warnings for doubly-connected drives

2015-06-25 Thread Markus Armbruster
it up manually to two different devices; in this case their command line is doubly broken and if they use if=none as suggested by message 1 they'll then get message 2 and can fix their own double-usage...) With the commit message of PATCH 3 amended, series Reviewed-by: Markus Armbruster arm

Re: [Qemu-block] [Qemu-devel] [PATCH v2 for-2.4 3/3] hw/arm/virt: Make block devices default to virtio

2015-06-25 Thread Markus Armbruster
Peter Maydell peter.mayd...@linaro.org writes: On 25 June 2015 at 08:40, Markus Armbruster arm...@redhat.com wrote: Peter Maydell peter.mayd...@linaro.org writes: Now we have virtio-pci, we can make the virt board's default block device type be IF_VIRTIO. This allows users to use simplified

Re: [Qemu-block] [Qemu-devel] [PULL v2 43/60] i386: drop FDC in pc-q35-2.4+ if neither it nor floppy drives are wanted

2015-06-19 Thread Markus Armbruster
, - -device isa-fdc is not passed on the command line (nor in the config file), - no -drive if=floppy,... is requested. Cc: Markus Armbruster arm...@redhat.com Cc: Paolo Bonzini pbonz...@redhat.com Cc: Gerd Hoffmann kra...@redhat.com Cc: John Snow js...@redhat.com Cc: Gabriel L. Somlo gso

Re: [Qemu-block] [Qemu-devel] [PATCHv2 for-2.4] block: Auto-generate node_names for each BDS entry

2015-06-23 Thread Markus Armbruster
Copying Paolo for advice on the more general problem. Can you explain why we need this in 2.4? Eric Blake ebl...@redhat.com writes: From: Jeff Cody jc...@redhat.com Currently, node_name is only filled in when done so explicitly by the user. If no node_name is specified, then the node name

Re: [Qemu-block] [Qemu-devel] [PATCH v3 2/2] virtio-blk: Use blk_drain() to drain IO requests

2015-06-26 Thread Markus Armbruster
Just spotted this in my git-pull... Alexander Yarygin yary...@linux.vnet.ibm.com writes: Each call of the virtio_blk_reset() function calls blk_drain_all(), which works for all existing BlockDriverStates, while draining only one is needed. This patch replaces blk_drain_all() by blk_drain()

Re: [Qemu-block] [Qemu-devel] RFC cdrom in own thread?

2015-06-18 Thread Markus Armbruster
Peter Lieven p...@kamp.de writes: Am 17.06.2015 um 10:35 schrieb Kevin Wolf: Am 16.06.2015 um 17:34 hat Stefan Hajnoczi geschrieben: On Tue, Jun 16, 2015 at 3:44 PM, Peter Lieven p...@kamp.de wrote: I wonder how difficult it would be to have the IDE CDROM run in its own thread? We usually

Re: [Qemu-block] [Qemu-devel] [PATCH v2 0/4] tighten conditions for board-implied FDC in pc-q35-2.4+

2015-05-29 Thread Markus Armbruster
correctly / dynamically on Q35 (an independent issue was discovered but Gerd took that on, thanks). Sorry if I misunderstood. Series Reviewed-by: Markus Armbruster arm...@redhat.com

[Qemu-block] [PATCH 6/9] blkdebug: Simplify passing of Error through qemu_opts_foreach()

2015-05-28 Thread Markus Armbruster
Cc: Kevin Wolf kw...@redhat.com Cc: qemu-block@nongnu.org Signed-off-by: Markus Armbruster arm...@redhat.com --- block/blkdebug.c | 10 -- 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/block/blkdebug.c b/block/blkdebug.c index 50ef1fc..1e92607 100644 --- a/block/blkdebug.c

Re: [Qemu-block] [Qemu-devel] [PATCH v3 2/2] virtio-blk: Use blk_drain() to drain IO requests

2015-07-01 Thread Markus Armbruster
Stefan Hajnoczi stefa...@redhat.com writes: On Mon, Jun 29, 2015 at 08:10:20AM +0200, Markus Armbruster wrote: Alexander Yarygin yary...@linux.vnet.ibm.com writes: Markus Armbruster arm...@redhat.com writes: * Ignorant answer: I was told that the bdrv_drain_all()'s comment is obsolete

Re: [Qemu-block] [Qemu-devel] [PATCH] block/raw-posix: Don't think /dev/fd/NN is a floppy drive.

2015-07-01 Thread Markus Armbruster
/fdset/, NULL) +!strstart(filename, /dev/fd/, NULL)) { prio = 50; } Checking filenames is slightly less krazy than it seems, because it's under #ifdef __linux__. Not your fault anyway. Reviewed-by: Markus Armbruster arm...@redhat.com

Re: [Qemu-block] [Qemu-devel] [RFC 02/10] fdc: add default drive type option

2015-07-03 Thread Markus Armbruster
John Snow js...@redhat.com writes: We want to change the current default drive type, but to be kind, we need to allow users to specify the old drive type somehow. Uh, what is *this* commit about? as far as I can tell, it adds drive type properties (not a default drive type option), but

Re: [Qemu-block] [Qemu-devel] [RFC 08/10] fdc: refactor pick_geometry

2015-07-03 Thread Markus Armbruster
John Snow js...@redhat.com writes: This one is the crazy one. I'm afraid I don't have the mental capacity to properly review this one right now. From what I've understood of your series so far, it's a strict decrease of fdc craziness. Thanks!

Re: [Qemu-block] [Qemu-devel] [PATCH] opts: produce valid command line in qemu_opts_print

2015-07-03 Thread Markus Armbruster
-value.uint); } else { printf(%s%s=%s, sep, desc-name, value); } +sep = separator; } } Reviewed-by: Markus Armbruster arm...@redhat.com

Re: [Qemu-block] [Qemu-devel] [RFC 02/10] fdc: add default drive type option

2015-07-03 Thread Markus Armbruster
John Snow js...@redhat.com writes: We want to change the current default drive type, but to be kind, we need to allow users to specify the old drive type somehow. Signed-off-by: John Snow js...@redhat.com --- hw/block/fdc.c | 13 + hw/core/qdev-properties.c|

Re: [Qemu-block] [Qemu-devel] [RFC 05/10] fdc: refactor pick_geometry

2015-07-03 Thread Markus Armbruster
John Snow js...@redhat.com writes: Lessen the number of parameters it takes. Signed-off-by: John Snow js...@redhat.com Haven't reviewed in detail, but: YES, please!

Re: [Qemu-block] [Qemu-devel] [RFC 06/10] fdc: add physical disk sizes

2015-07-03 Thread Markus Armbruster
John Snow js...@redhat.com writes: 2.88MB capable drives can accept 1.44MB floppies, for instance. To rework the pick_geometry function, we need to know if our current drive can even accept the type of disks we're considering. NB: This allows us to distinguish between all of the total

Re: [Qemu-block] [Qemu-devel] [PATCH] opts: produce valid command line in qemu_opts_print

2015-07-03 Thread Markus Armbruster
Kővágó Zoltán dirty.ice...@gmail.com writes: 2015-07-03 15:01 keltezéssel, Markus Armbruster írta: Kővágó, Zoltán dirty.ice...@gmail.com writes: This will let us print options in a format that the user would actually write it on the command line (foo=bar,baz=asd,etc=def), without prepending

Re: [Qemu-block] [Qemu-devel] [PATCH v2 5/6] qmp: Add blockdev-mirror command

2015-07-02 Thread Markus Armbruster
, and you can add Acked-by: Markus Armbruster arm...@redhat.com Only Acked- because my review is partial. Adressing my other nitpicks is desirable, but I'm not insisting on it.

Re: [Qemu-block] [Qemu-devel] [RFC 02/10] fdc: add default drive type option

2015-07-04 Thread Markus Armbruster
John Snow js...@redhat.com writes: On 07/03/2015 09:18 AM, Markus Armbruster wrote: [...] diff --git a/include/hw/qdev-properties.h b/include/hw/qdev-properties.h index 0cfff1c..0872b41 100644 --- a/include/hw/qdev-properties.h +++ b/include/hw/qdev-properties.h @@ -20,6 +20,7 @@ extern

Re: [Qemu-block] [Qemu-devel] [RFC 03/10] fdc: respect default drive type

2015-07-04 Thread Markus Armbruster
John Snow js...@redhat.com writes: On 07/03/2015 09:34 AM, Markus Armbruster wrote: John Snow js...@redhat.com writes: Respect the default drive type as proffered via the CLI. This patch overloads the drive out parameter of pick_geometry to be used as a default hint which is offered

Re: [Qemu-block] [Qemu-devel] [PATCH 5/5] opts: produce valid command line in qemu_opts_print

2015-07-02 Thread Markus Armbruster
Kővágó, Zoltán dirty.ice...@gmail.com writes: This will let us print options in a format that the user would actually write it on the command line (foo=bar,baz=asd,etc=def), without prepending a spurious comma at the beginning of the list, or quoting values unnecessarily. This patch provides

Re: [Qemu-block] [Qemu-devel] [PATCH] qapi: add dirty bitmap status

2015-05-22 Thread Markus Armbruster
Kevin Wolf kw...@redhat.com writes: Am 21.05.2015 um 23:48 hat John Snow geschrieben: On 05/20/2015 04:20 AM, Markus Armbruster wrote: John Snow js...@redhat.com writes: On 05/12/2015 04:06 PM, Eric Blake wrote: On 05/12/2015 01:53 PM, John Snow wrote: Bitmaps can be in a handful

Re: [Qemu-block] [Qemu-devel] [PATCH 3/8] fdc: Introduce fdctrl-phase

2015-05-21 Thread Markus Armbruster
Kevin Wolf kw...@redhat.com writes: Am 21.05.2015 um 12:11 hat Peter Maydell geschrieben: On 21 May 2015 at 10:42, Kevin Wolf kw...@redhat.com wrote: Am 20.05.2015 um 14:07 hat Peter Maydell geschrieben: On 20 May 2015 at 12:55, John Snow js...@redhat.com wrote: So even if /currently/ we

Re: [Qemu-block] [Qemu-devel] [PATCH v3 2/2] virtio-blk: Use blk_drain() to drain IO requests

2015-06-29 Thread Markus Armbruster
Alexander Yarygin yary...@linux.vnet.ibm.com writes: Markus Armbruster arm...@redhat.com writes: Just spotted this in my git-pull... Alexander Yarygin yary...@linux.vnet.ibm.com writes: Each call of the virtio_blk_reset() function calls blk_drain_all(), which works for all existing

Re: [Qemu-block] [Qemu-devel] [PATCH v3 0/3] block: warn about aio=native if libaio is unavailable

2015-07-23 Thread Markus Armbruster
Stefan Hajnoczi stefa...@redhat.com writes: v3: * Fix Patch 2 commit description because the mention of raw-posix.c ignored Windows [Markus] * Drop #ifdef CONFIG_LINUX_AIO from qemu-nbd.c No fishy uses of CONFIG_LINUX_AIO left. Series Reviewed-by: Markus Armbruster arm...@redhat.com

Re: [Qemu-block] [Qemu-devel] [PATCH 0/1] A couple of problems with BlockDriverState's children list

2015-07-23 Thread Markus Armbruster
Alberto Garcia be...@igalia.com writes: I've been debugging a couple of problems related to the recently merged bdrv_reopen() overhaul code. 1. bs-children is not updated correctly The problem is described in this e-mail:

Re: [Qemu-block] [Qemu-devel] [PATCH v2 2/2] blockdev: always compile in -drive aio= parsing

2015-07-23 Thread Markus Armbruster
Stefan Hajnoczi stefa...@redhat.com writes: CONFIG_LINUX_AIO is an implementation detail of raw-posix.c. Don't mention CONFIG_LINUX_AIO in blockdev.c. Let raw-posix.c decide what to To be precise: raw-posix.c or raw-win32.c, or maybe the block driver. do with BDRV_O_NATIVE_AIO if

Re: [Qemu-block] [Qemu-devel] [RFC 03/10] fdc: respect default drive type

2015-07-22 Thread Markus Armbruster
John Snow js...@redhat.com writes: On 07/04/2015 02:47 AM, Markus Armbruster wrote: John Snow js...@redhat.com writes: On 07/03/2015 09:34 AM, Markus Armbruster wrote: John Snow js...@redhat.com writes: Respect the default drive type as proffered via the CLI. This patch overloads

Re: [Qemu-block] [Qemu-devel] [PATCH v2 0/2] block: warn about aio=native if libaio is unavailable

2015-07-23 Thread Markus Armbruster
Stefan Hajnoczi stefa...@redhat.com writes: v2: * Banish CONFIG_LINUX_AIO from blockdev.c, that is raw-posix.c's business [Kevin] * Print the warning in the same way as the aio=native,cache.direct=off deprecation warning [Kevin] Open question: what about the Windows case? We now

Re: [Qemu-block] [Qemu-devel] Dynamic reconfiguration

2015-10-26 Thread Markus Armbruster
Wen Congyang <we...@cn.fujitsu.com> writes: > On 10/21/2015 04:27 PM, Markus Armbruster wrote: [...] >> Can we phrase the operation differently? Instead of "insert between A >> and B (silently replacing everything that is now between A and B)", >&g

Re: [Qemu-block] [Qemu-devel] [PATCH v11 18/28] qerror: more error_setg() usage

2015-11-11 Thread Markus Armbruster
Eric Blake writes: > A few uses of error_set(ERROR_CLASS_GENERIC_ERROR) have snuck in > since c6bd8c706. Nuke them. Doesn't really belong to this series, but that's okay. > Signed-off-by: Eric Blake > > --- > v11: new patch > --- > block.c

Re: [Qemu-block] [Qemu-devel] [PATCH v11 21/28] qapi: Convert qtype_code into qapi enum type

2015-11-11 Thread Markus Armbruster
Eric Blake writes: > What's more meta than using qapi to define qapi? :) > > Convert qtype_code into a full-fledged[*] builtin qapi enum type, > so that a subsequent patch can then use it as the discriminator > type of qapi alternate types. Doing so is easiest when renaming >

Re: [Qemu-block] [Qemu-devel] [PATCH v11 19/28] qapi: Change munging of CamelCase enum values

2015-11-11 Thread Markus Armbruster
Eric Blake <ebl...@redhat.com> writes: > [hmm, wonder why scripts/get-maintainer.pl didn't loop in Gerd to the > patch itself] > > On 11/11/2015 07:50 AM, Markus Armbruster wrote: >> Eric Blake <ebl...@redhat.com> writes: >> >>> When munging enum val

Re: [Qemu-block] [Qemu-devel] [PATCH v11 18/28] qerror: more error_setg() usage

2015-11-11 Thread Markus Armbruster
Eric Blake <ebl...@redhat.com> writes: > On 11/11/2015 07:21 AM, Markus Armbruster wrote: >> Eric Blake <ebl...@redhat.com> writes: >> >>> A few uses of error_set(ERROR_CLASS_GENERIC_ERROR) have snuck in >>> since c6bd8c706. Nuke them. >>

Re: [Qemu-block] [Qemu-devel] [PATCH v11 19/28] qapi: Change munging of CamelCase enum values

2015-11-11 Thread Markus Armbruster
Eric Blake writes: > When munging enum values, the fact that we were passing the entire > prefix + value through camel_to_upper() meant that enum values > spelled with CamelCase could be turned into CAMEL_CASE. However, > this provides a potential collision (both OneTwo and

Re: [Qemu-block] [Qemu-devel] [PATCH v6 3/4] qmp: add monitor command to add/remove a child

2015-11-10 Thread Markus Armbruster
Wen Congyang writes: > On 11/09/2015 10:42 PM, Alberto Garcia wrote: >> Sorry again for the late review, here are my comments: >> >> On Fri 16 Oct 2015 10:57:45 AM CEST, Wen Congyang wrote: >>> +void qmp_x_blockdev_change(ChangeOperation op, const char *parent, >>> +

Re: [Qemu-block] [Qemu-devel] [RFC] ide: Don't use qemu_hw_version() for firmware revision

2015-11-12 Thread Markus Armbruster
Eduardo Habkost writes: > The IDEState.version field is used for firmware version > information returned to the guest. Updating firmware information > on QEMU upgrade is supposed to be acceptable, so IDE doesn't need > the version compatibility magic of qemu_hw_version() and

Re: [Qemu-block] [Qemu-devel] [PATCH v11 19/28] qapi: Change munging of CamelCase enum values

2015-11-12 Thread Markus Armbruster
Gerd Hoffmann writes: > Hi, > >> > If desired, I can prepare an alternate patch that adds the dash to the >> > qapi enum definition, to see what we think. >> >> If Gerd is fine with the rename, let's do it. > > No need to do so I think ... > >> >> -

Re: [Qemu-block] [Qemu-devel] [PATCH v11 21/28] qapi: Convert qtype_code into qapi enum type

2015-11-12 Thread Markus Armbruster
Eric Blake <ebl...@redhat.com> writes: > On 11/11/2015 09:42 AM, Markus Armbruster wrote: >> Eric Blake <ebl...@redhat.com> writes: >> >>> What's more meta than using qapi to define qapi? :) >>> >>> Convert qtype_code into a full-fledged[*]

Re: [Qemu-block] [Qemu-devel] [PATCH v11 19/28] qapi: Change munging of CamelCase enum values

2015-11-13 Thread Markus Armbruster
Eric Blake writes: > On 11/10/2015 11:51 PM, Eric Blake wrote: >> When munging enum values, the fact that we were passing the entire >> prefix + value through camel_to_upper() meant that enum values >> spelled with CamelCase could be turned into CAMEL_CASE. However, >> this

Re: [Qemu-block] [Qemu-devel] [PATCH v11 19/28] qapi: Change munging of CamelCase enum values

2015-11-16 Thread Markus Armbruster
Eric Blake <ebl...@redhat.com> writes: > On 11/13/2015 11:13 AM, Markus Armbruster wrote: > >> We need c_name() to protect ticklish identifiers only when its result is >> used as identifier. Not when it's *part* of an identifier, >> e.g. prefixed with qapi

Re: [Qemu-block] [Qemu-devel] [PATCH v3 1/2] qemu-iotests: fix cleanup of background processes

2015-11-01 Thread Markus Armbruster
Max Reitz writes: > On 30.10.2015 20:25, Jeff Cody wrote: >> Commit 934659c switched the iotests to run qemu and qemu-nbd from a bash >> subshell, in order to catch segfaults. Unfortunately, this means the >> process PID cannot be captured via '$!'. We stopped killing qemu

Re: [Qemu-block] [Qemu-devel] [PATCH v10 12/14] block: add transactional properties

2015-11-05 Thread Markus Armbruster
John Snow writes: > On 11/05/2015 05:47 AM, Stefan Hajnoczi wrote: >> On Tue, Nov 03, 2015 at 12:27:19PM -0500, John Snow wrote: >>> >>> >>> On 11/03/2015 10:17 AM, Stefan Hajnoczi wrote: On Fri, Oct 23, 2015 at 07:56:50PM -0400, John Snow wrote: > @@ -1732,6 +1757,10

Re: [Qemu-block] [Qemu-devel] [RFC] transactions: add transaction-wide property

2015-10-19 Thread Markus Armbruster
John Snow writes: > On 10/16/2015 08:23 AM, Stefan Hajnoczi wrote: >> On Mon, Oct 12, 2015 at 12:50:20PM -0400, John Snow wrote: >>> Ping -- any consensus on how we should implement the "do-or-die" >>> argument for transactions that start block jobs? :) >>> >>> This patch may

Re: [Qemu-block] [Qemu-devel] [PATCH v5 3/4] qmp: add monitor command to add/remove a child

2015-10-08 Thread Markus Armbruster
Max Reitz writes: > On 22.09.2015 09:44, Wen Congyang wrote: >> The new QMP command name is x-blockdev-child-add, and x-blockdev-child-del. >> It justs for adding/removing quorum's child now, and don't support all >> kinds of children, > > It does support all kinds of children

Re: [Qemu-block] [Qemu-devel] Dynamic reconfiguration

2015-10-21 Thread Markus Armbruster
Sorry for my slow reply. Kevin Wolf <kw...@redhat.com> writes: > Am 08.10.2015 um 13:02 hat Kevin Wolf geschrieben: >> Am 08.10.2015 um 08:15 hat Markus Armbruster geschrieben: >> > Max Reitz <mre...@redhat.com> writes: >> > > E.g. you may have a

Re: [Qemu-block] [Qemu-devel] [PATCH 0/3] Add 'blockdev-del' command

2015-10-21 Thread Markus Armbruster
Alberto Garcia writes: > Here's my first attempt at the 'blockdev-del' command. > > This series goes on top of Max's "BlockBackend and media" v6: > > https://lists.gnu.org/archive/html/qemu-devel/2015-10/msg02810.html > > With Max's code, 'blockdev-add' can now create a

Re: [Qemu-block] [Qemu-devel] [PATCH v5 3/4] qmp: add monitor command to add/remove a child

2015-10-12 Thread Markus Armbruster
"Dr. David Alan Gilbert" <dgilb...@redhat.com> writes: > * Max Reitz (mre...@redhat.com) wrote: >> On 08.10.2015 08:15, Markus Armbruster wrote: >> > Max Reitz <mre...@redhat.com> writes: >> > >> >> On 22.09.2015 09:44, Wen Congyang w

Re: [Qemu-block] [Qemu-devel] [PATCH v5 3/4] qmp: add monitor command to add/remove a child

2015-10-12 Thread Markus Armbruster
Max Reitz <mre...@redhat.com> writes: > On 08.10.2015 08:15, Markus Armbruster wrote: >> Max Reitz <mre...@redhat.com> writes: >> >>> On 22.09.2015 09:44, Wen Congyang wrote: >>>> The new QMP command name is x-blockdev-child-add, and x-block

Re: [Qemu-block] [Qemu-devel] [PATCH v3 4/4] qemu-iotests: update tests for generated node-names

2015-10-13 Thread Markus Armbruster
Shouldn't PATCH 3+4 be squashed into PATCH 2 to keep bisection working?

Re: [Qemu-block] [Qemu-devel] [PATCH v3 2/4] block: auto-generated node-names

2015-10-13 Thread Markus Armbruster
/* copy node name into the bs and insert it into the graph list */ > pstrcpy(bs->node_name, sizeof(bs->node_name), node_name); > QTAILQ_INSERT_TAIL(_bdrv_states, bs, node_list); > +out: > +g_free(gen_node_name); > } > > static QemuOptsList bdrv_runtime_opts = { Reviewed-by: Markus Armbruster <arm...@redhat.com>

Re: [Qemu-block] [Qemu-devel] [PATCH v3 1/4] util - add automated ID generation utility

2015-10-13 Thread Markus Armbruster
Jeff Cody writes: > Multiple sub-systems in QEMU may find it useful to generate IDs > for objects that a user may reference via QMP or HMP. This patch > presents a standardized way to do it, so that automatic ID generation > follows the same rules. > > This patch enforces the

Re: [Qemu-block] [Qemu-devel] [PATCH v3 1/4] util - add automated ID generation utility

2015-10-13 Thread Markus Armbruster
Jeff Cody <jc...@redhat.com> writes: > On Tue, Oct 13, 2015 at 09:37:29AM +0200, Markus Armbruster wrote: >> Jeff Cody <jc...@redhat.com> writes: >> >> > Multiple sub-systems in QEMU may find it useful to generate IDs >> > for objects that a u

Re: [Qemu-block] [Qemu-devel] [PATCH v3 0/4]

2015-10-13 Thread Markus Armbruster
Kevin Wolf writes: > Am 13.10.2015 um 01:36 hat Jeff Cody geschrieben: >> Born from the conversation on qemu-devel, this generation scheme uses the >> format ultimately proposed by Kevin, after list discussion. >> >> It attempts to keep the ID strings as small as possible,

Re: [Qemu-block] [Qemu-devel] [PATCH v12 29/36] qobject: Rename qtype_code to QType

2015-11-18 Thread Markus Armbruster
Eric Blake writes: > The name QType is more in line with our conventions for qapi > types, and matches the fact that each enum member has a prefix > of QTYPE_. > > Signed-off-by: Eric Blake At this point, the connection to QAPI is unobvious. You can

Re: [Qemu-block] [Qemu-devel] [PATCH v12 19/36] blkdebug: Merge hand-rolled and qapi BlkdebugEvent enum

2015-11-18 Thread Markus Armbruster
Kevin Wolf <kw...@redhat.com> writes: > Am 18.11.2015 um 17:26 hat Eric Blake geschrieben: >> On 11/18/2015 05:08 AM, Kevin Wolf wrote: >> > Am 18.11.2015 um 11:30 hat Markus Armbruster geschrieben: >> >> Eric Blake <ebl...@redhat.com> writes: >&

Re: [Qemu-block] [Qemu-devel] [PATCH v12 22/36] qapi: Don't let implicit enum MAX member collide

2015-11-18 Thread Markus Armbruster
Eric Blake <ebl...@redhat.com> writes: > On 11/18/2015 06:12 AM, Markus Armbruster wrote: >> Eric Blake <ebl...@redhat.com> writes: >> >>> Now that we guarantee the user doesn't have any enum values >>> beginning with a single underscore, we can

Re: [Qemu-block] [Qemu-devel] blkdebug event names [was: What to do about QAPI naming convention violations]

2015-11-16 Thread Markus Armbruster
Eric Blake <ebl...@redhat.com> writes: > On 11/10/2015 07:35 AM, Markus Armbruster wrote: > >>>> Oddballs not related to case: >>>> >>>> * enum BlkdebugEvent uses '.' in member names > >> I had a closer look at how the screwy names are use

Re: [Qemu-block] [Qemu-devel] [PATCH v3] opts: produce valid command line in qemu_opts_print

2015-08-28 Thread Markus Armbruster
Kővágó Zoltán dirty.ice...@gmail.com writes: 2015-08-26 15:15 keltezéssel, Markus Armbruster írta: Stefan Hajnoczi stefa...@gmail.com writes: On Tue, Jul 7, 2015 at 3:42 PM, Kővágó, Zoltán dirty.ice...@gmail.com wrote: This will let us print options in a format that the user would actually

Re: [Qemu-block] [Qemu-devel] hd-geo-test creates 4GB files on FSes that don't support sparse images, doesn't delete them on error

2015-08-28 Thread Markus Armbruster
John Snow js...@redhat.com writes: On 08/27/2015 11:29 AM, Eric Blake wrote: On 08/27/2015 09:17 AM, Peter Maydell wrote: I've noticed recently that tests/hd-geo-test.c creates test disk images which are 4GB in size, which is a problem if the filesystem on the host doesn't support sparse

Re: [Qemu-block] [Qemu-devel] [Patch for-2.5 v2 6/6] hmp: add monitor command to add/remove a child

2015-08-31 Thread Markus Armbruster
Wen Congyang <we...@cn.fujitsu.com> writes: > Ping... > Patch 1-4 have been reviewed by Alberto Garcia > Luiz Capitulino, Markus Armbruster, do you have time to review the > monitor command implementation? I will review at least the QMP parts of this series. My review queue ha

Re: [Qemu-block] [Qemu-devel] [PATCH v3] opts: produce valid command line in qemu_opts_print

2015-08-26 Thread Markus Armbruster
dirty.ice...@gmail.com Reviewed-by: Markus Armbruster arm...@redhat.com Feel free to send a Ping email reply if your patches haven't been reviewed after about 1 week. Reviewed-by: Stefan Hajnoczi stefa...@redhat.com Route via qemu-trivial or qemu-block?

Re: [Qemu-block] [Qemu-devel] hd-geo-test creates 4GB files on FSes that don't support sparse images, doesn't delete them on error

2015-09-01 Thread Markus Armbruster
John Snow <js...@redhat.com> writes: > On 08/28/2015 09:06 AM, Markus Armbruster wrote: >> John Snow <js...@redhat.com> writes: >> >>> On 08/27/2015 11:29 AM, Eric Blake wrote: >>>> On 08/27/2015 09:17 AM, Peter Maydell wrote: >>>>&

Re: [Qemu-block] [Qemu-devel] [PATCH 1/1] block: Allow passing BlockdevOptions to blockdev-snapshot-sync

2015-09-02 Thread Markus Armbruster
Kevin Wolf writes: > Am 01.09.2015 um 16:22 hat Alberto Garcia geschrieben: [...] >> Would you then prefer me to create a new command instead of extending >> the existing one? What would be the benefit (other than a better name)? > > A clean interface. There is really little

Re: [Qemu-block] [Qemu-devel] [PATCH 2/4] qtest/ahci: export generate_pattern

2015-09-10 Thread Markus Armbruster
John Snow writes: > Share the pattern function for ide and ahci test. > > Signed-off-by: John Snow > --- > tests/ahci-test.c | 26 -- > tests/libqos/libqos.c | 26 ++ > tests/libqos/libqos.h | 1 + > 3

Re: [Qemu-block] [Qemu-devel] [PATCH 0/4] ide: simple ATAPI tests

2015-09-10 Thread Markus Armbruster
John Snow writes: > On 09/09/2015 01:00 PM, Paolo Bonzini wrote: >> >> >> On 09/09/2015 18:37, John Snow wrote: >>> Ping -- apologies. :) >>> >>> I'll take a simple ACK before I merge it into my tree. >> >> I don't think you need one. :) >> >> Paolo >> > > I guess

Re: [Qemu-block] [Qemu-devel] [PATCH v3 4/5] qmp: add monitor command to add/remove a child

2015-09-14 Thread Markus Armbruster
Wen Congyang writes: > Signed-off-by: Wen Congyang > Signed-off-by: zhanghailiang > Signed-off-by: Gonglei > --- > blockdev.c | 47 ++ >

Re: [Qemu-block] [Qemu-devel] [PATCH v3 1/5] support nbd driver in blockdev-add

2015-09-14 Thread Markus Armbruster
Wen Congyang writes: > The NBD driver needs: filename, path or (host, port, exportname). > It checks which key exists and decides use unix or inet socket. > It doesn't recognize the key type, so we can't use union, and > can't reuse InetSocketAddress. > > Signed-off-by: Wen

Re: [Qemu-block] [Qemu-devel] [PATCH v3 4/5] qmp: add monitor command to add/remove a child

2015-09-14 Thread Markus Armbruster
Kevin Wolf <kw...@redhat.com> writes: > Am 14.09.2015 um 16:36 hat Markus Armbruster geschrieben: >> Wen Congyang <we...@cn.fujitsu.com> writes: >> > diff --git a/qmp-commands.hx b/qmp-commands.hx >> > index 495670b..139a23b 100644 >> >

  1   2   3   4   5   6   7   8   9   >