I should mention that I hunted down all new instances of funky error
classes since 2.2. This is the last one. The other two are:
[PATCH] vnc: Fix QMP change not to use funky error class
[PATCH] block: Fix block-set-write-threshold not to use funky error class
Error classes are a leftover from the days of rich error objects.
New code should always use ERROR_CLASS_GENERIC_ERROR. Commit
b7b9d39..7c6a4ab added uses of ERROR_CLASS_DEVICE_NOT_FOUND. Replace
them.
Signed-off-by: Markus Armbruster arm...@redhat.com
---
blockdev.c | 8
Paolo Bonzini pbonz...@redhat.com writes:
On 24/03/2015 17:49, Markus Armbruster wrote:
But what about migration from newer to older QEMU? Libvirt even
supports QEMU versions where the only way to specify disks is -hda
XYZ, so it is _impossible_ to honor the format=raw specifier.
If you
Andreas Färber afaer...@suse.de writes:
Hello Markus et al.,
This series attempts to fix the -device pc87312 issues you reported.
I can't add alias properties for devices that don't get created before
realize.
Therefore this involves moving code for various ISA devices, to enable us
to
Kevin Wolf kw...@redhat.com writes:
Am 01.05.2015 um 01:28 hat Don Slutz geschrieben:
[...]
So do you want a more complex patch that allows the format to be
specified?
Only for 'disk_image'?
Include -hd* ?
I'm afraid that there is no nice way to improve the plain 'disk_image'
case.
Daniel P. Berrange berra...@redhat.com writes:
On Tue, May 12, 2015 at 12:32:53PM -0600, Eric Blake wrote:
On 05/12/2015 10:09 AM, Daniel P. Berrange wrote:
The qemu-io tool does not check if the image is encrypted so
historically would silently corrupt the sectors by writing
plain text
Kevin and Stefan asked me to take care of this part.
Signed-off-by: Markus Armbruster arm...@redhat.com
---
MAINTAINERS | 8
1 file changed, 8 insertions(+)
diff --git a/MAINTAINERS b/MAINTAINERS
index b3552b2..8df0c6a 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -812,6 +812,14 @@ F
Cc: Kevin Wolf kw...@redhat.com
Cc: qemu-block@nongnu.org
Signed-off-by: Markus Armbruster arm...@redhat.com
Reviewed-by: Eric Blake ebl...@redhat.com
Acked-by: Kevin Wolf kw...@redhat.com
---
block/blkdebug.c | 10 --
1 file changed, 4 insertions(+), 6 deletions(-)
diff --git a/block
Peter Maydell peter.mayd...@linaro.org writes:
blockdev.c will create implicit virtio-blk-* devices for IF_VIRTIO
drives. I want to turn this on for the ARM virt board (now it has PCI),
so that users can use shorter and more comprehensible command lines.
I had to read further until understood
Peter Maydell peter.mayd...@linaro.org writes:
On 22 June 2015 at 10:59, Markus Armbruster arm...@redhat.com wrote:
What about this instead:
1. When -device creation connects a qdev_prop_drive property to a
backend, fail when the backend has a DriveInfo and the DriveInfo has
type != IF_NONE
Peter Maydell peter.mayd...@linaro.org writes:
On 20 June 2015 at 16:00, Markus Armbruster arm...@redhat.com wrote:
Peter Maydell peter.mayd...@linaro.org writes:
I do definitely want to enable short-options for virt for 2.4...
Enable short options = change virt's default block interface
Peter Maydell peter.mayd...@linaro.org writes:
On 22 June 2015 at 10:12, Markus Armbruster arm...@redhat.com wrote:
We generally do not end error messages with a period.
The message for auto_claimed drives is of the form
LOCATION: This went wrong. Advice on how to fix it.
All in one
Peter Maydell peter.mayd...@linaro.org writes:
Improve the diagnosis of command line errors where the user requested
an automatic connection of a drive (via if=something, or by not
setting if= and using the board-default-if). We already fail this
case if the board actually handles
Peter Maydell peter.mayd...@linaro.org writes:
Instead of having set_pointer() call a parse callback which returns
an error number that we then convert to an Error string with
error_set_from_qdev_prop_error(), make the parse callback take an
Error** and set the error itself. This will allow
Peter Maydell peter.mayd...@linaro.org writes:
On 25 June 2015 at 10:26, Markus Armbruster arm...@redhat.com wrote:
Peter Maydell peter.mayd...@linaro.org writes:
This patchset attempts to improve the warning and error messages for
bad user command lines that attempt to connect a drive up
Programmingkid programmingk...@gmail.com writes:
On Jun 23, 2015, at 2:06 PM, John Snow wrote:
On 06/23/2015 01:56 PM, Programmingkid wrote:
Fix real cdrom detection so that a real cdrom can actually be used.
signed-off-by: John Arbuckle programmingk...@gmail.com
it up manually
to two different devices; in this case their command line is doubly broken
and if they use if=none as suggested by message 1 they'll then get message 2
and can fix their own double-usage...)
With the commit message of PATCH 3 amended, series
Reviewed-by: Markus Armbruster arm
Peter Maydell peter.mayd...@linaro.org writes:
On 25 June 2015 at 08:40, Markus Armbruster arm...@redhat.com wrote:
Peter Maydell peter.mayd...@linaro.org writes:
Now we have virtio-pci, we can make the virt board's default block
device type be IF_VIRTIO. This allows users to use simplified
,
- -device isa-fdc is not passed on the command line (nor in the config
file),
- no -drive if=floppy,... is requested.
Cc: Markus Armbruster arm...@redhat.com
Cc: Paolo Bonzini pbonz...@redhat.com
Cc: Gerd Hoffmann kra...@redhat.com
Cc: John Snow js...@redhat.com
Cc: Gabriel L. Somlo gso
Copying Paolo for advice on the more general problem.
Can you explain why we need this in 2.4?
Eric Blake ebl...@redhat.com writes:
From: Jeff Cody jc...@redhat.com
Currently, node_name is only filled in when done so explicitly by the
user. If no node_name is specified, then the node name
Just spotted this in my git-pull...
Alexander Yarygin yary...@linux.vnet.ibm.com writes:
Each call of the virtio_blk_reset() function calls blk_drain_all(),
which works for all existing BlockDriverStates, while draining only
one is needed.
This patch replaces blk_drain_all() by blk_drain()
Peter Lieven p...@kamp.de writes:
Am 17.06.2015 um 10:35 schrieb Kevin Wolf:
Am 16.06.2015 um 17:34 hat Stefan Hajnoczi geschrieben:
On Tue, Jun 16, 2015 at 3:44 PM, Peter Lieven p...@kamp.de wrote:
I wonder how difficult it would be to have the IDE CDROM run in its own
thread?
We usually
correctly / dynamically on Q35 (an independent issue
was discovered but Gerd took that on, thanks).
Sorry if I misunderstood.
Series
Reviewed-by: Markus Armbruster arm...@redhat.com
Cc: Kevin Wolf kw...@redhat.com
Cc: qemu-block@nongnu.org
Signed-off-by: Markus Armbruster arm...@redhat.com
---
block/blkdebug.c | 10 --
1 file changed, 4 insertions(+), 6 deletions(-)
diff --git a/block/blkdebug.c b/block/blkdebug.c
index 50ef1fc..1e92607 100644
--- a/block/blkdebug.c
Stefan Hajnoczi stefa...@redhat.com writes:
On Mon, Jun 29, 2015 at 08:10:20AM +0200, Markus Armbruster wrote:
Alexander Yarygin yary...@linux.vnet.ibm.com writes:
Markus Armbruster arm...@redhat.com writes:
* Ignorant answer: I was told that the bdrv_drain_all()'s comment is
obsolete
/fdset/, NULL)
+!strstart(filename, /dev/fd/, NULL)) {
prio = 50;
}
Checking filenames is slightly less krazy than it seems, because it's
under #ifdef __linux__. Not your fault anyway.
Reviewed-by: Markus Armbruster arm...@redhat.com
John Snow js...@redhat.com writes:
We want to change the current default drive type,
but to be kind, we need to allow users to specify
the old drive type somehow.
Uh, what is *this* commit about? as far as I can tell, it adds drive
type properties (not a default drive type option), but
John Snow js...@redhat.com writes:
This one is the crazy one.
I'm afraid I don't have the mental capacity to properly review this one
right now.
From what I've understood of your series so far, it's a strict decrease
of fdc craziness. Thanks!
-value.uint);
} else {
printf(%s%s=%s, sep, desc-name, value);
}
+sep = separator;
}
}
Reviewed-by: Markus Armbruster arm...@redhat.com
John Snow js...@redhat.com writes:
We want to change the current default drive type,
but to be kind, we need to allow users to specify
the old drive type somehow.
Signed-off-by: John Snow js...@redhat.com
---
hw/block/fdc.c | 13 +
hw/core/qdev-properties.c|
John Snow js...@redhat.com writes:
Lessen the number of parameters it takes.
Signed-off-by: John Snow js...@redhat.com
Haven't reviewed in detail, but: YES, please!
, and you can add
Acked-by: Markus Armbruster arm...@redhat.com
Only Acked- because my review is partial.
Adressing my other nitpicks is desirable, but I'm not insisting on it.
John Snow js...@redhat.com writes:
On 07/03/2015 09:18 AM, Markus Armbruster wrote:
[...]
diff --git a/include/hw/qdev-properties.h b/include/hw/qdev-properties.h
index 0cfff1c..0872b41 100644
--- a/include/hw/qdev-properties.h
+++ b/include/hw/qdev-properties.h
@@ -20,6 +20,7 @@ extern
John Snow js...@redhat.com writes:
On 07/03/2015 09:34 AM, Markus Armbruster wrote:
John Snow js...@redhat.com writes:
Respect the default drive type as proffered via the CLI.
This patch overloads the drive out parameter of pick_geometry
to be used as a default hint which is offered
Kevin Wolf kw...@redhat.com writes:
Am 21.05.2015 um 23:48 hat John Snow geschrieben:
On 05/20/2015 04:20 AM, Markus Armbruster wrote:
John Snow js...@redhat.com writes:
On 05/12/2015 04:06 PM, Eric Blake wrote:
On 05/12/2015 01:53 PM, John Snow wrote:
Bitmaps can be in a handful
Alexander Yarygin yary...@linux.vnet.ibm.com writes:
Markus Armbruster arm...@redhat.com writes:
Just spotted this in my git-pull...
Alexander Yarygin yary...@linux.vnet.ibm.com writes:
Each call of the virtio_blk_reset() function calls blk_drain_all(),
which works for all existing
Stefan Hajnoczi stefa...@redhat.com writes:
v3:
* Fix Patch 2 commit description because the mention of raw-posix.c ignored
Windows [Markus]
* Drop #ifdef CONFIG_LINUX_AIO from qemu-nbd.c
No fishy uses of CONFIG_LINUX_AIO left.
Series
Reviewed-by: Markus Armbruster arm...@redhat.com
Alberto Garcia be...@igalia.com writes:
I've been debugging a couple of problems related to the recently
merged bdrv_reopen() overhaul code.
1. bs-children is not updated correctly
The problem is described in this e-mail:
Stefan Hajnoczi stefa...@redhat.com writes:
v2:
* Banish CONFIG_LINUX_AIO from blockdev.c, that is raw-posix.c's business
[Kevin]
* Print the warning in the same way as the aio=native,cache.direct=off
deprecation warning [Kevin]
Open question: what about the Windows case? We now
Wen Congyang <we...@cn.fujitsu.com> writes:
> On 10/21/2015 04:27 PM, Markus Armbruster wrote:
[...]
>> Can we phrase the operation differently? Instead of "insert between A
>> and B (silently replacing everything that is now between A and B)",
>&g
Eric Blake writes:
> A few uses of error_set(ERROR_CLASS_GENERIC_ERROR) have snuck in
> since c6bd8c706. Nuke them.
Doesn't really belong to this series, but that's okay.
> Signed-off-by: Eric Blake
>
> ---
> v11: new patch
> ---
> block.c
Eric Blake <ebl...@redhat.com> writes:
> [hmm, wonder why scripts/get-maintainer.pl didn't loop in Gerd to the
> patch itself]
>
> On 11/11/2015 07:50 AM, Markus Armbruster wrote:
>> Eric Blake <ebl...@redhat.com> writes:
>>
>>> When munging enum val
Eric Blake writes:
> When munging enum values, the fact that we were passing the entire
> prefix + value through camel_to_upper() meant that enum values
> spelled with CamelCase could be turned into CAMEL_CASE. However,
> this provides a potential collision (both OneTwo and
Wen Congyang writes:
> On 11/09/2015 10:42 PM, Alberto Garcia wrote:
>> Sorry again for the late review, here are my comments:
>>
>> On Fri 16 Oct 2015 10:57:45 AM CEST, Wen Congyang wrote:
>>> +void qmp_x_blockdev_change(ChangeOperation op, const char *parent,
>>> +
Eduardo Habkost writes:
> The IDEState.version field is used for firmware version
> information returned to the guest. Updating firmware information
> on QEMU upgrade is supposed to be acceptable, so IDE doesn't need
> the version compatibility magic of qemu_hw_version() and
Eric Blake <ebl...@redhat.com> writes:
> On 11/11/2015 09:42 AM, Markus Armbruster wrote:
>> Eric Blake <ebl...@redhat.com> writes:
>>
>>> What's more meta than using qapi to define qapi? :)
>>>
>>> Convert qtype_code into a full-fledged[*]
Eric Blake writes:
> On 11/10/2015 11:51 PM, Eric Blake wrote:
>> When munging enum values, the fact that we were passing the entire
>> prefix + value through camel_to_upper() meant that enum values
>> spelled with CamelCase could be turned into CAMEL_CASE. However,
>> this
Eric Blake <ebl...@redhat.com> writes:
> On 11/13/2015 11:13 AM, Markus Armbruster wrote:
>
>> We need c_name() to protect ticklish identifiers only when its result is
>> used as identifier. Not when it's *part* of an identifier,
>> e.g. prefixed with qapi
Max Reitz writes:
> On 30.10.2015 20:25, Jeff Cody wrote:
>> Commit 934659c switched the iotests to run qemu and qemu-nbd from a bash
>> subshell, in order to catch segfaults. Unfortunately, this means the
>> process PID cannot be captured via '$!'. We stopped killing qemu
John Snow writes:
> On 11/05/2015 05:47 AM, Stefan Hajnoczi wrote:
>> On Tue, Nov 03, 2015 at 12:27:19PM -0500, John Snow wrote:
>>>
>>>
>>> On 11/03/2015 10:17 AM, Stefan Hajnoczi wrote:
On Fri, Oct 23, 2015 at 07:56:50PM -0400, John Snow wrote:
> @@ -1732,6 +1757,10
John Snow writes:
> On 10/16/2015 08:23 AM, Stefan Hajnoczi wrote:
>> On Mon, Oct 12, 2015 at 12:50:20PM -0400, John Snow wrote:
>>> Ping -- any consensus on how we should implement the "do-or-die"
>>> argument for transactions that start block jobs? :)
>>>
>>> This patch may
Max Reitz writes:
> On 22.09.2015 09:44, Wen Congyang wrote:
>> The new QMP command name is x-blockdev-child-add, and x-blockdev-child-del.
>> It justs for adding/removing quorum's child now, and don't support all
>> kinds of children,
>
> It does support all kinds of children
Sorry for my slow reply.
Kevin Wolf <kw...@redhat.com> writes:
> Am 08.10.2015 um 13:02 hat Kevin Wolf geschrieben:
>> Am 08.10.2015 um 08:15 hat Markus Armbruster geschrieben:
>> > Max Reitz <mre...@redhat.com> writes:
>> > > E.g. you may have a
Alberto Garcia writes:
> Here's my first attempt at the 'blockdev-del' command.
>
> This series goes on top of Max's "BlockBackend and media" v6:
>
> https://lists.gnu.org/archive/html/qemu-devel/2015-10/msg02810.html
>
> With Max's code, 'blockdev-add' can now create a
"Dr. David Alan Gilbert" <dgilb...@redhat.com> writes:
> * Max Reitz (mre...@redhat.com) wrote:
>> On 08.10.2015 08:15, Markus Armbruster wrote:
>> > Max Reitz <mre...@redhat.com> writes:
>> >
>> >> On 22.09.2015 09:44, Wen Congyang w
Max Reitz <mre...@redhat.com> writes:
> On 08.10.2015 08:15, Markus Armbruster wrote:
>> Max Reitz <mre...@redhat.com> writes:
>>
>>> On 22.09.2015 09:44, Wen Congyang wrote:
>>>> The new QMP command name is x-blockdev-child-add, and x-block
Shouldn't PATCH 3+4 be squashed into PATCH 2 to keep bisection working?
/* copy node name into the bs and insert it into the graph list */
> pstrcpy(bs->node_name, sizeof(bs->node_name), node_name);
> QTAILQ_INSERT_TAIL(_bdrv_states, bs, node_list);
> +out:
> +g_free(gen_node_name);
> }
>
> static QemuOptsList bdrv_runtime_opts = {
Reviewed-by: Markus Armbruster <arm...@redhat.com>
Kevin Wolf writes:
> Am 13.10.2015 um 01:36 hat Jeff Cody geschrieben:
>> Born from the conversation on qemu-devel, this generation scheme uses the
>> format ultimately proposed by Kevin, after list discussion.
>>
>> It attempts to keep the ID strings as small as possible,
Eric Blake writes:
> The name QType is more in line with our conventions for qapi
> types, and matches the fact that each enum member has a prefix
> of QTYPE_.
>
> Signed-off-by: Eric Blake
At this point, the connection to QAPI is unobvious.
You can
Kevin Wolf <kw...@redhat.com> writes:
> Am 18.11.2015 um 17:26 hat Eric Blake geschrieben:
>> On 11/18/2015 05:08 AM, Kevin Wolf wrote:
>> > Am 18.11.2015 um 11:30 hat Markus Armbruster geschrieben:
>> >> Eric Blake <ebl...@redhat.com> writes:
>&
Eric Blake <ebl...@redhat.com> writes:
> On 11/18/2015 06:12 AM, Markus Armbruster wrote:
>> Eric Blake <ebl...@redhat.com> writes:
>>
>>> Now that we guarantee the user doesn't have any enum values
>>> beginning with a single underscore, we can
Eric Blake <ebl...@redhat.com> writes:
> On 11/10/2015 07:35 AM, Markus Armbruster wrote:
>
>>>> Oddballs not related to case:
>>>>
>>>> * enum BlkdebugEvent uses '.' in member names
>
>> I had a closer look at how the screwy names are use
Kővágó Zoltán dirty.ice...@gmail.com writes:
2015-08-26 15:15 keltezéssel, Markus Armbruster írta:
Stefan Hajnoczi stefa...@gmail.com writes:
On Tue, Jul 7, 2015 at 3:42 PM, Kővágó, Zoltán
dirty.ice...@gmail.com wrote:
This will let us print options in a format that the user would actually
Wen Congyang <we...@cn.fujitsu.com> writes:
> Ping...
> Patch 1-4 have been reviewed by Alberto Garcia
> Luiz Capitulino, Markus Armbruster, do you have time to review the
> monitor command implementation?
I will review at least the QMP parts of this series. My review queue
ha
John Snow <js...@redhat.com> writes:
> On 08/28/2015 09:06 AM, Markus Armbruster wrote:
>> John Snow <js...@redhat.com> writes:
>>
>>> On 08/27/2015 11:29 AM, Eric Blake wrote:
>>>> On 08/27/2015 09:17 AM, Peter Maydell wrote:
>>>>&
Kevin Wolf writes:
> Am 01.09.2015 um 16:22 hat Alberto Garcia geschrieben:
[...]
>> Would you then prefer me to create a new command instead of extending
>> the existing one? What would be the benefit (other than a better name)?
>
> A clean interface. There is really little
John Snow writes:
> On 09/09/2015 01:00 PM, Paolo Bonzini wrote:
>>
>>
>> On 09/09/2015 18:37, John Snow wrote:
>>> Ping -- apologies. :)
>>>
>>> I'll take a simple ACK before I merge it into my tree.
>>
>> I don't think you need one. :)
>>
>> Paolo
>>
>
> I guess
Wen Congyang writes:
> Signed-off-by: Wen Congyang
> Signed-off-by: zhanghailiang
> Signed-off-by: Gonglei
> ---
> blockdev.c | 47 ++
>
Wen Congyang <we...@cn.fujitsu.com> writes:
> On 09/15/2015 03:49 PM, Markus Armbruster wrote:
>> Wen Congyang <we...@cn.fujitsu.com> writes:
>>
>>> On 09/14/2015 10:36 PM, Markus Armbruster wrote:
>>>> Wen Congyang <we...@cn.fujitsu.com&
Wen Congyang <we...@cn.fujitsu.com> writes:
> On 09/15/2015 07:12 PM, Markus Armbruster wrote:
>> Wen Congyang <we...@cn.fujitsu.com> writes:
>>
>>> On 09/15/2015 03:37 PM, Markus Armbruster wrote:
>>>> Wen Congyang <we...@cn.fujitsu.com>
Wen Congyang <we...@cn.fujitsu.com> writes:
> On 09/16/2015 04:21 PM, Markus Armbruster wrote:
>> Wen Congyang <we...@cn.fujitsu.com> writes:
>>
>>> On 09/15/2015 07:12 PM, Markus Armbruster wrote:
>>>> Wen Congyang <we...@cn.fujitsu.com
Wen Congyang <we...@cn.fujitsu.com> writes:
> On 09/14/2015 10:36 PM, Markus Armbruster wrote:
>> Wen Congyang <we...@cn.fujitsu.com> writes:
>>
>>> Signed-off-by: Wen Congyang <we...@cn.fujitsu.com>
>>> Signed-off-by: zhanghailiang <zhan
John Snow writes:
> We're a little too lenient with what we'll let an ATAPI drive handle.
> Clamp down on the IDE command execution table to remove CD_OK permissions
> from commands that are not and have never been ATAPI commands.
>
> For ATAPI command validity, please see:
> -
John Snow writes:
> We're supposed to abort on transfers like this, unless we fill
> Word 125 of our IDENTIFY data with a default transfer size, which
> we don't currently do.
>
> This is an ATA error, not a SCSI/ATAPI one.
> See ATA8-ACS3 sections 7.17.6.49 or 7.21.5.
Wen Congyang <we...@cn.fujitsu.com> writes:
> On 09/14/2015 11:47 PM, Eric Blake wrote:
>> On 09/14/2015 08:27 AM, Markus Armbruster wrote:
>>> Wen Congyang <we...@cn.fujitsu.com> writes:
>>>
>>>> The NBD driver needs: filename, path or (host,
John Snow <js...@redhat.com> writes:
> On 09/15/2015 02:53 AM, Markus Armbruster wrote:
>> John Snow <js...@redhat.com> writes:
>>
>>> We're a little too lenient with what we'll let an ATAPI drive handle.
>>> Clamp down on the IDE command executi
John Snow <js...@redhat.com> writes:
> On 09/15/2015 02:11 PM, Markus Armbruster wrote:
>> John Snow <js...@redhat.com> writes:
>>
>>> On 09/15/2015 02:53 AM, Markus Armbruster wrote:
>>>> John Snow <js...@redhat.com> writes:
>>>
Wen Congyang <we...@cn.fujitsu.com> writes:
> On 09/15/2015 03:37 PM, Markus Armbruster wrote:
>> Wen Congyang <we...@cn.fujitsu.com> writes:
>>
>>> On 09/14/2015 11:47 PM, Eric Blake wrote:
>>>> On 09/14/2015 08:27 AM, Markus Armbruster wrote:
Wen Congyang <we...@cn.fujitsu.com> writes:
> On 09/16/2015 07:18 PM, Markus Armbruster wrote:
>> Wen Congyang <we...@cn.fujitsu.com> writes:
>>
>>> On 09/16/2015 04:21 PM, Markus Armbruster wrote:
>>>> Wen Congyang <we...@cn.fujitsu.com
Kevin Wolf writes:
> Am 29.09.2015 um 22:20 hat John Snow geschrieben:
>> If a migration is already in progress and somebody attempts
>> to add a migration blocker, this should rightly fail.
>>
>> Add an errp parameter and a retcode return value to migrate_add_blocker.
>>
>>
Jeff Cody writes:
> Changes from RFC v1:
>
> Patch 1: Several typos / grammatical errors (thanks Eric, John)
> Make id_subsys_str[] const pointer to const strings (thanks Eric)
> Moved id_subsys_str[] out from id_generate() (thanks John)
>
Jeff Cody writes:
> If a node-name is not specified, automatically generate the node-name.
>
> Generated node-names will use the "block" sub-system identifier.
>
> Reviewed-by: Eric Blake
> Reviewed-by: John Snow
> Signed-off-by: Jeff Cody
Jeff Cody writes:
> Multiple sub-systems in QEMU may find it useful to generate IDs
> for objects that a user may reference via QMP or HMP. This patch
> presents a standardized way to do it, so that automatic ID generation
> follows the same rules.
>
> This patch enforces the
nough to be a useful exercise to get you going with
the code.
> On 12/07/2015 05:59 PM, Markus Armbruster wrote:
>> Cao jin <caoj.f...@cn.fujitsu.com> writes:
>>
>>> msi_init() is a supporting function in PCI device initialization, in order
>>> to
>>
Cao jin writes:
> Hi John
>
> On 12/05/2015 01:55 AM, John Snow wrote:
>>
>>
>> On 12/04/2015 02:47 AM, Cao jin wrote:
>>> Hi,
>>> As you know, there are many PCI devices still using .init() as its
>>> initialization function, I am planning to do the "convert
Markus Armbruster <arm...@redhat.com> writes:
> Cao jin <caoj.f...@cn.fujitsu.com> writes:
>
>> Hi John
>>
>> On 12/05/2015 01:55 AM, John Snow wrote:
>>>
>>>
>>> On 12/04/2015 02:47 AM, Cao jin wrote:
>>>> Hi,
&
John Snow writes:
> This allows us to distinguish between the current disk type and the
> current drive type. The drive is what's reported to CMOS, the disk is
> whatever the pick_geometry function suspects has been inserted.
>
> The drive field maintains the exact same meaning
John Snow writes:
> Modify this function to operate directly on FDrive objects instead of
> unpacking and passing all of those parameters manually.
>
> Helps reduce complexity in each caller, and reduces the number of args.
For now, there's just one.
Diffstat suggests it's an
This reverts commit 662da3854e3f490223373b40afdcfcc339d14aa5.
Signed-off-by: Markus Armbruster <arm...@redhat.com>
---
scripts/tracetool.py | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/scripts/tracetool.py b/scripts/tracetool.py
index 83bde7b..7b82959
PEP 8 calls for it, because it's forward compatibile with Python 3.
Signed-off-by: Markus Armbruster <arm...@redhat.com>
---
scripts/qapi.py | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/scripts/qapi.py b/scripts/qapi.py
index 7c50cc4..ba7151b 100644
--- a/s
PEP 8 calls for it, because it's forward compatibile with Python 3.
Signed-off-by: Markus Armbruster <arm...@redhat.com>
---
scripts/qmp/qemu-ga-client | 2 +-
scripts/qmp/qmp| 4 ++--
scripts/qmp/qmp-shell | 2 +-
scripts/qmp/qmp.py | 4 ++--
4 files chan
I can take this through my tree, but of course don't mind if a
maintainer prefers to pick up "his" parts.
Markus Armbruster (4):
qapi: Use Python 2.6 "except E as ..." syntax
scripts/qmp: Use Python 2.6 "except E as ..." syntax
Revert "tracetool: use Pytho
PEP 8 calls for it, because it's forward compatibile with Python 3.
Signed-off-by: Markus Armbruster <arm...@redhat.com>
---
tests/image-fuzzer/runner.py | 12 ++--
tests/qemu-iotests/qed.py| 2 +-
2 files changed, 7 insertions(+), 7 deletions(-)
diff --git a/tests/image-
Peter Maydell writes:
> On 11 December 2015 at 15:43, Max Reitz wrote:
>> On 2015-12-11 at 16:40, Peter Maydell wrote:
>>>
>>> On 11 December 2015 at 15:30, Eric Blake wrote:
On 12/11/2015 08:23 AM, Max Reitz wrote:
mber. Otherwise qemu might fail with
> "cyls must be between 1 and 65535"
>
> Acked-by: Cornelia Huck <cornelia.h...@de.ibm.com>
> Signed-off-by: Christian Borntraeger <borntrae...@de.ibm.com>
Reviewed-by: Markus Armbruster <arm...@redhat.com>
Kevin Wolf writes:
> Am 09.12.2015 um 21:59 hat John Snow geschrieben:
>> I have a question about how the device name of block jobs gets reported
>> now after the bdrv_swap removal patch.
>>
>> Previously, it appears that the job stayed attached to the root-node (if
>>
Eric Blake <ebl...@redhat.com> writes:
> On 12/17/2015 03:06 AM, Markus Armbruster wrote:
>> This reverts commit 662da3854e3f490223373b40afdcfcc339d14aa5.
>>
>> Signed-off-by: Markus Armbruster <arm...@redhat.com>
>> ---
>> scripts/tracetool.py |
John Snow <js...@redhat.com> writes:
> On 12/17/2015 03:30 AM, Markus Armbruster wrote:
>> John Snow <js...@redhat.com> writes:
>>
>>> This allows us to distinguish between the current disk type and the
>>> current drive type. The drive is what
Eric Blake <ebl...@redhat.com> writes:
> On 12/17/2015 03:06 AM, Markus Armbruster wrote:
>> PEP 8 calls for it, because it's forward compatibile with Python 3.
>
> And possible as a cleanup only because we require 2.6 as a minimum since
> fec21036 (your subjec
1 - 100 of 3087 matches
Mail list logo