way harder to figure out what is
causing the script to fail, the person making the change is the most
likely to know right away what the problem is.
Signed-off-by: Fabiano Rosas
Acked-by: Thomas Huth
Reviewed-by: Juan Quintela
Signed-off-by: Juan Quintela
Message-ID: <20231009184326.15777-7-f
On 22/05/2024 14.48, Fabiano Rosas wrote:
Thomas Huth writes:
On 21/05/2024 14.46, Fabiano Rosas wrote:
Alex Bennée writes:
Juan Quintela writes:
From: Fabiano Rosas
Add a smoke test that migrates to a file and gives it to the
script. It should catch the most annoying errors such as
ich is currently
disabled with -fsanitize-cfi-icall-generalize-pointers. Thus let us avoid
the problem by using "void *" as parameter in all spots where it is needed.
Signed-off-by: Thomas Huth
---
Yes, I know, the patch looks ugly ... but I don't see a better way to
tackle this. If someo
On 29/05/2024 20.22, Stefan Hajnoczi wrote:
On Wed, May 29, 2024 at 07:49:48PM +0200, Thomas Huth wrote:
aio_set_event_notifier() and aio_set_event_notifier_poll() in
util/aio-posix.c and util/aio-win32.c are casting function pointers of
functions that take an "EventNotifier *"
cado: tags=arch:x86_64
+:avocado: tags=machine:q35
+:avocado: tags=accel:kvm
+"""
+ self.require_accelerator('kvm')
+self.vm.add_args('-accel', 'kvm')
+self.vm.add_args('-device', 'pcie-pci-bridge,id=pci.1,bus=pcie.0')
+
+self.launch_and_wait()
+self.blockdev_add()
+
+self.plug()
+self.unplug()
Reviewed-by: Thomas Huth
On 27/06/2024 18.22, Philippe Mathieu-Daudé wrote:
Disable tests using 0x4567 hardcoded RCA otherwise when
using random RCA we get:
ERROR:../../tests/qtest/npcm7xx_sdhci-test.c:69:write_sdread: assertion
failed: (ret == len)
not ok /arm/npcm7xx_sdhci/read_sd -
ERROR:../../tests/qtest/npc
-introspect-test.c | 7 +++
1 file changed, 3 insertions(+), 4 deletions(-)
Reviewed-by: Thomas Huth
On 02/07/2024 00.23, BALATON Zoltan wrote:
On Mon, 1 Jul 2024, Michael S. Tsirkin wrote:
On Thu, Jun 27, 2024 at 10:37:43PM +0900, Akihiko Odaki wrote:
Based-on:
<3ad18bc590ef28e1526e8053568086b453e7ffde.1718211878.git.quic_mathb...@quicinc.com>
("[PATCH] cpu: fix memleak of 'halt_cond' and 't
On 27/06/2024 15.37, Akihiko Odaki wrote:
A test run may create boot files several times. Delete the previous boot
file before creating a new one.
Signed-off-by: Akihiko Odaki
---
tests/qtest/migration-test.c | 18 +++---
1 file changed, 11 insertions(+), 7 deletions(-)
diff --g
ically into
the list.
Signed-off-by: Thomas Huth
---
system/qdev-monitor.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/system/qdev-monitor.c b/system/qdev-monitor.c
index 6af6ef7d66..60c3b6ad96 100644
--- a/system/qdev-monitor.c
+++ b/system/qdev-monitor.c
@@ -57,10 +57,
insertions(+), 7 deletions(-)
Acked-by: Thomas Huth
The virtiofs_submounts test has been removed in commit 5da7701e2a
("virtiofsd: Remove test"), so we don't need this files anymore.
Signed-off-by: Thomas Huth
---
.../virtiofs_submounts.py.data/cleanup.sh | 46 --
.../guest-cleanup.sh
On 31/10/2023 19.58, Kevin Wolf wrote:
From: Andrey Drobyshev
As the previous commit changes the logic of "qemu-img rebase" (it's using
write alignment now), let's add a couple more test cases which would
ensure it works correctly. In particular, the following scenarios:
024: add test case fo
4 files changed, 4 insertions(+), 6 deletions(-)
Reviewed-by: Thomas Huth
eration
constants' prefix from CPU_S390_POLARIZATION to S390_CPU_POLARIZATION.
Rename the type to S390CpuEntitlement, so that 'prefix' is not needed.
Likewise change CpuS390Polarization to S390CpuPolarization, and
CpuS390State to S390CpuState.
Signed-off-by: Markus Armbruster
---
Acked-by: Thomas Huth
On 24/07/2024 11.47, Daniel P. Berrangé wrote:
The current TLS session I/O APIs just return a synthetic errno
value on error, which has been translated from a gnutls error
value. This looses a large amount of valuable information that
distinguishes different scenarios.
Pushing population of the
'job.c',
'qemu-io-cmds.c',
- ))
+ ), qemuutil)
if config_host_data.get('CONFIG_REPLICATION')
block_ss.add(files('replication.c'))
endif
Reviewed-by: Thomas Huth
... and CC:-ing the block maintainers, hoping that they can have a look,
too, and finally pick up this patch.
On 26/08/2024 17.26, Peter Xu wrote:
On Fri, Aug 23, 2024 at 03:13:12PM +0900, Akihiko Odaki wrote:
A test run may create boot files several times. Delete the previous boot
file before creating a new one.
Signed-off-by: Akihiko Odaki
Reviewed-by: Michael S. Tsirkin
Acked-by: Thomas Huth
I
On 27/08/2024 09.05, Markus Armbruster wrote:
Daniel P. Berrangé writes:
On Mon, Aug 12, 2024 at 05:38:41PM +0200, Thomas Huth wrote:
On 24/07/2024 11.47, Daniel P. Berrangé wrote:
The current TLS session I/O APIs just return a synthetic errno
value on error, which has been translated from
effect of changing the output from one of the NBD
tests.
Reported-by: Thomas Huth
Signed-off-by: Daniel P. Berrangé
---
NB, wrt qemu-stable this will be for the 9.1 stable branch once
that is created, no earlier releases will need this.
tests/qemu-iotests/233.out | 12 ++--
1 file
When configuring QEMU with the --without-default-devices switch, these
tests are currently failing since they assume that the "pc" and "q35"
machines are always available. Add some proper checks to make the test
work without these machines, too.
Signed-off-by: Thomas Huth
--
In case QEMU has been configured with "--without-default-devices", the
"pc" machine type might be missing in the binary. We should check for
its availability before using it.
Signed-off-by: Thomas Huth
---
tests/qtest/hd-geo-test.c | 71 +--
);
+g_assert_not_reached();
}
#endif
Reviewed-by: Thomas Huth
)
-#define fatal(...) do { g_test_message(__VA_ARGS__); g_assert(0); } while (0)
+#define fatal(...) do { g_test_message(__VA_ARGS__); g_assert_not_reached(); }
while (0)
static void test_timer(void)
{
Reviewed-by: Thomas Huth
On 11/09/2024 14.51, Richard W.M. Jones wrote:
On Wed, Sep 11, 2024 at 02:46:18PM +0200, Maciej S. Szmigiero wrote:
On 11.09.2024 14:37, Eric Blake wrote:
On Wed, Sep 11, 2024 at 07:33:59AM GMT, Eric Blake wrote:
On Tue, Sep 10, 2024 at 03:15:28PM GMT, Pierrick Bouvier wrote:
Signed-off-by: P
des PCI and thus e.g. support for virtio-blk and virtio-scsi,
too. With this change, there are no failing iotests anymore when
using the qemu-system-or1k binary for running the tests.
Signed-off-by: Thomas Huth
---
tests/qemu-iotests/testenv.py | 1 +
1 file changed, 1 insertion(+)
diff --git
Commit 0ea0538fae516f9b4 removed the default machine of the sh4
binaries, so a lot of iotests are failing now without such a default
machine. Teach the iotest harness to use the "r2d" machine instead
to fix this problem.
Signed-off-by: Thomas Huth
---
tests/qemu-iotests/testenv.py
The "return;" statements at the end of functions do not make
much sense, so let's remove them.
Cc: John Snow
Cc: qemu-block@nongnu.org
Signed-off-by: Thomas Huth
---
hw/ide/atapi.c | 1 -
hw/ide/macio.c | 2 --
2 files changed, 3 deletions(-)
diff --git a/hw/ide/atapi.c b/hw/id
On 14/06/2022 12.29, Vladimir Sementsov-Ogievskiy wrote:
From: Vladimir Sementsov-Ogievskiy
Add two simple test-cases: timeout failure with
break-snapshot-on-cbw-error behavior and similar with
break-guest-write-on-cbw-error behavior.
Signed-off-by: Vladimir Sementsov-Ogievskiy
Reviewed-by: H
Hi!
I've just hit a failure in iotest 183:
--- /home/thuth/devel/qemu/tests/qemu-iotests/183.out
+++ /home/thuth/tmp/qemu-build/tests/qemu-iotests/scratch/183/183.out.bad
@@ -30,7 +30,7 @@
'arguments': { 'uri': 'unix:SOCK_DIR/migrate', 'blk': true } }
{"return": {}}
{ 'execute': 'qu
On 05/07/2022 11.58, Hanna Reitz wrote:
On 05.07.22 11:35, Thomas Huth wrote:
Hi!
I've just hit a failure in iotest 183:
--- /home/thuth/devel/qemu/tests/qemu-iotests/183.out
+++ /home/thuth/tmp/qemu-build/tests/qemu-iotests/scratch/183/183.out.bad
@@ -30,7 +30,7 @@
'
ntsov-Ogievskiy
---
As John and Thomas noted, the new iotests fails for FreeBSD and maxOS.
Here is a fix. Would be great if someone can test it.
Thanks, seems to work now:
https://gitlab.com/thuth/qemu/-/jobs/2683487160#L3256
https://gitlab.com/thuth/qemu/-/jobs/2683487162#L2897
Tested-by: Th
On 05/07/2022 19.22, Richard Henderson wrote:
On 7/5/22 21:07, Vladimir Sementsov-Ogievskiy wrote:
strerror() represents ETIMEDOUT a bit different in Linux and macOS /
FreeBSD. Let's support the latter too.
Fixes: 9d05a87b77 ("iotests: copy-before-write: add cases for cbw-timeout
option")
Sig
On 05/07/2022 11.03, Thomas Huth wrote:
On 14/06/2022 12.29, Vladimir Sementsov-Ogievskiy wrote:
From: Vladimir Sementsov-Ogievskiy
Add two simple test-cases: timeout failure with
break-snapshot-on-cbw-error behavior and similar with
break-guest-write-on-cbw-error behavior.
Signed-off-by
if __name__ == '__main__':
iotests.main(supported_fmts=['qcow2'],
- supported_protocols=['file'])
+ supported_protocols=['file'],
+ required_fmts=['copy-before-write'])
Thanks, that fixes the issue for me!
Tested-by: Thomas Huth
On 12/07/2022 20.34, John Snow wrote:
On Fri, Jul 8, 2022 at 11:35 AM John Snow wrote:
Note: patches 10-12 are included for testing simplicity, they shouldn't
be merged. They will be included in a forthcoming block PR.
Patches 1-9 are fully reviewed. Whose tree should this go in?
I can tak
On 08/07/2022 17.34, John Snow wrote:
Note: patches 10-12 are included for testing simplicity, they shouldn't
be merged. They will be included in a forthcoming block PR.
V4:
- Addressed concern by Marc-Andre in patch 01.
- Squashed Ubuntu patches (rth)
This patch series attempts to improve the
On 18/07/2022 11.49, Markus Armbruster wrote:
[...]
An OTP device isn't really a parallel flash, and neither are eFuses.
More fast-and-lose use of IF_PFLASH may exist in the tree, and maybe of
other interface types, too.
This patch introduces IF_OTHER. The patch after next uses it for an
EEPROM
On 03/02/2021 17.02, Michael Roth wrote:
On Wed, Feb 03, 2021 at 04:47:08PM +0100, Kevin Wolf wrote:
Am 03.02.2021 um 13:45 hat BALATON Zoltan geschrieben:
On Wed, 3 Feb 2021, Daniel P. Berrangé wrote:
On Tue, Feb 02, 2021 at 09:58:15PM +0100, Philippe Mathieu-Daudé wrote:
Follow the inclusiv
On 05/02/2021 17.37, Vladimir Sementsov-Ogievskiy wrote:
Check that cancel doesn't wait for 10s of nbd reconnect timeout.
Signed-off-by: Vladimir Sementsov-Ogievskiy
Reviewed-by: Eric Blake
---
tests/qemu-iotests/264 | 38 ++
tests/qemu-iotests/264.ou
On 05/07/2022 12.20, Thomas Huth wrote:
On 05/07/2022 11.58, Hanna Reitz wrote:
On 05.07.22 11:35, Thomas Huth wrote:
Hi!
I've just hit a failure in iotest 183:
--- /home/thuth/devel/qemu/tests/qemu-iotests/183.out
+++ /home/thuth/tmp/qemu-build/tests/qemu-iotests/scratch/183/183.ou
It is possible to hit the assertTrue(delta_t < 2.0) on very loaded
systems. Increase the value to 5.0 to ease the situation a little bit.
Signed-off-by: Thomas Huth
---
See also https://lists.gnu.org/archive/html/qemu-devel/2022-07/msg03936.html
tests/qemu-iotests/264 | 2 +-
1 file chan
++--
tests/qtest/vhost-user-test.c | 4 ++--
tests/unit/test-qga.c | 2 +-
10 files changed, 17 insertions(+), 17 deletions(-)
Reviewed-by: Thomas Huth
On 24/08/2022 11.39, Bin Meng wrote:
From: Bin Meng
Use g_get_tmp_dir() to get the directory to use for temporary files.
Signed-off-by: Bin Meng
---
tests/qtest/fuzz/generic_fuzz_configs.h | 6 --
tests/qtest/ahci-test.c | 15 +++
tests/qtest/aspeed_smc-t
On 24/08/2022 11.40, Bin Meng wrote:
From: Bin Meng
When QEMU is configured with '--without-default-devices', we should
not build and run iotests and qtest because devices used by these
test cases are not built in.
Signed-off-by: Bin Meng
---
tests/qemu-iotests/meson.build | 5 +
test
On 24/08/2022 11.40, Bin Meng wrote:
From: Bin Meng
On Windows, the MinGW provided mkstemp() API opens the file with
exclusive access, denying other processes to read/write the file.
Such behavior prevents the QEMU executable from opening the file,
(e.g.: CreateFile returns ERROR_SHARING_VIOLAT
On 24/08/2022 11.40, Bin Meng wrote:
From: Xuzhou Cheng
By default Windows opens file in text mode, while a POSIX compliant
implementation treats text files and binary files the same.
The fopen() 'mode' string can include the letter 'b' to indicate
binary mode shall be used. POSIX spec says th
x27;test-fdmon-epoll': [testblock]}
endif
+ if config_host_data.get('CONFIG_SECRET_KEYRING')
+tests += {'test-crypto-secret': [crypto, keyutils]}
+ endif
endif
if have_system
Reviewed-by: Thomas Huth
# has_header
config_host_data.set('CONFIG_EPOLL', cc.has_header('sys/epoll.h'))
Fixes: 406523f6b3 ("configure, meson: move block layer options to
meson_options.txt")
Reviewed-by: Thomas Huth
anged, 14 insertions(+), 15 deletions(-)
Reviewed-by: Thomas Huth
On 02/09/2022 19.16, Alexander Bulekov wrote:
On 220902 1851, Juan Quintela wrote:
Hi
For a long, long time I have had local hacks on my tree to be able to
run "make tests" when I have a minimal configure guest. This is a
first try to upstream some of it.
- by default we always setup -display
On 02/09/2022 18.51, Juan Quintela wrote:
So we don't need to set anywhere else.
Signed-off-by: Juan Quintela
---
...
diff --git a/tests/qtest/fuzz/generic_fuzz.c b/tests/qtest/fuzz/generic_fuzz.c
index afc1d20355..94b00288d9 100644
--- a/tests/qtest/fuzz/generic_fuzz.c
+++ b/tests/qtest/fuzz
On 21/09/2022 14.18, Bin Meng wrote:
Hi,
On Thu, Sep 8, 2022 at 9:28 PM Bin Meng wrote:
At present packaging the required DLLs of QEMU executables is a
manual process, and error prone.
Improve scripts/nsis.py by adding a logic to automatically package
required DLLs of QEMU executables.
'mak
is initialized
tests/qtest/ahci-test.c | 19 +++
1 file changed, 11 insertions(+), 8 deletions(-)
Reviewed-by: Thomas Huth
fd);
It would maybe make sense to merge this with patch 05 ("tests/qtest:
ahci-test: Avoid using hardcoded /tmp") ? ... but if you want to keep it
separate, that's fine for me, too.
Reviewed-by: Thomas Huth
On 27/09/2022 13.05, Bin Meng wrote:
In preparation to adding virtio-9p support on Windows, this series
enables running qtest on Windows, so that we can run the virtio-9p
tests on Windows to make sure it does not break accidently.
Thanks for your patches - I've picked many of them for my pull r
,
+ test_cli_device_del_q35);
+qtest_add_func("/device_del/drive/device_add_q35",
+ test_device_add_and_del_q35);
+qtest_add_func("/device_del/drive/drive_add_device_add_q35",
+ test_drive_add_device_add_and_del_q35);
+qtest_add_func("/device_del/blockdev_q35",
+ test_blockdev_add_device_add_and_del_q35);
+}
}
return g_test_run();
Reviewed-by: Thomas Huth
fy", test_identify);
qtest_add_func("/ide/diagnostic", test_diagnostic);
Acked-by: Thomas Huth
test-image-locking leaves some temporary files around - clean
them up. While we're at it, test-image-locking is a unit test,
so it should not use "qtest.*" for temporary file names. Give
them better names instead, so that it clear where the temporary
files come from.
Signed-off-
On 12/10/2022 11.21, Marc-André Lureau wrote:
Hi
On Wed, Oct 12, 2022 at 1:03 PM Thomas Huth <mailto:th...@redhat.com>> wrote:
test-image-locking leaves some temporary files around - clean
them up. While we're at it, test-image-locking is a unit test,
so it should
On 29/10/2022 15.45, Bin Meng wrote:
Hi Thomas,
On Wed, Sep 21, 2022 at 8:24 PM Thomas Huth wrote:
On 21/09/2022 14.18, Bin Meng wrote:
Hi,
On Thu, Sep 8, 2022 at 9:28 PM Bin Meng wrote:
At present packaging the required DLLs of QEMU executables is a
manual process, and error prone
in.buf = g_new(uint8_t, in.bsz);
-for (out_pos = 0; in_pos < size; block_count++) {
+for (out_pos = 0; in_pos < size; ) {
int bytes = (in_pos + in.bsz > size) ? size - in_pos : in.bsz;
ret = blk_pread(blk1, in_pos, bytes, in.buf, 0);
Reviewed-by: Thomas Huth
The condition '!A || (A && B)' is equivalent to '!A || B'.
Buglink: https://bugs.launchpad.net/qemu/+bug/1464611
Signed-off-by: Thomas Huth
---
hw/block/nvme.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/hw/block/nvme.c b/hw/block/n
On 07.11.2016 17:40, Max Reitz wrote:
> On 04.08.2016 20:18, John Snow wrote:
>> These files are currently unmaintained.
>>
>> I'm proposing that Fam and I co-maintain them; under the model that
>> whomever between us isn't authoring a given series will be responsible
>> for reviewing it.
>>
>> Sig
Hi Christopher,
On 16.11.2016 20:41, Christopher Oliver wrote:
> This patch (hack?) works around the slowness in SEEK_HOLE for large dense
> files
> on Linux tmpfs. It may improve life elsewhere as well, and the penalty of
> the checks
> should be vanishingly small where it is not needed.
>
>
F_NONE must be zero, because we want MachineClass member
> + * block_default_type to default-initialize to IF_NONE
> */
> - IF_IDE = 0,
> -IF_NONE,
> -IF_SCSI, IF_FLOPPY, IF_PFLASH, IF_MTD, IF_SD, IF_VIRTIO, IF_XEN,
> +IF_NONE = 0,
> +IF_IDE, IF_SCSI, IF_FLOPPY, IF_PFLASH, IF_MTD, IF_SD, IF_VIRTIO, IF_XEN,
> IF_COUNT
> } BlockInterfaceType;
>
>
Makes sense.
Reviewed-by: Thomas Huth
_zynq.c
> +++ b/hw/arm/xilinx_zynq.c
> @@ -323,7 +323,6 @@ static void zynq_machine_init(MachineClass *mc)
> {
> mc->desc = "Xilinx Zynq Platform Baseboard for Cortex-A9";
> mc->init = zynq_init;
> -mc->block_default_type = IF_SCSI;
> mc->max_cpus = 1;
> mc->no_sdcard = 1;
> }
Right, that looks like old copy-n-paste bugs from other machine types.
Reviewed-by: Thomas Huth
t;units_per_default_bus = 1;
> mc->max_cpus = 4;
> }
>
> @@ -421,7 +424,8 @@ static void midway_class_init(ObjectClass *oc, void *data)
>
> mc->desc = "Calxeda Midway (ECX-2000)";
> mc->init = midway_init;
> -mc->block_default_type = IF_SCSI;
> +mc->block_default_type = IF_IDE;
> +mc->units_per_default_bus = 1;
> mc->max_cpus = 4;
> }
>
>
Reviewed-by: Thomas Huth
> hw/mips/mips_malta.c| 1 +
> hw/mips/mips_r4k.c | 1 +
> hw/ppc/mac_newworld.c | 1 +
> hw/ppc/mac_oldworld.c | 1 +
> hw/ppc/prep.c | 1 +
> hw/sh4/r2d.c| 1 +
> hw/sparc64/sun4u.c | 2 ++
> 12 files changed, 15 insertions(+)
Patch looks right to me.
Reviewed-by: Thomas Huth
On 27.01.2017 11:21, Yongbok Kim wrote:
>
>>> Slightly off-topic, but: Is fulong2e still maintained? I did not spot an
>>> entry in MAINTAINERS...?
>>
>> It's covered by the general MIPS stanza:
>>
>> $ scripts/get_maintainer.pl -f hw/mips/mips_fulong2e.c
>> Aurelien Jarno (maintainer:MI
The sheepdog URL is broken twice: First it uses a duplicated
http:// prefix, second the website seems to have moved to
https://sheepdog.github.io/sheepdog/ instead.
Signed-off-by: Thomas Huth
---
qemu-options.hx | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/qemu-options.hx
Hi,
On 14.02.2017 22:38, Shubham Kumar wrote:
> Since the problem seems like the used FAT-16 file system ,
> Will it solve the problem if I change the code of vvfat.c for FAT-32 file
> system to increase acceptable file size ?
As far as I know, FAT16 can already support up to 4GB file systems
On 2018-10-18 19:28, Mark Cave-Ayland wrote:
> From: Laurent Vivier
>
> Co-developed-by: Mark Cave-Ayland
> Signed-off-by: Mark Cave-Ayland
> Signed-off-by: Laurent Vivier
> ---
[...]
> diff --git a/hw/m68k/Makefile.objs b/hw/m68k/Makefile.objs
> index d1f089c08a..18ebf1937a 100644
> --- a/hw/
On 2018-10-18 19:28, Mark Cave-Ayland wrote:
> From: Laurent Vivier
>
> Co-developed-by: Mark Cave-Ayland
> Signed-off-by: Mark Cave-Ayland
> Signed-off-by: Laurent Vivier
> ---
> arch_init.c | 4 +
> hw/display/Makefile.objs| 1 +
> hw/display/macfb-template.h | 158 +
On 2018-10-18 19:28, Mark Cave-Ayland wrote:
> From: Laurent Vivier
>
> This is broken as the linux driver seems broken too...
So is this required for the initial version, or does Linux also boot
without this device in the emulated machine? In the first case, please
mention it in the cover lette
On 2018-10-18 19:28, Mark Cave-Ayland wrote:
> From: Laurent Vivier
>
> Co-developed-by: Mark Cave-Ayland
> Signed-off-by: Mark Cave-Ayland
> Signed-off-by: Laurent Vivier
> ---
[...]
> diff --git a/hw/misc/mac_via.c b/hw/misc/mac_via.c
> new file mode 100644
> index 00..084974a24d
> -
On 2018-10-18 19:28, Mark Cave-Ayland wrote:
> From: Laurent Vivier
>
> Co-developed-by: Mark Cave-Ayland
> Signed-off-by: Mark Cave-Ayland
> Signed-off-by: Laurent Vivier
> ---
> hw/input/adb.c| 2 +
> hw/misc/mac_via.c | 166
> +
On 2018-10-18 19:28, Mark Cave-Ayland wrote:
> From: Laurent Vivier
>
> Co-developed-by: Mark Cave-Ayland
> Signed-off-by: Mark Cave-Ayland
> Signed-off-by: Laurent Vivier
> ---
[...]
> +static void nubus_register_format_block(NubusDevice *dev)
> +{
> +char fblock_name[27];
> +
> +spri
On 2018-11-04 14:41, Mark Cave-Ayland wrote:
> On 04/11/2018 06:53, no-re...@patchew.org wrote:
>
>> Hi,
>>
>> This series seems to have some coding style problems. See output below for
>> more information:
>>
>> Type: series
>> Message-id: 20181102152257.20637-1-mark.cave-ayl...@ilande.co.uk
>> S
s(-)
> create mode 100644 hw/display/macfb.c
> create mode 100644 include/hw/display/macfb.h
Again, due to lack of knowledge about the Mac hardware, just a weak:
Reviewed-by: Thomas Huth
/mac_via.c | 190
> ++
> include/hw/misc/mac_via.h | 7 ++
> 2 files changed, 197 insertions(+)
Looks ok to me at a quick glance now (can't say much about the details
since I don't know the ADB stuff at all), so FWIW, a weak:
Reviewed-by: Thomas Huth
e 100644 hw/nubus/nubus-bus.c
> create mode 100644 hw/nubus/nubus-device.c
> create mode 100644 include/hw/nubus/mac-nubus-bridge.h
> create mode 100644 include/hw/nubus/nubus.h
Reviewed-by: Thomas Huth
e code can also simply use blk_attach_dev() with a pointer
to the DeviceState instead.
So we can finally remove all code related to the "legacy_dev" flag, too,
and turn the related "void *" in block-backend.c into "DeviceState *"
to fix some of the remaining TODOs there.
On 2018-12-18 19:33, Markus Armbruster wrote:
> Thomas Huth writes:
>
>> The last user of blk_attach_dev_legacy() is the code in xen_disk.c.
>> It passes a pointer to a XenBlkDev as second parameter. XenBlkDev
>> is derived from XenDevice which in turn is derived from Dev
On 2019-01-08 20:12, Kevin Wolf wrote:
> Am 08.01.2019 um 18:18 hat Markus Armbruster geschrieben:
>> This patch series got stuck.
>>
>> Markus Armbruster writes:
>>
>>> Fam Zheng writes:
>>>
On Tue, 09/25 07:00, Markus Armbruster wrote:
> Jeff Cody writes:
>
>> I'll not be invo
On 2019-01-11 15:08, Philippe Mathieu-Daudé wrote:
> From: Philippe Mathieu-Daudé
>
> There is only one file requiring this typedef (hw/arm/pxa.h),
I'd suggest to replace "file" with "header file" here.
Reviewed-by: Thomas Huth
> let it include &qu
On 2019-01-11 15:08, Philippe Mathieu-Daudé wrote:
> From: Philippe Mathieu-Daudé
>
> There are only three files requiring this typedef, let them
s/files/header files/
Reviewed-by: Thomas Huth
> include "hw/ssi/ssi.h" directly to simplify "qemu/typedefs.h"
ntext AioContext;
> -typedef struct AllwinnerAHCIState AllwinnerAHCIState;
> typedef struct AudioState AudioState;
> typedef struct BdrvDirtyBitmap BdrvDirtyBitmap;
> typedef struct BdrvDirtyBitmapIter BdrvDirtyBitmapIter;
>
Reviewed-by: Thomas Huth
On 2019-01-11 15:08, Philippe Mathieu-Daudé wrote:
> Range is only used in "hw/pci-host/q35.h" in the MCHPCIState, and
> in "hw/pci/pci.h" by pci_bus_get_w64_range(). Let them include
> "qemu/range.h" directly to simplify "qemu/typedefs.h".
>
> To clean "qemu/typedefs.h", move the declaration to
On 2019-01-11 15:08, Philippe Mathieu-Daudé wrote:
> MouseTransformInfo is only used in "ui/console.h", there is no
> need to expose it via "qemu/typedefs.h".
You also touch devices.h here ... that should be mentioned, too?
Thomas
> Move the declaration to "ui/console.h" (removing the forward
ggested-by: Daniel P. Berrangé
Signed-off-by: Thomas Huth
---
configure | 5 +
1 file changed, 5 insertions(+)
diff --git a/configure b/configure
index 2b9ba7d..aa80c17 100755
--- a/configure
+++ b/configure
@@ -4562,6 +4562,11 @@ if test "$libiscsi" != "no" ; then
On 2019-01-14 15:31, Daniel P. Berrangé wrote:
> On Mon, Jan 14, 2019 at 01:52:01PM +, Peter Maydell wrote:
>> On Mon, 14 Jan 2019 at 13:47, Thomas Huth wrote:
>>>
>>> The header "scsi-lowlevel.h" of libiscsi 1.9.0 contains some bad
>>> "
by: Daniel P. Berrangé
Signed-off-by: Thomas Huth
---
v2: Use "-Wno-error" instead of "-fgnu89-inline"
configure | 5 +
1 file changed, 5 insertions(+)
diff --git a/configure b/configure
index 2b9ba7d..9514533 100755
--- a/configure
+++ b/configure
@@ -4562,6 +4562,11 @
On 2019-01-14 15:50, Eric Blake wrote:
> On 1/14/19 8:31 AM, Daniel P. Berrangé wrote:
>
>>>
>>> Can we suppress the warnings with #pragma instead ?
>>> That would avoid compiling the .o file with different
>>> C semantics.
>>
>> IIUC this is a built-in warning you can't disable, except by changin
On 2019-01-14 15:31, Philippe Mathieu-Daudé wrote:
> On 1/14/19 2:46 PM, Thomas Huth wrote:
>> The header "scsi-lowlevel.h" of libiscsi 1.9.0 contains some bad
>> "inline" prototype definitions which GCC refuses to compile in its
>> gnu99 mode:
>&
On 2019-01-14 16:02, Eric Blake wrote:
> On 1/14/19 8:53 AM, Thomas Huth wrote:
>> On 2019-01-14 15:50, Eric Blake wrote:
>>> On 1/14/19 8:31 AM, Daniel P. Berrangé wrote:
>>>
>>>>>
>>>>> Can we suppress the warnings with #pragma in
On 2019-01-14 16:23, Thomas Huth wrote:
> On 2019-01-14 16:02, Eric Blake wrote:
>> On 1/14/19 8:53 AM, Thomas Huth wrote:
[...]
>>> The patch is only changing libiscsi_cflags, so it's not affecting the
>>> entire project, but just the files that use libiscsi.
>&
nu89" mode behavior via "gnu_inline" instead.
Signed-off-by: Thomas Huth
---
block/iscsi.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/block/iscsi.c b/block/iscsi.c
index a7e8c1f..ff47320 100644
--- a/block/iscsi.c
+++ b/block/iscsi.c
@@ -49,7 +49,9 @@
/* Conflict
On 2019-01-15 13:28, Markus Armbruster wrote:
> Philippe Mathieu-Daudé writes:
>
>> From: Philippe Mathieu-Daudé
>>
>> There are only three files requiring this typedef, let them
>> include "hw/ssi/ssi.h" directly to simplify "qemu/typedefs.h".
>>
>> To clean "qemu/typedefs.h", move the forward
On 2018-12-18 17:11, Thomas Huth wrote:
> The last user of blk_attach_dev_legacy() is the code in xen_disk.c.
> It passes a pointer to a XenBlkDev as second parameter. XenBlkDev
> is derived from XenDevice which in turn is derived from DeviceState
> since commit 3a6c9172ac5951e ("
1 - 100 of 1291 matches
Mail list logo
