[PATCH] vfio: fix incorrect print type

[Zhengui li]

The type of input variable is unsigned int
while the printer type is int. So fix incorrect print type.

Signed-off-by: Zhengui li 
---
 hw/vfio/common.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/hw/vfio/common.c b/hw/vfio/common.c
index 13471ae..acc3356 100644
--- a/hw/vfio/common.c
+++ b/hw/vfio/common.c
@@ -203,7 +203,7 @@ void vfio_region_write(void *opaque, hwaddr addr,
 buf.qword = cpu_to_le64(data);
 break;
 default:
-hw_error("vfio: unsupported write size, %d bytes", size);
+hw_error("vfio: unsupported write size, %u bytes", size);
 break;
 }
 
@@ -260,7 +260,7 @@ uint64_t vfio_region_read(void *opaque,
 data = le64_to_cpu(buf.qword);
 break;
 default:
-hw_error("vfio: unsupported read size, %d bytes", size);
+hw_error("vfio: unsupported read size, %u bytes", size);
 break;
 }
 
-- 
1.8.3.1

Re: [PATCH] vfio: fix incorrect print type

[Alex Williamson]

On Mon, 19 Oct 2020 13:32:17 +
Zhengui li  wrote:

> fix incorrect print type.

Why is it incorrect, describe your change.  Patches must include a
Signed-off-by to adhere to the developer's certificate of origin.
Thanks,

Alex

> ---
>  hw/vfio/common.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/hw/vfio/common.c b/hw/vfio/common.c
> index 13471ae..acc3356 100644
> --- a/hw/vfio/common.c
> +++ b/hw/vfio/common.c
> @@ -203,7 +203,7 @@ void vfio_region_write(void *opaque, hwaddr addr,
>  buf.qword = cpu_to_le64(data);
>  break;
>  default:
> -hw_error("vfio: unsupported write size, %d bytes", size);
> +hw_error("vfio: unsupported write size, %u bytes", size);
>  break;
>  }
>  
> @@ -260,7 +260,7 @@ uint64_t vfio_region_read(void *opaque,
>  data = le64_to_cpu(buf.qword);
>  break;
>  default:
> -hw_error("vfio: unsupported read size, %d bytes", size);
> +hw_error("vfio: unsupported read size, %u bytes", size);
>  break;
>  }
>  

Re: [PATCH] vfio: fix incorrect print type

[no-reply]

Patchew URL: 
https://patchew.org/QEMU/1603114337-28056-1-git-send-email-lizhen...@huawei.com/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Type: series
Message-id: 1603114337-28056-1-git-send-email-lizhen...@huawei.com
Subject: [PATCH] vfio: fix incorrect print type

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
   ba2a9a9..000f5b8  master -> master
 * [new tag] 
patchew/1603114337-28056-1-git-send-email-lizhen...@huawei.com -> 
patchew/1603114337-28056-1-git-send-email-lizhen...@huawei.com
Switched to a new branch 'test'
c84a69c vfio: fix incorrect print type

=== OUTPUT BEGIN ===
ERROR: Missing Signed-off-by: line(s)

total: 1 errors, 0 warnings, 16 lines checked

Commit c84a69c621bd (vfio: fix incorrect print type) has style problems, please 
review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
http://patchew.org/logs/1603114337-28056-1-git-send-email-lizhen...@huawei.com/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-de...@redhat.com

[PATCH] vfio: fix incorrect print type

[Zhengui li]

fix incorrect print type.
---
 hw/vfio/common.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/hw/vfio/common.c b/hw/vfio/common.c
index 13471ae..acc3356 100644
--- a/hw/vfio/common.c
+++ b/hw/vfio/common.c
@@ -203,7 +203,7 @@ void vfio_region_write(void *opaque, hwaddr addr,
 buf.qword = cpu_to_le64(data);
 break;
 default:
-hw_error("vfio: unsupported write size, %d bytes", size);
+hw_error("vfio: unsupported write size, %u bytes", size);
 break;
 }
 
@@ -260,7 +260,7 @@ uint64_t vfio_region_read(void *opaque,
 data = le64_to_cpu(buf.qword);
 break;
 default:
-hw_error("vfio: unsupported read size, %d bytes", size);
+hw_error("vfio: unsupported read size, %u bytes", size);
 break;
 }
 
-- 
1.8.3.1