Re: [PATCH v4 00/45] Less clumsy error checking

2020-07-07 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20200707160613.848843-1-arm...@redhat.com/ Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20200707160613.848843-1-arm...@redhat.com Subject: [PATCH v4 00/45] Less clumsy error

Re: [PATCH v4 00/45] Less clumsy error checking

2020-07-07 Thread Markus Armbruster
Neglected to mention: code changes are limited to resolving rebase conflicts in PATCH 26. v4 is about comments, mostly to reduce churn when combined with Vladimir's auto propagation work.

[PATCH v4 00/45] Less clumsy error checking

2020-07-07 Thread Markus Armbruster
When the Error API was created, we adopted the (unwritten) rule to return void when the function returns no useful value on success, unlike GError, which recommends to return true on success and false on error then. When a function returns a distinct error value, say false, a checked call that