Re: [Qemu-block] [PATCH] migration/block-dirty-bitmap: Silence coverity CID 1390625

2019-03-26 Thread Peter Maydell
On Fri, 16 Nov 2018 at 18:43, John Snow wrote: > > Coverity warns that backing_bs() could give us a NULL pointer, which > we then use without checking that it isn't. > > In our loop condition, we check bs && bs->drv as a point of habit, but > by nature of the block graph, we cannot have null bs

[Qemu-block] [PATCH] migration/block-dirty-bitmap: Silence coverity CID 1390625

2018-11-16 Thread John Snow
Coverity warns that backing_bs() could give us a NULL pointer, which we then use without checking that it isn't. In our loop condition, we check bs && bs->drv as a point of habit, but by nature of the block graph, we cannot have null bs pointers here. This loop skips only implicit nodes, which