Re: [Qemu-block] [PATCH 1/2] nbd: Drop connection if broken server is detected

2017-08-11 Thread Eric Blake
On 08/11/2017 09:53 AM, Vladimir Sementsov-Ogievskiy wrote: > 11.08.2017 17:15, Eric Blake wrote: >> On 08/11/2017 02:48 AM, Vladimir Sementsov-Ogievskiy wrote: >>> 11.08.2017 05:37, Eric Blake wrote: As soon as the server is sending us garbage, we should quit trying to send further

Re: [Qemu-block] [PATCH 1/2] nbd: Drop connection if broken server is detected

2017-08-11 Thread Vladimir Sementsov-Ogievskiy
11.08.2017 17:15, Eric Blake wrote: On 08/11/2017 02:48 AM, Vladimir Sementsov-Ogievskiy wrote: 11.08.2017 05:37, Eric Blake wrote: As soon as the server is sending us garbage, we should quit trying to send further messages to the server, and allow all pending coroutines for any remaining

Re: [Qemu-block] [PATCH 1/2] nbd: Drop connection if broken server is detected

2017-08-11 Thread Eric Blake
On 08/11/2017 02:48 AM, Vladimir Sementsov-Ogievskiy wrote: > 11.08.2017 05:37, Eric Blake wrote: >> As soon as the server is sending us garbage, we should quit >> trying to send further messages to the server, and allow all >> pending coroutines for any remaining replies to error out. >> Failure

Re: [Qemu-block] [PATCH 1/2] nbd: Drop connection if broken server is detected

2017-08-11 Thread Vladimir Sementsov-Ogievskiy
11.08.2017 05:37, Eric Blake wrote: As soon as the server is sending us garbage, we should quit trying to send further messages to the server, and allow all pending coroutines for any remaining replies to error out. Failure to do so can let a malicious server cause the client to hang, for

[Qemu-block] [PATCH 1/2] nbd: Drop connection if broken server is detected

2017-08-10 Thread Eric Blake
As soon as the server is sending us garbage, we should quit trying to send further messages to the server, and allow all pending coroutines for any remaining replies to error out. Failure to do so can let a malicious server cause the client to hang, for example, if the server sends an invalid