Re: [Qemu-block] [PATCH 1/3] block: Add '-blockdev' command line option

2016-09-23 Thread Eric Blake
On 09/23/2016 04:37 AM, Kevin Wolf wrote: >> >>> +static int blockdev_init_func(void *opaque, QemuOpts *opts, Error **errp) >>> +{ >>> +BlockdevOptions *options; >> >> Uninitialized... > > Oops, good catch. Thanks. > >>> +visit_free(v); >>> + >>> +v = qapi_dealloc_visitor_new(); >>>

Re: [Qemu-block] [PATCH 1/3] block: Add '-blockdev' command line option

2016-09-23 Thread Kevin Wolf
Am 22.09.2016 um 20:45 hat Eric Blake geschrieben: > On 09/22/2016 10:42 AM, Kevin Wolf wrote: > > This is an option that is directly mapped to the blockdev-add QMP > > command. It works more or less like -drive, except that it doesn't > > create a BlockBackend and doesn't support legacy options. >

Re: [Qemu-block] [PATCH 1/3] block: Add '-blockdev' command line option

2016-09-22 Thread Eric Blake
On 09/22/2016 10:42 AM, Kevin Wolf wrote: > This is an option that is directly mapped to the blockdev-add QMP > command. It works more or less like -drive, except that it doesn't > create a BlockBackend and doesn't support legacy options. > > This patch adds minimal documentation, the next patches

[Qemu-block] [PATCH 1/3] block: Add '-blockdev' command line option

2016-09-22 Thread Kevin Wolf
This is an option that is directly mapped to the blockdev-add QMP command. It works more or less like -drive, except that it doesn't create a BlockBackend and doesn't support legacy options. This patch adds minimal documentation, the next patches will improve it. Signed-off-by: Kevin Wolf --- b