Re: [Qemu-block] [PATCH v2] vl: pause vcpus before stopping iothreads

2018-02-07 Thread Stefan Hajnoczi
On Thu, Feb 01, 2018 at 11:07:08AM +, Stefan Hajnoczi wrote: > Commit dce8921b2baaf95974af8176406881872067adfa ("iothread: Stop threads > before main() quits") introduced iothread_stop_all() to avoid the > following virtio-scsi assertion failure: > > assert(blk_get_aio_context(d->conf.blk)

[Qemu-block] [PATCH v2] vl: pause vcpus before stopping iothreads

2018-02-01 Thread Stefan Hajnoczi
Commit dce8921b2baaf95974af8176406881872067adfa ("iothread: Stop threads before main() quits") introduced iothread_stop_all() to avoid the following virtio-scsi assertion failure: assert(blk_get_aio_context(d->conf.blk) == s->ctx); Back then the assertion failed because when bdrv_close_all()