Re: [Qemu-block] [PATCH v2 3/6] block: require job-id when device is a node name

2017-08-22 Thread Alberto Garcia
On Tue 22 Aug 2017 12:31:26 PM CEST, Manos Pitsidianakis wrote: > On Tue, Aug 22, 2017 at 11:57:28AM +0200, Alberto Garcia wrote: >>On Mon 21 Aug 2017 05:39:48 PM CEST, Manos Pitsidianakis wrote: > -if (job_id == NULL && !(flags & BLOCK_JOB_INTERNAL)) { > -job_id =

Re: [Qemu-block] [PATCH v2 3/6] block: require job-id when device is a node name

2017-08-22 Thread Manos Pitsidianakis
On Tue, Aug 22, 2017 at 11:57:28AM +0200, Alberto Garcia wrote: On Mon 21 Aug 2017 05:39:48 PM CEST, Manos Pitsidianakis wrote: -if (job_id == NULL && !(flags & BLOCK_JOB_INTERNAL)) { -job_id = bdrv_get_device_name(bs); -if (!*job_id) { -error_setg(errp, "An

Re: [Qemu-block] [PATCH v2 3/6] block: require job-id when device is a node name

2017-08-22 Thread Alberto Garcia
On Mon 21 Aug 2017 05:39:48 PM CEST, Manos Pitsidianakis wrote: >>> -if (job_id == NULL && !(flags & BLOCK_JOB_INTERNAL)) { >>> -job_id = bdrv_get_device_name(bs); >>> -if (!*job_id) { >>> -error_setg(errp, "An explicit job ID is required for this >>> node"); >>> -

Re: [Qemu-block] [PATCH v2 3/6] block: require job-id when device is a node name

2017-08-21 Thread Manos Pitsidianakis
On Mon, Aug 21, 2017 at 05:05:30PM +0200, Alberto Garcia wrote: On Wed 09 Aug 2017 04:02:53 PM CEST, Manos Pitsidianakis wrote: @@ -622,20 +622,14 @@ void *block_job_create(const char *job_id, const BlockJobDriver *driver, return NULL; } -if (job_id == NULL && !(flags &

Re: [Qemu-block] [PATCH v2 3/6] block: require job-id when device is a node name

2017-08-21 Thread Alberto Garcia
On Wed 09 Aug 2017 04:02:53 PM CEST, Manos Pitsidianakis wrote: > @@ -622,20 +622,14 @@ void *block_job_create(const char *job_id, const > BlockJobDriver *driver, > return NULL; > } > > -if (job_id == NULL && !(flags & BLOCK_JOB_INTERNAL)) { > -job_id =