Re: [Qemu-block] [RFC v4 12/21] blockjobs: ensure abort is called for cancelled jobs

2018-02-28 Thread Kevin Wolf
Am 24.02.2018 um 00:51 hat John Snow geschrieben: > Presently, even if a job is canceled post-completion as a result of > a failing peer in a transaction, it will still call .commit because > nothing has updated or changed its return code. > > The reason why this does not cause problems currently

[Qemu-block] [RFC v4 12/21] blockjobs: ensure abort is called for cancelled jobs

2018-02-23 Thread John Snow
Presently, even if a job is canceled post-completion as a result of a failing peer in a transaction, it will still call .commit because nothing has updated or changed its return code. The reason why this does not cause problems currently is because backup's implementation of .commit checks for can