Re: [PATCH] io_uring: use io_uring_cq_ready() to check for ready cqes

[Stefano Garzarella]

On Thu, May 21, 2020 at 03:45:34PM +0100, Stefan Hajnoczi wrote:
> On Tue, May 19, 2020 at 03:49:42PM +0200, Stefano Garzarella wrote:
> > In qemu_luring_poll_cb() we are not using the cqe peeked from the
> > CQ ring. We are using io_uring_peek_cqe() only to see if there
> > are cqes ready, so we can replace it with io_uring_cq_ready().
> > 
> > Signed-off-by: Stefano Garzarella 
> > ---
> >  block/io_uring.c | 9 +++--
> >  1 file changed, 3 insertions(+), 6 deletions(-)
> 
> io_uring_cq_ready() was added in liburing 0.2 and is already used by
> fdmon-io_uring.c. It's safe to use here.
> 
> I wanted to mention this in case anyone is concerned about dependencies.
> liburing is a fast-moving target and everyone should be on liburing 0.5+.

Yeah, thanks for doing that. I did this check, but I forgot to write it down...

> 
> Thanks, applied to my block tree:
> https://github.com/stefanha/qemu/commits/block

Thanks,
Stefano

Re: [PATCH] io_uring: use io_uring_cq_ready() to check for ready cqes

[Stefan Hajnoczi]

On Tue, May 19, 2020 at 03:49:42PM +0200, Stefano Garzarella wrote:
> In qemu_luring_poll_cb() we are not using the cqe peeked from the
> CQ ring. We are using io_uring_peek_cqe() only to see if there
> are cqes ready, so we can replace it with io_uring_cq_ready().
> 
> Signed-off-by: Stefano Garzarella 
> ---
>  block/io_uring.c | 9 +++--
>  1 file changed, 3 insertions(+), 6 deletions(-)

io_uring_cq_ready() was added in liburing 0.2 and is already used by
fdmon-io_uring.c. It's safe to use here.

I wanted to mention this in case anyone is concerned about dependencies.
liburing is a fast-moving target and everyone should be on liburing 0.5+.

Thanks, applied to my block tree:
https://github.com/stefanha/qemu/commits/block

Stefan


signature.asc
Description: PGP signature