Re: [PATCH 1/4] migration: Prevent memleak by ...params_test_apply

2020-07-02 Thread Max Reitz
On 01.07.20 16:38, Eric Blake wrote: > On 6/30/20 3:45 AM, Max Reitz wrote: >> The created structure is not really a proper QAPI object, so we cannot >> and will not free its members.  Strings therein should therefore not be >> duplicated, or we will leak them. > > This seems fragile to me;

Re: [PATCH 1/4] migration: Prevent memleak by ...params_test_apply

2020-07-01 Thread Eric Blake
On 6/30/20 3:45 AM, Max Reitz wrote: The created structure is not really a proper QAPI object, so we cannot and will not free its members. Strings therein should therefore not be duplicated, or we will leak them. This seems fragile to me; having to code QAPI usage differently depending on

Re: [PATCH 1/4] migration: Prevent memleak by ...params_test_apply

2020-07-01 Thread Vladimir Sementsov-Ogievskiy
30.06.2020 11:45, Max Reitz wrote: The created structure is not really a proper QAPI object, so we cannot and will not free its members. Strings therein should therefore not be duplicated, or we will leak them. Signed-off-by: Max Reitz Reviewed-by: Vladimir Sementsov-Ogievskiy -- Best

Re: [PATCH 1/4] migration: Prevent memleak by ...params_test_apply

2020-06-30 Thread Dr. David Alan Gilbert
* Max Reitz (mre...@redhat.com) wrote: > The created structure is not really a proper QAPI object, so we cannot > and will not free its members. Strings therein should therefore not be > duplicated, or we will leak them. > > Signed-off-by: Max Reitz > --- > migration/migration.c | 4 ++-- > 1