Re: [PATCH 1/4] vl: Split off user_creatable_print_help()
On 10/14/19 4:55 AM, Kevin Wolf wrote: Am 11.10.2019 um 23:35 hat Eric Blake geschrieben: On 10/11/19 3:55 PM, Kevin Wolf wrote: Printing help for --object is something that we don't only want in the s/don't/not/ Can someone send a fix for the English grammar? It's obviously broken and doesn't know what it wants. Actually, maybe do-support was a bad idea and we should just revert it and restore consistent use of proper verb-second word order? Lol (Hm, actually, since this seems to negate "only" rather than the verb, does "...that we want not only in..." work without patching the grammar?) Yes, that formulation also works. (Thanks for the correction.) Kevin system emulator, but also in tools that support --object. Move it into a separate function in qom/object_interfaces.c to make the code accessible for tools. Signed-off-by: Kevin Wolf -- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3226 Virtualization: qemu.org | libvirt.org
Re: [PATCH 1/4] vl: Split off user_creatable_print_help()
Am 11.10.2019 um 23:35 hat Eric Blake geschrieben: > On 10/11/19 3:55 PM, Kevin Wolf wrote: > > Printing help for --object is something that we don't only want in the > > s/don't/not/ Can someone send a fix for the English grammar? It's obviously broken and doesn't know what it wants. Actually, maybe do-support was a bad idea and we should just revert it and restore consistent use of proper verb-second word order? (Hm, actually, since this seems to negate "only" rather than the verb, does "...that we want not only in..." work without patching the grammar?) (Thanks for the correction.) Kevin > > system emulator, but also in tools that support --object. Move it into a > > separate function in qom/object_interfaces.c to make the code accessible > > for tools. > > > > Signed-off-by: Kevin Wolf
Re: [PATCH 1/4] vl: Split off user_creatable_print_help()
On 10/11/19 3:55 PM, Kevin Wolf wrote: Printing help for --object is something that we don't only want in the s/don't/not/ system emulator, but also in tools that support --object. Move it into a separate function in qom/object_interfaces.c to make the code accessible for tools. Signed-off-by: Kevin Wolf --- include/qom/object_interfaces.h | 12 +++ qom/object_interfaces.c | 61 + vl.c| 52 +--- 3 files changed, 74 insertions(+), 51 deletions(-) diff --git a/include/qom/object_interfaces.h b/include/qom/object_interfaces.h index 682ba1d9b0..3e4e1d928b 100644 --- a/include/qom/object_interfaces.h Reviewed-by: Eric Blake -- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3226 Virtualization: qemu.org | libvirt.org
