Re: [PATCH 2/4] migration: Add block-bitmap-mapping parameter

2020-07-02 Thread Vladimir Sementsov-Ogievskiy
02.07.2020 12:41, Max Reitz wrote: As I've said before, it may be reasonable to ignore bitmaps not referenced in the hash-table. No problem with that.  We just decided on this behavior when we discussed the RFC. Sorry for that. The reason for my changed opinion is a recent bug from customers

Re: [PATCH 2/4] migration: Add block-bitmap-mapping parameter

2020-07-02 Thread Dr. David Alan Gilbert
* Max Reitz (mre...@redhat.com) wrote: > On 30.06.20 12:51, Dr. David Alan Gilbert wrote: > > * Max Reitz (mre...@redhat.com) wrote: > >> This migration parameter allows mapping block node names and bitmap > >> names to aliases for the purpose of block dirty bitmap migration. > >> > >> This way,

Re: [PATCH 2/4] migration: Add block-bitmap-mapping parameter

2020-07-02 Thread Vladimir Sementsov-Ogievskiy
02.07.2020 12:41, Max Reitz wrote: I don’t know if doing it differently would actually be beneficial for anyone, but OTOH naively it seems like a more invasive code change. I don't see real benefits, we can go either way, so, not worth rewriting the patch. === I feel like a stupid reviewer:)

Re: [PATCH 2/4] migration: Add block-bitmap-mapping parameter

2020-07-02 Thread Vladimir Sementsov-Ogievskiy
02.07.2020 12:41, Max Reitz wrote: On 02.07.20 11:19, Vladimir Sementsov-Ogievskiy wrote: 02.07.2020 11:09, Max Reitz wrote: On 01.07.20 16:34, Vladimir Sementsov-Ogievskiy wrote: 30.06.2020 11:45, Max Reitz wrote: This migration parameter allows mapping block node names and bitmap names to

Re: [PATCH 2/4] migration: Add block-bitmap-mapping parameter

2020-07-02 Thread Max Reitz
On 02.07.20 11:19, Vladimir Sementsov-Ogievskiy wrote: > 02.07.2020 11:09, Max Reitz wrote: >> On 01.07.20 16:34, Vladimir Sementsov-Ogievskiy wrote: >>> 30.06.2020 11:45, Max Reitz wrote: This migration parameter allows mapping block node names and bitmap names to aliases for the

Re: [PATCH 2/4] migration: Add block-bitmap-mapping parameter

2020-07-02 Thread Vladimir Sementsov-Ogievskiy
02.07.2020 11:09, Max Reitz wrote: On 01.07.20 16:34, Vladimir Sementsov-Ogievskiy wrote: 30.06.2020 11:45, Max Reitz wrote: This migration parameter allows mapping block node names and bitmap names to aliases for the purpose of block dirty bitmap migration. This way, management tools can use

Re: [PATCH 2/4] migration: Add block-bitmap-mapping parameter

2020-07-02 Thread Max Reitz
On 01.07.20 16:34, Vladimir Sementsov-Ogievskiy wrote: > 30.06.2020 11:45, Max Reitz wrote: >> This migration parameter allows mapping block node names and bitmap >> names to aliases for the purpose of block dirty bitmap migration. >> >> This way, management tools can use different node and bitmap

Re: [PATCH 2/4] migration: Add block-bitmap-mapping parameter

2020-07-01 Thread Vladimir Sementsov-Ogievskiy
30.06.2020 11:45, Max Reitz wrote: This migration parameter allows mapping block node names and bitmap names to aliases for the purpose of block dirty bitmap migration. This way, management tools can use different node and bitmap names on the source and destination and pass the mapping of how

Re: [PATCH 2/4] migration: Add block-bitmap-mapping parameter

2020-07-01 Thread Max Reitz
On 30.06.20 12:51, Dr. David Alan Gilbert wrote: > * Max Reitz (mre...@redhat.com) wrote: >> This migration parameter allows mapping block node names and bitmap >> names to aliases for the purpose of block dirty bitmap migration. >> >> This way, management tools can use different node and bitmap

Re: [PATCH 2/4] migration: Add block-bitmap-mapping parameter

2020-06-30 Thread Dr. David Alan Gilbert
* Max Reitz (mre...@redhat.com) wrote: > This migration parameter allows mapping block node names and bitmap > names to aliases for the purpose of block dirty bitmap migration. > > This way, management tools can use different node and bitmap names on > the source and destination and pass the