Re: [PATCH v2 2/4] Avoid conflicting types for 'copy_file_range'

2024-01-23 Thread Kevin Wolf
Am 22.01.2024 um 18:04 hat Peter Maydell geschrieben: > (Cc'ing the block folks) > > On Thu, 18 Jan 2024 at 16:03, Manolo de Medici > wrote: > > > > Compilation fails on systems where copy_file_range is already defined as a > > stub. > > What do you mean by "stub" here ? If the system headers

Re: [PATCH v2 2/4] Avoid conflicting types for 'copy_file_range'

2024-01-23 Thread Manolo de Medici
On Mon, Jan 22, 2024 at 6:04 PM Peter Maydell wrote: > > (Cc'ing the block folks) > > On Thu, 18 Jan 2024 at 16:03, Manolo de Medici > wrote: > > > > Compilation fails on systems where copy_file_range is already defined as a > > stub. > > What do you mean by "stub" here ? If the system headers

Re: [PATCH v2 2/4] Avoid conflicting types for 'copy_file_range'

2024-01-22 Thread Sergey Bugaev
Hello, On Mon, Jan 22, 2024 at 8:05 PM Peter Maydell wrote: > > On Thu, 18 Jan 2024 at 16:03, Manolo de Medici > wrote: > > > > Compilation fails on systems where copy_file_range is already defined as a > > stub. > > What do you mean by "stub" here ? If the system headers define > a prototype

Re: [PATCH v2 2/4] Avoid conflicting types for 'copy_file_range'

2024-01-22 Thread Sergey Bugaev
On Mon, Jan 22, 2024 at 9:23 PM Sergey Bugaev wrote: > call such a function. For example on GNU/Linux, remove(2) is a stub, (That was supposed to say revoke(2), of course.)

Re: [PATCH v2 2/4] Avoid conflicting types for 'copy_file_range'

2024-01-22 Thread Peter Maydell
(Cc'ing the block folks) On Thu, 18 Jan 2024 at 16:03, Manolo de Medici wrote: > > Compilation fails on systems where copy_file_range is already defined as a > stub. What do you mean by "stub" here ? If the system headers define a prototype for the function, I would have expected the meson